From: Daniel Thompson <daniel.thompson@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com,
jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com,
robh+dt@kernel.org, mark.rutland@arm.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH 2/2] dt-bindings: backlight: lm3630a: add enable_gpios
Date: Mon, 9 Sep 2019 11:59:42 +0100 [thread overview]
Message-ID: <20190909105942.pxwz6rtjg3cxlcnf@holly.lan> (raw)
In-Reply-To: <20190908203704.30147-3-andreas@kemnade.info>
On Sun, Sep 08, 2019 at 10:37:04PM +0200, Andreas Kemnade wrote:
> add enable-gpios to describe HWEN pin
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Looks like patches are in the wrong order. Changes to bindings must
appear in patchsets *before* the Linux implementation of the bindings.
> ---
> .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> index dc129d9a329e..a9656d72b668 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> @@ -29,6 +29,10 @@ properties:
> '#size-cells':
> const: 0
>
> + enable-gpios:
> + description: GPIO to use to enable/disable the backlight (HWEN pin).
> + maxItems: 1
> +
> required:
> - compatible
> - reg
Please add enable-gpios to one of the examples.
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: lee.jones@linaro.org, jingoohan1@gmail.com,
jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com,
robh+dt@kernel.org, mark.rutland@arm.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH 2/2] dt-bindings: backlight: lm3630a: add enable_gpios
Date: Mon, 09 Sep 2019 10:59:42 +0000 [thread overview]
Message-ID: <20190909105942.pxwz6rtjg3cxlcnf@holly.lan> (raw)
In-Reply-To: <20190908203704.30147-3-andreas@kemnade.info>
On Sun, Sep 08, 2019 at 10:37:04PM +0200, Andreas Kemnade wrote:
> add enable-gpios to describe HWEN pin
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Looks like patches are in the wrong order. Changes to bindings must
appear in patchsets *before* the Linux implementation of the bindings.
> ---
> .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> index dc129d9a329e..a9656d72b668 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> @@ -29,6 +29,10 @@ properties:
> '#size-cells':
> const: 0
>
> + enable-gpios:
> + description: GPIO to use to enable/disable the backlight (HWEN pin).
> + maxItems: 1
> +
> required:
> - compatible
> - reg
Please add enable-gpios to one of the examples.
Daniel.
next prev parent reply other threads:[~2019-09-09 10:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 20:37 [PATCH 0/2] backlight_lm3630a: add enable_gpios property Andreas Kemnade
2019-09-08 20:37 ` Andreas Kemnade
2019-09-08 20:37 ` [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin Andreas Kemnade
2019-09-08 20:37 ` Andreas Kemnade
2019-09-09 10:57 ` Daniel Thompson
2019-09-09 10:57 ` Daniel Thompson
2019-09-09 20:13 ` Andreas Kemnade
2019-09-09 20:13 ` Andreas Kemnade
2019-09-10 10:21 ` Daniel Thompson
2019-09-10 10:21 ` Daniel Thompson
2019-09-10 19:06 ` Andreas Kemnade
2019-09-10 19:06 ` Andreas Kemnade
2019-09-15 16:52 ` Pavel Machek
2019-09-15 16:52 ` Pavel Machek
2019-09-15 17:34 ` Andreas Kemnade
2019-09-15 17:34 ` Andreas Kemnade
2019-09-08 20:37 ` [PATCH 2/2] dt-bindings: backlight: lm3630a: add enable_gpios Andreas Kemnade
2019-09-08 20:37 ` Andreas Kemnade
2019-09-09 10:59 ` Daniel Thompson [this message]
2019-09-09 10:59 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909105942.pxwz6rtjg3cxlcnf@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=andreas@kemnade.info \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.