* [LTP] [PATCH] [Fixes]:#570
@ 2019-09-11 12:21 Wu, Haiqiang
2019-09-11 12:54 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Haiqiang @ 2019-09-11 12:21 UTC (permalink / raw)
To: ltp
Signed-off-by: Wu,Haiqiang <frequentemail@126.com>
---
testcases/kernel/syscalls/dup2/dup201.c | 24 +++++-------------------
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/testcases/kernel/syscalls/dup2/dup201.c b/testcases/kernel/syscalls/dup2/dup201.c
index 4507ac19a..066428edf 100644
--- a/testcases/kernel/syscalls/dup2/dup201.c
+++ b/testcases/kernel/syscalls/dup2/dup201.c
@@ -75,9 +75,6 @@ int maxfd;
int goodfd = 5;
int badfd = -1;
int mystdout = 0;
-int fd, fd1;
-int mypid;
-char fname[20];
struct test_case_t {
int *ofd;
@@ -86,17 +83,14 @@ struct test_case_t {
void (*setupfunc) ();
} TC[] = {
/* First fd argument is less than 0 - EBADF */
- {
- &badfd, &goodfd, EBADF, NULL},
+ {&badfd, &goodfd, EBADF, NULL},
/* First fd argument is getdtablesize() - EBADF */
- {
- &maxfd, &goodfd, EBADF, NULL},
+ {&maxfd, &goodfd, EBADF, NULL},
/* Second fd argument is less than 0 - EBADF */
- {
- &mystdout, &badfd, EBADF, NULL},
+ {&mystdout, &badfd, EBADF, NULL},
/* Second fd argument is getdtablesize() - EBADF */
- {
-&mystdout, &maxfd, EBADF, NULL},};
+ {&mystdout, &maxfd, EBADF, NULL},
+};
int main(int ac, char **av)
{
@@ -137,12 +131,6 @@ int main(int ac, char **av)
strerror(TC[i].error));
}
}
- /* cleanup things in case we are looping */
- for (j = fd1; j < maxfd; j++) {
- sprintf(fname, "dup201.%d.%d", j, mypid);
- (void)close(j);
- (void)unlink(fname);
- }
}
cleanup();
@@ -163,7 +151,6 @@ void setup(void)
/* get some test specific values */
maxfd = getdtablesize();
- mypid = getpid();
}
/*
@@ -172,6 +159,5 @@ void setup(void)
*/
void cleanup(void)
{
-
tst_rmdir();
}
--
Wu,Haiqiang<frequentemail@126.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH] [Fixes]:#570
2019-09-11 12:21 [LTP] [PATCH] [Fixes]:#570 Wu, Haiqiang
@ 2019-09-11 12:54 ` Cyril Hrubis
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2019-09-11 12:54 UTC (permalink / raw)
To: ltp
Hi!
I've written a description for the patch that should have been here and
pushed it, thanks.
Please make sure you describe why the patch is needed here next time.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH] [Fixes]:#570
@ 2019-09-11 12:13 Wu, Haiqiang
0 siblings, 0 replies; 3+ messages in thread
From: Wu, Haiqiang @ 2019-09-11 12:13 UTC (permalink / raw)
To: ltp
---
testcases/kernel/syscalls/dup2/dup201.c | 24 +++++-------------------
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/testcases/kernel/syscalls/dup2/dup201.c b/testcases/kernel/syscalls/dup2/dup201.c
index 4507ac19a..066428edf 100644
--- a/testcases/kernel/syscalls/dup2/dup201.c
+++ b/testcases/kernel/syscalls/dup2/dup201.c
@@ -75,9 +75,6 @@ int maxfd;
int goodfd = 5;
int badfd = -1;
int mystdout = 0;
-int fd, fd1;
-int mypid;
-char fname[20];
struct test_case_t {
int *ofd;
@@ -86,17 +83,14 @@ struct test_case_t {
void (*setupfunc) ();
} TC[] = {
/* First fd argument is less than 0 - EBADF */
- {
- &badfd, &goodfd, EBADF, NULL},
+ {&badfd, &goodfd, EBADF, NULL},
/* First fd argument is getdtablesize() - EBADF */
- {
- &maxfd, &goodfd, EBADF, NULL},
+ {&maxfd, &goodfd, EBADF, NULL},
/* Second fd argument is less than 0 - EBADF */
- {
- &mystdout, &badfd, EBADF, NULL},
+ {&mystdout, &badfd, EBADF, NULL},
/* Second fd argument is getdtablesize() - EBADF */
- {
-&mystdout, &maxfd, EBADF, NULL},};
+ {&mystdout, &maxfd, EBADF, NULL},
+};
int main(int ac, char **av)
{
@@ -137,12 +131,6 @@ int main(int ac, char **av)
strerror(TC[i].error));
}
}
- /* cleanup things in case we are looping */
- for (j = fd1; j < maxfd; j++) {
- sprintf(fname, "dup201.%d.%d", j, mypid);
- (void)close(j);
- (void)unlink(fname);
- }
}
cleanup();
@@ -163,7 +151,6 @@ void setup(void)
/* get some test specific values */
maxfd = getdtablesize();
- mypid = getpid();
}
/*
@@ -172,6 +159,5 @@ void setup(void)
*/
void cleanup(void)
{
-
tst_rmdir();
}
--
Wu,Haiqiang<frequentemail@126.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-11 12:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 12:21 [LTP] [PATCH] [Fixes]:#570 Wu, Haiqiang
2019-09-11 12:54 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2019-09-11 12:13 Wu, Haiqiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.