* [PATCH 0/2] correction in pktlog service connect and pktlog enable command
@ 2019-05-17 10:05 ` Abhishek Ambure
0 siblings, 0 replies; 10+ messages in thread
From: Abhishek Ambure @ 2019-05-17 10:05 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Abhishek Ambure
WCN3990 firmware supports htc pktlog service through which host driver
gets pktlog information. Pktlog service should be connected before htc
start command, hence pktlog connect is moved before htc start.
WCN3990 firwmare expects pdev_id along with filter and reserved params to
enable pktlog htc service. So adding pdev_id in pktlog enable comamnd
params.
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
Abhishek Ambure (2):
ath10k: move pktlog connect service before htc start
ath10k: correct wmi_tlv command params to enable pktlog for WCN3990
drivers/net/wireless/ath/ath10k/htc.c | 16 ++++++++--------
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++
drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 +
3 files changed, 11 insertions(+), 8 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/2] correction in pktlog service connect and pktlog enable command
@ 2019-05-17 10:05 ` Abhishek Ambure
0 siblings, 0 replies; 10+ messages in thread
From: Abhishek Ambure @ 2019-05-17 10:05 UTC (permalink / raw)
To: ath10k; +Cc: Abhishek Ambure, linux-wireless
WCN3990 firmware supports htc pktlog service through which host driver
gets pktlog information. Pktlog service should be connected before htc
start command, hence pktlog connect is moved before htc start.
WCN3990 firwmare expects pdev_id along with filter and reserved params to
enable pktlog htc service. So adding pdev_id in pktlog enable comamnd
params.
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
Abhishek Ambure (2):
ath10k: move pktlog connect service before htc start
ath10k: correct wmi_tlv command params to enable pktlog for WCN3990
drivers/net/wireless/ath/ath10k/htc.c | 16 ++++++++--------
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++
drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 +
3 files changed, 11 insertions(+), 8 deletions(-)
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] ath10k: move pktlog connect service before htc start
2019-05-17 10:05 ` Abhishek Ambure
@ 2019-05-17 10:05 ` Abhishek Ambure
-1 siblings, 0 replies; 10+ messages in thread
From: Abhishek Ambure @ 2019-05-17 10:05 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Abhishek Ambure
WCN3990 supports HTC service for pktlog. PKTLOG service should be
connected before HTC start. Hence move connect pktlog service before
HTC start
Fixes: 713358c321f4 ("ath10k: enable pktlog for WCN3990 target")
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/htc.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c
index 805a7f8..e2980fe9 100644
--- a/drivers/net/wireless/ath/ath10k/htc.c
+++ b/drivers/net/wireless/ath/ath10k/htc.c
@@ -893,6 +893,14 @@ int ath10k_htc_start(struct ath10k_htc *htc)
int status = 0;
struct ath10k_htc_msg *msg;
+ if (ath10k_htc_pktlog_svc_supported(ar)) {
+ status = ath10k_htc_pktlog_connect(ar);
+ if (status) {
+ ath10k_err(ar, "failed to connect to pktlog: %d\n", status);
+ return status;
+ }
+ }
+
skb = ath10k_htc_build_tx_ctrl_skb(htc->ar);
if (!skb)
return -ENOMEM;
@@ -919,14 +927,6 @@ int ath10k_htc_start(struct ath10k_htc *htc)
return status;
}
- if (ath10k_htc_pktlog_svc_supported(ar)) {
- status = ath10k_htc_pktlog_connect(ar);
- if (status) {
- ath10k_err(ar, "failed to connect to pktlog: %d\n", status);
- return status;
- }
- }
-
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/2] ath10k: move pktlog connect service before htc start
@ 2019-05-17 10:05 ` Abhishek Ambure
0 siblings, 0 replies; 10+ messages in thread
From: Abhishek Ambure @ 2019-05-17 10:05 UTC (permalink / raw)
To: ath10k; +Cc: Abhishek Ambure, linux-wireless
WCN3990 supports HTC service for pktlog. PKTLOG service should be
connected before HTC start. Hence move connect pktlog service before
HTC start
Fixes: 713358c321f4 ("ath10k: enable pktlog for WCN3990 target")
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/htc.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c
index 805a7f8..e2980fe9 100644
--- a/drivers/net/wireless/ath/ath10k/htc.c
+++ b/drivers/net/wireless/ath/ath10k/htc.c
@@ -893,6 +893,14 @@ int ath10k_htc_start(struct ath10k_htc *htc)
int status = 0;
struct ath10k_htc_msg *msg;
+ if (ath10k_htc_pktlog_svc_supported(ar)) {
+ status = ath10k_htc_pktlog_connect(ar);
+ if (status) {
+ ath10k_err(ar, "failed to connect to pktlog: %d\n", status);
+ return status;
+ }
+ }
+
skb = ath10k_htc_build_tx_ctrl_skb(htc->ar);
if (!skb)
return -ENOMEM;
@@ -919,14 +927,6 @@ int ath10k_htc_start(struct ath10k_htc *htc)
return status;
}
- if (ath10k_htc_pktlog_svc_supported(ar)) {
- status = ath10k_htc_pktlog_connect(ar);
- if (status) {
- ath10k_err(ar, "failed to connect to pktlog: %d\n", status);
- return status;
- }
- }
-
return 0;
}
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990
2019-05-17 10:05 ` Abhishek Ambure
@ 2019-05-17 10:05 ` Abhishek Ambure
-1 siblings, 0 replies; 10+ messages in thread
From: Abhishek Ambure @ 2019-05-17 10:05 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Abhishek Ambure
PKT log enable command expects pdev id in enable params which is missing
in current configuration. Fill pdev id in pkt log enable wmi command for
correct configuration.
Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++
drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index 582fb11..8a209f8 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
@@ -2981,6 +2981,8 @@ static void *ath10k_wmi_tlv_put_wmm(void *ptr,
tlv->len = __cpu_to_le16(sizeof(*cmd));
cmd = (void *)tlv->value;
cmd->filter = __cpu_to_le32(filter);
+ cmd->pdev_id = __cpu_to_le32(0);
+ cmd->reserved = __cpu_to_le32(0);
ptr += sizeof(*tlv);
ptr += sizeof(*cmd);
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
index 65e6aa5..5226283 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.h
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
@@ -1923,6 +1923,7 @@ struct wmi_tlv_vdev_stats {
} __packed;
struct wmi_tlv_pktlog_enable {
+ __le32 pdev_id;
__le32 reserved;
__le32 filter;
} __packed;
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990
@ 2019-05-17 10:05 ` Abhishek Ambure
0 siblings, 0 replies; 10+ messages in thread
From: Abhishek Ambure @ 2019-05-17 10:05 UTC (permalink / raw)
To: ath10k; +Cc: Abhishek Ambure, linux-wireless
PKT log enable command expects pdev id in enable params which is missing
in current configuration. Fill pdev id in pkt log enable wmi command for
correct configuration.
Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++
drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index 582fb11..8a209f8 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
@@ -2981,6 +2981,8 @@ static void *ath10k_wmi_tlv_put_wmm(void *ptr,
tlv->len = __cpu_to_le16(sizeof(*cmd));
cmd = (void *)tlv->value;
cmd->filter = __cpu_to_le32(filter);
+ cmd->pdev_id = __cpu_to_le32(0);
+ cmd->reserved = __cpu_to_le32(0);
ptr += sizeof(*tlv);
ptr += sizeof(*cmd);
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
index 65e6aa5..5226283 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.h
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
@@ -1923,6 +1923,7 @@ struct wmi_tlv_vdev_stats {
} __packed;
struct wmi_tlv_pktlog_enable {
+ __le32 pdev_id;
__le32 reserved;
__le32 filter;
} __packed;
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990
2019-05-17 10:05 ` Abhishek Ambure
(?)
@ 2019-09-18 13:45 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2019-09-18 13:45 UTC (permalink / raw)
To: Abhishek Ambure; +Cc: ath10k, linux-wireless, Abhishek Ambure
Abhishek Ambure <aambure@codeaurora.org> wrote:
> PKT log enable command expects pdev id in enable params which is missing
> in current configuration. Fill pdev id in pkt log enable wmi command for
> correct configuration.
>
> Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
>
> Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
How do I know this doesn't break QCA6174/QCA9377?
--
https://patchwork.kernel.org/patch/10947635/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990
2019-05-17 10:05 ` Abhishek Ambure
(?)
(?)
@ 2019-09-18 13:45 ` Kalle Valo
2019-09-23 7:53 ` Kalle Valo
-1 siblings, 1 reply; 10+ messages in thread
From: Kalle Valo @ 2019-09-18 13:45 UTC (permalink / raw)
To: Abhishek Ambure; +Cc: linux-wireless, ath10k
Abhishek Ambure <aambure@codeaurora.org> wrote:
> PKT log enable command expects pdev id in enable params which is missing
> in current configuration. Fill pdev id in pkt log enable wmi command for
> correct configuration.
>
> Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
>
> Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
How do I know this doesn't break QCA6174/QCA9377?
--
https://patchwork.kernel.org/patch/10947635/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990
2019-09-18 13:45 ` Kalle Valo
@ 2019-09-23 7:53 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2019-09-23 7:53 UTC (permalink / raw)
To: Abhishek Ambure; +Cc: linux-wireless, ath10k
Kalle Valo <kvalo@codeaurora.org> writes:
> Abhishek Ambure <aambure@codeaurora.org> wrote:
>
>> PKT log enable command expects pdev id in enable params which is missing
>> in current configuration. Fill pdev id in pkt log enable wmi command for
>> correct configuration.
>>
>> Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
>> Tested HW: WCN3990
>> Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
>>
>> Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
> How do I know this doesn't break QCA6174/QCA9377?
Abhishek mentioned me privately that he is checking this.
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990
@ 2019-09-23 7:53 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2019-09-23 7:53 UTC (permalink / raw)
To: Abhishek Ambure; +Cc: linux-wireless, ath10k
Kalle Valo <kvalo@codeaurora.org> writes:
> Abhishek Ambure <aambure@codeaurora.org> wrote:
>
>> PKT log enable command expects pdev id in enable params which is missing
>> in current configuration. Fill pdev id in pkt log enable wmi command for
>> correct configuration.
>>
>> Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
>> Tested HW: WCN3990
>> Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
>>
>> Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
> How do I know this doesn't break QCA6174/QCA9377?
Abhishek mentioned me privately that he is checking this.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-09-23 7:53 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 10:05 [PATCH 0/2] correction in pktlog service connect and pktlog enable command Abhishek Ambure
2019-05-17 10:05 ` Abhishek Ambure
2019-05-17 10:05 ` [PATCH 1/2] ath10k: move pktlog connect service before htc start Abhishek Ambure
2019-05-17 10:05 ` Abhishek Ambure
2019-05-17 10:05 ` [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990 Abhishek Ambure
2019-05-17 10:05 ` Abhishek Ambure
2019-09-18 13:45 ` Kalle Valo
2019-09-18 13:45 ` Kalle Valo
2019-09-23 7:53 ` Kalle Valo
2019-09-23 7:53 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.