From: Benoit Parrot <bparrot@ti.com> To: Hans Verkuil <hverkuil@xs4all.nl> Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Benoit Parrot <bparrot@ti.com> Subject: [Patch 00/13] media: am437x-vpfe: overdue maintenance Date: Thu, 19 Sep 2019 15:41:12 -0500 [thread overview] Message-ID: <20190919204125.15254-1-bparrot@ti.com> (raw) This patch series is a collection of patches we have been carrying for a while. A few patches do fix actual bug and v4l2-compliance errors/warnings. Other are drivers re-work to simplify/clarify the code for easier maintenance. We also include the SPDX Licensing update which seemed to have been missed by the global script thus far. Changes since v1: - Address review comment from Joe, Hans and Prabhakar - Cleaned-up the function entry debug log - Split off the pcr change into its own patch - Rework/combine two patches but remove code churn - fix miscellaneous typos ============================= v4l2-compliance SHA: 5b168dc8473911227890526bad26553d9e8ff81b, 32 bits Compliance test for vpfe device /dev/video0: Driver Info: Driver name : vpfe Card type : TI AM437x VPFE Bus info : platform:vpfe 48326000.vpfe Driver version : 5.3.0 Capabilities : 0x85200001 Vide o Capture Read/Write Streaming Extended Pix Format D evice Capabilities Device Caps : 0x05200001 Video Capt ure Read/Write Streaming Extended Pix Format Required ioctls: test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second /dev/video0 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls (Input 0): test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 3 Private Controls: 0 Format ioctls (Input 0): test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) fail: v4l2-test-formats.cpp(1419): node->frmsizes_count[pixfmt] > 1 test Cropping: FAIL test Composing: OK (Not Supported) test Scaling: OK (Not Supported) Codec ioctls (Input 0): test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls (Input 0): test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Test input 0: Streaming ioctls: test read/write: OK test blocking wait: OK test MMAP (no poll): OK test MMAP (select): OK test MMAP (epoll): OK test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total for vpfe device /dev/video0: 51, Succeeded: 50, Failed: 1, Warnings: 0 dd ============================ Benoit Parrot (12): media: am437x-vpfe: Fix missing first line media: am437x-vpfe: Rework ISR routine for clarity media: am437x-vpfe: Wait for end of frame before tear-down media: am437x-vpfe: fix start streaming error path media: am437x-vpfe: Streamlined vb2 buffer cleanup media: am437x-vpfe: Setting STD to current value is not an error media: am437x-vpfe: Use a per instance format array instead of a static one media: am437x-vpfe: fix function trace debug log media: am437x-vpfe: Remove print_fourcc helper media: am437x-vpfe: TRY_FMT ioctl is not really trying anything media: am437x-vpfe: Remove per bus width static data media: am437x-vpfe: Switch to SPDX Licensing Dave Gerlach (1): media: am437x-vpfe: Fix suspend path to always handle pinctrl config drivers/media/platform/am437x/am437x-vpfe.c | 878 ++++++++---------- drivers/media/platform/am437x/am437x-vpfe.h | 45 +- .../media/platform/am437x/am437x-vpfe_regs.h | 10 +- 3 files changed, 406 insertions(+), 527 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Benoit Parrot <bparrot@ti.com> To: Hans Verkuil <hverkuil@xs4all.nl> Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Benoit Parrot <bparrot@ti.com> Subject: [Patch 00/13] media: am437x-vpfe: overdue maintenance Date: Thu, 19 Sep 2019 15:41:12 -0500 [thread overview] Message-ID: <20190919204125.15254-1-bparrot@ti.com> (raw) This patch series is a collection of patches we have been carrying for a while. A few patches do fix actual bug and v4l2-compliance errors/warnings. Other are drivers re-work to simplify/clarify the code for easier maintenance. We also include the SPDX Licensing update which seemed to have been missed by the global script thus far. Changes since v1: - Address review comment from Joe, Hans and Prabhakar - Cleaned-up the function entry debug log - Split off the pcr change into its own patch - Rework/combine two patches but remove code churn - fix miscellaneous typos ============================= v4l2-compliance SHA: 5b168dc8473911227890526bad26553d9e8ff81b, 32 bits Compliance test for vpfe device /dev/video0: Driver Info: Driver name : vpfe Card type : TI AM437x VPFE Bus info : platform:vpfe 48326000.vpfe Driver version : 5.3.0 Capabilities : 0x85200001 Vide o Capture Read/Write Streaming Extended Pix Format D evice Capabilities Device Caps : 0x05200001 Video Capt ure Read/Write Streaming Extended Pix Format Required ioctls: test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second /dev/video0 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls (Input 0): test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 3 Private Controls: 0 Format ioctls (Input 0): test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) fail: v4l2-test-formats.cpp(1419): node->frmsizes_count[pixfmt] > 1 test Cropping: FAIL test Composing: OK (Not Supported) test Scaling: OK (Not Supported) Codec ioctls (Input 0): test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls (Input 0): test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Test input 0: Streaming ioctls: test read/write: OK test blocking wait: OK test MMAP (no poll): OK test MMAP (select): OK test MMAP (epoll): OK test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total for vpfe device /dev/video0: 51, Succeeded: 50, Failed: 1, Warnings: 0 dd ============================ Benoit Parrot (12): media: am437x-vpfe: Fix missing first line media: am437x-vpfe: Rework ISR routine for clarity media: am437x-vpfe: Wait for end of frame before tear-down media: am437x-vpfe: fix start streaming error path media: am437x-vpfe: Streamlined vb2 buffer cleanup media: am437x-vpfe: Setting STD to current value is not an error media: am437x-vpfe: Use a per instance format array instead of a static one media: am437x-vpfe: fix function trace debug log media: am437x-vpfe: Remove print_fourcc helper media: am437x-vpfe: TRY_FMT ioctl is not really trying anything media: am437x-vpfe: Remove per bus width static data media: am437x-vpfe: Switch to SPDX Licensing Dave Gerlach (1): media: am437x-vpfe: Fix suspend path to always handle pinctrl config drivers/media/platform/am437x/am437x-vpfe.c | 878 ++++++++---------- drivers/media/platform/am437x/am437x-vpfe.h | 45 +- .../media/platform/am437x/am437x-vpfe_regs.h | 10 +- 3 files changed, 406 insertions(+), 527 deletions(-) -- 2.17.1
next reply other threads:[~2019-09-19 20:39 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-19 20:41 Benoit Parrot [this message] 2019-09-19 20:41 ` [Patch 00/13] media: am437x-vpfe: overdue maintenance Benoit Parrot 2019-09-19 20:41 ` [Patch v2 01/13] media: am437x-vpfe: Fix suspend path to always handle pinctrl config Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 02/13] media: am437x-vpfe: Fix missing first line Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 03/13] media: am437x-vpfe: Rework ISR routine for clarity Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 04/13] media: am437x-vpfe: Wait for end of frame before tear-down Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 05/13] media: am437x-vpfe: fix start streaming error path Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 06/13] media: am437x-vpfe: Streamlined vb2 buffer cleanup Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 07/13] media: am437x-vpfe: Setting STD to current value is not an error Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 08/13] media: am437x-vpfe: Use a per instance format array instead of a static one Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-20 8:19 ` Hans Verkuil 2019-09-20 12:13 ` Benoit Parrot 2019-09-20 12:13 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 09/13] media: am437x-vpfe: fix function trace debug log Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 10/13] media: am437x-vpfe: Remove print_fourcc helper Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-20 8:21 ` Hans Verkuil 2019-09-20 12:18 ` Benoit Parrot 2019-09-20 12:18 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 11/13] media: am437x-vpfe: TRY_FMT ioctl is not really trying anything Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 12/13] media: am437x-vpfe: Remove per bus width static data Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-19 20:41 ` [Patch v2 13/13] media: am437x-vpfe: Switch to SPDX Licensing Benoit Parrot 2019-09-19 20:41 ` Benoit Parrot 2019-09-20 8:25 ` [Patch 00/13] media: am437x-vpfe: overdue maintenance Hans Verkuil 2019-09-20 12:20 ` Benoit Parrot 2019-09-20 12:20 ` Benoit Parrot -- strict thread matches above, loose matches on Subject: below -- 2019-09-09 16:27 Benoit Parrot 2019-09-09 16:27 ` Benoit Parrot 2019-09-10 10:42 ` Hans Verkuil 2019-09-10 16:20 ` Benoit Parrot 2019-09-10 16:20 ` Benoit Parrot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190919204125.15254-1-bparrot@ti.com \ --to=bparrot@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=hverkuil@xs4all.nl \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=prabhakar.csengg@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.