All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leonardo Bras <leonardo@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Leonardo Bras <leonardo@linux.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Arnd Bergmann <arnd@arndb.de>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Richard Fontana <rfontana@redhat.com>,
	Ganesh Goudar <ganeshgr@linux.ibm.com>,
	Allison Randal <allison@lohutok.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mike Rapoport <rppt@linux.ibm.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Ira Weiny <ira.weiny@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	John Hubbard <jhubbard@nvidia.com>,
	Keith Busch <keith.busch@intel.com>
Subject: [PATCH v2 05/11] powerpc/perf: Applies counting method to monitor lockless pgtbl walks
Date: Fri, 20 Sep 2019 16:50:41 -0300	[thread overview]
Message-ID: <20190920195047.7703-6-leonardo@linux.ibm.com> (raw)
In-Reply-To: <20190920195047.7703-1-leonardo@linux.ibm.com>

Applies the counting-based method for monitoring lockless pgtable walks on
read_user_stack_slow.

Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
---
 arch/powerpc/perf/callchain.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/perf/callchain.c b/arch/powerpc/perf/callchain.c
index c84bbd4298a0..9d76194a2a8f 100644
--- a/arch/powerpc/perf/callchain.c
+++ b/arch/powerpc/perf/callchain.c
@@ -113,16 +113,18 @@ static int read_user_stack_slow(void __user *ptr, void *buf, int nb)
 	int ret = -EFAULT;
 	pgd_t *pgdir;
 	pte_t *ptep, pte;
+	struct mm_struct *mm = current->mm;
 	unsigned shift;
 	unsigned long addr = (unsigned long) ptr;
 	unsigned long offset;
 	unsigned long pfn, flags;
 	void *kaddr;
 
-	pgdir = current->mm->pgd;
+	pgdir = mm->pgd;
 	if (!pgdir)
 		return -EFAULT;
 
+	start_lockless_pgtbl_walk(mm);
 	local_irq_save(flags);
 	ptep = find_current_mm_pte(pgdir, addr, NULL, &shift);
 	if (!ptep)
@@ -146,6 +148,7 @@ static int read_user_stack_slow(void __user *ptr, void *buf, int nb)
 	ret = 0;
 err_out:
 	local_irq_restore(flags);
+	end_lockless_pgtbl_walk(mm);
 	return ret;
 }
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Leonardo Bras <leonardo@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Keith Busch <keith.busch@intel.com>,
	Richard Fontana <rfontana@redhat.com>,
	Paul Mackerras <paulus@samba.org>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Ganesh Goudar <ganeshgr@linux.ibm.com>,
	Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
	Leonardo Bras <leonardo@linux.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>, John Hubbard <jhubbard@nvidia.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v2 05/11] powerpc/perf: Applies counting method to monitor lockless pgtbl walks
Date: Fri, 20 Sep 2019 16:50:41 -0300	[thread overview]
Message-ID: <20190920195047.7703-6-leonardo@linux.ibm.com> (raw)
In-Reply-To: <20190920195047.7703-1-leonardo@linux.ibm.com>

Applies the counting-based method for monitoring lockless pgtable walks on
read_user_stack_slow.

Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
---
 arch/powerpc/perf/callchain.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/perf/callchain.c b/arch/powerpc/perf/callchain.c
index c84bbd4298a0..9d76194a2a8f 100644
--- a/arch/powerpc/perf/callchain.c
+++ b/arch/powerpc/perf/callchain.c
@@ -113,16 +113,18 @@ static int read_user_stack_slow(void __user *ptr, void *buf, int nb)
 	int ret = -EFAULT;
 	pgd_t *pgdir;
 	pte_t *ptep, pte;
+	struct mm_struct *mm = current->mm;
 	unsigned shift;
 	unsigned long addr = (unsigned long) ptr;
 	unsigned long offset;
 	unsigned long pfn, flags;
 	void *kaddr;
 
-	pgdir = current->mm->pgd;
+	pgdir = mm->pgd;
 	if (!pgdir)
 		return -EFAULT;
 
+	start_lockless_pgtbl_walk(mm);
 	local_irq_save(flags);
 	ptep = find_current_mm_pte(pgdir, addr, NULL, &shift);
 	if (!ptep)
@@ -146,6 +148,7 @@ static int read_user_stack_slow(void __user *ptr, void *buf, int nb)
 	ret = 0;
 err_out:
 	local_irq_restore(flags);
+	end_lockless_pgtbl_walk(mm);
 	return ret;
 }
 
-- 
2.20.1


  parent reply	other threads:[~2019-09-20 19:52 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 19:50 [PATCH v2 00/11] Introduces new count-based method for monitoring lockless pagetable wakls Leonardo Bras
2019-09-20 19:50 ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 01/11] powerpc/mm: Adds counting method to monitor lockless pgtable walks Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-23 20:42   ` John Hubbard
2019-09-23 20:42     ` John Hubbard
2019-09-23 20:50     ` Leonardo Bras
2019-09-23 20:50       ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 02/11] asm-generic/pgtable: Adds dummy functions " Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-23 20:39   ` John Hubbard
2019-09-23 20:39     ` John Hubbard
2019-09-23 20:48     ` Leonardo Bras
2019-09-23 20:48       ` Leonardo Bras
2019-09-23 20:53       ` John Hubbard
2019-09-23 20:53         ` John Hubbard
2019-09-20 19:50 ` [PATCH v2 03/11] mm/gup: Applies counting method to monitor gup_pgd_range Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-23 20:27   ` John Hubbard
2019-09-23 20:27     ` John Hubbard
2019-09-23 21:01     ` Leonardo Bras
2019-09-23 21:01       ` Leonardo Bras
2019-09-23 21:09       ` John Hubbard
2019-09-23 21:09         ` John Hubbard
2019-09-20 19:50 ` [PATCH v2 04/11] powerpc/mce_power: Applies counting method to monitor lockless pgtbl walks Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-20 19:50 ` Leonardo Bras [this message]
2019-09-20 19:50   ` [PATCH v2 05/11] powerpc/perf: " Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 06/11] powerpc/mm/book3s64/hash: " Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 07/11] powerpc/kvm/e500: " Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 08/11] powerpc/kvm/book3s_hv: " Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-23 20:47   ` John Hubbard
2019-09-23 20:47     ` John Hubbard
2019-09-20 19:50 ` [PATCH v2 09/11] powerpc/kvm/book3s_64: " Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 10/11] powerpc/book3s_64: Enables counting method to monitor lockless pgtbl walk Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-20 19:50 ` [PATCH v2 11/11] powerpc/mm/book3s64/pgtable: Uses counting method to skip serializing Leonardo Bras
2019-09-20 19:50   ` Leonardo Bras
2019-09-20 20:11   ` John Hubbard
2019-09-20 20:28     ` Leonardo Bras
2019-09-20 20:28       ` Leonardo Bras
2019-09-20 21:15       ` John Hubbard
2019-09-21  0:48       ` John Hubbard
2019-09-21  0:48         ` John Hubbard
2019-09-23 17:25         ` Leonardo Bras
2019-09-23 17:25           ` Leonardo Bras
2019-09-23 18:14           ` John Hubbard
2019-09-23 18:14             ` John Hubbard
2019-09-23 19:40             ` Leonardo Bras
2019-09-23 19:40               ` Leonardo Bras
2019-09-23 19:58               ` John Hubbard
2019-09-23 19:58                 ` John Hubbard
2019-09-23 20:23                 ` Leonardo Bras
2019-09-23 20:23                   ` Leonardo Bras
2019-09-23 20:26                   ` John Hubbard
2019-09-23 20:26                     ` John Hubbard
2019-09-20 19:56 ` [PATCH v2 00/11] Introduces new count-based method for monitoring lockless pagetable wakls Leonardo Bras
2019-09-20 19:56   ` Leonardo Bras
2019-09-20 20:12 ` Leonardo Bras
2019-09-20 20:12   ` Leonardo Bras
2019-09-20 21:24   ` John Hubbard
2019-09-20 21:24     ` John Hubbard
2019-09-23 20:51   ` John Hubbard
2019-09-23 20:51     ` John Hubbard
2019-09-23 20:58     ` Leonardo Bras
2019-09-23 20:58       ` Leonardo Bras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190920195047.7703-6-leonardo@linux.ibm.com \
    --to=leonardo@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=allison@lohutok.net \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=dan.j.williams@intel.com \
    --cc=ganeshgr@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ira.weiny@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=rfontana@redhat.com \
    --cc=rppt@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.