* [Buildroot] [PATCH v3 1/1] package/libsodium: add config for full build
@ 2019-09-22 20:04 Adrien Gallouët
2019-09-23 7:24 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Gallouët @ 2019-09-22 20:04 UTC (permalink / raw)
To: buildroot
A new default option is added to build all functions.
Signed-off-by: Adrien Gallou?t <adrien@gallouet.fr>
---
Changes v2 -> v3:
- add a better help (suggested by Arnout Vandecappelle)
Changes v1 -> v2:
- full build (suggested by Arnout Vandecappelle)
---
package/libsodium/Config.in | 12 ++++++++++++
package/libsodium/libsodium.mk | 4 ++++
2 files changed, 16 insertions(+)
diff --git a/package/libsodium/Config.in b/package/libsodium/Config.in
index 47b9bb350c..518b0532ed 100644
--- a/package/libsodium/Config.in
+++ b/package/libsodium/Config.in
@@ -4,3 +4,15 @@ config BR2_PACKAGE_LIBSODIUM
A modern and easy-to-use crypto library.
http://libsodium.org/
+
+if BR2_PACKAGE_LIBSODIUM
+
+config BR2_PACKAGE_LIBSODIUM_FULL
+ bool "all functions"
+ default y
+ help
+ Build all seldom used and obsolete functions. Without
+ this option, only the minimal set of normally used
+ functions is built.
+
+endif
diff --git a/package/libsodium/libsodium.mk b/package/libsodium/libsodium.mk
index a94a8271c5..9afa09ff37 100644
--- a/package/libsodium/libsodium.mk
+++ b/package/libsodium/libsodium.mk
@@ -14,5 +14,9 @@ ifeq ($(BR2_TOOLCHAIN_SUPPORTS_PIE),)
LIBSODIUM_CONF_OPTS += --disable-pie
endif
+ifeq ($(BR2_PACKAGE_LIBSODIUM_FULL),)
+LIBSODIUM_CONF_OPTS += --enable-minimal
+endif
+
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v3 1/1] package/libsodium: add config for full build
2019-09-22 20:04 [Buildroot] [PATCH v3 1/1] package/libsodium: add config for full build Adrien Gallouët
@ 2019-09-23 7:24 ` Thomas Petazzoni
2019-09-23 9:58 ` Adrien Gallouët
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2019-09-23 7:24 UTC (permalink / raw)
To: buildroot
On Sun, 22 Sep 2019 20:04:10 +0000
Adrien Gallou?t <adrien@gallouet.fr> wrote:
> A new default option is added to build all functions.
>
> Signed-off-by: Adrien Gallou?t <adrien@gallouet.fr>
I have missed the original discussion, but what is the reason to
enable this by default ? It should be explained in the commit log I
believe.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v3 1/1] package/libsodium: add config for full build
2019-09-23 7:24 ` Thomas Petazzoni
@ 2019-09-23 9:58 ` Adrien Gallouët
0 siblings, 0 replies; 3+ messages in thread
From: Adrien Gallouët @ 2019-09-23 9:58 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Mon, Sep 23, 2019 at 9:24 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Sun, 22 Sep 2019 20:04:10 +0000
> Adrien Gallou?t <adrien@gallouet.fr> wrote:
>
> > A new default option is added to build all functions.
> >
> > Signed-off-by: Adrien Gallou?t <adrien@gallouet.fr>
>
> I have missed the original discussion, but what is the reason to
> enable this by default ? It should be explained in the commit log I
> believe.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
I submitted a new patch with a more detailed commit log.
Regards,
Adrien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-23 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-22 20:04 [Buildroot] [PATCH v3 1/1] package/libsodium: add config for full build Adrien Gallouët
2019-09-23 7:24 ` Thomas Petazzoni
2019-09-23 9:58 ` Adrien Gallouët
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.