From: Matthew Wilcox <willy@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org,
catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
mhocko@suse.com, david@redhat.com, cai@lca.pw,
logang@deltatee.com, cpandya@codeaurora.org,
arunks@codeaurora.org, dan.j.williams@intel.com,
mgorman@techsingularity.net, osalvador@suse.de,
ard.biesheuvel@arm.com, steve.capper@arm.com, broonie@kernel.org,
valentin.schneider@arm.com, Robin.Murphy@arm.com,
steven.price@arm.com, suzuki.poulose@arm.com,
ira.weiny@intel.com
Subject: Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove
Date: Mon, 23 Sep 2019 04:17:45 -0700 [thread overview]
Message-ID: <20190923111745.GG15392@bombadil.infradead.org> (raw)
In-Reply-To: <1569217425-23777-3-git-send-email-anshuman.khandual@arm.com>
On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote:
> +#ifdef CONFIG_MEMORY_HOTPLUG
> +static void free_hotplug_page_range(struct page *page, size_t size)
> +{
> + WARN_ON(!page || PageReserved(page));
WARN_ON(!page) isn't terribly useful. You're going to crash on the very
next line when you call page_address() anyway. If this line were
if (WARN_ON(!page || PageReserved(page)))
return;
it would make sense, or if it were just
WARN_ON(PageReserved(page))
it would also make sense.
> + free_pages((unsigned long)page_address(page), get_order(size));
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: mark.rutland@arm.com, mhocko@suse.com, david@redhat.com,
catalin.marinas@arm.com, linux-mm@kvack.org,
arunks@codeaurora.org, cpandya@codeaurora.org, will@kernel.org,
ira.weiny@intel.com, steven.price@arm.com,
valentin.schneider@arm.com, suzuki.poulose@arm.com,
Robin.Murphy@arm.com, broonie@kernel.org, cai@lca.pw,
ard.biesheuvel@arm.com, dan.j.williams@intel.com,
linux-arm-kernel@lists.infradead.org, osalvador@suse.de,
steve.capper@arm.com, logang@deltatee.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mgorman@techsingularity.net
Subject: Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove
Date: Mon, 23 Sep 2019 04:17:45 -0700 [thread overview]
Message-ID: <20190923111745.GG15392@bombadil.infradead.org> (raw)
In-Reply-To: <1569217425-23777-3-git-send-email-anshuman.khandual@arm.com>
On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote:
> +#ifdef CONFIG_MEMORY_HOTPLUG
> +static void free_hotplug_page_range(struct page *page, size_t size)
> +{
> + WARN_ON(!page || PageReserved(page));
WARN_ON(!page) isn't terribly useful. You're going to crash on the very
next line when you call page_address() anyway. If this line were
if (WARN_ON(!page || PageReserved(page)))
return;
it would make sense, or if it were just
WARN_ON(PageReserved(page))
it would also make sense.
> + free_pages((unsigned long)page_address(page), get_order(size));
> +}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-23 11:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 5:43 [PATCH V8 0/2] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-09-23 5:43 ` Anshuman Khandual
2019-09-23 5:43 ` [PATCH V8 1/2] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump Anshuman Khandual
2019-09-23 5:43 ` Anshuman Khandual
2019-09-23 5:43 ` [PATCH V8 2/2] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-09-23 5:43 ` Anshuman Khandual
2019-09-23 11:17 ` Matthew Wilcox [this message]
2019-09-23 11:17 ` Matthew Wilcox
2019-09-24 8:41 ` Anshuman Khandual
2019-09-24 8:41 ` Anshuman Khandual
2019-09-23 17:39 ` kbuild test robot
2019-09-23 17:39 ` kbuild test robot
2019-10-07 14:17 ` Catalin Marinas
2019-10-07 14:17 ` Catalin Marinas
2019-10-08 4:36 ` Anshuman Khandual
2019-10-08 4:36 ` Anshuman Khandual
2019-10-08 10:55 ` Catalin Marinas
2019-10-08 10:55 ` Catalin Marinas
2019-10-08 11:48 ` Anshuman Khandual
2019-10-08 11:48 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923111745.GG15392@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Robin.Murphy@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ard.biesheuvel@arm.com \
--cc=arunks@codeaurora.org \
--cc=broonie@kernel.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=steve.capper@arm.com \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.