All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaowei Bao <xiaowei.bao@nxp.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
	leoyang.li@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com,
	minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com,
	jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
	andrew.murray@arm.com, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Xiaowei Bao <xiaowei.bao@nxp.com>
Subject: [PATCH v4 08/11] PCI: layerscape: Modify the MSIX to the doorbell mode
Date: Tue, 24 Sep 2019 10:18:46 +0800	[thread overview]
Message-ID: <20190924021849.3185-9-xiaowei.bao@nxp.com> (raw)
In-Reply-To: <20190924021849.3185-1-xiaowei.bao@nxp.com>

dw_pcie_ep_raise_msix_irq was never called in the exisitng driver
before, because the ls1046a platform don't support the MSIX feature
and msix_capable was always set to false.
Now that add the ls1088a platform with MSIX support, but the existing
dw_pcie_ep_raise_msix_irq doesn't work, so use the doorbell method to
support the MSIX feature.

Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
Reviewed-by: Andrew Murray <andrew.murray@arm.com>
---
v2: 
 - No change
v3:
 - Modify the commit message make it clearly.
v4: 
 - No change

 drivers/pci/controller/dwc/pci-layerscape-ep.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index 1e07287..5f0cb99 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -79,7 +79,8 @@ static int ls_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
 	case PCI_EPC_IRQ_MSI:
 		return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num);
 	case PCI_EPC_IRQ_MSIX:
-		return dw_pcie_ep_raise_msix_irq(ep, func_no, interrupt_num);
+		return dw_pcie_ep_raise_msix_irq_doorbell(ep, func_no,
+							  interrupt_num);
 	default:
 		dev_err(pci->dev, "UNKNOWN IRQ type\n");
 		return -EINVAL;
-- 
2.9.5


WARNING: multiple messages have this Message-ID (diff)
From: Xiaowei Bao <xiaowei.bao@nxp.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
	leoyang.li@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com,
	minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com,
	jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
	andrew.murray@arm.com, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Xiaowei Bao <xiaowei.bao@nxp.com>
Subject: [PATCH v4 08/11] PCI: layerscape: Modify the MSIX to the doorbell mode
Date: Tue, 24 Sep 2019 10:18:46 +0800	[thread overview]
Message-ID: <20190924021849.3185-9-xiaowei.bao@nxp.com> (raw)
In-Reply-To: <20190924021849.3185-1-xiaowei.bao@nxp.com>

dw_pcie_ep_raise_msix_irq was never called in the exisitng driver
before, because the ls1046a platform don't support the MSIX feature
and msix_capable was always set to false.
Now that add the ls1088a platform with MSIX support, but the existing
dw_pcie_ep_raise_msix_irq doesn't work, so use the doorbell method to
support the MSIX feature.

Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
Reviewed-by: Andrew Murray <andrew.murray@arm.com>
---
v2: 
 - No change
v3:
 - Modify the commit message make it clearly.
v4: 
 - No change

 drivers/pci/controller/dwc/pci-layerscape-ep.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index 1e07287..5f0cb99 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -79,7 +79,8 @@ static int ls_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
 	case PCI_EPC_IRQ_MSI:
 		return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num);
 	case PCI_EPC_IRQ_MSIX:
-		return dw_pcie_ep_raise_msix_irq(ep, func_no, interrupt_num);
+		return dw_pcie_ep_raise_msix_irq_doorbell(ep, func_no,
+							  interrupt_num);
 	default:
 		dev_err(pci->dev, "UNKNOWN IRQ type\n");
 		return -EINVAL;
-- 
2.9.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-09-24  2:30 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24  2:18 [PATCH v4 00/11] Add the multiple PF support for DWC and Layerscape Xiaowei Bao
2019-09-24  2:18 ` Xiaowei Bao
2019-09-24  2:18 ` [PATCH v4 01/11] PCI: designware-ep: Add multiple PFs support for DWC Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-26 13:27   ` Gustavo Pimentel
2019-09-26 13:27     ` Gustavo Pimentel
2019-09-26 13:27     ` Gustavo Pimentel
2019-09-26 13:27     ` Gustavo Pimentel
2019-09-24  2:18 ` [PATCH v4 02/11] PCI: designware-ep: Add the doorbell mode of MSI-X in EP mode Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-24  2:18 ` [PATCH v4 03/11] PCI: designware-ep: Move the function of getting MSI capability forward Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-24  2:18 ` [PATCH v4 04/11] PCI: designware-ep: Modify MSI and MSIX CAP way of finding Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-24  2:18 ` [PATCH v4 05/11] dt-bindings: pci: layerscape-pci: Add compatible strings for ls1088a and ls2088a Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-27 17:07   ` Rob Herring
2019-09-27 17:07     ` Rob Herring
2019-09-27 17:07     ` Rob Herring
2019-09-27 17:07     ` Rob Herring
2019-09-24  2:18 ` [PATCH v4 06/11] PCI: layerscape: Fix some format issue of the code Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-24  2:18 ` [PATCH v4 07/11] PCI: layerscape: Modify the way of getting capability with different PEX Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-24  2:18 ` Xiaowei Bao [this message]
2019-09-24  2:18   ` [PATCH v4 08/11] PCI: layerscape: Modify the MSIX to the doorbell mode Xiaowei Bao
2020-02-28 11:40   ` Kishon Vijay Abraham I
2020-02-28 11:40     ` Kishon Vijay Abraham I
2020-02-28 14:43     ` Xiaowei Bao
2020-02-28 14:43       ` Xiaowei Bao
2020-02-28 14:43       ` Xiaowei Bao
2019-09-24  2:18 ` [PATCH v4 09/11] PCI: layerscape: Add EP mode support for ls1088a and ls2088a Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-24  2:18 ` [PATCH v4 10/11] arm64: dts: layerscape: Add PCIe EP node for ls1088a Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-30 14:55   ` Andrew Murray
2019-09-30 14:55     ` Andrew Murray
2019-09-30 14:55     ` Andrew Murray
2019-09-24  2:18 ` [PATCH v4 11/11] misc: pci_endpoint_test: Add LS1088a in pci_device_id table Xiaowei Bao
2019-09-24  2:18   ` Xiaowei Bao
2019-09-30 14:57   ` Andrew Murray
2019-09-30 14:57     ` Andrew Murray
2019-09-30 14:57     ` Andrew Murray
2019-10-08  1:23     ` Xiaowei Bao
2019-10-08  1:23       ` Xiaowei Bao
2019-10-08  1:23       ` Xiaowei Bao
2019-10-08  1:23       ` Xiaowei Bao
2020-02-28 11:30 ` [PATCH v4 00/11] Add the multiple PF support for DWC and Layerscape Lorenzo Pieralisi
2020-02-28 11:30   ` Lorenzo Pieralisi
2020-02-28 11:30   ` Lorenzo Pieralisi
2020-02-28 14:52   ` Xiaowei Bao
2020-02-28 14:52     ` Xiaowei Bao
2020-02-28 14:52     ` Xiaowei Bao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190924021849.3185-9-xiaowei.bao@nxp.com \
    --to=xiaowei.bao@nxp.com \
    --cc=andrew.murray@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=minghuan.Lian@nxp.com \
    --cc=mingkai.hu@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=roy.zang@nxp.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.