All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] quectel: remove unused variable in quectel_pre_sim
@ 2019-09-24  7:23 Nicola Lunghi
  0 siblings, 0 replies; 5+ messages in thread
From: Nicola Lunghi @ 2019-09-24  7:23 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

From: Nicola Lunghi <nick83ola@gmail.com>

This variable was left over by a previous commit and in gcc 9.1
was throwing an error an error (unused variable)
---
 plugins/quectel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/quectel.c b/plugins/quectel.c
index d4947489..1d21d6dd 100644
--- a/plugins/quectel.c
+++ b/plugins/quectel.c
@@ -1147,7 +1147,6 @@ static void quectel_set_online(struct ofono_modem *modem, ofono_bool_t online,
 static void quectel_pre_sim(struct ofono_modem *modem)
 {
 	struct quectel_data *data = ofono_modem_get_data(modem);
-	struct ofono_sim *sim;
 
 	DBG("%p", modem);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] quectel: remove unused variable in quectel_pre_sim
  2019-09-24  7:15 Nicola Lunghi
@ 2019-09-24 14:56 ` Denis Kenzior
  0 siblings, 0 replies; 5+ messages in thread
From: Denis Kenzior @ 2019-09-24 14:56 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi Nicola,

On 9/24/19 2:15 AM, Nicola Lunghi wrote:
> From: Nicola Lunghi <nick83ola@gmail.com>
> 
> This variable was left over by a previous commit and in gcc 9.1
> was throwing an error an error (unused variable)
> ---
>   plugins/quectel.c | 1 -
>   1 file changed, 1 deletion(-)
> 

Thanks for the patch.  I pushed the one from Richard since it was in my 
mailbox a bit earlier.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] quectel: remove unused variable in quectel_pre_sim
@ 2019-09-24  7:32 Nicola Lunghi
  0 siblings, 0 replies; 5+ messages in thread
From: Nicola Lunghi @ 2019-09-24  7:32 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

From: Nicola Lunghi <nick83ola@gmail.com>

This variable was left over by a previous commit and in gcc 9.1
was throwing an error an error (unused variable)
---
 plugins/quectel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/quectel.c b/plugins/quectel.c
index d4947489..1d21d6dd 100644
--- a/plugins/quectel.c
+++ b/plugins/quectel.c
@@ -1147,7 +1147,6 @@ static void quectel_set_online(struct ofono_modem *modem, ofono_bool_t online,
 static void quectel_pre_sim(struct ofono_modem *modem)
 {
 	struct quectel_data *data = ofono_modem_get_data(modem);
-	struct ofono_sim *sim;
 
 	DBG("%p", modem);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] quectel: remove unused variable in quectel_pre_sim
@ 2019-09-24  7:31 Nicola Lunghi
  0 siblings, 0 replies; 5+ messages in thread
From: Nicola Lunghi @ 2019-09-24  7:31 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

From: Nicola Lunghi <nick83ola@gmail.com>

This variable was left over by a previous commit and in gcc 9.1
was throwing an error an error (unused variable)
---
 plugins/quectel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/quectel.c b/plugins/quectel.c
index d4947489..1d21d6dd 100644
--- a/plugins/quectel.c
+++ b/plugins/quectel.c
@@ -1147,7 +1147,6 @@ static void quectel_set_online(struct ofono_modem *modem, ofono_bool_t online,
 static void quectel_pre_sim(struct ofono_modem *modem)
 {
 	struct quectel_data *data = ofono_modem_get_data(modem);
-	struct ofono_sim *sim;
 
 	DBG("%p", modem);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] quectel: remove unused variable in quectel_pre_sim
@ 2019-09-24  7:15 Nicola Lunghi
  2019-09-24 14:56 ` Denis Kenzior
  0 siblings, 1 reply; 5+ messages in thread
From: Nicola Lunghi @ 2019-09-24  7:15 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

From: Nicola Lunghi <nick83ola@gmail.com>

This variable was left over by a previous commit and in gcc 9.1
was throwing an error an error (unused variable)
---
 plugins/quectel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/quectel.c b/plugins/quectel.c
index d4947489..1d21d6dd 100644
--- a/plugins/quectel.c
+++ b/plugins/quectel.c
@@ -1147,7 +1147,6 @@ static void quectel_set_online(struct ofono_modem *modem, ofono_bool_t online,
 static void quectel_pre_sim(struct ofono_modem *modem)
 {
 	struct quectel_data *data = ofono_modem_get_data(modem);
-	struct ofono_sim *sim;
 
 	DBG("%p", modem);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-09-24 14:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24  7:23 [PATCH] quectel: remove unused variable in quectel_pre_sim Nicola Lunghi
  -- strict thread matches above, loose matches on Subject: below --
2019-09-24  7:32 Nicola Lunghi
2019-09-24  7:31 Nicola Lunghi
2019-09-24  7:15 Nicola Lunghi
2019-09-24 14:56 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.