* [igt-dev] [PATCH i-g-t] runner: Chomp away trailing spaces from cmdline
@ 2019-09-24 9:19 Chris Wilson
2019-09-24 9:39 ` Petri Latvala
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2019-09-24 9:19 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
A minor refinement to remove the trailing spaces after converting the
NUL-terminators to spaces.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
runner/executor.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/runner/executor.c b/runner/executor.c
index 3e0121421..130ba38d2 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -630,6 +630,10 @@ static const char *get_cmdline(pid_t pid, char *buf, ssize_t len)
if (buf[i] == '\0')
buf[i] = ' ';
+ /* chomp away the trailing spaces */
+ while (buf[len - 1] == ' ')
+ --len;
+
buf[len] = '\0'; /* but make sure that we return a valid string! */
return buf;
}
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] runner: Chomp away trailing spaces from cmdline
2019-09-24 9:19 [igt-dev] [PATCH i-g-t] runner: Chomp away trailing spaces from cmdline Chris Wilson
@ 2019-09-24 9:39 ` Petri Latvala
2019-09-24 9:43 ` Chris Wilson
2019-09-24 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-09-24 20:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Petri Latvala @ 2019-09-24 9:39 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Tue, Sep 24, 2019 at 10:19:43AM +0100, Chris Wilson wrote:
> A minor refinement to remove the trailing spaces after converting the
> NUL-terminators to spaces.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
I suppose it's impossible that cmdline is entirely spaces...
> ---
> runner/executor.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/runner/executor.c b/runner/executor.c
> index 3e0121421..130ba38d2 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -630,6 +630,10 @@ static const char *get_cmdline(pid_t pid, char *buf, ssize_t len)
> if (buf[i] == '\0')
> buf[i] = ' ';
>
> + /* chomp away the trailing spaces */
> + while (buf[len - 1] == ' ')
> + --len;
> +
> buf[len] = '\0'; /* but make sure that we return a valid string! */
> return buf;
> }
> --
> 2.23.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] runner: Chomp away trailing spaces from cmdline
2019-09-24 9:39 ` Petri Latvala
@ 2019-09-24 9:43 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2019-09-24 9:43 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
Quoting Petri Latvala (2019-09-24 10:39:48)
> On Tue, Sep 24, 2019 at 10:19:43AM +0100, Chris Wilson wrote:
> > A minor refinement to remove the trailing spaces after converting the
> > NUL-terminators to spaces.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Petri Latvala <petri.latvala@intel.com>
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>
> I suppose it's impossible that cmdline is entirely spaces...
Ok, technically you can have a filename that is entirely spaces!
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for runner: Chomp away trailing spaces from cmdline
2019-09-24 9:19 [igt-dev] [PATCH i-g-t] runner: Chomp away trailing spaces from cmdline Chris Wilson
2019-09-24 9:39 ` Petri Latvala
@ 2019-09-24 10:50 ` Patchwork
2019-09-24 20:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-09-24 10:50 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: runner: Chomp away trailing spaces from cmdline
URL : https://patchwork.freedesktop.org/series/67154/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6947 -> IGTPW_3494
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/67154/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3494 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@legacy-render:
- fi-icl-u2: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#111381])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- {fi-tgl-u}: [INCOMPLETE][3] -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/fi-tgl-u/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/fi-tgl-u/igt@i915_pm_rpm@module-reload.html
* igt@kms_chamelium@hdmi-edid-read:
- {fi-icl-u4}: [FAIL][5] ([fdo#111045]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][7] ([fdo#111045] / [fdo#111096]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
Participating hosts (52 -> 41)
------------------------------
Additional (1): fi-icl-guc
Missing (12): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-skl-6260u fi-kbl-guc fi-pnv-d510 fi-icl-y fi-bdw-samus fi-byt-clapper fi-skl-6700k2
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5200 -> IGTPW_3494
CI-20190529: 20190529
CI_DRM_6947: 567ef14d043c8fd9d9d948dac219c68216fda305 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3494: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/
IGT_5200: 732d99774ac1aac66e46b914e0bc96d2366167d0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for runner: Chomp away trailing spaces from cmdline
2019-09-24 9:19 [igt-dev] [PATCH i-g-t] runner: Chomp away trailing spaces from cmdline Chris Wilson
2019-09-24 9:39 ` Petri Latvala
2019-09-24 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-09-24 20:55 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-09-24 20:55 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: runner: Chomp away trailing spaces from cmdline
URL : https://patchwork.freedesktop.org/series/67154/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6947_full -> IGTPW_3494_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/67154/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3494_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-apl6/igt@gem_ctx_isolation@rcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-apl8/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs0-s3:
- shard-kbl: [PASS][3] -> [INCOMPLETE][4] ([fdo#103665])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-kbl4/igt@gem_ctx_isolation@vcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-kbl1/igt@gem_ctx_isolation@vcs0-s3.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-iclb: [PASS][7] -> [INCOMPLETE][8] ([fdo#107713])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
- shard-kbl: [PASS][9] -> [FAIL][10] ([fdo#103232])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
- shard-apl: [PASS][11] -> [FAIL][12] ([fdo#103232])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-apl3/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][13] -> [FAIL][14] ([fdo#103355])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-hsw7/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103167]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb7/igt@kms_psr@psr2_sprite_render.html
* igt@kms_setmode@basic:
- shard-hsw: [PASS][19] -> [FAIL][20] ([fdo#99912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-hsw7/igt@kms_setmode@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-hsw8/igt@kms_setmode@basic.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109276]) +10 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb4/igt@prime_busy@hang-bsd2.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb3/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_exec_schedule@preempt-bsd1:
- shard-iclb: [SKIP][23] ([fdo#109276]) -> [PASS][24] +14 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb5/igt@gem_exec_schedule@preempt-bsd1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb1/igt@gem_exec_schedule@preempt-bsd1.html
* igt@gem_exec_schedule@preempt-contexts-bsd:
- shard-iclb: [SKIP][25] ([fdo#111325]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb5/igt@gem_exec_schedule@preempt-contexts-bsd.html
* {igt@gem_mmap_gtt@cpuset-big-copy-xy}:
- shard-apl: [INCOMPLETE][27] ([fdo#103927]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-apl3/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-apl2/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@gem_mmap_gtt@hang:
- shard-iclb: [FAIL][29] ([fdo#109677]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb7/igt@gem_mmap_gtt@hang.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb3/igt@gem_mmap_gtt@hang.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +6 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-apl4/igt@i915_suspend@fence-restore-untiled.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-apl6/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][33] ([fdo#103540]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-iclb: [FAIL][35] ([fdo#103167]) -> [PASS][36] +7 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][37] ([fdo#109441]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6947/shard-iclb3/igt@kms_psr@psr2_basic.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/shard-iclb2/igt@kms_psr@psr2_basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109677]: https://bugs.freedesktop.org/show_bug.cgi?id=109677
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (9 -> 6)
------------------------------
Missing (3): pig-skl-6260u shard-skl pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5200 -> IGTPW_3494
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_6947: 567ef14d043c8fd9d9d948dac219c68216fda305 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3494: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/
IGT_5200: 732d99774ac1aac66e46b914e0bc96d2366167d0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3494/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-24 20:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24 9:19 [igt-dev] [PATCH i-g-t] runner: Chomp away trailing spaces from cmdline Chris Wilson
2019-09-24 9:39 ` Petri Latvala
2019-09-24 9:43 ` Chris Wilson
2019-09-24 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-09-24 20:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.