[PATCH] Partially revert "HID: logitech-hidpp: add USB PID for a few more supported mice"

[PATCH] Partially revert "HID: logitech-hidpp: add USB PID for a few more supported mice"

[Jeremy Cline]

From: Benjamin Tissoires <benjamin.tissoires@redhat.com>

commit addf3382c47c033e579c9c88f18e36c4e75d806a upstream.

This partially reverts commit 27fc32fd9417968a459d43d9a7c50fd423d53eb9.

It turns out that the G502 has some issues with hid-logitech-hidpp:
when plugging it in, the driver tries to contact it but it fails.
So the driver bails out leaving only the mouse event node available.

This timeout is problematic as it introduce a delay in the boot,
and having only the mouse event node means that the hardware
macros keys can not be relayed to the userspace.

Filipe and I just gave a shot at the following devices:

G403 Wireless (0xC082)
G703 (0xC087)
G703 Hero (0xC090)
G903 (0xC086)
G903 Hero (0xC091)
G Pro (0xC088)

Reverting the devices we are not sure that works flawlessly.

Reviewed-by: Filipe Laíns <lains@archlinux.org>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---

For the v5.2 stable kernels. v5.2.11 picked up upstream commit
27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more supported
mice") and v5.2.12 picked up commit a3384b8d9f63cc0 ("HID:
logitech-hidpp: remove support for the G700 over USB") with some
conflicts because this patch wasn't picked up. This backport resolves
the conflicts against v5.2.17.

 drivers/hid/hid-logitech-hidpp.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 4effce12607b..424d0f775ffa 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -3749,28 +3749,8 @@ static const struct hid_device_id hidpp_devices[] = {
 
 	{ L27MHZ_DEVICE(HID_ANY_ID) },
 
-	{ /* Logitech G203/Prodigy Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC084) },
-	{ /* Logitech G302 Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07F) },
-	{ /* Logitech G303 Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC080) },
-	{ /* Logitech G400 Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07E) },
 	{ /* Logitech G403 Wireless Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
-	{ /* Logitech G403 Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC083) },
-	{ /* Logitech G403 Hero Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08F) },
-	{ /* Logitech G502 Proteus Core Gaming Mouse */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07D) },
-	{ /* Logitech G502 Proteus Spectrum Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC332) },
-	{ /* Logitech G502 Hero Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08B) },
-	{ /* Logitech G700s Gaming Mouse over USB */
-	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC07C) },
 	{ /* Logitech G703 Gaming Mouse over USB */
 	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
 	{ /* Logitech G703 Hero Gaming Mouse over USB */
-- 
2.21.0

Re: [PATCH] Partially revert "HID: logitech-hidpp: add USB PID for a few more supported mice"

[Greg KH]

On Tue, Sep 24, 2019 at 07:13:11PM +0000, Jeremy Cline wrote:
> From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> 
> commit addf3382c47c033e579c9c88f18e36c4e75d806a upstream.
> 
> This partially reverts commit 27fc32fd9417968a459d43d9a7c50fd423d53eb9.
> 
> It turns out that the G502 has some issues with hid-logitech-hidpp:
> when plugging it in, the driver tries to contact it but it fails.
> So the driver bails out leaving only the mouse event node available.
> 
> This timeout is problematic as it introduce a delay in the boot,
> and having only the mouse event node means that the hardware
> macros keys can not be relayed to the userspace.
> 
> Filipe and I just gave a shot at the following devices:
> 
> G403 Wireless (0xC082)
> G703 (0xC087)
> G703 Hero (0xC090)
> G903 (0xC086)
> G903 Hero (0xC091)
> G Pro (0xC088)
> 
> Reverting the devices we are not sure that works flawlessly.
> 
> Reviewed-by: Filipe Laíns <lains@archlinux.org>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
> 
> For the v5.2 stable kernels. v5.2.11 picked up upstream commit
> 27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more supported
> mice") and v5.2.12 picked up commit a3384b8d9f63cc0 ("HID:
> logitech-hidpp: remove support for the G700 over USB") with some
> conflicts because this patch wasn't picked up. This backport resolves
> the conflicts against v5.2.17.

Thanks, now queued up.

greg k-h