All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: kernel-janitors@vger.kernel.org,
	linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH V2] bnvdimm/namsepace: Don't set claim_class on error
Date: Wed, 25 Sep 2019 14:15:20 -0700	[thread overview]
Message-ID: <20190925211520.GA12748@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <CAPcyv4jtYxggf-+ZvO5PN3KTMjiqqJrpj_V39_9axJZNpG_EQg@mail.gmail.com>

On Wed, Sep 25, 2019 at 12:36:35PM -0700, Dan Williams wrote:
> On Wed, Sep 25, 2019 at 11:49 AM <ira.weiny@intel.com> wrote:
> >

[snip]

> >
> > ---
> > V1->V2
> >         Add space after variable declaration...
> 
> Oh, was also hoping this would address s/bnvdimm/libnvdimm/ in the
> patch subject.

Yea...

> 
> Note, kernel-janitors is for minor spelling fixes and trivial changes
> with no runtime side-effects that might otherwise fall through the
> cracks. This has functional implications so is not a janitorial
> change.

Ah yea I just thought it was ok to let that list know what was going on...
I've removed them from V3.  Sorry.

> 
> One more comment below...
> 

[snip]

> > -
> 
> Since this effectively replaces Dan's patch can you respin without
> that baseline, and just give Dan credit with a Reported-by?

V3 sent.

Ira

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: kernel-janitors@vger.kernel.org,
	linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH V2] bnvdimm/namsepace: Don't set claim_class on error
Date: Wed, 25 Sep 2019 21:15:20 +0000	[thread overview]
Message-ID: <20190925211520.GA12748@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <CAPcyv4jtYxggf-+ZvO5PN3KTMjiqqJrpj_V39_9axJZNpG_EQg@mail.gmail.com>

On Wed, Sep 25, 2019 at 12:36:35PM -0700, Dan Williams wrote:
> On Wed, Sep 25, 2019 at 11:49 AM <ira.weiny@intel.com> wrote:
> >

[snip]

> >
> > ---
> > V1->V2
> >         Add space after variable declaration...
> 
> Oh, was also hoping this would address s/bnvdimm/libnvdimm/ in the
> patch subject.

Yea...

> 
> Note, kernel-janitors is for minor spelling fixes and trivial changes
> with no runtime side-effects that might otherwise fall through the
> cracks. This has functional implications so is not a janitorial
> change.

Ah yea I just thought it was ok to let that list know what was going on...
I've removed them from V3.  Sorry.

> 
> One more comment below...
> 

[snip]

> > -
> 
> Since this effectively replaces Dan's patch can you respin without
> that baseline, and just give Dan credit with a Reported-by?

V3 sent.

Ira

  reply	other threads:[~2019-09-25 21:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 18:48 [PATCH V2] bnvdimm/namsepace: Don't set claim_class on error ira.weiny
2019-09-25 18:48 ` ira.weiny
2019-09-25 19:36 ` Dan Williams
2019-09-25 19:36   ` Dan Williams
2019-09-25 21:15   ` Ira Weiny [this message]
2019-09-25 21:15     ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190925211520.GA12748@iweiny-DESK2.sc.intel.com \
    --to=ira.weiny@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.