* [PATCH] media: ov5695: Add suport for registering sensor-related
@ 2019-09-27 7:18 ` Dongchun Zhu
0 siblings, 0 replies; 14+ messages in thread
From: Dongchun Zhu @ 2019-09-27 7:18 UTC (permalink / raw)
To: mchehab-DgEjT+Ai2ygdnm+yROfE0A,
andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
sakari.ailus-VuQAYsv1563Yd54FQh9/CA,
drinkcat-F7+t8E8rja9g9hUCZPvPmw, tfiga-F7+t8E8rja9g9hUCZPvPmw,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
bingbu.cao-ral2JQCrhuEAvxtiuMwx3w
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w,
shengnan.wang-NuS5LvNUpcJWk0Htik3J/w,
sj.huang-NuS5LvNUpcJWk0Htik3J/w,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w,
louis.kuo-NuS5LvNUpcJWk0Htik3J/w,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-media-u79uwXL29TY76Z2rM5mHXA
Hello,
This series modifies the interface of async register V4L2 sub-device invoked in probe function for OV5695 CMOS sensor.
The Omnivision OV5695 image sensor would be used in camera features on CrOS application.
5.0 Mega Pixel MIPI Camera Mdoule also supports auto-focus control (AFC) with embedded AF VCM Driver.
Here we use v4l2_async_register_subdev_sensor_common() instead of v4l2_async_register_subdev()
to register a sensor sub-device to the asynchronous sub-device framework and parse set up
common sensor-related devices, such as actuator.
This function is just like v4l2_async_register_subdev() with the exception that calling it will also parse
firmware interfaces for remote references using v4l2_async_notifier_parse_fwnode_sensor_common()
and registers the async sub-devices.
After applying this change, we can see the VCM move when changing the scene.
Dongchun Zhu (1):
media: i2c: ov5695: Modify the function of async register subdev
drivers/media/i2c/ov5695.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.9.2
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] media: ov5695: Add suport for registering sensor-related
@ 2019-09-27 7:18 ` Dongchun Zhu
0 siblings, 0 replies; 14+ messages in thread
From: Dongchun Zhu @ 2019-09-27 7:18 UTC (permalink / raw)
To: mchehab, andriy.shevchenko, robh+dt, mark.rutland, sakari.ailus,
drinkcat, tfiga, matthias.bgg, bingbu.cao
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, sj.huang,
linux-media, devicetree, louis.kuo, shengnan.wang, dongchun.zhu
Hello,
This series modifies the interface of async register V4L2 sub-device invoked in probe function for OV5695 CMOS sensor.
The Omnivision OV5695 image sensor would be used in camera features on CrOS application.
5.0 Mega Pixel MIPI Camera Mdoule also supports auto-focus control (AFC) with embedded AF VCM Driver.
Here we use v4l2_async_register_subdev_sensor_common() instead of v4l2_async_register_subdev()
to register a sensor sub-device to the asynchronous sub-device framework and parse set up
common sensor-related devices, such as actuator.
This function is just like v4l2_async_register_subdev() with the exception that calling it will also parse
firmware interfaces for remote references using v4l2_async_notifier_parse_fwnode_sensor_common()
and registers the async sub-devices.
After applying this change, we can see the VCM move when changing the scene.
Dongchun Zhu (1):
media: i2c: ov5695: Modify the function of async register subdev
drivers/media/i2c/ov5695.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.9.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] media: ov5695: Add suport for registering sensor-related
@ 2019-09-27 7:18 ` Dongchun Zhu
0 siblings, 0 replies; 14+ messages in thread
From: Dongchun Zhu @ 2019-09-27 7:18 UTC (permalink / raw)
To: mchehab, andriy.shevchenko, robh+dt, mark.rutland, sakari.ailus,
drinkcat, tfiga, matthias.bgg, bingbu.cao
Cc: devicetree, srv_heupstream, shengnan.wang, sj.huang,
linux-mediatek, dongchun.zhu, louis.kuo, linux-arm-kernel,
linux-media
Hello,
This series modifies the interface of async register V4L2 sub-device invoked in probe function for OV5695 CMOS sensor.
The Omnivision OV5695 image sensor would be used in camera features on CrOS application.
5.0 Mega Pixel MIPI Camera Mdoule also supports auto-focus control (AFC) with embedded AF VCM Driver.
Here we use v4l2_async_register_subdev_sensor_common() instead of v4l2_async_register_subdev()
to register a sensor sub-device to the asynchronous sub-device framework and parse set up
common sensor-related devices, such as actuator.
This function is just like v4l2_async_register_subdev() with the exception that calling it will also parse
firmware interfaces for remote references using v4l2_async_notifier_parse_fwnode_sensor_common()
and registers the async sub-devices.
After applying this change, we can see the VCM move when changing the scene.
Dongchun Zhu (1):
media: i2c: ov5695: Modify the function of async register subdev
drivers/media/i2c/ov5695.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.9.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices
2019-09-27 7:18 ` Dongchun Zhu
(?)
@ 2019-09-27 7:18 ` Dongchun Zhu
-1 siblings, 0 replies; 14+ messages in thread
From: Dongchun Zhu @ 2019-09-27 7:18 UTC (permalink / raw)
To: mchehab-DgEjT+Ai2ygdnm+yROfE0A,
andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
sakari.ailus-VuQAYsv1563Yd54FQh9/CA,
drinkcat-F7+t8E8rja9g9hUCZPvPmw, tfiga-F7+t8E8rja9g9hUCZPvPmw,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
bingbu.cao-ral2JQCrhuEAvxtiuMwx3w
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w,
shengnan.wang-NuS5LvNUpcJWk0Htik3J/w,
sj.huang-NuS5LvNUpcJWk0Htik3J/w,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w,
louis.kuo-NuS5LvNUpcJWk0Htik3J/w,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-media-u79uwXL29TY76Z2rM5mHXA
This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
sensor related devices such as actuator/VCM.
Signed-off-by: Dongchun Zhu <dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
drivers/media/i2c/ov5695.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
index e65a943..b6ee62c 100644
--- a/drivers/media/i2c/ov5695.c
+++ b/drivers/media/i2c/ov5695.c
@@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
goto err_power_off;
#endif
- ret = v4l2_async_register_subdev(sd);
+ ret = v4l2_async_register_subdev_sensor_common(sd);
if (ret) {
dev_err(dev, "v4l2 async register subdev failed\n");
goto err_clean_entity;
--
2.9.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices
@ 2019-09-27 7:18 ` Dongchun Zhu
0 siblings, 0 replies; 14+ messages in thread
From: Dongchun Zhu @ 2019-09-27 7:18 UTC (permalink / raw)
To: mchehab, andriy.shevchenko, robh+dt, mark.rutland, sakari.ailus,
drinkcat, tfiga, matthias.bgg, bingbu.cao
Cc: srv_heupstream, linux-mediatek, linux-arm-kernel, sj.huang,
linux-media, devicetree, louis.kuo, shengnan.wang, dongchun.zhu
This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
sensor related devices such as actuator/VCM.
Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
---
drivers/media/i2c/ov5695.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
index e65a943..b6ee62c 100644
--- a/drivers/media/i2c/ov5695.c
+++ b/drivers/media/i2c/ov5695.c
@@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
goto err_power_off;
#endif
- ret = v4l2_async_register_subdev(sd);
+ ret = v4l2_async_register_subdev_sensor_common(sd);
if (ret) {
dev_err(dev, "v4l2 async register subdev failed\n");
goto err_clean_entity;
--
2.9.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices
@ 2019-09-27 7:18 ` Dongchun Zhu
0 siblings, 0 replies; 14+ messages in thread
From: Dongchun Zhu @ 2019-09-27 7:18 UTC (permalink / raw)
To: mchehab, andriy.shevchenko, robh+dt, mark.rutland, sakari.ailus,
drinkcat, tfiga, matthias.bgg, bingbu.cao
Cc: devicetree, srv_heupstream, shengnan.wang, sj.huang,
linux-mediatek, dongchun.zhu, louis.kuo, linux-arm-kernel,
linux-media
This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
sensor related devices such as actuator/VCM.
Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
---
drivers/media/i2c/ov5695.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
index e65a943..b6ee62c 100644
--- a/drivers/media/i2c/ov5695.c
+++ b/drivers/media/i2c/ov5695.c
@@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
goto err_power_off;
#endif
- ret = v4l2_async_register_subdev(sd);
+ ret = v4l2_async_register_subdev_sensor_common(sd);
if (ret) {
dev_err(dev, "v4l2 async register subdev failed\n");
goto err_clean_entity;
--
2.9.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] media: ov5695: Add suport for registering sensor-related
2019-09-27 7:18 ` Dongchun Zhu
(?)
@ 2019-09-27 9:45 ` Andy Shevchenko
-1 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2019-09-27 9:45 UTC (permalink / raw)
To: Dongchun Zhu
Cc: mark.rutland, devicetree, drinkcat, srv_heupstream,
shengnan.wang, tfiga, louis.kuo, sj.huang, robh+dt,
linux-mediatek, sakari.ailus, matthias.bgg, bingbu.cao, mchehab,
linux-arm-kernel, linux-media
On Fri, Sep 27, 2019 at 03:18:23PM +0800, Dongchun Zhu wrote:
> Hello,
>
> This series modifies the interface of async register V4L2 sub-device invoked in probe function for OV5695 CMOS sensor.
> The Omnivision OV5695 image sensor would be used in camera features on CrOS application.
> 5.0 Mega Pixel MIPI Camera Mdoule also supports auto-focus control (AFC) with embedded AF VCM Driver.
>
> Here we use v4l2_async_register_subdev_sensor_common() instead of v4l2_async_register_subdev()
> to register a sensor sub-device to the asynchronous sub-device framework and parse set up
> common sensor-related devices, such as actuator.
>
> This function is just like v4l2_async_register_subdev() with the exception that calling it will also parse
> firmware interfaces for remote references using v4l2_async_notifier_parse_fwnode_sensor_common()
> and registers the async sub-devices.
>
> After applying this change, we can see the VCM move when changing the scene.
When you derive Cc list, set some threshold to the get_maintainer.pl, like
scripts/get_maintainer.pl --git --git-min-percent=67
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] media: ov5695: Add suport for registering sensor-related
@ 2019-09-27 9:45 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2019-09-27 9:45 UTC (permalink / raw)
To: Dongchun Zhu
Cc: mchehab, robh+dt, mark.rutland, sakari.ailus, drinkcat, tfiga,
matthias.bgg, bingbu.cao, srv_heupstream, linux-mediatek,
linux-arm-kernel, sj.huang, linux-media, devicetree, louis.kuo,
shengnan.wang
On Fri, Sep 27, 2019 at 03:18:23PM +0800, Dongchun Zhu wrote:
> Hello,
>
> This series modifies the interface of async register V4L2 sub-device invoked in probe function for OV5695 CMOS sensor.
> The Omnivision OV5695 image sensor would be used in camera features on CrOS application.
> 5.0 Mega Pixel MIPI Camera Mdoule also supports auto-focus control (AFC) with embedded AF VCM Driver.
>
> Here we use v4l2_async_register_subdev_sensor_common() instead of v4l2_async_register_subdev()
> to register a sensor sub-device to the asynchronous sub-device framework and parse set up
> common sensor-related devices, such as actuator.
>
> This function is just like v4l2_async_register_subdev() with the exception that calling it will also parse
> firmware interfaces for remote references using v4l2_async_notifier_parse_fwnode_sensor_common()
> and registers the async sub-devices.
>
> After applying this change, we can see the VCM move when changing the scene.
When you derive Cc list, set some threshold to the get_maintainer.pl, like
scripts/get_maintainer.pl --git --git-min-percent=67
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] media: ov5695: Add suport for registering sensor-related
@ 2019-09-27 9:45 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2019-09-27 9:45 UTC (permalink / raw)
To: Dongchun Zhu
Cc: mark.rutland, devicetree, drinkcat, srv_heupstream,
shengnan.wang, tfiga, louis.kuo, sj.huang, robh+dt,
linux-mediatek, sakari.ailus, matthias.bgg, bingbu.cao, mchehab,
linux-arm-kernel, linux-media
On Fri, Sep 27, 2019 at 03:18:23PM +0800, Dongchun Zhu wrote:
> Hello,
>
> This series modifies the interface of async register V4L2 sub-device invoked in probe function for OV5695 CMOS sensor.
> The Omnivision OV5695 image sensor would be used in camera features on CrOS application.
> 5.0 Mega Pixel MIPI Camera Mdoule also supports auto-focus control (AFC) with embedded AF VCM Driver.
>
> Here we use v4l2_async_register_subdev_sensor_common() instead of v4l2_async_register_subdev()
> to register a sensor sub-device to the asynchronous sub-device framework and parse set up
> common sensor-related devices, such as actuator.
>
> This function is just like v4l2_async_register_subdev() with the exception that calling it will also parse
> firmware interfaces for remote references using v4l2_async_notifier_parse_fwnode_sensor_common()
> and registers the async sub-devices.
>
> After applying this change, we can see the VCM move when changing the scene.
When you derive Cc list, set some threshold to the get_maintainer.pl, like
scripts/get_maintainer.pl --git --git-min-percent=67
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices
2019-09-27 7:18 ` Dongchun Zhu
(?)
@ 2019-09-28 12:17 ` Tomasz Figa
-1 siblings, 0 replies; 14+ messages in thread
From: Tomasz Figa @ 2019-09-28 12:17 UTC (permalink / raw)
To: Dongchun Zhu
Cc: Mark Rutland, Nicolas Boichat,
andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA, srv_heupstream,
devicetree-u79uwXL29TY76Z2rM5mHXA,
shengnan.wang-NuS5LvNUpcJWk0Htik3J/w, Louis Kuo, Sj Huang,
Rob Herring, moderated list:ARM/Mediatek SoC support,
Sakari Ailus, Matthias Brugger, Cao Bing Bu,
Mauro Carvalho Chehab,
list-Y9sIeH5OGRo@public.gmane.org:IOMMU DRIVERS
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
, Linux Media Mailing List
On Fri, Sep 27, 2019 at 4:18 PM Dongchun Zhu <dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
>
> This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
> sensor related devices such as actuator/VCM.
nit: The description should be wrapped around the 80th column.
Sakari, do we need to resent or you could just rewrap when applying?
>
> Signed-off-by: Dongchun Zhu <dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> drivers/media/i2c/ov5695.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> index e65a943..b6ee62c 100644
> --- a/drivers/media/i2c/ov5695.c
> +++ b/drivers/media/i2c/ov5695.c
> @@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
> goto err_power_off;
> #endif
>
> - ret = v4l2_async_register_subdev(sd);
> + ret = v4l2_async_register_subdev_sensor_common(sd);
> if (ret) {
> dev_err(dev, "v4l2 async register subdev failed\n");
> goto err_clean_entity;
> --
> 2.9.2
>
Otherwise:
Reviewed-by: Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices
@ 2019-09-28 12:17 ` Tomasz Figa
0 siblings, 0 replies; 14+ messages in thread
From: Tomasz Figa @ 2019-09-28 12:17 UTC (permalink / raw)
To: Dongchun Zhu
Cc: Mauro Carvalho Chehab, andriy.shevchenko, Rob Herring,
Mark Rutland, Sakari Ailus, Nicolas Boichat, Matthias Brugger,
Cao Bing Bu, srv_heupstream,
moderated list:ARM/Mediatek SoC support,
list@263.net:IOMMU DRIVERS
<iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,,
Sj Huang, Linux Media Mailing List, devicetree, Louis Kuo,
shengnan.wang
On Fri, Sep 27, 2019 at 4:18 PM Dongchun Zhu <dongchun.zhu@mediatek.com> wrote:
>
> This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
> sensor related devices such as actuator/VCM.
nit: The description should be wrapped around the 80th column.
Sakari, do we need to resent or you could just rewrap when applying?
>
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
> drivers/media/i2c/ov5695.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> index e65a943..b6ee62c 100644
> --- a/drivers/media/i2c/ov5695.c
> +++ b/drivers/media/i2c/ov5695.c
> @@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
> goto err_power_off;
> #endif
>
> - ret = v4l2_async_register_subdev(sd);
> + ret = v4l2_async_register_subdev_sensor_common(sd);
> if (ret) {
> dev_err(dev, "v4l2 async register subdev failed\n");
> goto err_clean_entity;
> --
> 2.9.2
>
Otherwise:
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices
@ 2019-09-28 12:17 ` Tomasz Figa
0 siblings, 0 replies; 14+ messages in thread
From: Tomasz Figa @ 2019-09-28 12:17 UTC (permalink / raw)
To: Dongchun Zhu
Cc: Mark Rutland, Nicolas Boichat, andriy.shevchenko, srv_heupstream,
devicetree, shengnan.wang, Louis Kuo, Sj Huang, Rob Herring,
moderated list:ARM/Mediatek SoC support, Sakari Ailus,
Matthias Brugger, Cao Bing Bu, Mauro Carvalho Chehab,
list@263.net:IOMMU DRIVERS
<iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>, ,
Linux Media Mailing List
On Fri, Sep 27, 2019 at 4:18 PM Dongchun Zhu <dongchun.zhu@mediatek.com> wrote:
>
> This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
> sensor related devices such as actuator/VCM.
nit: The description should be wrapped around the 80th column.
Sakari, do we need to resent or you could just rewrap when applying?
>
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
> drivers/media/i2c/ov5695.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> index e65a943..b6ee62c 100644
> --- a/drivers/media/i2c/ov5695.c
> +++ b/drivers/media/i2c/ov5695.c
> @@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
> goto err_power_off;
> #endif
>
> - ret = v4l2_async_register_subdev(sd);
> + ret = v4l2_async_register_subdev_sensor_common(sd);
> if (ret) {
> dev_err(dev, "v4l2 async register subdev failed\n");
> goto err_clean_entity;
> --
> 2.9.2
>
Otherwise:
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices
@ 2019-09-30 7:58 ` Sakari Ailus
0 siblings, 0 replies; 14+ messages in thread
From: Sakari Ailus @ 2019-09-30 7:58 UTC (permalink / raw)
To: Tomasz Figa
Cc: Dongchun Zhu, andriy.shevchenko, Mark Rutland, Nicolas Boichat,
Matthias Brugger, Cao Bing Bu, srv_heupstream,
moderated list:ARM/Mediatek SoC support, Sj Huang,
Linux Media Mailing List, Louis Kuo, shengnan.wang
Hi Tomasz, Dongchun,
(Removed randomly cc'd people from distribution.)
On Sat, Sep 28, 2019 at 09:17:11PM +0900, Tomasz Figa wrote:
> On Fri, Sep 27, 2019 at 4:18 PM Dongchun Zhu <dongchun.zhu@mediatek.com> wrote:
> >
> > This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
> > sensor related devices such as actuator/VCM.
>
> nit: The description should be wrapped around the 80th column.
>
> Sakari, do we need to resent or you could just rewrap when applying?
I'll rewrap.
>
> >
> > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > ---
> > drivers/media/i2c/ov5695.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> > index e65a943..b6ee62c 100644
> > --- a/drivers/media/i2c/ov5695.c
> > +++ b/drivers/media/i2c/ov5695.c
> > @@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
> > goto err_power_off;
> > #endif
> >
> > - ret = v4l2_async_register_subdev(sd);
> > + ret = v4l2_async_register_subdev_sensor_common(sd);
> > if (ret) {
> > dev_err(dev, "v4l2 async register subdev failed\n");
> > goto err_clean_entity;
> > --
> > 2.9.2
> >
>
> Otherwise:
>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Thanks!
--
Sakari Ailus
sakari.ailus@linux.intel.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices
@ 2019-09-30 7:58 ` Sakari Ailus
0 siblings, 0 replies; 14+ messages in thread
From: Sakari Ailus @ 2019-09-30 7:58 UTC (permalink / raw)
To: Tomasz Figa
Cc: Mark Rutland, Nicolas Boichat, srv_heupstream,
shengnan.wang-NuS5LvNUpcJWk0Htik3J/w, Louis Kuo, Sj Huang,
moderated list:ARM/Mediatek SoC support, Dongchun Zhu,
Matthias Brugger, Cao Bing Bu,
andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA,
Linux Media Mailing List
Hi Tomasz, Dongchun,
(Removed randomly cc'd people from distribution.)
On Sat, Sep 28, 2019 at 09:17:11PM +0900, Tomasz Figa wrote:
> On Fri, Sep 27, 2019 at 4:18 PM Dongchun Zhu <dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> >
> > This patch adds support for registering a sensor sub-device to the async sub-device framework and parse set up common
> > sensor related devices such as actuator/VCM.
>
> nit: The description should be wrapped around the 80th column.
>
> Sakari, do we need to resent or you could just rewrap when applying?
I'll rewrap.
>
> >
> > Signed-off-by: Dongchun Zhu <dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > drivers/media/i2c/ov5695.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> > index e65a943..b6ee62c 100644
> > --- a/drivers/media/i2c/ov5695.c
> > +++ b/drivers/media/i2c/ov5695.c
> > @@ -1328,7 +1328,7 @@ static int ov5695_probe(struct i2c_client *client,
> > goto err_power_off;
> > #endif
> >
> > - ret = v4l2_async_register_subdev(sd);
> > + ret = v4l2_async_register_subdev_sensor_common(sd);
> > if (ret) {
> > dev_err(dev, "v4l2 async register subdev failed\n");
> > goto err_clean_entity;
> > --
> > 2.9.2
> >
>
> Otherwise:
>
> Reviewed-by: Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Thanks!
--
Sakari Ailus
sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-09-30 7:58 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 7:18 [PATCH] media: ov5695: Add suport for registering sensor-related Dongchun Zhu
2019-09-27 7:18 ` Dongchun Zhu
2019-09-27 7:18 ` Dongchun Zhu
[not found] ` <20190927071824.18675-1-dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-09-27 7:18 ` [PATCH] media: i2c: ov5695: Modify the function of async register subdev related devices Dongchun Zhu
2019-09-27 7:18 ` Dongchun Zhu
2019-09-27 7:18 ` Dongchun Zhu
[not found] ` <20190927071824.18675-2-dongchun.zhu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-09-28 12:17 ` Tomasz Figa
2019-09-28 12:17 ` Tomasz Figa
2019-09-28 12:17 ` Tomasz Figa
2019-09-30 7:58 ` Sakari Ailus
2019-09-30 7:58 ` Sakari Ailus
2019-09-27 9:45 ` [PATCH] media: ov5695: Add suport for registering sensor-related Andy Shevchenko
2019-09-27 9:45 ` Andy Shevchenko
2019-09-27 9:45 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.