* [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
@ 2019-09-28 10:01 Chris Wilson
2019-09-28 10:20 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (7 more replies)
0 siblings, 8 replies; 12+ messages in thread
From: Chris Wilson @ 2019-09-28 10:01 UTC (permalink / raw)
To: intel-gfx
My current theory is that masks interrupt delivery to the local CPU
during a critical phase. Purely papering over the symptoms with a delay
plucked out of thin air from testing on tgl1-gem.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index fa385218ce92..fe8f4625f04f 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -1186,6 +1186,21 @@ static void execlists_submit_ports(struct intel_engine_cs *engine)
/* we need to manually load the submit queue */
if (execlists->ctrl_reg)
writel(EL_CTRL_LOAD, execlists->ctrl_reg);
+
+ /*
+ * Now this is evil magic.
+ *
+ * Adding the same udelay() to process_csb before we clear
+ * execlists->pending (that is after we receive the HW ack for this
+ * submit and before we can submit again) does not relieve the symptoms
+ * (machine lockup). So is the active difference here the wait under
+ * the irq-off spinlock? That gives more credance to the theory that
+ * the issue is interrupt delivery. Also note that we still rely on
+ * disabling RPS, again that seems like an issue with simultaneous
+ * GT interrupts being delivered to the same CPU.
+ */
+ if (IS_TIGERLAKE(engine->i915))
+ udelay(250);
}
static bool ctx_single_port_submission(const struct intel_context *ce)
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
@ 2019-09-28 10:20 ` Patchwork
2019-09-28 10:43 ` ✓ Fi.CI.BAT: success " Patchwork
` (6 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-09-28 10:20 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
URL : https://patchwork.freedesktop.org/series/67365/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3f46cddad144 drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
-:37: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#37: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1203:
+ udelay(250);
total: 0 errors, 0 warnings, 1 checks, 21 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
2019-09-28 10:20 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2019-09-28 10:43 ` Patchwork
2019-09-28 20:03 ` ✓ Fi.CI.IGT: " Patchwork
` (5 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-09-28 10:43 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
URL : https://patchwork.freedesktop.org/series/67365/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6973 -> Patchwork_14579
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/index.html
Known issues
------------
Here are the changes found in Patchwork_14579 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][1] -> [FAIL][2] ([fdo#111045] / [fdo#111096])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_vgem@basic-fence-read:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-icl-u3/igt@prime_vgem@basic-fence-read.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/fi-icl-u3/igt@prime_vgem@basic-fence-read.html
#### Possible fixes ####
* igt@gem_mmap@basic-small-bo:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-icl-u3/igt@gem_mmap@basic-small-bo.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/fi-icl-u3/igt@gem_mmap@basic-small-bo.html
* igt@i915_selftest@live_gem_contexts:
- fi-bxt-dsi: [INCOMPLETE][7] ([fdo#103927]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-bxt-dsi/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/fi-bxt-dsi/igt@i915_selftest@live_gem_contexts.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
Participating hosts (53 -> 44)
------------------------------
Missing (9): fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6973 -> Patchwork_14579
CI-20190529: 20190529
CI_DRM_6973: 7462c58bba0fb6e85bd380591c3fd86e298c0f95 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5206: 5a6c68568def840cd720f18fc66f529a89f84675 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14579: 3f46cddad1445544ba122e9836e31dc0aa1dba57 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3f46cddad144 drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
2019-09-28 10:20 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-09-28 10:43 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-09-28 20:03 ` Patchwork
2019-09-29 20:25 ` [PATCH] " Andi Shyti
` (4 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-09-28 20:03 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
URL : https://patchwork.freedesktop.org/series/67365/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6973_full -> Patchwork_14579_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14579_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@unwedge-stress:
- shard-snb: [PASS][1] -> [FAIL][2] ([fdo#109661])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-snb5/igt@gem_eio@unwedge-stress.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-snb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +24 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb6/igt@gem_exec_schedule@reorder-wide-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb1/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_pread@snoop:
- shard-apl: [PASS][7] -> [INCOMPLETE][8] ([fdo#103927]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-apl5/igt@gem_pread@snoop.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-apl4/igt@gem_pread@snoop.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][9] -> [INCOMPLETE][10] ([fdo#110741])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108566]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-apl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-apl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145] / [fdo#110403])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_cursor@pipe-a-primary-size-256:
- shard-iclb: [PASS][17] -> [INCOMPLETE][18] ([fdo#107713])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb2/igt@kms_plane_cursor@pipe-a-primary-size-256.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb1/igt@kms_plane_cursor@pipe-a-primary-size-256.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][21] -> [FAIL][22] ([fdo#99912])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-apl1/igt@kms_setmode@basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-apl6/igt@kms_setmode@basic.html
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#99912])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl2/igt@kms_setmode@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-skl2/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][25] ([fdo#110841]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][27] ([fdo#110854]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb7/igt@gem_exec_balancer@smoke.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][29] ([fdo#109276]) -> [PASS][30] +17 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb7/igt@gem_exec_schedule@preempt-contexts-bsd2.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][31] ([fdo#111325]) -> [PASS][32] +11 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-apl4/igt@i915_suspend@sysfs-reader.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-apl7/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding:
- shard-skl: [FAIL][35] ([fdo#103232]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding.html
* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-kbl: [DMESG-WARN][37] ([fdo#107122]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-kbl3/igt@kms_cursor_legacy@all-pipes-torture-move.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-kbl3/igt@kms_cursor_legacy@all-pipes-torture-move.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][39] ([fdo#102670]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][41] ([fdo#103167]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][43] ([fdo#108145]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@perf@blocking:
- shard-skl: [FAIL][47] ([fdo#110728]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl6/igt@perf@blocking.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-skl6/igt@perf@blocking.html
#### Warnings ####
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [SKIP][49] ([fdo#109276]) -> [FAIL][50] ([fdo#111330]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb7/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/shard-iclb1/igt@gem_mocs_settings@mocs-isolation-bsd2.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
[fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (16 -> 10)
------------------------------
Missing (6): shard-tglb1 shard-tglb2 shard-tglb3 shard-tglb4 shard-tglb5 shard-tglb6
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6973 -> Patchwork_14579
CI-20190529: 20190529
CI_DRM_6973: 7462c58bba0fb6e85bd380591c3fd86e298c0f95 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5206: 5a6c68568def840cd720f18fc66f529a89f84675 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14579: 3f46cddad1445544ba122e9836e31dc0aa1dba57 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14579/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
` (2 preceding siblings ...)
2019-09-28 20:03 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-09-29 20:25 ` Andi Shyti
2019-09-30 7:43 ` Chris Wilson
2019-09-30 9:11 ` [PATCH v2] drm/i915/tgl: Magic interrupt shadow to relieve some random lockups Chris Wilson
` (3 subsequent siblings)
7 siblings, 1 reply; 12+ messages in thread
From: Andi Shyti @ 2019-09-29 20:25 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
Hi Chris,
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -1186,6 +1186,21 @@ static void execlists_submit_ports(struct intel_engine_cs *engine)
> /* we need to manually load the submit queue */
> if (execlists->ctrl_reg)
> writel(EL_CTRL_LOAD, execlists->ctrl_reg);
> +
> + /*
> + * Now this is evil magic.
> + *
> + * Adding the same udelay() to process_csb before we clear
> + * execlists->pending (that is after we receive the HW ack for this
> + * submit and before we can submit again) does not relieve the symptoms
> + * (machine lockup). So is the active difference here the wait under
> + * the irq-off spinlock? That gives more credance to the theory that
> + * the issue is interrupt delivery. Also note that we still rely on
> + * disabling RPS, again that seems like an issue with simultaneous
> + * GT interrupts being delivered to the same CPU.
> + */
> + if (IS_TIGERLAKE(engine->i915))
> + udelay(250);
you want a delay of 250us. Two questions:
1. why 250?
2. is there any good reason for using 'udelay' for sleeping 250us
(that is quite a long time) and not 'usleep'?
Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines
2019-09-29 20:25 ` [PATCH] " Andi Shyti
@ 2019-09-30 7:43 ` Chris Wilson
0 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2019-09-30 7:43 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
Quoting Andi Shyti (2019-09-29 21:25:54)
> Hi Chris,
>
> > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> > @@ -1186,6 +1186,21 @@ static void execlists_submit_ports(struct intel_engine_cs *engine)
> > /* we need to manually load the submit queue */
> > if (execlists->ctrl_reg)
> > writel(EL_CTRL_LOAD, execlists->ctrl_reg);
> > +
> > + /*
> > + * Now this is evil magic.
> > + *
> > + * Adding the same udelay() to process_csb before we clear
> > + * execlists->pending (that is after we receive the HW ack for this
> > + * submit and before we can submit again) does not relieve the symptoms
> > + * (machine lockup). So is the active difference here the wait under
> > + * the irq-off spinlock? That gives more credance to the theory that
> > + * the issue is interrupt delivery. Also note that we still rely on
> > + * disabling RPS, again that seems like an issue with simultaneous
> > + * GT interrupts being delivered to the same CPU.
> > + */
> > + if (IS_TIGERLAKE(engine->i915))
> > + udelay(250);
>
> you want a delay of 250us. Two questions:
>
> 1. why 250?
Magic. Purely first random number.
> 2. is there any good reason for using 'udelay' for sleeping 250us
> (that is quite a long time) and not 'usleep'?
We are inside interrupt context. That this trick worked much better
inside interrupt context than out makes me suspect interrupt delivery so
much more.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] drm/i915/tgl: Magic interrupt shadow to relieve some random lockups
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
` (3 preceding siblings ...)
2019-09-29 20:25 ` [PATCH] " Andi Shyti
@ 2019-09-30 9:11 ` Chris Wilson
2019-09-30 12:02 ` Mika Kuoppala
2019-09-30 9:57 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2) Patchwork
` (2 subsequent siblings)
7 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2019-09-30 9:11 UTC (permalink / raw)
To: intel-gfx
My current theory is that this masks interrupt delivery to the local CPU
during a critical phase. Purely papering over the symptoms with a delay
plucked out of thin air from testing on tgl1-gem, refined slightly by
just waiting for the next ack (though technically the next CS event may
not be the corresponding event for this submit, but an intermediate
completion).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index ab725a6ca0ac..35410d647b52 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -1155,6 +1155,7 @@ assert_pending_valid(const struct intel_engine_execlists *execlists,
static void execlists_submit_ports(struct intel_engine_cs *engine)
{
struct intel_engine_execlists *execlists = &engine->execlists;
+ unsigned int tail = READ_ONCE(*execlists->csb_write);
unsigned int n;
GEM_BUG_ON(!assert_pending_valid(execlists, "submit"));
@@ -1186,6 +1187,14 @@ static void execlists_submit_ports(struct intel_engine_cs *engine)
/* we need to manually load the submit queue */
if (execlists->ctrl_reg)
writel(EL_CTRL_LOAD, execlists->ctrl_reg);
+
+ if (IS_TIGERLAKE(engine->i915)) {
+ u64 start = local_clock();
+ do
+ cpu_relax();
+ while (tail == READ_ONCE(*execlists->csb_write) &&
+ (local_clock() - start) >> 20 == 0);
+ }
}
static bool ctx_single_port_submission(const struct intel_context *ce)
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2)
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
` (4 preceding siblings ...)
2019-09-30 9:11 ` [PATCH v2] drm/i915/tgl: Magic interrupt shadow to relieve some random lockups Chris Wilson
@ 2019-09-30 9:57 ` Patchwork
2019-09-30 10:23 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-30 12:20 ` ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-09-30 9:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2)
URL : https://patchwork.freedesktop.org/series/67365/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ffe0e0f4ce51 drm/i915/tgl: Magic interrupt shadow to relieve some random lockups
-:37: WARNING:LINE_SPACING: Missing a blank line after declarations
#37: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1193:
+ u64 start = local_clock();
+ do
total: 0 errors, 1 warnings, 0 checks, 21 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2)
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
` (5 preceding siblings ...)
2019-09-30 9:57 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2) Patchwork
@ 2019-09-30 10:23 ` Patchwork
2019-09-30 12:20 ` ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-09-30 10:23 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2)
URL : https://patchwork.freedesktop.org/series/67365/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6973 -> Patchwork_14581
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/index.html
Known issues
------------
Here are the changes found in Patchwork_14581 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
* igt@gem_ctx_switch@legacy-render:
- fi-apl-guc: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927] / [fdo#111381])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-apl-guc/igt@gem_ctx_switch@legacy-render.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/fi-apl-guc/igt@gem_ctx_switch@legacy-render.html
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][5] -> [INCOMPLETE][6] ([fdo#107718])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@gem_mmap_gtt@basic-write:
- fi-icl-u3: [PASS][7] -> [DMESG-WARN][8] ([fdo#107724]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-icl-u3/igt@gem_mmap_gtt@basic-write.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/fi-icl-u3/igt@gem_mmap_gtt@basic-write.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][9] -> [FAIL][10] ([fdo#111045] / [fdo#111096])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@gem_mmap@basic-small-bo:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/fi-icl-u3/igt@gem_mmap@basic-small-bo.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/fi-icl-u3/igt@gem_mmap@basic-small-bo.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#110387]: https://bugs.freedesktop.org/show_bug.cgi?id=110387
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831
Participating hosts (53 -> 46)
------------------------------
Additional (1): fi-cml-h
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6973 -> Patchwork_14581
CI-20190529: 20190529
CI_DRM_6973: 7462c58bba0fb6e85bd380591c3fd86e298c0f95 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5206: 5a6c68568def840cd720f18fc66f529a89f84675 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14581: ffe0e0f4ce510d58f1c20d6901bf2c1c5eccb189 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ffe0e0f4ce51 drm/i915/tgl: Magic interrupt shadow to relieve some random lockups
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/i915/tgl: Magic interrupt shadow to relieve some random lockups
2019-09-30 9:11 ` [PATCH v2] drm/i915/tgl: Magic interrupt shadow to relieve some random lockups Chris Wilson
@ 2019-09-30 12:02 ` Mika Kuoppala
2019-09-30 12:09 ` Chris Wilson
0 siblings, 1 reply; 12+ messages in thread
From: Mika Kuoppala @ 2019-09-30 12:02 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> My current theory is that this masks interrupt delivery to the local CPU
> during a critical phase. Purely papering over the symptoms with a delay
> plucked out of thin air from testing on tgl1-gem, refined slightly by
> just waiting for the next ack (though technically the next CS event may
> not be the corresponding event for this submit, but an intermediate
> completion).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_lrc.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index ab725a6ca0ac..35410d647b52 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -1155,6 +1155,7 @@ assert_pending_valid(const struct intel_engine_execlists *execlists,
> static void execlists_submit_ports(struct intel_engine_cs *engine)
> {
> struct intel_engine_execlists *execlists = &engine->execlists;
> + unsigned int tail = READ_ONCE(*execlists->csb_write);
> unsigned int n;
>
> GEM_BUG_ON(!assert_pending_valid(execlists, "submit"));
> @@ -1186,6 +1187,14 @@ static void execlists_submit_ports(struct intel_engine_cs *engine)
> /* we need to manually load the submit queue */
> if (execlists->ctrl_reg)
> writel(EL_CTRL_LOAD, execlists->ctrl_reg);
> +
I don't doubt we forget this but a comment would still be
good that we limit the intr generation for reasons still
unknown.
> + if (IS_TIGERLAKE(engine->i915)) {
> + u64 start = local_clock();
> + do
> + cpu_relax();
> + while (tail == READ_ONCE(*execlists->csb_write) &&
> + (local_clock() - start) >> 20 == 0);
1ms..well, if it works :O
Need to track this closely and pls consider limiting this to current revid
just so that we would notice the diff immediately when we get updates.
Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> + }
> }
>
> static bool ctx_single_port_submission(const struct intel_context *ce)
> --
> 2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/i915/tgl: Magic interrupt shadow to relieve some random lockups
2019-09-30 12:02 ` Mika Kuoppala
@ 2019-09-30 12:09 ` Chris Wilson
0 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2019-09-30 12:09 UTC (permalink / raw)
To: Mika Kuoppala, intel-gfx
Quoting Mika Kuoppala (2019-09-30 13:02:49)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > My current theory is that this masks interrupt delivery to the local CPU
> > during a critical phase. Purely papering over the symptoms with a delay
> > plucked out of thin air from testing on tgl1-gem, refined slightly by
> > just waiting for the next ack (though technically the next CS event may
> > not be the corresponding event for this submit, but an intermediate
> > completion).
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > Cc: Andi Shyti <andi.shyti@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_lrc.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> > index ab725a6ca0ac..35410d647b52 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> > @@ -1155,6 +1155,7 @@ assert_pending_valid(const struct intel_engine_execlists *execlists,
> > static void execlists_submit_ports(struct intel_engine_cs *engine)
> > {
> > struct intel_engine_execlists *execlists = &engine->execlists;
> > + unsigned int tail = READ_ONCE(*execlists->csb_write);
> > unsigned int n;
> >
> > GEM_BUG_ON(!assert_pending_valid(execlists, "submit"));
> > @@ -1186,6 +1187,14 @@ static void execlists_submit_ports(struct intel_engine_cs *engine)
> > /* we need to manually load the submit queue */
> > if (execlists->ctrl_reg)
> > writel(EL_CTRL_LOAD, execlists->ctrl_reg);
> > +
>
> I don't doubt we forget this but a comment would still be
> good that we limit the intr generation for reasons still
> unknown.
>
> > + if (IS_TIGERLAKE(engine->i915)) {
> > + u64 start = local_clock();
> > + do
> > + cpu_relax();
> > + while (tail == READ_ONCE(*execlists->csb_write) &&
> > + (local_clock() - start) >> 20 == 0);
>
> 1ms..well, if it works :O
>
> Need to track this closely and pls consider limiting this to current revid
> just so that we would notice the diff immediately when we get updates.
>
> Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Yeah, this one I'm not so keen to put in drm-intel-next-queued itself.
It's clear that we are not pruning features to achieve a stable base,
but now into the hax territory.
If possible, we'll get a topic/tgl-snafu branch where we can soak test
such hax on CI. But failing that, I'll try soaking it in core-for-CI --
once that is rebased on to v5.4-rc1.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2)
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
` (6 preceding siblings ...)
2019-09-30 10:23 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-09-30 12:20 ` Patchwork
7 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-09-30 12:20 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2)
URL : https://patchwork.freedesktop.org/series/67365/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6973_full -> Patchwork_14581_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14581_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@unwedge-stress:
- shard-snb: [PASS][1] -> [FAIL][2] ([fdo#109661])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-snb5/igt@gem_eio@unwedge-stress.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-snb5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +14 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb7/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-apl7/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([fdo#105763] / [fdo#106538])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-glk4/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@kms_busy@extended-modeset-hang-oldfb-render-a:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([fdo#107713])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb8/igt@kms_busy@extended-modeset-hang-oldfb-render-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb7/igt@kms_busy@extended-modeset-hang-oldfb-render-a.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [PASS][11] -> [FAIL][12] ([fdo#105767])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +6 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][19] -> [FAIL][20] ([fdo#99912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-apl1/igt@kms_setmode@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-apl5/igt@kms_setmode@basic.html
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#99912])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl2/igt@kms_setmode@basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-skl7/igt@kms_setmode@basic.html
* igt@perf@polling:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#110728])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl3/igt@perf@polling.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-skl7/igt@perf@polling.html
#### Possible fixes ####
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][25] ([fdo#111325]) -> [PASS][26] +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb5/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [SKIP][27] ([fdo#109276]) -> [PASS][28] +12 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-iclb: [DMESG-WARN][29] ([fdo#111764]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb1/igt@i915_pm_rpm@system-suspend-execbuf.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb7/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-apl4/igt@i915_suspend@sysfs-reader.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-apl5/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-kbl: [DMESG-WARN][33] ([fdo#107122]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-kbl3/igt@kms_cursor_legacy@all-pipes-torture-move.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-kbl6/igt@kms_cursor_legacy@all-pipes-torture-move.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][35] ([fdo#102670]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: [FAIL][37] ([fdo#103167]) -> [PASS][38] +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][39] ([fdo#103166]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][41] ([fdo#109642] / [fdo#111068]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb7/igt@kms_psr2_su@frontbuffer.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@perf@blocking:
- shard-skl: [FAIL][43] ([fdo#110728]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-skl6/igt@perf@blocking.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-skl9/igt@perf@blocking.html
#### Warnings ####
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [FAIL][45] ([fdo#111330]) -> [SKIP][46] ([fdo#109276])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb2/igt@gem_mocs_settings@mocs-settings-bsd2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb6/igt@gem_mocs_settings@mocs-settings-bsd2.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][47] ([fdo#109349]) -> [DMESG-WARN][48] ([fdo#107724])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6973/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (16 -> 10)
------------------------------
Missing (6): shard-tglb1 shard-tglb2 shard-tglb3 shard-tglb4 shard-tglb5 shard-tglb6
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6973 -> Patchwork_14581
CI-20190529: 20190529
CI_DRM_6973: 7462c58bba0fb6e85bd380591c3fd86e298c0f95 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5206: 5a6c68568def840cd720f18fc66f529a89f84675 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14581: ffe0e0f4ce510d58f1c20d6901bf2c1c5eccb189 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14581/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-09-30 12:20 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-28 10:01 [PATCH] drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines Chris Wilson
2019-09-28 10:20 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-09-28 10:43 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-28 20:03 ` ✓ Fi.CI.IGT: " Patchwork
2019-09-29 20:25 ` [PATCH] " Andi Shyti
2019-09-30 7:43 ` Chris Wilson
2019-09-30 9:11 ` [PATCH v2] drm/i915/tgl: Magic interrupt shadow to relieve some random lockups Chris Wilson
2019-09-30 12:02 ` Mika Kuoppala
2019-09-30 12:09 ` Chris Wilson
2019-09-30 9:57 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Magic udelay to relieve the random lockups with multiple engines (rev2) Patchwork
2019-09-30 10:23 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-30 12:20 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.