[PATCH] usb: dwc3: pci: prevent memory leak in dwc3_pci_probe

* [PATCH] usb: dwc3: pci: prevent memory leak in dwc3_pci_probe
@ 2019-09-30  2:41 Navid Emamdoost
  2019-09-30  6:55   ` Markus Elfring
  0 siblings, 1 reply; 3+ messages in thread
From: Navid Emamdoost @ 2019-09-30  2:41 UTC (permalink / raw)
  Cc: emamd001, kjlu, smccaman, Navid Emamdoost, Felipe Balbi,
	Greg Kroah-Hartman, linux-usb, linux-kernel

In dwc3_pci_probe a call to platform_device_alloc allocates a device
which is correctly put in case of error except one case: when the call to
platform_device_add_properties fails it directly returns instead of
going to error handling. This commit replaces return with the goto.

Fixes: 1a7b12f69a94 ("usb: dwc3: pci: Supply device properties via driver data")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
 drivers/usb/dwc3/dwc3-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 5e8e18222f92..023f0357efd7 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -258,7 +258,7 @@ static int dwc3_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
 
 	ret = platform_device_add_properties(dwc->dwc3, p);
 	if (ret < 0)
-		return ret;
+		goto err;
 
 	ret = dwc3_pci_quirks(dwc);
 	if (ret)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread