* [PATCH] atmodem: CGDCONT handling for cid 0
@ 2019-09-27 6:46 Antara Borwankar
2019-09-30 8:22 ` Pavel Machek
2019-09-30 16:15 ` Denis Kenzior
0 siblings, 2 replies; 4+ messages in thread
From: Antara Borwankar @ 2019-09-27 6:46 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
Added handling for cid 0 in +CGDCONT callback.
---
drivers/atmodem/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index 16f4927..defbba0 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -240,7 +240,7 @@ static void at_cgdcont_read_cb(gboolean ok, GAtResult *result,
return;
}
- cids = l_uintset_new(activated_cid);
+ cids = l_uintset_new_from_range(0,activated_cid);
l_uintset_put(cids, activated_cid);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] atmodem: CGDCONT handling for cid 0
2019-09-27 6:46 [PATCH] atmodem: CGDCONT handling for cid 0 Antara Borwankar
@ 2019-09-30 8:22 ` Pavel Machek
2019-09-30 16:15 ` Denis Kenzior
1 sibling, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2019-09-30 8:22 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Fri 2019-09-27 12:16:32, Antara Borwankar wrote:
> Added handling for cid 0 in +CGDCONT callback.
> ---
> drivers/atmodem/gprs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
> index 16f4927..defbba0 100644
> --- a/drivers/atmodem/gprs.c
> +++ b/drivers/atmodem/gprs.c
> @@ -240,7 +240,7 @@ static void at_cgdcont_read_cb(gboolean ok, GAtResult *result,
> return;
> }
>
> - cids = l_uintset_new(activated_cid);
> + cids = l_uintset_new_from_range(0,activated_cid);
>
For consistency, it should probably be "(0, activated_cid);".
> l_uintset_put(cids, activated_cid);
>
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] atmodem: CGDCONT handling for cid 0
2019-09-27 6:46 [PATCH] atmodem: CGDCONT handling for cid 0 Antara Borwankar
2019-09-30 8:22 ` Pavel Machek
@ 2019-09-30 16:15 ` Denis Kenzior
1 sibling, 0 replies; 4+ messages in thread
From: Denis Kenzior @ 2019-09-30 16:15 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
Hi Antara,
On 9/27/19 1:46 AM, Antara Borwankar wrote:
> Added handling for cid 0 in +CGDCONT callback.
> ---
> drivers/atmodem/gprs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
> index 16f4927..defbba0 100644
> --- a/drivers/atmodem/gprs.c
> +++ b/drivers/atmodem/gprs.c
> @@ -240,7 +240,7 @@ static void at_cgdcont_read_cb(gboolean ok, GAtResult *result,
> return;
> }
>
> - cids = l_uintset_new(activated_cid);
> + cids = l_uintset_new_from_range(0,activated_cid);
Applied with a silent amend to put a space between ',' and 2nd argument.
>
> l_uintset_put(cids, activated_cid);
>
>
Regards,
-Denis
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] atmodem: CGDCONT handling for cid 0
@ 2019-09-30 10:41 Antara Borwankar
0 siblings, 0 replies; 4+ messages in thread
From: Antara Borwankar @ 2019-09-30 10:41 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Added handling for cid 0 in +CGDCONT callback.
---
drivers/atmodem/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index 16f4927..b637f73 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -240,7 +240,7 @@ static void at_cgdcont_read_cb(gboolean ok, GAtResult *result,
return;
}
- cids = l_uintset_new(activated_cid);
+ cids = l_uintset_new_from_range(0, activated_cid);
l_uintset_put(cids, activated_cid);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-30 16:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 6:46 [PATCH] atmodem: CGDCONT handling for cid 0 Antara Borwankar
2019-09-30 8:22 ` Pavel Machek
2019-09-30 16:15 ` Denis Kenzior
2019-09-30 10:41 Antara Borwankar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.