All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] packagegroup: fix a comment regarding PACKAGE_ARCH
@ 2019-10-01 15:57 André Draszik
  0 siblings, 0 replies; only message in thread
From: André Draszik @ 2019-10-01 15:57 UTC (permalink / raw)
  To: openembedded-core

From: André Draszik <andre.draszik@jci.com>

packagegroups whose dependencies are affected by MACHINE_FEATURES
need to be marked as MACHINE_ARCH *before* inheriting the
packagegroup class, not after.

This has changed in commit 9c826962ec8f
("packagegroup: Make allarch inherit conditional"),
commit 4f3f34deafe4 in poky but the comment here
wasn't updated at the time.

Signed-off-by: André Draszik <andre.draszik@jci.com>
---
 meta/classes/packagegroup.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/packagegroup.bbclass b/meta/classes/packagegroup.bbclass
index 94a59e0c03..1541c8fbff 100644
--- a/meta/classes/packagegroup.bbclass
+++ b/meta/classes/packagegroup.bbclass
@@ -8,7 +8,7 @@ PACKAGES = "${PN}"
 
 # By default, packagegroup packages do not depend on a certain architecture.
 # Only if dependencies are modified by MACHINE_FEATURES, packages
-# need to be set to MACHINE_ARCH after inheriting packagegroup.bbclass
+# need to be set to MACHINE_ARCH before inheriting packagegroup.bbclass
 PACKAGE_ARCH ?= "all"
 
 # Fully expanded - so it applies the overrides as well
-- 
2.23.0.rc1



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-10-01 15:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 15:57 [PATCH] packagegroup: fix a comment regarding PACKAGE_ARCH André Draszik

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.