* [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout
@ 2019-10-02 16:58 don.hiatt
2019-10-02 17:33 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/01] " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: don.hiatt @ 2019-10-02 16:58 UTC (permalink / raw)
To: igt-dev
From: Don Hiatt <don.hiatt@intel.com>
Display the runtime pm status if we timeout waiting for status.
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
lib/igt_pm.c | 16 ++++++++++++----
lib/igt_pm.h | 2 +-
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 64ce240e093f..0d3561fdf821 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -658,16 +658,17 @@ void igt_disable_runtime_pm(void)
/**
* igt_get_runtime_pm_status:
+ * @buf: buffer to place pm status string in
+ * @len: length of buf
*
* Returns: The current runtime PM status.
*/
-enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
+enum igt_runtime_pm_status igt_get_runtime_pm_status(char *buf, int len)
{
ssize_t n_read;
- char buf[32];
lseek(pm_status_fd, 0, SEEK_SET);
- n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf) - 1);
+ n_read = read(pm_status_fd, buf, len - 1);
igt_assert(n_read >= 0);
buf[n_read] = '\0';
@@ -697,7 +698,14 @@ enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
*/
bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
{
- return igt_wait(igt_get_runtime_pm_status() == status, 10000, 100);
+ bool ret;
+ char buf[32];
+
+ ret = igt_wait(igt_get_runtime_pm_status(buf, ARRAY_SIZE(buf)) == status, 10000, 100);
+ if (!ret)
+ igt_warn("timeout: pm_status=%s", buf);
+
+ return ret;
}
/**
diff --git a/lib/igt_pm.h b/lib/igt_pm.h
index 7dc241749180..b2ff835e8a33 100644
--- a/lib/igt_pm.h
+++ b/lib/igt_pm.h
@@ -49,7 +49,7 @@ enum igt_runtime_pm_status {
bool igt_setup_runtime_pm(void);
void igt_disable_runtime_pm(void);
void igt_restore_runtime_pm(void);
-enum igt_runtime_pm_status igt_get_runtime_pm_status(void);
+enum igt_runtime_pm_status igt_get_runtime_pm_status(char *buf, int len);
bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
bool igt_pm_dmc_loaded(int debugfs);
bool igt_pm_pc8_plus_residencies_enabled(int msr_fd);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/01] lib/igt_pm: dump runtime pm status on timeout
2019-10-02 16:58 [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout don.hiatt
@ 2019-10-02 17:33 ` Patchwork
2019-10-02 20:56 ` [igt-dev] [PATCH i-g-t 01/01] " Vanshidhar Konda
2019-10-03 2:07 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,01/01] " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-02 17:33 UTC (permalink / raw)
To: don.hiatt; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,01/01] lib/igt_pm: dump runtime pm status on timeout
URL : https://patchwork.freedesktop.org/series/67507/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6991 -> IGTPW_3530
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/index.html
Known issues
------------
Here are the changes found in IGTPW_3530 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
* igt@vgem_basic@dmabuf-fence-before:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-icl-u3/igt@vgem_basic@dmabuf-fence-before.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/fi-icl-u3/igt@vgem_basic@dmabuf-fence-before.html
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-small-bo-tiledx:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledx.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledx.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][7] ([fdo#109635 ]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [FAIL][9] ([fdo#109483]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111045] / [fdo#111096]) -> [FAIL][12] ([fdo#111407])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
Participating hosts (51 -> 45)
------------------------------
Additional (1): fi-kbl-soraka
Missing (7): fi-ilk-m540 fi-tgl-u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5209 -> IGTPW_3530
CI-20190529: 20190529
CI_DRM_6991: 1f02b477cc08d4560a0c2cf6cc98340e09c7c734 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3530: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/index.html
IGT_5209: ec639c89860b859fdf4b038c2fa8ad593bd6909e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout
2019-10-02 16:58 [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout don.hiatt
2019-10-02 17:33 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/01] " Patchwork
@ 2019-10-02 20:56 ` Vanshidhar Konda
2019-10-03 21:43 ` Hiatt, Don
2019-10-03 2:07 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,01/01] " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Vanshidhar Konda @ 2019-10-02 20:56 UTC (permalink / raw)
To: don.hiatt; +Cc: igt-dev
On Wed, Oct 02, 2019 at 09:58:04AM -0700, don.hiatt@intel.com wrote:
>From: Don Hiatt <don.hiatt@intel.com>
>
>Display the runtime pm status if we timeout waiting for status.
>
>Signed-off-by: Don Hiatt <don.hiatt@intel.com>
>---
> lib/igt_pm.c | 16 ++++++++++++----
> lib/igt_pm.h | 2 +-
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/lib/igt_pm.c b/lib/igt_pm.c
>index 64ce240e093f..0d3561fdf821 100644
>--- a/lib/igt_pm.c
>+++ b/lib/igt_pm.c
>@@ -658,16 +658,17 @@ void igt_disable_runtime_pm(void)
>
> /**
> * igt_get_runtime_pm_status:
>+ * @buf: buffer to place pm status string in
>+ * @len: length of buf
> *
> * Returns: The current runtime PM status.
> */
>-enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
>+enum igt_runtime_pm_status igt_get_runtime_pm_status(char *buf, int len)
> {
> ssize_t n_read;
>- char buf[32];
>
> lseek(pm_status_fd, 0, SEEK_SET);
>- n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf) - 1);
>+ n_read = read(pm_status_fd, buf, len - 1);
> igt_assert(n_read >= 0);
May be we should add an assert here that makes sure n_read < len?
Vanshi
> buf[n_read] = '\0';
>
>@@ -697,7 +698,14 @@ enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
> */
> bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
> {
>- return igt_wait(igt_get_runtime_pm_status() == status, 10000, 100);
>+ bool ret;
>+ char buf[32];
>+
>+ ret = igt_wait(igt_get_runtime_pm_status(buf, ARRAY_SIZE(buf)) == status, 10000, 100);
>+ if (!ret)
>+ igt_warn("timeout: pm_status=%s", buf);
>+
>+ return ret;
> }
>
> /**
>diff --git a/lib/igt_pm.h b/lib/igt_pm.h
>index 7dc241749180..b2ff835e8a33 100644
>--- a/lib/igt_pm.h
>+++ b/lib/igt_pm.h
>@@ -49,7 +49,7 @@ enum igt_runtime_pm_status {
> bool igt_setup_runtime_pm(void);
> void igt_disable_runtime_pm(void);
> void igt_restore_runtime_pm(void);
>-enum igt_runtime_pm_status igt_get_runtime_pm_status(void);
>+enum igt_runtime_pm_status igt_get_runtime_pm_status(char *buf, int len);
> bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
> bool igt_pm_dmc_loaded(int debugfs);
> bool igt_pm_pc8_plus_residencies_enabled(int msr_fd);
>--
>2.20.1
>
>_______________________________________________
>igt-dev mailing list
>igt-dev@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,01/01] lib/igt_pm: dump runtime pm status on timeout
2019-10-02 16:58 [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout don.hiatt
2019-10-02 17:33 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/01] " Patchwork
2019-10-02 20:56 ` [igt-dev] [PATCH i-g-t 01/01] " Vanshidhar Konda
@ 2019-10-03 2:07 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-03 2:07 UTC (permalink / raw)
To: don.hiatt; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,01/01] lib/igt_pm: dump runtime pm status on timeout
URL : https://patchwork.freedesktop.org/series/67507/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6991_full -> IGTPW_3530_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3530_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3530_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3530_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_params@rs-invalid:
- shard-kbl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-kbl3/igt@gem_exec_params@rs-invalid.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-kbl2/igt@gem_exec_params@rs-invalid.html
* igt@gem_mmap_gtt@hang:
- shard-glk: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-glk5/igt@gem_mmap_gtt@hang.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-glk7/igt@gem_mmap_gtt@hang.html
Known issues
------------
Here are the changes found in IGTPW_3530_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110854])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb1/igt@gem_exec_balancer@smoke.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb8/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@preempt-queue-bsd2:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +17 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd2.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd2.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#111325]) +10 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_softpin@noreloc-s3:
- shard-iclb: [PASS][11] -> [INCOMPLETE][12] ([fdo#107713] / [fdo#109100])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb4/igt@gem_softpin@noreloc-s3.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb3/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@coherency-sync:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-hsw6/igt@gem_userptr_blits@coherency-sync.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-hsw2/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-kbl7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-kbl6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([fdo#111870]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-glk5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-glk8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [PASS][19] -> [DMESG-WARN][20] ([fdo#111870]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([fdo#108566]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-apl7/igt@gem_workarounds@suspend-resume-context.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* igt@kms_busy@basic-flip-c:
- shard-apl: [PASS][23] -> [INCOMPLETE][24] ([fdo#103927]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-apl2/igt@kms_busy@basic-flip-c.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-apl3/igt@kms_busy@basic-flip-c.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][25] -> [FAIL][26] ([fdo#105767])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [PASS][27] -> [FAIL][28] ([fdo#106509] / [fdo#107409])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-glk6/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-glk7/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [PASS][29] -> [FAIL][30] ([fdo#105363])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_vblank@pipe-a-query-idle:
- shard-hsw: [PASS][35] -> [INCOMPLETE][36] ([fdo#103540])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-hsw5/igt@kms_vblank@pipe-a-query-idle.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-hsw2/igt@kms_vblank@pipe-a-query-idle.html
* igt@perf_pmu@cpu-hotplug:
- shard-kbl: [PASS][37] -> [TIMEOUT][38] ([fdo#111546] / [fdo#111800])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-kbl3/igt@perf_pmu@cpu-hotplug.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-kbl2/igt@perf_pmu@cpu-hotplug.html
#### Possible fixes ####
* igt@gem_eio@suspend:
- shard-kbl: [FAIL][39] ([fdo#111550]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-kbl2/igt@gem_eio@suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-kbl6/igt@gem_eio@suspend.html
* igt@gem_exec_basic@gtt-rcs0:
- shard-snb: [DMESG-WARN][41] -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-snb7/igt@gem_exec_basic@gtt-rcs0.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-snb4/igt@gem_exec_basic@gtt-rcs0.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [SKIP][43] ([fdo#111325]) -> [PASS][44] +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb8/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_mmap_gtt@basic-small-copy-xy:
- shard-glk: [DMESG-WARN][45] ([fdo#107732]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-glk9/igt@gem_mmap_gtt@basic-small-copy-xy.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-glk7/igt@gem_mmap_gtt@basic-small-copy-xy.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][47] ([fdo#111870]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-snb7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-glk: [DMESG-WARN][49] ([fdo#111870]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-glk3/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-glk3/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-hsw: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-iclb: [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* {igt@i915_pm_dc@dc6-dpms}:
- shard-iclb: [FAIL][55] ([fdo#110548]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_cursor_crc@pipe-a-cursor-dpms:
- shard-kbl: [FAIL][57] ([fdo#103232]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-dpms.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-dpms.html
- shard-apl: [FAIL][59] ([fdo#103232]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-dpms.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-dpms.html
* igt@kms_flip@2x-flip-vs-panning:
- shard-hsw: [DMESG-WARN][61] -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-hsw1/igt@kms_flip@2x-flip-vs-panning.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-hsw4/igt@kms_flip@2x-flip-vs-panning.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-kbl: [FAIL][63] ([fdo#105363]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-kbl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][65] ([fdo#108566]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-apl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [FAIL][67] ([fdo#103167]) -> [PASS][68] +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][69] ([fdo#108341]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb1/igt@kms_psr@no_drrs.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb7/igt@kms_psr@psr2_primary_blt.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][73] ([fdo#99912]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-glk5/igt@kms_setmode@basic.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-glk2/igt@kms_setmode@basic.html
- shard-kbl: [FAIL][75] ([fdo#99912]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-kbl3/igt@kms_setmode@basic.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-kbl7/igt@kms_setmode@basic.html
* igt@perf_pmu@cpu-hotplug:
- shard-glk: [DMESG-WARN][77] ([fdo#107732] / [fdo#111800]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-glk9/igt@perf_pmu@cpu-hotplug.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-glk1/igt@perf_pmu@cpu-hotplug.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][79] ([fdo#109276]) -> [PASS][80] +14 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb7/igt@prime_busy@hang-bsd2.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb4/igt@prime_busy@hang-bsd2.html
* igt@prime_busy@wait-before-bsd:
- shard-iclb: [WARN][81] -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb1/igt@prime_busy@wait-before-bsd.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb4/igt@prime_busy@wait-before-bsd.html
#### Warnings ####
* igt@gem_mocs_settings@mocs-rc6-bsd2:
- shard-iclb: [FAIL][83] ([fdo#111330]) -> [SKIP][84] ([fdo#109276])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb4/igt@gem_mocs_settings@mocs-rc6-bsd2.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb3/igt@gem_mocs_settings@mocs-rc6-bsd2.html
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [SKIP][85] ([fdo#109276]) -> [FAIL][86] ([fdo#111330])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb5/igt@gem_mocs_settings@mocs-settings-bsd2.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb4/igt@gem_mocs_settings@mocs-settings-bsd2.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [DMESG-WARN][87] ([fdo#111870]) -> [DMESG-WARN][88] ([fdo#110789] / [fdo#111870])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][89] ([fdo#109349]) -> [DMESG-WARN][90] ([fdo#107724])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111546]: https://bugs.freedesktop.org/show_bug.cgi?id=111546
[fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
[fdo#111800]: https://bugs.freedesktop.org/show_bug.cgi?id=111800
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (11 -> 6)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-tglb pig-skl-6260u
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5209 -> IGTPW_3530
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_6991: 1f02b477cc08d4560a0c2cf6cc98340e09c7c734 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3530: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/index.html
IGT_5209: ec639c89860b859fdf4b038c2fa8ad593bd6909e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3530/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout
2019-10-02 20:56 ` [igt-dev] [PATCH i-g-t 01/01] " Vanshidhar Konda
@ 2019-10-03 21:43 ` Hiatt, Don
2019-10-03 21:53 ` Vanshidhar Konda
0 siblings, 1 reply; 6+ messages in thread
From: Hiatt, Don @ 2019-10-03 21:43 UTC (permalink / raw)
To: Konda, Vanshidhar R; +Cc: igt-dev
________________________________________
From: Konda, Vanshidhar R
Sent: Wednesday, October 02, 2019 1:56 PM
To: Hiatt, Don
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout
On Wed, Oct 02, 2019 at 09:58:04AM -0700, don.hiatt@intel.com wrote:
>From: Don Hiatt <don.hiatt@intel.com>
>
>Display the runtime pm status if we timeout waiting for status.
>
>Signed-off-by: Don Hiatt <don.hiatt@intel.com>
>---
> lib/igt_pm.c | 16 ++++++++++++----
> lib/igt_pm.h | 2 +-
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/lib/igt_pm.c b/lib/igt_pm.c
>index 64ce240e093f..0d3561fdf821 100644
>--- a/lib/igt_pm.c
>+++ b/lib/igt_pm.c
>@@ -658,16 +658,17 @@ void igt_disable_runtime_pm(void)
>
> /**
> * igt_get_runtime_pm_status:
>+ * @buf: buffer to place pm status string in
>+ * @len: length of buf
> *
> * Returns: The current runtime PM status.
> */
>-enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
>+enum igt_runtime_pm_status igt_get_runtime_pm_status(char *buf, int len)
> {
> ssize_t n_read;
>- char buf[32];
>
> lseek(pm_status_fd, 0, SEEK_SET);
>- n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf) - 1);
>+ n_read = read(pm_status_fd, buf, len - 1);
> igt_assert(n_read >= 0);
> May be we should add an assert here that makes sure n_read < len?
>
>Vanshi
Hi Vanshi,
read() can never return more than the size requested, see 'man 3 read':
ssize_t pread(int fildes, void *buf, size_t nbyte, off_t offset);
"This number shall never be greater than nbyte."
Thanks,
don
> buf[n_read] = '\0';
>
>@@ -697,7 +698,14 @@ enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
> */
> bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
> {
>- return igt_wait(igt_get_runtime_pm_status() == status, 10000, 100);
>+ bool ret;
>+ char buf[32];
>+
>+ ret = igt_wait(igt_get_runtime_pm_status(buf, ARRAY_SIZE(buf)) == status, 10000, 100);
>+ if (!ret)
>+ igt_warn("timeout: pm_status=%s", buf);
>+
>+ return ret;
> }
>
> /**
>diff --git a/lib/igt_pm.h b/lib/igt_pm.h
>index 7dc241749180..b2ff835e8a33 100644
>--- a/lib/igt_pm.h
>+++ b/lib/igt_pm.h
>@@ -49,7 +49,7 @@ enum igt_runtime_pm_status {
> bool igt_setup_runtime_pm(void);
> void igt_disable_runtime_pm(void);
> void igt_restore_runtime_pm(void);
>-enum igt_runtime_pm_status igt_get_runtime_pm_status(void);
>+enum igt_runtime_pm_status igt_get_runtime_pm_status(char *buf, int len);
> bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
> bool igt_pm_dmc_loaded(int debugfs);
> bool igt_pm_pc8_plus_residencies_enabled(int msr_fd);
>--
>2.20.1
>
>_______________________________________________
>igt-dev mailing list
>igt-dev@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout
2019-10-03 21:43 ` Hiatt, Don
@ 2019-10-03 21:53 ` Vanshidhar Konda
0 siblings, 0 replies; 6+ messages in thread
From: Vanshidhar Konda @ 2019-10-03 21:53 UTC (permalink / raw)
To: Hiatt, Don; +Cc: igt-dev
On Thu, Oct 03, 2019 at 02:43:11PM -0700, Hiatt, Don wrote:
>
>________________________________________
>From: Konda, Vanshidhar R
>Sent: Wednesday, October 02, 2019 1:56 PM
>To: Hiatt, Don
>Cc: igt-dev@lists.freedesktop.org
>Subject: Re: [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout
>
>On Wed, Oct 02, 2019 at 09:58:04AM -0700, don.hiatt@intel.com wrote:
>>From: Don Hiatt <don.hiatt@intel.com>
>>
>>Display the runtime pm status if we timeout waiting for status.
>>
>>Signed-off-by: Don Hiatt <don.hiatt@intel.com>
>>---
>> lib/igt_pm.c | 16 ++++++++++++----
>> lib/igt_pm.h | 2 +-
>> 2 files changed, 13 insertions(+), 5 deletions(-)
>>
>>diff --git a/lib/igt_pm.c b/lib/igt_pm.c
>>index 64ce240e093f..0d3561fdf821 100644
>>--- a/lib/igt_pm.c
>>+++ b/lib/igt_pm.c
>>@@ -658,16 +658,17 @@ void igt_disable_runtime_pm(void)
>>
>> /**
>> * igt_get_runtime_pm_status:
>>+ * @buf: buffer to place pm status string in
>>+ * @len: length of buf
>> *
>> * Returns: The current runtime PM status.
>> */
>>-enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
>>+enum igt_runtime_pm_status igt_get_runtime_pm_status(char *buf, int len)
>> {
>> ssize_t n_read;
>>- char buf[32];
>>
>> lseek(pm_status_fd, 0, SEEK_SET);
>>- n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf) - 1);
>>+ n_read = read(pm_status_fd, buf, len - 1);
>> igt_assert(n_read >= 0);
>
>> May be we should add an assert here that makes sure n_read < len?
>>
>>Vanshi
>
>Hi Vanshi,
>
>read() can never return more than the size requested, see 'man 3 read':
> ssize_t pread(int fildes, void *buf, size_t nbyte, off_t offset);
> "This number shall never be greater than nbyte."
>
Ah! You are right. I missed that.
Reviewed-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
>Thanks,
>
>don
>
>
>> buf[n_read] = '\0';
>>
>>@@ -697,7 +698,14 @@ enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
>> */
>> bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
>> {
>>- return igt_wait(igt_get_runtime_pm_status() == status, 10000, 100);
>>+ bool ret;
>>+ char buf[32];
>>+
>>+ ret = igt_wait(igt_get_runtime_pm_status(buf, ARRAY_SIZE(buf)) == status, 10000, 100);
>>+ if (!ret)
>>+ igt_warn("timeout: pm_status=%s", buf);
>>+
>>+ return ret;
>> }
>>
>> /**
>>diff --git a/lib/igt_pm.h b/lib/igt_pm.h
>>index 7dc241749180..b2ff835e8a33 100644
>>--- a/lib/igt_pm.h
>>+++ b/lib/igt_pm.h
>>@@ -49,7 +49,7 @@ enum igt_runtime_pm_status {
>> bool igt_setup_runtime_pm(void);
>> void igt_disable_runtime_pm(void);
>> void igt_restore_runtime_pm(void);
>>-enum igt_runtime_pm_status igt_get_runtime_pm_status(void);
>>+enum igt_runtime_pm_status igt_get_runtime_pm_status(char *buf, int len);
>> bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
>> bool igt_pm_dmc_loaded(int debugfs);
>> bool igt_pm_pc8_plus_residencies_enabled(int msr_fd);
>>--
>>2.20.1
>>
>>_______________________________________________
>>igt-dev mailing list
>>igt-dev@lists.freedesktop.org
>>https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-03 21:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 16:58 [igt-dev] [PATCH i-g-t 01/01] lib/igt_pm: dump runtime pm status on timeout don.hiatt
2019-10-02 17:33 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/01] " Patchwork
2019-10-02 20:56 ` [igt-dev] [PATCH i-g-t 01/01] " Vanshidhar Konda
2019-10-03 21:43 ` Hiatt, Don
2019-10-03 21:53 ` Vanshidhar Konda
2019-10-03 2:07 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,01/01] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.