All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Steven Price <steven.price@arm.com>
Cc: "Marc Zyngier" <maz@kernel.org>, "Will Deacon" <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"James Morse" <james.morse@arm.com>,
	"Julien Thierry" <julien.thierry.kdev@gmail.com>,
	"Suzuki K Pouloze" <suzuki.poulose@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Christoffer Dall" <christoffer.dall@arm.com>
Subject: Re: [PATCH v5 02/10] KVM: arm/arm64: Factor out hypercall handling from PSCI code
Date: Thu, 3 Oct 2019 14:23:02 +0200	[thread overview]
Message-ID: <20191003122302.emrmpzntkgzqlc3m@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20191002145037.51630-3-steven.price@arm.com>

On Wed, Oct 02, 2019 at 03:50:29PM +0100, Steven Price wrote:
> From: Christoffer Dall <christoffer.dall@arm.com>
> 
> We currently intertwine the KVM PSCI implementation with the general
> dispatch of hypercall handling, which makes perfect sense because PSCI
> is the only category of hypercalls we support.
> 
> However, as we are about to support additional hypercalls, factor out
> this functionality into a separate hypercall handler file.
> 
> Signed-off-by: Christoffer Dall <christoffer.dall@arm.com>
> [steven.price@arm.com: rebased]
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>  arch/arm/kvm/Makefile        |  2 +-
>  arch/arm/kvm/handle_exit.c   |  2 +-
>  arch/arm64/kvm/Makefile      |  1 +
>  arch/arm64/kvm/handle_exit.c |  4 +-
>  include/Kbuild               |  2 +
>  include/kvm/arm_hypercalls.h | 43 ++++++++++++++++++
>  include/kvm/arm_psci.h       |  2 +-
>  virt/kvm/arm/hypercalls.c    | 59 +++++++++++++++++++++++++
>  virt/kvm/arm/psci.c          | 84 +-----------------------------------
>  9 files changed, 112 insertions(+), 87 deletions(-)
>  create mode 100644 include/kvm/arm_hypercalls.h
>  create mode 100644 virt/kvm/arm/hypercalls.c
>

Reviewed-by: Andrew Jones <drjones@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com>
To: Steven Price <steven.price@arm.com>
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	linux-doc@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Will Deacon <will@kernel.org>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 02/10] KVM: arm/arm64: Factor out hypercall handling from PSCI code
Date: Thu, 3 Oct 2019 14:23:02 +0200	[thread overview]
Message-ID: <20191003122302.emrmpzntkgzqlc3m@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20191002145037.51630-3-steven.price@arm.com>

On Wed, Oct 02, 2019 at 03:50:29PM +0100, Steven Price wrote:
> From: Christoffer Dall <christoffer.dall@arm.com>
> 
> We currently intertwine the KVM PSCI implementation with the general
> dispatch of hypercall handling, which makes perfect sense because PSCI
> is the only category of hypercalls we support.
> 
> However, as we are about to support additional hypercalls, factor out
> this functionality into a separate hypercall handler file.
> 
> Signed-off-by: Christoffer Dall <christoffer.dall@arm.com>
> [steven.price@arm.com: rebased]
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>  arch/arm/kvm/Makefile        |  2 +-
>  arch/arm/kvm/handle_exit.c   |  2 +-
>  arch/arm64/kvm/Makefile      |  1 +
>  arch/arm64/kvm/handle_exit.c |  4 +-
>  include/Kbuild               |  2 +
>  include/kvm/arm_hypercalls.h | 43 ++++++++++++++++++
>  include/kvm/arm_psci.h       |  2 +-
>  virt/kvm/arm/hypercalls.c    | 59 +++++++++++++++++++++++++
>  virt/kvm/arm/psci.c          | 84 +-----------------------------------
>  9 files changed, 112 insertions(+), 87 deletions(-)
>  create mode 100644 include/kvm/arm_hypercalls.h
>  create mode 100644 virt/kvm/arm/hypercalls.c
>

Reviewed-by: Andrew Jones <drjones@redhat.com>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com>
To: Steven Price <steven.price@arm.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Christoffer Dall" <christoffer.dall@arm.com>,
	kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Suzuki K Pouloze" <suzuki.poulose@arm.com>,
	linux-doc@vger.kernel.org, "Russell King" <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org, "James Morse" <james.morse@arm.com>,
	"Julien Thierry" <julien.thierry.kdev@gmail.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Will Deacon" <will@kernel.org>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 02/10] KVM: arm/arm64: Factor out hypercall handling from PSCI code
Date: Thu, 3 Oct 2019 14:23:02 +0200	[thread overview]
Message-ID: <20191003122302.emrmpzntkgzqlc3m@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20191002145037.51630-3-steven.price@arm.com>

On Wed, Oct 02, 2019 at 03:50:29PM +0100, Steven Price wrote:
> From: Christoffer Dall <christoffer.dall@arm.com>
> 
> We currently intertwine the KVM PSCI implementation with the general
> dispatch of hypercall handling, which makes perfect sense because PSCI
> is the only category of hypercalls we support.
> 
> However, as we are about to support additional hypercalls, factor out
> this functionality into a separate hypercall handler file.
> 
> Signed-off-by: Christoffer Dall <christoffer.dall@arm.com>
> [steven.price@arm.com: rebased]
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>  arch/arm/kvm/Makefile        |  2 +-
>  arch/arm/kvm/handle_exit.c   |  2 +-
>  arch/arm64/kvm/Makefile      |  1 +
>  arch/arm64/kvm/handle_exit.c |  4 +-
>  include/Kbuild               |  2 +
>  include/kvm/arm_hypercalls.h | 43 ++++++++++++++++++
>  include/kvm/arm_psci.h       |  2 +-
>  virt/kvm/arm/hypercalls.c    | 59 +++++++++++++++++++++++++
>  virt/kvm/arm/psci.c          | 84 +-----------------------------------
>  9 files changed, 112 insertions(+), 87 deletions(-)
>  create mode 100644 include/kvm/arm_hypercalls.h
>  create mode 100644 virt/kvm/arm/hypercalls.c
>

Reviewed-by: Andrew Jones <drjones@redhat.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-03 12:23 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 14:50 [PATCH v5 00/10] arm64: Stolen time support Steven Price
2019-10-02 14:50 ` Steven Price
2019-10-02 14:50 ` Steven Price
2019-10-02 14:50 ` [PATCH v5 01/10] KVM: arm64: Document PV-time interface Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-03 12:19   ` Andrew Jones
2019-10-03 12:19     ` Andrew Jones
2019-10-03 12:19     ` Andrew Jones
2019-10-04  9:00     ` Steven Price
2019-10-04  9:00       ` Steven Price
2019-10-04  9:00       ` Steven Price
2019-10-02 14:50 ` [PATCH v5 02/10] KVM: arm/arm64: Factor out hypercall handling from PSCI code Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-03 12:23   ` Andrew Jones [this message]
2019-10-03 12:23     ` Andrew Jones
2019-10-03 12:23     ` Andrew Jones
2019-10-02 14:50 ` [PATCH v5 03/10] KVM: arm64: Implement PV_FEATURES call Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50 ` [PATCH v5 04/10] KVM: Implement kvm_put_guest() Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50 ` [PATCH v5 05/10] KVM: arm64: Support stolen time reporting via shared structure Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-03 13:22   ` Andrew Jones
2019-10-03 13:22     ` Andrew Jones
2019-10-03 13:22     ` Andrew Jones
2019-10-04  7:03     ` Andrew Jones
2019-10-04  7:03       ` Andrew Jones
2019-10-04  7:03       ` Andrew Jones
2019-10-04  9:13       ` Steven Price
2019-10-04  9:13         ` Steven Price
2019-10-04  9:13         ` Steven Price
2019-10-04  9:51         ` Andrew Jones
2019-10-04  9:51           ` Andrew Jones
2019-10-04  9:51           ` Andrew Jones
2019-10-02 14:50 ` [PATCH v5 06/10] KVM: Allow kvm_device_ops to be const Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-03 13:23   ` Andrew Jones
2019-10-03 13:23     ` Andrew Jones
2019-10-03 13:23     ` Andrew Jones
2019-10-02 14:50 ` [PATCH v5 07/10] KVM: arm64: Provide VCPU attributes for stolen time Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50 ` [PATCH v5 08/10] arm/arm64: Provide a wrapper for SMCCC 1.1 calls Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50 ` [PATCH v5 09/10] arm/arm64: Make use of the SMCCC 1.1 wrapper Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50 ` [PATCH v5 10/10] arm64: Retrieve stolen time as paravirtualized guest Steven Price
2019-10-02 14:50   ` Steven Price
2019-10-02 14:50   ` Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003122302.emrmpzntkgzqlc3m@kamzik.brq.redhat.com \
    --to=drjones@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@arm.com \
    --cc=james.morse@arm.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=steven.price@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.