* [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze
@ 2019-10-03 14:58 Peter Seiderer
2019-10-05 21:33 ` Thomas Petazzoni
2019-10-28 9:34 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Peter Seiderer @ 2019-10-03 14:58 UTC (permalink / raw)
To: buildroot
Fixes [1]:
In file included from double-conversion.h:42:0,
from number_decimalquantity.cpp:19:
double-conversion-utils.h:120:2: error: #error Target architecture was not detected as supported by Double-Conversion.
#error Target architecture was not detected as supported by Double-Conversion.
Apply the same fix as previously for qt5base ([2], already sent upstream [3],
but seems to be lost while merging [4]).
[1] http://autobuild.buildroot.net/results/24005bc54cbc742decee221fb09bca19ee70502c
[2] https://git.buildroot.net/buildroot/commit/?id=530668ddb709cf27aa6694e00f44cf58af858b0b
[3] https://github.com/google/double-conversion/issues/73
[4] https://github.com/google/double-conversion/commit/768a445f0c28311bf88685bf0bb990505c12fd4c
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
...ble-conversion-enable-for-microblaze.patch | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 package/icu/0007-double-conversion-enable-for-microblaze.patch
diff --git a/package/icu/0007-double-conversion-enable-for-microblaze.patch b/package/icu/0007-double-conversion-enable-for-microblaze.patch
new file mode 100644
index 0000000000..7a1977ad76
--- /dev/null
+++ b/package/icu/0007-double-conversion-enable-for-microblaze.patch
@@ -0,0 +1,25 @@
+From 395f063b6af8885cc9d688eeeb44acf9d75c6045 Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Thu, 3 Oct 2019 16:31:22 +0200
+Subject: [PATCH] double-conversion: enable for microblaze
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ source/i18n/double-conversion-utils.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/source/i18n/double-conversion-utils.h b/source/i18n/double-conversion-utils.h
+index 0cf9939..a00037e 100644
+--- a/source/i18n/double-conversion-utils.h
++++ b/source/i18n/double-conversion-utils.h
+@@ -104,6 +104,7 @@ int main(int argc, char** argv) {
+ defined(__AARCH64EL__) || defined(__aarch64__) || defined(__AARCH64EB__) || \
+ defined(__riscv) || \
+ defined(__or1k__) || defined(__arc__) || \
++ defined(__microblaze__) || \
+ defined(__EMSCRIPTEN__)
+ #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
+ #elif defined(__mc68000__) || \
+--
+2.23.0
+
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze
2019-10-03 14:58 [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze Peter Seiderer
@ 2019-10-05 21:33 ` Thomas Petazzoni
2019-10-06 13:26 ` Peter Seiderer
2019-10-28 9:34 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2019-10-05 21:33 UTC (permalink / raw)
To: buildroot
On Thu, 3 Oct 2019 16:58:06 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> Fixes [1]:
>
> In file included from double-conversion.h:42:0,
> from number_decimalquantity.cpp:19:
> double-conversion-utils.h:120:2: error: #error Target architecture was not detected as supported by Double-Conversion.
> #error Target architecture was not detected as supported by Double-Conversion.
>
> Apply the same fix as previously for qt5base ([2], already sent upstream [3],
> but seems to be lost while merging [4]).
>
> [1] http://autobuild.buildroot.net/results/24005bc54cbc742decee221fb09bca19ee70502c
> [2] https://git.buildroot.net/buildroot/commit/?id=530668ddb709cf27aa6694e00f44cf58af858b0b
> [3] https://github.com/google/double-conversion/issues/73
> [4] https://github.com/google/double-conversion/commit/768a445f0c28311bf88685bf0bb990505c12fd4c
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...ble-conversion-enable-for-microblaze.patch | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 package/icu/0007-double-conversion-enable-for-microblaze.patch
Applied to master, thanks. Could you get back to upstream so that this
microblaze support gets added ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze
2019-10-05 21:33 ` Thomas Petazzoni
@ 2019-10-06 13:26 ` Peter Seiderer
0 siblings, 0 replies; 4+ messages in thread
From: Peter Seiderer @ 2019-10-06 13:26 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Sat, 5 Oct 2019 23:33:41 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Thu, 3 Oct 2019 16:58:06 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > Fixes [1]:
> >
> > In file included from double-conversion.h:42:0,
> > from number_decimalquantity.cpp:19:
> > double-conversion-utils.h:120:2: error: #error Target architecture was not detected as supported by Double-Conversion.
> > #error Target architecture was not detected as supported by Double-Conversion.
> >
> > Apply the same fix as previously for qt5base ([2], already sent upstream [3],
> > but seems to be lost while merging [4]).
> >
> > [1] http://autobuild.buildroot.net/results/24005bc54cbc742decee221fb09bca19ee70502c
> > [2] https://git.buildroot.net/buildroot/commit/?id=530668ddb709cf27aa6694e00f44cf58af858b0b
> > [3] https://github.com/google/double-conversion/issues/73
> > [4] https://github.com/google/double-conversion/commit/768a445f0c28311bf88685bf0bb990505c12fd4c
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > ...ble-conversion-enable-for-microblaze.patch | 25 +++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> > create mode 100644 package/icu/0007-double-conversion-enable-for-microblaze.patch
>
> Applied to master, thanks. Could you get back to upstream so that this
> microblaze support gets added ?
Added a comment on the buggy merge commit (see [5]), maybe will wait some days before
submitting a new pull request ;-)
Regards,
Peter
[5] https://github.com/google/double-conversion/commit/768a445f0c28311bf88685bf0bb990505c12fd4c#commitcomment-35346617
>
> Thanks!
>
> Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze
2019-10-03 14:58 [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze Peter Seiderer
2019-10-05 21:33 ` Thomas Petazzoni
@ 2019-10-28 9:34 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-10-28 9:34 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> Fixes [1]:
> In file included from double-conversion.h:42:0,
> from number_decimalquantity.cpp:19:
> double-conversion-utils.h:120:2: error: #error Target architecture was not detected as supported by Double-Conversion.
> #error Target architecture was not detected as supported by Double-Conversion.
> Apply the same fix as previously for qt5base ([2], already sent upstream [3],
> but seems to be lost while merging [4]).
> [1] http://autobuild.buildroot.net/results/24005bc54cbc742decee221fb09bca19ee70502c
> [2] https://git.buildroot.net/buildroot/commit/?id=530668ddb709cf27aa6694e00f44cf58af858b0b
> [3] https://github.com/google/double-conversion/issues/73
> [4] https://github.com/google/double-conversion/commit/768a445f0c28311bf88685bf0bb990505c12fd4c
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Committed to 2019.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-28 9:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-03 14:58 [Buildroot] [PATCH v1] package/icu: fix double conversion compile for microblaze Peter Seiderer
2019-10-05 21:33 ` Thomas Petazzoni
2019-10-06 13:26 ` Peter Seiderer
2019-10-28 9:34 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.