All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/selftests: Appease lockdep
@ 2019-10-04 20:31 Chris Wilson
  2019-10-04 20:54 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2019-10-04 20:31 UTC (permalink / raw)
  To: intel-gfx

Disable irqs around updating the context image to keep lockdep happy:

<4>[  673.483340] WARNING: possible irq lock inversion dependency detected
<4>[  673.483342] 5.4.0-rc1-CI-Trybot_5118+ #1 Tainted: G     U
<4>[  673.483342] --------------------------------------------------------
<4>[  673.483343] swapper/2/0 just changed the state of lock:
<4>[  673.483344] ffff88845db885a0 (&i915_request_get(rq)->submit/1){-...}, at: __i915_sw_fence_complete+0x1b2/0x250 [i915]
<4>[  673.483387] but this lock took another, HARDIRQ-unsafe lock in the past:
<4>[  673.483388]  (&ce->pin_mutex/2){+...}
<4>[  673.483389]

                  and interrupts could create inverse lock ordering between them.

<4>[  673.483390]
                  other info that might help us debug this:
<4>[  673.483390] Chain exists of:
                    &i915_request_get(rq)->submit/1 --> &engine->active.lock --> &ce->pin_mutex/2

<4>[  673.483392]  Possible interrupt unsafe locking scenario:

<4>[  673.483392]        CPU0                    CPU1
<4>[  673.483393]        ----                    ----
<4>[  673.483393]   lock(&ce->pin_mutex/2);
<4>[  673.483394]                                local_irq_disable();
<4>[  673.483395]                                lock(&i915_request_get(rq)->submit/1);
<4>[  673.483396]                                lock(&engine->active.lock);
<4>[  673.483396]   <Interrupt>
<4>[  673.483397]     lock(&i915_request_get(rq)->submit/1);
<4>[  673.483398]
                   *** DEADLOCK ***

<4>[  673.483398] 2 locks held by swapper/2/0:
<4>[  673.483399]  #0: ffff8883f61ac9b0 (&(&gt->irq_lock)->rlock){-.-.}, at: gen11_gt_irq_handler+0x42/0x280 [i915]
<4>[  673.483433]  #1: ffff88845db8c418 (&(&rq->lock)->rlock){-.-.}, at: intel_engine_breadcrumbs_irq+0x34a/0x5a0 [i915]
<4>[  673.483463]
                  the shortest dependencies between 2nd lock and 1st lock:
<4>[  673.483466]   -> (&ce->pin_mutex/2){+...} ops: 614520 {
<4>[  673.483468]      HARDIRQ-ON-W at:
<4>[  673.483471]                         lock_acquire+0xa7/0x1c0
<4>[  673.483501]                         live_unlite_restore+0x1d8/0x6c0 [i915]
<4>[  673.483543]                         __i915_subtests+0xb8/0x210 [i915]
<4>[  673.483581]                         __run_selftests+0x112/0x170 [i915]
<4>[  673.483615]                         i915_live_selftests+0x2c/0x60 [i915]
<4>[  673.483644]                         i915_pci_probe+0x93/0x1b0 [i915]
<4>[  673.483646]                         pci_device_probe+0x9e/0x120
<4>[  673.483648]                         really_probe+0xea/0x420
<4>[  673.483649]                         driver_probe_device+0x10b/0x120
<4>[  673.483651]                         device_driver_attach+0x4a/0x50
<4>[  673.483652]                         __driver_attach+0x97/0x130
<4>[  673.483653]                         bus_for_each_dev+0x74/0xc0
<4>[  673.483654]                         bus_add_driver+0x142/0x220
<4>[  673.483655]                         driver_register+0x56/0xf0
<4>[  673.483657]                         do_one_initcall+0x58/0x2ff
<4>[  673.483659]                         do_init_module+0x56/0x1f8
<4>[  673.483660]                         load_module+0x243e/0x29f0
<4>[  673.483661]                         __do_sys_finit_module+0xe9/0x110
<4>[  673.483662]                         do_syscall_64+0x4f/0x210
<4>[  673.483665]                         entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4>[  673.483665]      INITIAL USE at:
<4>[  673.483667]                        lock_acquire+0xa7/0x1c0
<4>[  673.483698]                        live_unlite_restore+0x1d8/0x6c0 [i915]
<4>[  673.483733]                        __i915_subtests+0xb8/0x210 [i915]
<4>[  673.483764]                        __run_selftests+0x112/0x170 [i915]
<4>[  673.483793]                        i915_live_selftests+0x2c/0x60 [i915]
<4>[  673.483821]                        i915_pci_probe+0x93/0x1b0 [i915]
<4>[  673.483822]                        pci_device_probe+0x9e/0x120
<4>[  673.483824]                        really_probe+0xea/0x420
<4>[  673.483825]                        driver_probe_device+0x10b/0x120
<4>[  673.483826]                        device_driver_attach+0x4a/0x50
<4>[  673.483827]                        __driver_attach+0x97/0x130
<4>[  673.483828]                        bus_for_each_dev+0x74/0xc0
<4>[  673.483829]                        bus_add_driver+0x142/0x220
<4>[  673.483830]                        driver_register+0x56/0xf0
<4>[  673.483831]                        do_one_initcall+0x58/0x2ff
<4>[  673.483833]                        do_init_module+0x56/0x1f8
<4>[  673.483834]                        load_module+0x243e/0x29f0
<4>[  673.483835]                        __do_sys_finit_module+0xe9/0x110
<4>[  673.483836]                        do_syscall_64+0x4f/0x210
<4>[  673.483837]                        entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4>[  673.483838]    }
<4>[  673.483868]    ... key      at: [<ffffffffa0a8f132>] __key.70113+0x2/0xffffffffffef2ed0 [i915]
<4>[  673.483869]    ... acquired at:
<4>[  673.483935]    __execlists_reset+0xfb/0xc20 [i915]
<4>[  673.483965]    execlists_reset+0x3d/0x50 [i915]
<4>[  673.483995]    intel_engine_reset+0xdf/0x230 [i915]
<4>[  673.484022]    live_preempt_hang+0x1d7/0x2e0 [i915]
<4>[  673.484064]    __i915_subtests+0xb8/0x210 [i915]
<4>[  673.484130]    __run_selftests+0x112/0x170 [i915]
<4>[  673.484163]    i915_live_selftests+0x2c/0x60 [i915]
<4>[  673.484193]    i915_pci_probe+0x93/0x1b0 [i915]
<4>[  673.484194]    pci_device_probe+0x9e/0x120
<4>[  673.484195]    really_probe+0xea/0x420
<4>[  673.484196]    driver_probe_device+0x10b/0x120
<4>[  673.484197]    device_driver_attach+0x4a/0x50
<4>[  673.484198]    __driver_attach+0x97/0x130
<4>[  673.484199]    bus_for_each_dev+0x74/0xc0
<4>[  673.484200]    bus_add_driver+0x142/0x220
<4>[  673.484202]    driver_register+0x56/0xf0
<4>[  673.484203]    do_one_initcall+0x58/0x2ff
<4>[  673.484204]    do_init_module+0x56/0x1f8
<4>[  673.484205]    load_module+0x243e/0x29f0
<4>[  673.484206]    __do_sys_finit_module+0xe9/0x110
<4>[  673.484207]    do_syscall_64+0x4f/0x210
<4>[  673.484208]    entry_SYSCALL_64_after_hwframe+0x49/0xbe

<4>[  673.484209]  -> (&engine->active.lock){..-.} ops: 972791 {
<4>[  673.484211]     IN-SOFTIRQ-W at:
<4>[  673.484213]                       lock_acquire+0xa7/0x1c0
<4>[  673.484214]                       _raw_spin_lock_irqsave+0x33/0x50
<4>[  673.484244]                       execlists_submission_tasklet+0xaf/0x100 [i915]
<4>[  673.484246]                       tasklet_action_common.isra.18+0x6c/0x1c0
<4>[  673.484247]                       __do_softirq+0xdf/0x47f
<4>[  673.484248]                       irq_exit+0xba/0xc0
<4>[  673.484249]                       do_IRQ+0x83/0x160
<4>[  673.484250]                       ret_from_intr+0x0/0x1d
<4>[  673.484252]                       cpuidle_enter_state+0xb2/0x450
<4>[  673.484253]                       cpuidle_enter+0x24/0x40
<4>[  673.484254]                       do_idle+0x1e7/0x250
<4>[  673.484256]                       cpu_startup_entry+0x14/0x20
<4>[  673.484257]                       start_secondary+0x15f/0x1b0
<4>[  673.484258]                       secondary_startup_64+0xa4/0xb0
<4>[  673.484259]     INITIAL USE at:
<4>[  673.484261]                      lock_acquire+0xa7/0x1c0
<4>[  673.484290]                      intel_engine_init_active+0x7e/0xb0 [i915]
<4>[  673.484305]                      intel_engines_setup+0x1cd/0x3b0 [i915]
<4>[  673.484305]                      i915_gem_init+0x12d/0x900 [i915]
<4>[  673.484305]                      i915_driver_probe+0xb70/0x15d0 [i915]
<4>[  673.484305]                      i915_pci_probe+0x43/0x1b0 [i915]
<4>[  673.484305]                      pci_device_probe+0x9e/0x120
<4>[  673.484305]                      really_probe+0xea/0x420
<4>[  673.484305]                      driver_probe_device+0x10b/0x120
<4>[  673.484305]                      device_driver_attach+0x4a/0x50
<4>[  673.484305]                      __driver_attach+0x97/0x130
<4>[  673.484305]                      bus_for_each_dev+0x74/0xc0
<4>[  673.484305]                      bus_add_driver+0x142/0x220
<4>[  673.484305]                      driver_register+0x56/0xf0
<4>[  673.484305]                      do_one_initcall+0x58/0x2ff
<4>[  673.484305]                      do_init_module+0x56/0x1f8
<4>[  673.484305]                      load_module+0x243e/0x29f0
<4>[  673.484305]                      __do_sys_finit_module+0xe9/0x110
<4>[  673.484305]                      do_syscall_64+0x4f/0x210
<4>[  673.484305]                      entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4>[  673.484305]   }
<4>[  673.484305]   ... key      at: [<ffffffffa0a8f160>] __key.70307+0x0/0xffffffffffef2ea0 [i915]
<4>[  673.484305]   ... acquired at:
<4>[  673.484305]    _raw_spin_lock_irqsave+0x33/0x50
<4>[  673.484305]    execlists_submit_request+0x2b/0x1e0 [i915]
<4>[  673.484305]    submit_notify+0xa8/0x13c [i915]
<4>[  673.484305]    __i915_sw_fence_complete+0x81/0x250 [i915]
<4>[  673.484305]    i915_sw_fence_wake+0x51/0x70 [i915]
<4>[  673.484305]    __i915_sw_fence_complete+0x1ee/0x250 [i915]
<4>[  673.484305]    dma_i915_sw_fence_wake+0x1b/0x30 [i915]
<4>[  673.484305]    dma_fence_signal_locked+0x9e/0x1b0
<4>[  673.484305]    dma_fence_signal+0x1f/0x40
<4>[  673.484305]    fence_work+0x28/0x80 [i915]
<4>[  673.484305]    process_one_work+0x26a/0x620
<4>[  673.484305]    worker_thread+0x37/0x380
<4>[  673.484305]    kthread+0x119/0x130
<4>[  673.484305]    ret_from_fork+0x24/0x50

<4>[  673.484305] -> (&i915_request_get(rq)->submit/1){-...} ops: 857694 {
<4>[  673.484305]    IN-HARDIRQ-W at:
<4>[  673.484305]                     lock_acquire+0xa7/0x1c0
<4>[  673.484305]                     _raw_spin_lock_irqsave_nested+0x39/0x50
<4>[  673.484305]                     __i915_sw_fence_complete+0x1b2/0x250 [i915]
<4>[  673.484305]                     intel_engine_breadcrumbs_irq+0x3d0/0x5a0 [i915]
<4>[  673.484305]                     cs_irq_handler+0x39/0x50 [i915]
<4>[  673.484305]                     gen11_gt_irq_handler+0x17b/0x280 [i915]
<4>[  673.484305]                     gen11_irq_handler+0x54/0xf0 [i915]
<4>[  673.484305]                     __handle_irq_event_percpu+0x41/0x2c0
<4>[  673.484305]                     handle_irq_event_percpu+0x2b/0x70
<4>[  673.484305]                     handle_irq_event+0x2f/0x50
<4>[  673.484305]                     handle_edge_irq+0x99/0x1b0
<4>[  673.484305]                     do_IRQ+0x7e/0x160
<4>[  673.484305]                     ret_from_intr+0x0/0x1d
<4>[  673.484305]                     cpuidle_enter_state+0xb2/0x450
<4>[  673.484305]                     cpuidle_enter+0x24/0x40
<4>[  673.484305]                     do_idle+0x1e7/0x250
<4>[  673.484305]                     cpu_startup_entry+0x14/0x20
<4>[  673.484305]                     start_secondary+0x15f/0x1b0
<4>[  673.484305]                     secondary_startup_64+0xa4/0xb0
<4>[  673.484305]    INITIAL USE at:
<4>[  673.484305]                    lock_acquire+0xa7/0x1c0
<4>[  673.484305]                    _raw_spin_lock_irqsave_nested+0x39/0x50
<4>[  673.484305]                    __i915_sw_fence_complete+0x1b2/0x250 [i915]
<4>[  673.484305]                    __engine_park+0x233/0x420 [i915]
<4>[  673.484305]                    ____intel_wakeref_put_last+0x1c/0x70 [i915]
<4>[  673.484305]                    intel_gt_resume+0x202/0x2c0 [i915]
<4>[  673.484305]                    i915_gem_init+0x36e/0x900 [i915]
<4>[  673.484305]                    i915_driver_probe+0xb70/0x15d0 [i915]
<4>[  673.484305]                    i915_pci_probe+0x43/0x1b0 [i915]
<4>[  673.484305]                    pci_device_probe+0x9e/0x120
<4>[  673.484305]                    really_probe+0xea/0x420
<4>[  673.484305]                    driver_probe_device+0x10b/0x120
<4>[  673.484305]                    device_driver_attach+0x4a/0x50
<4>[  673.484305]                    __driver_attach+0x97/0x130
<4>[  673.484305]                    bus_for_each_dev+0x74/0xc0
<4>[  673.484305]                    bus_add_driver+0x142/0x220
<4>[  673.484305]                    driver_register+0x56/0xf0
<4>[  673.484305]                    do_one_initcall+0x58/0x2ff
<4>[  673.484305]                    do_init_module+0x56/0x1f8
<4>[  673.484305]                    load_module+0x243e/0x29f0
<4>[  673.484305]                    __do_sys_finit_module+0xe9/0x110
<4>[  673.484305]                    do_syscall_64+0x4f/0x210
<4>[  673.484305]                    entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4>[  673.484305]  }
<4>[  673.484305]  ... key      at: [<ffffffffa0a8f6a1>] __key.80173+0x1/0xffffffffffef2960 [i915]
<4>[  673.484305]  ... acquired at:
<4>[  673.484305]    mark_lock+0x382/0x500
<4>[  673.484305]    __lock_acquire+0x7e1/0x15d0
<4>[  673.484305]    lock_acquire+0xa7/0x1c0
<4>[  673.484305]    _raw_spin_lock_irqsave_nested+0x39/0x50
<4>[  673.484305]    __i915_sw_fence_complete+0x1b2/0x250 [i915]
<4>[  673.484305]    intel_engine_breadcrumbs_irq+0x3d0/0x5a0 [i915]
<4>[  673.484305]    cs_irq_handler+0x39/0x50 [i915]
<4>[  673.484305]    gen11_gt_irq_handler+0x17b/0x280 [i915]
<4>[  673.484305]    gen11_irq_handler+0x54/0xf0 [i915]
<4>[  673.484305]    __handle_irq_event_percpu+0x41/0x2c0
<4>[  673.484305]    handle_irq_event_percpu+0x2b/0x70
<4>[  673.484305]    handle_irq_event+0x2f/0x50
<4>[  673.484305]    handle_edge_irq+0x99/0x1b0
<4>[  673.484305]    do_IRQ+0x7e/0x160
<4>[  673.484305]    ret_from_intr+0x0/0x1d
<4>[  673.484305]    cpuidle_enter_state+0xb2/0x450
<4>[  673.484305]    cpuidle_enter+0x24/0x40
<4>[  673.484305]    do_idle+0x1e7/0x250
<4>[  673.484305]    cpu_startup_entry+0x14/0x20
<4>[  673.484305]    start_secondary+0x15f/0x1b0
<4>[  673.484305]    secondary_startup_64+0xa4/0xb0

<4>[  673.484305]
                  stack backtrace:
<4>[  673.484305] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G     U            5.4.0-rc1-CI-Trybot_5118+ #1
<4>[  673.484305] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3183.A00.1905020411 05/02/2019
<4>[  673.484305] Call Trace:
<4>[  673.484305]  <IRQ>
<4>[  673.484305]  dump_stack+0x67/0x9b
<4>[  673.484305]  check_usage_forwards+0x13c/0x150
<4>[  673.484305]  ? mark_lock+0x382/0x500
<4>[  673.484305]  mark_lock+0x382/0x500
<4>[  673.484305]  ? check_usage_backwards+0x140/0x140
<4>[  673.484305]  __lock_acquire+0x7e1/0x15d0
<4>[  673.484305]  ? debug_object_deactivate+0x17e/0x190
<4>[  673.484305]  lock_acquire+0xa7/0x1c0
<4>[  673.484305]  ? __i915_sw_fence_complete+0x1b2/0x250 [i915]
<4>[  673.484305]  _raw_spin_lock_irqsave_nested+0x39/0x50
<4>[  673.484305]  ? __i915_sw_fence_complete+0x1b2/0x250 [i915]
<4>[  673.484305]  __i915_sw_fence_complete+0x1b2/0x250 [i915]
<4>[  673.484305]  intel_engine_breadcrumbs_irq+0x3d0/0x5a0 [i915]
<4>[  673.484305]  cs_irq_handler+0x39/0x50 [i915]
<4>[  673.484305]  gen11_gt_irq_handler+0x17b/0x280 [i915]
<4>[  673.484305]  gen11_irq_handler+0x54/0xf0 [i915]
<4>[  673.484305]  __handle_irq_event_percpu+0x41/0x2c0
<4>[  673.484305]  handle_irq_event_percpu+0x2b/0x70
<4>[  673.484305]  handle_irq_event+0x2f/0x50
<4>[  673.484305]  handle_edge_irq+0x99/0x1b0
<4>[  673.484305]  do_IRQ+0x7e/0x160
<4>[  673.484305]  common_interrupt+0xf/0xf
<4>[  673.484305]  </IRQ>

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 393ae5321e1d..198cf2f754f4 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -143,11 +143,11 @@ static int live_unlite_restore(struct drm_i915_private *i915, int prio)
 		GEM_BUG_ON(!ce[1]->ring->size);
 		intel_ring_reset(ce[1]->ring, ce[1]->ring->size / 2);
 
-		local_bh_disable(); /* appease lockdep */
+		local_irq_disable(); /* appease lockdep */
 		__context_pin_acquire(ce[1]);
 		__execlists_update_reg_state(ce[1], engine);
 		__context_pin_release(ce[1]);
-		local_bh_enable();
+		local_irq_enable();
 
 		rq[0] = igt_spinner_create_request(&spin, ce[0], MI_ARB_CHECK);
 		if (IS_ERR(rq[0])) {
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Appease lockdep
  2019-10-04 20:31 [PATCH] drm/i915/selftests: Appease lockdep Chris Wilson
@ 2019-10-04 20:54 ` Patchwork
  2019-10-04 21:20 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-10-04 20:54 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/selftests: Appease lockdep
URL   : https://patchwork.freedesktop.org/series/67622/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4c82f2976a87 drm/i915/selftests: Appease lockdep
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
<4>[  673.483344] ffff88845db885a0 (&i915_request_get(rq)->submit/1){-...}, at: __i915_sw_fence_complete+0x1b2/0x250 [i915]

total: 0 errors, 1 warnings, 0 checks, 13 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/selftests: Appease lockdep
  2019-10-04 20:31 [PATCH] drm/i915/selftests: Appease lockdep Chris Wilson
  2019-10-04 20:54 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2019-10-04 21:20 ` Patchwork
  2019-10-05  8:19 ` ✗ Fi.CI.IGT: failure " Patchwork
  2019-10-07 16:12 ` [PATCH] " Tvrtko Ursulin
  3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-10-04 21:20 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/selftests: Appease lockdep
URL   : https://patchwork.freedesktop.org/series/67622/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7012 -> Patchwork_14678
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/index.html

Known issues
------------

  Here are the changes found in Patchwork_14678 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_flink_basic@basic:
    - fi-icl-u3:          [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/fi-icl-u3/igt@gem_flink_basic@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/fi-icl-u3/igt@gem_flink_basic@basic.html

  
#### Possible fixes ####

  * igt@gem_ctx_switch@rcs0:
    - fi-bxt-dsi:         [INCOMPLETE][5] ([fdo#103927]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/fi-bxt-dsi/igt@gem_ctx_switch@rcs0.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/fi-bxt-dsi/igt@gem_ctx_switch@rcs0.html

  * igt@gem_mmap_gtt@basic-write-no-prefault:
    - fi-icl-u3:          [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html

  * igt@i915_selftest@live_hangcheck:
    - {fi-icl-guc}:       [DMESG-FAIL][9] ([fdo#111678]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/fi-icl-guc/igt@i915_selftest@live_hangcheck.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/fi-icl-guc/igt@i915_selftest@live_hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111678]: https://bugs.freedesktop.org/show_bug.cgi?id=111678


Participating hosts (52 -> 43)
------------------------------

  Missing    (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7012 -> Patchwork_14678

  CI-20190529: 20190529
  CI_DRM_7012: 42dcf5adc9c45f6f2f28e23b815ab723f96edca0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5212: d17a484b3c22706b2b004ef1577f367d79235e43 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_14678: 4c82f2976a87b7b5d72b1ce2deb5ee157d357350 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

4c82f2976a87 drm/i915/selftests: Appease lockdep

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* ✗ Fi.CI.IGT: failure for drm/i915/selftests: Appease lockdep
  2019-10-04 20:31 [PATCH] drm/i915/selftests: Appease lockdep Chris Wilson
  2019-10-04 20:54 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
  2019-10-04 21:20 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-10-05  8:19 ` Patchwork
  2019-10-07 16:12 ` [PATCH] " Tvrtko Ursulin
  3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-10-05  8:19 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/selftests: Appease lockdep
URL   : https://patchwork.freedesktop.org/series/67622/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7012_full -> Patchwork_14678_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_14678_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_14678_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_14678_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_isolation@bcs0-nonpriv:
    - shard-skl:          NOTRUN -> [FAIL][1] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-skl10/igt@gem_ctx_isolation@bcs0-nonpriv.html

  * igt@gem_ctx_isolation@vcs0-s3:
    - shard-kbl:          [PASS][2] -> [FAIL][3] +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-kbl3/igt@gem_ctx_isolation@vcs0-s3.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-kbl6/igt@gem_ctx_isolation@vcs0-s3.html

  * igt@gem_ctx_isolation@vecs0-clean:
    - shard-glk:          [PASS][4] -> [FAIL][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-glk9/igt@gem_ctx_isolation@vecs0-clean.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-glk5/igt@gem_ctx_isolation@vecs0-clean.html

  * igt@gem_ctx_isolation@vecs0-none:
    - shard-apl:          [PASS][6] -> [FAIL][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-apl8/igt@gem_ctx_isolation@vecs0-none.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-apl6/igt@gem_ctx_isolation@vecs0-none.html

  * igt@gem_ctx_isolation@vecs0-reset:
    - shard-skl:          [PASS][8] -> [FAIL][9] +3 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-skl8/igt@gem_ctx_isolation@vecs0-reset.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-skl9/igt@gem_ctx_isolation@vecs0-reset.html

  * igt@i915_selftest@live_hangcheck:
    - shard-hsw:          [PASS][10] -> [DMESG-FAIL][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-hsw6/igt@i915_selftest@live_hangcheck.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-hsw1/igt@i915_selftest@live_hangcheck.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@gem_ctx_isolation@vcs2-none:
    - {shard-tglb}:       NOTRUN -> [SKIP][12] +3 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-tglb6/igt@gem_ctx_isolation@vcs2-none.html

  * {igt@gem_ctx_isolation@vecs0-nonpriv-switch}:
    - shard-iclb:         NOTRUN -> [FAIL][13]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb5/igt@gem_ctx_isolation@vecs0-nonpriv-switch.html

  * igt@kms_flip@flip-vs-panning:
    - {shard-tglb}:       [PASS][14] -> [INCOMPLETE][15] +3 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-tglb2/igt@kms_flip@flip-vs-panning.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-tglb6/igt@kms_flip@flip-vs-panning.html

  
Known issues
------------

  Here are the changes found in Patchwork_14678_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_shared@exec-shared-gtt-bsd2:
    - shard-iclb:         [PASS][16] -> [SKIP][17] ([fdo#109276]) +4 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb1/igt@gem_ctx_shared@exec-shared-gtt-bsd2.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb7/igt@gem_ctx_shared@exec-shared-gtt-bsd2.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [PASS][18] -> [SKIP][19] ([fdo#111325]) +6 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-snb:          [PASS][20] -> [DMESG-WARN][21] ([fdo#111870])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-apl:          [PASS][22] -> [DMESG-WARN][23] ([fdo#108566]) +3 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-apl8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-apl8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_flip@flip-vs-panning:
    - shard-iclb:         [PASS][24] -> [INCOMPLETE][25] ([fdo#107713])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb1/igt@kms_flip@flip-vs-panning.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb7/igt@kms_flip@flip-vs-panning.html

  * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
    - shard-iclb:         [PASS][26] -> [FAIL][27] ([fdo#103167]) +4 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
    - shard-skl:          [PASS][28] -> [FAIL][29] ([fdo#108145])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][30] -> [FAIL][31] ([fdo#103166])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_primary_page_flip:
    - shard-iclb:         [PASS][32] -> [SKIP][33] ([fdo#109441])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb7/igt@kms_psr@psr2_primary_page_flip.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@bcs0-dirty-create:
    - shard-kbl:          [FAIL][34] -> [PASS][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-kbl3/igt@gem_ctx_isolation@bcs0-dirty-create.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-kbl4/igt@gem_ctx_isolation@bcs0-dirty-create.html

  * igt@gem_ctx_isolation@bcs0-none:
    - shard-glk:          [FAIL][36] -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-glk9/igt@gem_ctx_isolation@bcs0-none.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-glk8/igt@gem_ctx_isolation@bcs0-none.html

  * igt@gem_ctx_shared@q-smoketest-bsd:
    - {shard-tglb}:       [INCOMPLETE][38] ([fdo# 111852 ]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-tglb3/igt@gem_ctx_shared@q-smoketest-bsd.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-tglb6/igt@gem_ctx_shared@q-smoketest-bsd.html

  * igt@gem_eio@in-flight-contexts-10ms:
    - shard-hsw:          [FAIL][40] -> [PASS][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-hsw4/igt@gem_eio@in-flight-contexts-10ms.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-hsw8/igt@gem_eio@in-flight-contexts-10ms.html

  * igt@gem_exec_schedule@preempt-bsd:
    - shard-iclb:         [SKIP][42] ([fdo#111325]) -> [PASS][43] +1 similar issue
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb2/igt@gem_exec_schedule@preempt-bsd.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb7/igt@gem_exec_schedule@preempt-bsd.html

  * igt@gem_exec_suspend@basic-s3:
    - {shard-tglb}:       [INCOMPLETE][44] ([fdo#111736]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-tglb4/igt@gem_exec_suspend@basic-s3.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-tglb7/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_ppgtt@blt-vs-render-ctx0:
    - shard-hsw:          [INCOMPLETE][46] ([fdo#103540]) -> [PASS][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-hsw1/igt@gem_ppgtt@blt-vs-render-ctx0.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-hsw2/igt@gem_ppgtt@blt-vs-render-ctx0.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-hsw:          [DMESG-WARN][48] ([fdo#111870]) -> [PASS][49] +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-snb:          [DMESG-WARN][50] ([fdo#111870]) -> [PASS][51] +1 similar issue
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@i915_pm_rpm@system-suspend-modeset:
    - {shard-tglb}:       [INCOMPLETE][52] ([fdo#111600] / [fdo#111832]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-tglb4/igt@i915_pm_rpm@system-suspend-modeset.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-tglb3/igt@i915_pm_rpm@system-suspend-modeset.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [DMESG-WARN][54] ([fdo#108566]) -> [PASS][55] +8 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-apl1/igt@i915_suspend@sysfs-reader.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-apl7/igt@i915_suspend@sysfs-reader.html

  * igt@kms_cursor_legacy@pipe-c-single-bo:
    - shard-iclb:         [INCOMPLETE][56] ([fdo#107713]) -> [PASS][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb7/igt@kms_cursor_legacy@pipe-c-single-bo.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb5/igt@kms_cursor_legacy@pipe-c-single-bo.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-skl:          [FAIL][58] ([fdo#105363]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
    - shard-iclb:         [FAIL][60] ([fdo#103167]) -> [PASS][61] +3 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt:
    - shard-iclb:         [INCOMPLETE][62] ([fdo#106978] / [fdo#107713]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
    - {shard-tglb}:       [FAIL][64] ([fdo#103167]) -> [PASS][65] +8 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][66] ([fdo#108145] / [fdo#110403]) -> [PASS][67] +1 similar issue
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@psr2_sprite_blt:
    - shard-iclb:         [SKIP][68] ([fdo#109441]) -> [PASS][69] +1 similar issue
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb4/igt@kms_psr@psr2_sprite_blt.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][70] ([fdo#99912]) -> [PASS][71]
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-apl1/igt@kms_setmode@basic.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-apl7/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - {shard-tglb}:       [INCOMPLETE][72] ([fdo#111832]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-tglb7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-tglb6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html

  * igt@perf@rc6-disable:
    - shard-kbl:          [FAIL][74] ([fdo#103179]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-kbl2/igt@perf@rc6-disable.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-kbl7/igt@perf@rc6-disable.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [SKIP][76] ([fdo#109276]) -> [PASS][77] +13 similar issues
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb7/igt@prime_busy@hang-bsd2.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb4/igt@prime_busy@hang-bsd2.html

  
#### Warnings ####

  * igt@gem_mocs_settings@mocs-rc6-bsd2:
    - shard-iclb:         [SKIP][78] ([fdo#109276]) -> [FAIL][79] ([fdo#111330])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7012/shard-iclb3/igt@gem_mocs_settings@mocs-rc6-bsd2.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/shard-iclb1/igt@gem_mocs_settings@mocs-rc6-bsd2.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 111852 
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103179]: https://bugs.freedesktop.org/show_bug.cgi?id=103179
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
  [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
  [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
  [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
  [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
  [fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
  [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
  [fdo#111855]: https://bugs.freedesktop.org/show_bug.cgi?id=111855
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (11 -> 11)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7012 -> Patchwork_14678

  CI-20190529: 20190529
  CI_DRM_7012: 42dcf5adc9c45f6f2f28e23b815ab723f96edca0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5212: d17a484b3c22706b2b004ef1577f367d79235e43 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_14678: 4c82f2976a87b7b5d72b1ce2deb5ee157d357350 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14678/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i915/selftests: Appease lockdep
  2019-10-04 20:31 [PATCH] drm/i915/selftests: Appease lockdep Chris Wilson
                   ` (2 preceding siblings ...)
  2019-10-05  8:19 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-10-07 16:12 ` Tvrtko Ursulin
  3 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2019-10-07 16:12 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx


On 04/10/2019 21:31, Chris Wilson wrote:
> Disable irqs around updating the context image to keep lockdep happy:
> 
> <4>[  673.483340] WARNING: possible irq lock inversion dependency detected
> <4>[  673.483342] 5.4.0-rc1-CI-Trybot_5118+ #1 Tainted: G     U
> <4>[  673.483342] --------------------------------------------------------
> <4>[  673.483343] swapper/2/0 just changed the state of lock:
> <4>[  673.483344] ffff88845db885a0 (&i915_request_get(rq)->submit/1){-...}, at: __i915_sw_fence_complete+0x1b2/0x250 [i915]
> <4>[  673.483387] but this lock took another, HARDIRQ-unsafe lock in the past:
> <4>[  673.483388]  (&ce->pin_mutex/2){+...}
> <4>[  673.483389]
> 
>                    and interrupts could create inverse lock ordering between them.
> 
> <4>[  673.483390]
>                    other info that might help us debug this:
> <4>[  673.483390] Chain exists of:
>                      &i915_request_get(rq)->submit/1 --> &engine->active.lock --> &ce->pin_mutex/2
> 
> <4>[  673.483392]  Possible interrupt unsafe locking scenario:
> 
> <4>[  673.483392]        CPU0                    CPU1
> <4>[  673.483393]        ----                    ----
> <4>[  673.483393]   lock(&ce->pin_mutex/2);
> <4>[  673.483394]                                local_irq_disable();
> <4>[  673.483395]                                lock(&i915_request_get(rq)->submit/1);
> <4>[  673.483396]                                lock(&engine->active.lock);
> <4>[  673.483396]   <Interrupt>
> <4>[  673.483397]     lock(&i915_request_get(rq)->submit/1);
> <4>[  673.483398]
>                     *** DEADLOCK ***
> 
> <4>[  673.483398] 2 locks held by swapper/2/0:
> <4>[  673.483399]  #0: ffff8883f61ac9b0 (&(&gt->irq_lock)->rlock){-.-.}, at: gen11_gt_irq_handler+0x42/0x280 [i915]
> <4>[  673.483433]  #1: ffff88845db8c418 (&(&rq->lock)->rlock){-.-.}, at: intel_engine_breadcrumbs_irq+0x34a/0x5a0 [i915]
> <4>[  673.483463]
>                    the shortest dependencies between 2nd lock and 1st lock:
> <4>[  673.483466]   -> (&ce->pin_mutex/2){+...} ops: 614520 {
> <4>[  673.483468]      HARDIRQ-ON-W at:
> <4>[  673.483471]                         lock_acquire+0xa7/0x1c0
> <4>[  673.483501]                         live_unlite_restore+0x1d8/0x6c0 [i915]
> <4>[  673.483543]                         __i915_subtests+0xb8/0x210 [i915]
> <4>[  673.483581]                         __run_selftests+0x112/0x170 [i915]
> <4>[  673.483615]                         i915_live_selftests+0x2c/0x60 [i915]
> <4>[  673.483644]                         i915_pci_probe+0x93/0x1b0 [i915]
> <4>[  673.483646]                         pci_device_probe+0x9e/0x120
> <4>[  673.483648]                         really_probe+0xea/0x420
> <4>[  673.483649]                         driver_probe_device+0x10b/0x120
> <4>[  673.483651]                         device_driver_attach+0x4a/0x50
> <4>[  673.483652]                         __driver_attach+0x97/0x130
> <4>[  673.483653]                         bus_for_each_dev+0x74/0xc0
> <4>[  673.483654]                         bus_add_driver+0x142/0x220
> <4>[  673.483655]                         driver_register+0x56/0xf0
> <4>[  673.483657]                         do_one_initcall+0x58/0x2ff
> <4>[  673.483659]                         do_init_module+0x56/0x1f8
> <4>[  673.483660]                         load_module+0x243e/0x29f0
> <4>[  673.483661]                         __do_sys_finit_module+0xe9/0x110
> <4>[  673.483662]                         do_syscall_64+0x4f/0x210
> <4>[  673.483665]                         entry_SYSCALL_64_after_hwframe+0x49/0xbe
> <4>[  673.483665]      INITIAL USE at:
> <4>[  673.483667]                        lock_acquire+0xa7/0x1c0
> <4>[  673.483698]                        live_unlite_restore+0x1d8/0x6c0 [i915]
> <4>[  673.483733]                        __i915_subtests+0xb8/0x210 [i915]
> <4>[  673.483764]                        __run_selftests+0x112/0x170 [i915]
> <4>[  673.483793]                        i915_live_selftests+0x2c/0x60 [i915]
> <4>[  673.483821]                        i915_pci_probe+0x93/0x1b0 [i915]
> <4>[  673.483822]                        pci_device_probe+0x9e/0x120
> <4>[  673.483824]                        really_probe+0xea/0x420
> <4>[  673.483825]                        driver_probe_device+0x10b/0x120
> <4>[  673.483826]                        device_driver_attach+0x4a/0x50
> <4>[  673.483827]                        __driver_attach+0x97/0x130
> <4>[  673.483828]                        bus_for_each_dev+0x74/0xc0
> <4>[  673.483829]                        bus_add_driver+0x142/0x220
> <4>[  673.483830]                        driver_register+0x56/0xf0
> <4>[  673.483831]                        do_one_initcall+0x58/0x2ff
> <4>[  673.483833]                        do_init_module+0x56/0x1f8
> <4>[  673.483834]                        load_module+0x243e/0x29f0
> <4>[  673.483835]                        __do_sys_finit_module+0xe9/0x110
> <4>[  673.483836]                        do_syscall_64+0x4f/0x210
> <4>[  673.483837]                        entry_SYSCALL_64_after_hwframe+0x49/0xbe
> <4>[  673.483838]    }
> <4>[  673.483868]    ... key      at: [<ffffffffa0a8f132>] __key.70113+0x2/0xffffffffffef2ed0 [i915]
> <4>[  673.483869]    ... acquired at:
> <4>[  673.483935]    __execlists_reset+0xfb/0xc20 [i915]
> <4>[  673.483965]    execlists_reset+0x3d/0x50 [i915]
> <4>[  673.483995]    intel_engine_reset+0xdf/0x230 [i915]
> <4>[  673.484022]    live_preempt_hang+0x1d7/0x2e0 [i915]
> <4>[  673.484064]    __i915_subtests+0xb8/0x210 [i915]
> <4>[  673.484130]    __run_selftests+0x112/0x170 [i915]
> <4>[  673.484163]    i915_live_selftests+0x2c/0x60 [i915]
> <4>[  673.484193]    i915_pci_probe+0x93/0x1b0 [i915]
> <4>[  673.484194]    pci_device_probe+0x9e/0x120
> <4>[  673.484195]    really_probe+0xea/0x420
> <4>[  673.484196]    driver_probe_device+0x10b/0x120
> <4>[  673.484197]    device_driver_attach+0x4a/0x50
> <4>[  673.484198]    __driver_attach+0x97/0x130
> <4>[  673.484199]    bus_for_each_dev+0x74/0xc0
> <4>[  673.484200]    bus_add_driver+0x142/0x220
> <4>[  673.484202]    driver_register+0x56/0xf0
> <4>[  673.484203]    do_one_initcall+0x58/0x2ff
> <4>[  673.484204]    do_init_module+0x56/0x1f8
> <4>[  673.484205]    load_module+0x243e/0x29f0
> <4>[  673.484206]    __do_sys_finit_module+0xe9/0x110
> <4>[  673.484207]    do_syscall_64+0x4f/0x210
> <4>[  673.484208]    entry_SYSCALL_64_after_hwframe+0x49/0xbe
> 
> <4>[  673.484209]  -> (&engine->active.lock){..-.} ops: 972791 {
> <4>[  673.484211]     IN-SOFTIRQ-W at:
> <4>[  673.484213]                       lock_acquire+0xa7/0x1c0
> <4>[  673.484214]                       _raw_spin_lock_irqsave+0x33/0x50
> <4>[  673.484244]                       execlists_submission_tasklet+0xaf/0x100 [i915]
> <4>[  673.484246]                       tasklet_action_common.isra.18+0x6c/0x1c0
> <4>[  673.484247]                       __do_softirq+0xdf/0x47f
> <4>[  673.484248]                       irq_exit+0xba/0xc0
> <4>[  673.484249]                       do_IRQ+0x83/0x160
> <4>[  673.484250]                       ret_from_intr+0x0/0x1d
> <4>[  673.484252]                       cpuidle_enter_state+0xb2/0x450
> <4>[  673.484253]                       cpuidle_enter+0x24/0x40
> <4>[  673.484254]                       do_idle+0x1e7/0x250
> <4>[  673.484256]                       cpu_startup_entry+0x14/0x20
> <4>[  673.484257]                       start_secondary+0x15f/0x1b0
> <4>[  673.484258]                       secondary_startup_64+0xa4/0xb0
> <4>[  673.484259]     INITIAL USE at:
> <4>[  673.484261]                      lock_acquire+0xa7/0x1c0
> <4>[  673.484290]                      intel_engine_init_active+0x7e/0xb0 [i915]
> <4>[  673.484305]                      intel_engines_setup+0x1cd/0x3b0 [i915]
> <4>[  673.484305]                      i915_gem_init+0x12d/0x900 [i915]
> <4>[  673.484305]                      i915_driver_probe+0xb70/0x15d0 [i915]
> <4>[  673.484305]                      i915_pci_probe+0x43/0x1b0 [i915]
> <4>[  673.484305]                      pci_device_probe+0x9e/0x120
> <4>[  673.484305]                      really_probe+0xea/0x420
> <4>[  673.484305]                      driver_probe_device+0x10b/0x120
> <4>[  673.484305]                      device_driver_attach+0x4a/0x50
> <4>[  673.484305]                      __driver_attach+0x97/0x130
> <4>[  673.484305]                      bus_for_each_dev+0x74/0xc0
> <4>[  673.484305]                      bus_add_driver+0x142/0x220
> <4>[  673.484305]                      driver_register+0x56/0xf0
> <4>[  673.484305]                      do_one_initcall+0x58/0x2ff
> <4>[  673.484305]                      do_init_module+0x56/0x1f8
> <4>[  673.484305]                      load_module+0x243e/0x29f0
> <4>[  673.484305]                      __do_sys_finit_module+0xe9/0x110
> <4>[  673.484305]                      do_syscall_64+0x4f/0x210
> <4>[  673.484305]                      entry_SYSCALL_64_after_hwframe+0x49/0xbe
> <4>[  673.484305]   }
> <4>[  673.484305]   ... key      at: [<ffffffffa0a8f160>] __key.70307+0x0/0xffffffffffef2ea0 [i915]
> <4>[  673.484305]   ... acquired at:
> <4>[  673.484305]    _raw_spin_lock_irqsave+0x33/0x50
> <4>[  673.484305]    execlists_submit_request+0x2b/0x1e0 [i915]
> <4>[  673.484305]    submit_notify+0xa8/0x13c [i915]
> <4>[  673.484305]    __i915_sw_fence_complete+0x81/0x250 [i915]
> <4>[  673.484305]    i915_sw_fence_wake+0x51/0x70 [i915]
> <4>[  673.484305]    __i915_sw_fence_complete+0x1ee/0x250 [i915]
> <4>[  673.484305]    dma_i915_sw_fence_wake+0x1b/0x30 [i915]
> <4>[  673.484305]    dma_fence_signal_locked+0x9e/0x1b0
> <4>[  673.484305]    dma_fence_signal+0x1f/0x40
> <4>[  673.484305]    fence_work+0x28/0x80 [i915]
> <4>[  673.484305]    process_one_work+0x26a/0x620
> <4>[  673.484305]    worker_thread+0x37/0x380
> <4>[  673.484305]    kthread+0x119/0x130
> <4>[  673.484305]    ret_from_fork+0x24/0x50
> 
> <4>[  673.484305] -> (&i915_request_get(rq)->submit/1){-...} ops: 857694 {
> <4>[  673.484305]    IN-HARDIRQ-W at:
> <4>[  673.484305]                     lock_acquire+0xa7/0x1c0
> <4>[  673.484305]                     _raw_spin_lock_irqsave_nested+0x39/0x50
> <4>[  673.484305]                     __i915_sw_fence_complete+0x1b2/0x250 [i915]
> <4>[  673.484305]                     intel_engine_breadcrumbs_irq+0x3d0/0x5a0 [i915]
> <4>[  673.484305]                     cs_irq_handler+0x39/0x50 [i915]
> <4>[  673.484305]                     gen11_gt_irq_handler+0x17b/0x280 [i915]
> <4>[  673.484305]                     gen11_irq_handler+0x54/0xf0 [i915]
> <4>[  673.484305]                     __handle_irq_event_percpu+0x41/0x2c0
> <4>[  673.484305]                     handle_irq_event_percpu+0x2b/0x70
> <4>[  673.484305]                     handle_irq_event+0x2f/0x50
> <4>[  673.484305]                     handle_edge_irq+0x99/0x1b0
> <4>[  673.484305]                     do_IRQ+0x7e/0x160
> <4>[  673.484305]                     ret_from_intr+0x0/0x1d
> <4>[  673.484305]                     cpuidle_enter_state+0xb2/0x450
> <4>[  673.484305]                     cpuidle_enter+0x24/0x40
> <4>[  673.484305]                     do_idle+0x1e7/0x250
> <4>[  673.484305]                     cpu_startup_entry+0x14/0x20
> <4>[  673.484305]                     start_secondary+0x15f/0x1b0
> <4>[  673.484305]                     secondary_startup_64+0xa4/0xb0
> <4>[  673.484305]    INITIAL USE at:
> <4>[  673.484305]                    lock_acquire+0xa7/0x1c0
> <4>[  673.484305]                    _raw_spin_lock_irqsave_nested+0x39/0x50
> <4>[  673.484305]                    __i915_sw_fence_complete+0x1b2/0x250 [i915]
> <4>[  673.484305]                    __engine_park+0x233/0x420 [i915]
> <4>[  673.484305]                    ____intel_wakeref_put_last+0x1c/0x70 [i915]
> <4>[  673.484305]                    intel_gt_resume+0x202/0x2c0 [i915]
> <4>[  673.484305]                    i915_gem_init+0x36e/0x900 [i915]
> <4>[  673.484305]                    i915_driver_probe+0xb70/0x15d0 [i915]
> <4>[  673.484305]                    i915_pci_probe+0x43/0x1b0 [i915]
> <4>[  673.484305]                    pci_device_probe+0x9e/0x120
> <4>[  673.484305]                    really_probe+0xea/0x420
> <4>[  673.484305]                    driver_probe_device+0x10b/0x120
> <4>[  673.484305]                    device_driver_attach+0x4a/0x50
> <4>[  673.484305]                    __driver_attach+0x97/0x130
> <4>[  673.484305]                    bus_for_each_dev+0x74/0xc0
> <4>[  673.484305]                    bus_add_driver+0x142/0x220
> <4>[  673.484305]                    driver_register+0x56/0xf0
> <4>[  673.484305]                    do_one_initcall+0x58/0x2ff
> <4>[  673.484305]                    do_init_module+0x56/0x1f8
> <4>[  673.484305]                    load_module+0x243e/0x29f0
> <4>[  673.484305]                    __do_sys_finit_module+0xe9/0x110
> <4>[  673.484305]                    do_syscall_64+0x4f/0x210
> <4>[  673.484305]                    entry_SYSCALL_64_after_hwframe+0x49/0xbe
> <4>[  673.484305]  }
> <4>[  673.484305]  ... key      at: [<ffffffffa0a8f6a1>] __key.80173+0x1/0xffffffffffef2960 [i915]
> <4>[  673.484305]  ... acquired at:
> <4>[  673.484305]    mark_lock+0x382/0x500
> <4>[  673.484305]    __lock_acquire+0x7e1/0x15d0
> <4>[  673.484305]    lock_acquire+0xa7/0x1c0
> <4>[  673.484305]    _raw_spin_lock_irqsave_nested+0x39/0x50
> <4>[  673.484305]    __i915_sw_fence_complete+0x1b2/0x250 [i915]
> <4>[  673.484305]    intel_engine_breadcrumbs_irq+0x3d0/0x5a0 [i915]
> <4>[  673.484305]    cs_irq_handler+0x39/0x50 [i915]
> <4>[  673.484305]    gen11_gt_irq_handler+0x17b/0x280 [i915]
> <4>[  673.484305]    gen11_irq_handler+0x54/0xf0 [i915]
> <4>[  673.484305]    __handle_irq_event_percpu+0x41/0x2c0
> <4>[  673.484305]    handle_irq_event_percpu+0x2b/0x70
> <4>[  673.484305]    handle_irq_event+0x2f/0x50
> <4>[  673.484305]    handle_edge_irq+0x99/0x1b0
> <4>[  673.484305]    do_IRQ+0x7e/0x160
> <4>[  673.484305]    ret_from_intr+0x0/0x1d
> <4>[  673.484305]    cpuidle_enter_state+0xb2/0x450
> <4>[  673.484305]    cpuidle_enter+0x24/0x40
> <4>[  673.484305]    do_idle+0x1e7/0x250
> <4>[  673.484305]    cpu_startup_entry+0x14/0x20
> <4>[  673.484305]    start_secondary+0x15f/0x1b0
> <4>[  673.484305]    secondary_startup_64+0xa4/0xb0
> 
> <4>[  673.484305]
>                    stack backtrace:
> <4>[  673.484305] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G     U            5.4.0-rc1-CI-Trybot_5118+ #1
> <4>[  673.484305] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3183.A00.1905020411 05/02/2019
> <4>[  673.484305] Call Trace:
> <4>[  673.484305]  <IRQ>
> <4>[  673.484305]  dump_stack+0x67/0x9b
> <4>[  673.484305]  check_usage_forwards+0x13c/0x150
> <4>[  673.484305]  ? mark_lock+0x382/0x500
> <4>[  673.484305]  mark_lock+0x382/0x500
> <4>[  673.484305]  ? check_usage_backwards+0x140/0x140
> <4>[  673.484305]  __lock_acquire+0x7e1/0x15d0
> <4>[  673.484305]  ? debug_object_deactivate+0x17e/0x190
> <4>[  673.484305]  lock_acquire+0xa7/0x1c0
> <4>[  673.484305]  ? __i915_sw_fence_complete+0x1b2/0x250 [i915]
> <4>[  673.484305]  _raw_spin_lock_irqsave_nested+0x39/0x50
> <4>[  673.484305]  ? __i915_sw_fence_complete+0x1b2/0x250 [i915]
> <4>[  673.484305]  __i915_sw_fence_complete+0x1b2/0x250 [i915]
> <4>[  673.484305]  intel_engine_breadcrumbs_irq+0x3d0/0x5a0 [i915]
> <4>[  673.484305]  cs_irq_handler+0x39/0x50 [i915]
> <4>[  673.484305]  gen11_gt_irq_handler+0x17b/0x280 [i915]
> <4>[  673.484305]  gen11_irq_handler+0x54/0xf0 [i915]
> <4>[  673.484305]  __handle_irq_event_percpu+0x41/0x2c0
> <4>[  673.484305]  handle_irq_event_percpu+0x2b/0x70
> <4>[  673.484305]  handle_irq_event+0x2f/0x50
> <4>[  673.484305]  handle_edge_irq+0x99/0x1b0
> <4>[  673.484305]  do_IRQ+0x7e/0x160
> <4>[  673.484305]  common_interrupt+0xf/0xf
> <4>[  673.484305]  </IRQ>
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index 393ae5321e1d..198cf2f754f4 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -143,11 +143,11 @@ static int live_unlite_restore(struct drm_i915_private *i915, int prio)
>   		GEM_BUG_ON(!ce[1]->ring->size);
>   		intel_ring_reset(ce[1]->ring, ce[1]->ring->size / 2);
>   
> -		local_bh_disable(); /* appease lockdep */
> +		local_irq_disable(); /* appease lockdep */
>   		__context_pin_acquire(ce[1]);
>   		__execlists_update_reg_state(ce[1], engine);
>   		__context_pin_release(ce[1]);
> -		local_bh_enable();
> +		local_irq_enable();
>   
>   		rq[0] = igt_spinner_create_request(&spin, ce[0], MI_ARB_CHECK);
>   		if (IS_ERR(rq[0])) {
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-10-07 16:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 20:31 [PATCH] drm/i915/selftests: Appease lockdep Chris Wilson
2019-10-04 20:54 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-10-04 21:20 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-05  8:19 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-07 16:12 ` [PATCH] " Tvrtko Ursulin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.