* [PATCH net-next] net/rds: Add missing include file
@ 2019-10-06 7:08 YueHaibing
2019-10-06 16:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-10-06 7:08 UTC (permalink / raw)
To: santosh.shilimkar, davem, ka-cheong.poon
Cc: netdev, linux-rdma, rds-devel, linux-kernel, YueHaibing
Fix build error:
net/rds/ib_cm.c: In function rds_dma_hdrs_alloc:
net/rds/ib_cm.c:475:13: error: implicit declaration of function dma_pool_zalloc; did you mean mempool_alloc? [-Werror=implicit-function-declaration]
hdrs[i] = dma_pool_zalloc(pool, GFP_KERNEL, &hdr_daddrs[i]);
^~~~~~~~~~~~~~~
mempool_alloc
net/rds/ib.c: In function rds_ib_dev_free:
net/rds/ib.c:111:3: error: implicit declaration of function dma_pool_destroy; did you mean mempool_destroy? [-Werror=implicit-function-declaration]
dma_pool_destroy(rds_ibdev->rid_hdrs_pool);
^~~~~~~~~~~~~~~~
mempool_destroy
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 9b17f5884be4 ("net/rds: Use DMA memory pool allocation for rds_header")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/rds/ib.c | 1 +
net/rds/ib_cm.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/net/rds/ib.c b/net/rds/ib.c
index 23a2ae53f231..62d4ebeb08c1 100644
--- a/net/rds/ib.c
+++ b/net/rds/ib.c
@@ -30,6 +30,7 @@
* SOFTWARE.
*
*/
+#include <linux/dmapool.h>
#include <linux/kernel.h>
#include <linux/in.h>
#include <linux/if.h>
diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
index d08251f4a00c..6b345c858dba 100644
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -30,6 +30,7 @@
* SOFTWARE.
*
*/
+#include <linux/dmapool.h>
#include <linux/kernel.h>
#include <linux/in.h>
#include <linux/slab.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/rds: Add missing include file
2019-10-06 7:08 [PATCH net-next] net/rds: Add missing include file YueHaibing
@ 2019-10-06 16:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-06 16:34 UTC (permalink / raw)
To: yuehaibing
Cc: santosh.shilimkar, ka-cheong.poon, netdev, linux-rdma, rds-devel,
linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Sun, 6 Oct 2019 15:08:32 +0800
> Fix build error:
>
> net/rds/ib_cm.c: In function rds_dma_hdrs_alloc:
> net/rds/ib_cm.c:475:13: error: implicit declaration of function dma_pool_zalloc; did you mean mempool_alloc? [-Werror=implicit-function-declaration]
> hdrs[i] = dma_pool_zalloc(pool, GFP_KERNEL, &hdr_daddrs[i]);
> ^~~~~~~~~~~~~~~
> mempool_alloc
>
> net/rds/ib.c: In function rds_ib_dev_free:
> net/rds/ib.c:111:3: error: implicit declaration of function dma_pool_destroy; did you mean mempool_destroy? [-Werror=implicit-function-declaration]
> dma_pool_destroy(rds_ibdev->rid_hdrs_pool);
> ^~~~~~~~~~~~~~~~
> mempool_destroy
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 9b17f5884be4 ("net/rds: Use DMA memory pool allocation for rds_header")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-06 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-06 7:08 [PATCH net-next] net/rds: Add missing include file YueHaibing
2019-10-06 16:34 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.