* [PATCH] ipv6: Make ipv6_mc_may_pull() return bool.
@ 2019-10-07 13:38 David Miller
2019-10-08 12:21 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2019-10-07 13:38 UTC (permalink / raw)
To: netdev
Consistent with how pskb_may_pull() also now does so.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
include/net/addrconf.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/net/addrconf.h b/include/net/addrconf.h
index 3f62b347b04a..1bab88184d3c 100644
--- a/include/net/addrconf.h
+++ b/include/net/addrconf.h
@@ -202,11 +202,11 @@ u32 ipv6_addr_label(struct net *net, const struct in6_addr *addr,
/*
* multicast prototypes (mcast.c)
*/
-static inline int ipv6_mc_may_pull(struct sk_buff *skb,
- unsigned int len)
+static inline bool ipv6_mc_may_pull(struct sk_buff *skb,
+ unsigned int len)
{
if (skb_transport_offset(skb) + ipv6_transport_len(skb) < len)
- return 0;
+ return false;
return pskb_may_pull(skb, len);
}
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: Make ipv6_mc_may_pull() return bool.
2019-10-07 13:38 [PATCH] ipv6: Make ipv6_mc_may_pull() return bool David Miller
@ 2019-10-08 12:21 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2019-10-08 12:21 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Mon, Oct 07, 2019 at 03:38:04PM +0200, David Miller wrote:
>
> Consistent with how pskb_may_pull() also now does so.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
> ---
> include/net/addrconf.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/net/addrconf.h b/include/net/addrconf.h
> index 3f62b347b04a..1bab88184d3c 100644
> --- a/include/net/addrconf.h
> +++ b/include/net/addrconf.h
> @@ -202,11 +202,11 @@ u32 ipv6_addr_label(struct net *net, const struct in6_addr *addr,
> /*
> * multicast prototypes (mcast.c)
> */
> -static inline int ipv6_mc_may_pull(struct sk_buff *skb,
> - unsigned int len)
> +static inline bool ipv6_mc_may_pull(struct sk_buff *skb,
> + unsigned int len)
> {
> if (skb_transport_offset(skb) + ipv6_transport_len(skb) < len)
> - return 0;
> + return false;
>
> return pskb_may_pull(skb, len);
> }
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-08 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07 13:38 [PATCH] ipv6: Make ipv6_mc_may_pull() return bool David Miller
2019-10-08 12:21 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.