All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Ribalda Delgado <ribalda@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Sakari Ailus <sakari.ailus@iki.fi>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ribalda@kernel.org>
Subject: [PATCH v7 6/6] ad5820: Add support for ad5821 and ad5823
Date: Mon,  7 Oct 2019 15:20:49 +0200	[thread overview]
Message-ID: <20191007132050.27298-12-ribalda@kernel.org> (raw)
In-Reply-To: <20191007132050.27298-1-ribalda@kernel.org>

According to the datasheet, both AD5821 and AD5820 share a compatible
register-set:
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5821.pdf

Some camera modules also refer that AD5823 is a replacement of AD5820:
https://download.kamami.com/p564094-OV8865_DS.pdf

Suggested-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
 drivers/media/i2c/ad5820.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 5651609e5095..19c74db0649f 100644
--- a/drivers/media/i2c/ad5820.c
+++ b/drivers/media/i2c/ad5820.c
@@ -25,8 +25,6 @@
 #include <media/v4l2-device.h>
 #include <media/v4l2-subdev.h>
 
-#define AD5820_NAME		"ad5820"
-
 /* Register definitions */
 #define AD5820_POWER_DOWN		(1 << 15)
 #define AD5820_DAC_SHIFT		4
@@ -359,13 +357,17 @@ static int ad5820_remove(struct i2c_client *client)
 }
 
 static const struct i2c_device_id ad5820_id_table[] = {
-	{ AD5820_NAME, 0 },
+	{ "ad5820", 0 },
+	{ "ad5821", 0 },
+	{ "ad5823", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, ad5820_id_table);
 
 static const struct of_device_id ad5820_of_table[] = {
 	{ .compatible = "adi,ad5820" },
+	{ .compatible = "adi,ad5821" },
+	{ .compatible = "adi,ad5823" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ad5820_of_table);
@@ -374,7 +376,7 @@ static SIMPLE_DEV_PM_OPS(ad5820_pm, ad5820_suspend, ad5820_resume);
 
 static struct i2c_driver ad5820_i2c_driver = {
 	.driver		= {
-		.name	= AD5820_NAME,
+		.name	= "ad5820",
 		.pm	= &ad5820_pm,
 		.of_match_table = ad5820_of_table,
 	},
-- 
2.23.0


  parent reply	other threads:[~2019-10-07 13:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 13:20 [PATCH v7 0/6] ad5820: Multiple fixes Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 1/6] ad5820: Define entity function Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 1/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 2/6] ad5820: DT new optional field enable-gpios Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 2/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 3/6] ad5820: Add support for enable pin Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 3/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 4/6] ad5820: Add support for of-autoload Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 4/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 5/6] ad5820: DT new compatible devices Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 5/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` Ricardo Ribalda Delgado [this message]
2019-10-07 13:20 ` [PATCH v7 6/6] media: ad5820: Add support for ad5821 and ad5823 Ricardo Ribalda Delgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007132050.27298-12-ribalda@kernel.org \
    --to=ribalda@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.