From: Ricardo Ribalda Delgado <ribalda@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ribalda@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH v7 1/6] media: ad5820: Define entity function
Date: Mon, 7 Oct 2019 15:20:40 +0200 [thread overview]
Message-ID: <20191007132050.27298-3-ribalda@kernel.org> (raw)
In-Reply-To: <20191007132050.27298-1-ribalda@kernel.org>
Without this patch, media_device_register_entity throws a warning:
dev_warn(mdev->dev,
"Entity type for entity %s was not initialized!\n",
entity->name);
Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/ad5820.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 925c171e7797..7a49651f4d1f 100644
--- a/drivers/media/i2c/ad5820.c
+++ b/drivers/media/i2c/ad5820.c
@@ -309,6 +309,7 @@ static int ad5820_probe(struct i2c_client *client,
v4l2_i2c_subdev_init(&coil->subdev, client, &ad5820_ops);
coil->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
coil->subdev.internal_ops = &ad5820_internal_ops;
+ coil->subdev.entity.function = MEDIA_ENT_F_LENS;
strscpy(coil->subdev.name, "ad5820 focus", sizeof(coil->subdev.name));
ret = media_entity_pads_init(&coil->subdev.entity, 0, NULL);
--
2.23.0
next prev parent reply other threads:[~2019-10-07 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 13:20 [PATCH v7 0/6] ad5820: Multiple fixes Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 1/6] ad5820: Define entity function Ricardo Ribalda Delgado
2019-10-07 13:20 ` Ricardo Ribalda Delgado [this message]
2019-10-07 13:20 ` [PATCH v7 2/6] ad5820: DT new optional field enable-gpios Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 2/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 3/6] ad5820: Add support for enable pin Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 3/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 4/6] ad5820: Add support for of-autoload Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 4/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 5/6] ad5820: DT new compatible devices Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 5/6] media: " Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 6/6] ad5820: Add support for ad5821 and ad5823 Ricardo Ribalda Delgado
2019-10-07 13:20 ` [PATCH v7 6/6] media: " Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007132050.27298-3-ribalda@kernel.org \
--to=ribalda@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.