[djwong-xfs:rough-fixes 8/133] fs/xfs/libxfs/xfs_btree.c:4937:22: sparse: sparse: symbol 'xbtree_fakeroot_dup_cursor' was not declared. Should it be static?

[djwong-xfs:rough-fixes 8/133] fs/xfs/libxfs/xfs_btree.c:4937:22: sparse: sparse: symbol 'xbtree_fakeroot_dup_cursor' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git rough-fixes
head:   73421a54a60e2b4bcac0d82321b24e73e2a8f0ab
commit: 51e7c56bff7e0c6576e4532432c2c83734b0c8b1 [8/133] xfs: introduce fake roots for ag-rooted btrees
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-42-g38eda53-dirty
        git checkout 51e7c56bff7e0c6576e4532432c2c83734b0c8b1
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> fs/xfs/libxfs/xfs_btree.c:4937:22: sparse: sparse: symbol 'xbtree_fakeroot_dup_cursor' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH djwong-xfs] xfs: xbtree_fakeroot_dup_cursor can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]


Fixes: 51e7c56bff7e ("xfs: introduce fake roots for ag-rooted btrees")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 xfs_btree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
index 092004a6ea461f..35ca2264ccd11b 100644
--- a/fs/xfs/libxfs/xfs_btree.c
+++ b/fs/xfs/libxfs/xfs_btree.c
@@ -4934,7 +4934,7 @@ xfs_btree_has_more_records(
 }
 
 /* We don't allow staging cursors to be duplicated. */
-struct xfs_btree_cur *
+static struct xfs_btree_cur *
 xbtree_fakeroot_dup_cursor(
 	struct xfs_btree_cur	*cur)
 {