* [Buildroot] [PATCH] package/kf5-kcoreaddons: make passing CXXFLAGS to cmake clearer
@ 2019-10-01 9:08 Giulio Benetti
2019-10-08 21:24 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Giulio Benetti @ 2019-10-01 9:08 UTC (permalink / raw)
To: buildroot
Better to keep final assignment to *_CONF_OPTS after all assignements to
KF5_KCOREADDONS_CXXFLAGS have been done. So move _CONF_OPTS assignment
after -latomic assignment.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
index ea6aac4ec6..164bad1225 100644
--- a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
+++ b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
@@ -14,10 +14,11 @@ KF5_KCOREADDONS_DEPENDENCIES = kf5-extra-cmake-modules qt5tools
KF5_KCOREADDONS_INSTALL_STAGING = YES
KF5_KCOREADDONS_CXXFLAGS = $(TARGET_CXXFLAGS)
-KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_CXX_FLAGS="$(KF5_KCOREADDONS_CXXFLAGS)"
ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
KF5_KCOREADDONS_CXXFLAGS += -latomic
endif
+KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_CXX_FLAGS="$(KF5_KCOREADDONS_CXXFLAGS)"
+
$(eval $(cmake-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/kf5-kcoreaddons: make passing CXXFLAGS to cmake clearer
2019-10-01 9:08 [Buildroot] [PATCH] package/kf5-kcoreaddons: make passing CXXFLAGS to cmake clearer Giulio Benetti
@ 2019-10-08 21:24 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-10-08 21:24 UTC (permalink / raw)
To: buildroot
On Tue, 1 Oct 2019 11:08:32 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Better to keep final assignment to *_CONF_OPTS after all assignements to
> KF5_KCOREADDONS_CXXFLAGS have been done. So move _CONF_OPTS assignment
> after -latomic assignment.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-08 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 9:08 [Buildroot] [PATCH] package/kf5-kcoreaddons: make passing CXXFLAGS to cmake clearer Giulio Benetti
2019-10-08 21:24 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.