All of lore.kernel.org
 help / color / mirror / Atom feed
* [wireless-drivers-next:master 65/69] drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5194:6: sparse: sparse: symbol 'rtl8723bu_set_coex_with_type' was not declared. Should it be static?
@ 2019-10-09 12:15 kbuild test robot
  2019-10-09 12:15 ` [RFC PATCH wireless-drivers-next] rtl8xxxu: rtl8723bu_set_coex_with_type() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-10-09 12:15 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1754 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
head:   ac8efe4f4a84c6bf59237f77a5db65410bf20241
commit: e542e66b7c2ee2adeefdbb7f259f2f60cadf2819 [65/69] rtl8xxxu: add bluetooth co-existence support for single antenna
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-42-g38eda53-dirty
        git checkout e542e66b7c2ee2adeefdbb7f259f2f60cadf2819
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4822:17: sparse: sparse: cast from restricted __le16
   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4895:17: sparse: sparse: cast from restricted __le16
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5194:6: sparse: sparse: symbol 'rtl8723bu_set_coex_with_type' was not declared. Should it be static?
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5245:6: sparse: sparse: symbol 'rtl8723bu_update_bt_link_info' was not declared. Should it be static?
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5311:6: sparse: sparse: symbol 'rtl8723bu_handle_bt_inquiry' was not declared. Should it be static?
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5336:6: sparse: sparse: symbol 'rtl8723bu_handle_bt_info' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH wireless-drivers-next] rtl8xxxu: rtl8723bu_set_coex_with_type() can be static
  2019-10-09 12:15 [wireless-drivers-next:master 65/69] drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5194:6: sparse: sparse: symbol 'rtl8723bu_set_coex_with_type' was not declared. Should it be static? kbuild test robot
@ 2019-10-09 12:15 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-10-09 12:15 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]


Fixes: e542e66b7c2e ("rtl8xxxu: add bluetooth co-existence support for single antenna")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 rtl8xxxu_core.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 8c47fdf2fdef0..37815c272ff2e 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -5191,7 +5191,7 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work)
  * cases which Realtek doesn't provide detail for these settings. Keep
  * this aligned with vendor driver for easier maintenance.
  */
-void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type)
+static void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type)
 {
 	switch (type) {
 	case 0:
@@ -5242,7 +5242,7 @@ void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type)
 	}
 }
 
-void rtl8723bu_update_bt_link_info(struct rtl8xxxu_priv *priv, u8 bt_info)
+static void rtl8723bu_update_bt_link_info(struct rtl8xxxu_priv *priv, u8 bt_info)
 {
 	struct rtl8xxxu_btcoex *btcoex = &priv->bt_coex;
 
@@ -5308,7 +5308,7 @@ void rtl8723bu_update_bt_link_info(struct rtl8xxxu_priv *priv, u8 bt_info)
 		btcoex->bt_busy = false;
 }
 
-void rtl8723bu_handle_bt_inquiry(struct rtl8xxxu_priv *priv)
+static void rtl8723bu_handle_bt_inquiry(struct rtl8xxxu_priv *priv)
 {
 	struct ieee80211_vif *vif;
 	struct rtl8xxxu_btcoex *btcoex;
@@ -5333,7 +5333,7 @@ void rtl8723bu_handle_bt_inquiry(struct rtl8xxxu_priv *priv)
 	}
 }
 
-void rtl8723bu_handle_bt_info(struct rtl8xxxu_priv *priv)
+static void rtl8723bu_handle_bt_info(struct rtl8xxxu_priv *priv)
 {
 	struct ieee80211_vif *vif;
 	struct rtl8xxxu_btcoex *btcoex;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-09 12:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 12:15 [wireless-drivers-next:master 65/69] drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5194:6: sparse: sparse: symbol 'rtl8723bu_set_coex_with_type' was not declared. Should it be static? kbuild test robot
2019-10-09 12:15 ` [RFC PATCH wireless-drivers-next] rtl8xxxu: rtl8723bu_set_coex_with_type() can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.