* [PATCH] trace: add --group=all to tracing.txt
@ 2019-10-09 13:51 Stefan Hajnoczi
2019-10-09 13:53 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-10-09 13:51 UTC (permalink / raw)
To: qemu-devel
Cc: Daniel P . Berrange, Philippe Mathieu-Daudé, Stefan Hajnoczi
tracetool needs to know the group name ("all", "root", or a specific
subdirectory). Also remove the stdin redirection because tracetool.py
needs the path to the trace-events file. Update the documentation.
Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
("trace: move setting of group name into Makefiles")
Launchpad: https://bugs.launchpad.net/bugs/1844814
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
docs/devel/tracing.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
index 8231bbf5d1..8c0376fefa 100644
--- a/docs/devel/tracing.txt
+++ b/docs/devel/tracing.txt
@@ -317,7 +317,8 @@ probes:
--binary path/to/qemu-binary \
--target-type system \
--target-name x86_64 \
- <trace-events-all >qemu.stp
+ --group=all \
+ trace-events-all >qemu.stp
To facilitate simple usage of systemtap where there merely needs to be printf
logging of certain probes, a helper script "qemu-trace-stap" is provided.
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] trace: add --group=all to tracing.txt
2019-10-09 13:51 [PATCH] trace: add --group=all to tracing.txt Stefan Hajnoczi
@ 2019-10-09 13:53 ` Daniel P. Berrangé
2019-10-09 13:57 ` Philippe Mathieu-Daudé
2019-10-09 17:47 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2019-10-09 13:53 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Philippe Mathieu-Daudé, qemu-devel
On Wed, Oct 09, 2019 at 02:51:54PM +0100, Stefan Hajnoczi wrote:
> tracetool needs to know the group name ("all", "root", or a specific
> subdirectory). Also remove the stdin redirection because tracetool.py
> needs the path to the trace-events file. Update the documentation.
>
> Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
> ("trace: move setting of group name into Makefiles")
> Launchpad: https://bugs.launchpad.net/bugs/1844814
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> docs/devel/tracing.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trace: add --group=all to tracing.txt
2019-10-09 13:51 [PATCH] trace: add --group=all to tracing.txt Stefan Hajnoczi
2019-10-09 13:53 ` Daniel P. Berrangé
@ 2019-10-09 13:57 ` Philippe Mathieu-Daudé
2019-10-09 17:47 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-09 13:57 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Daniel P . Berrange
On 10/9/19 3:51 PM, Stefan Hajnoczi wrote:
> tracetool needs to know the group name ("all", "root", or a specific
> subdirectory). Also remove the stdin redirection because tracetool.py
> needs the path to the trace-events file. Update the documentation.
Thanks!
>
> Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
> ("trace: move setting of group name into Makefiles")
> Launchpad: https://bugs.launchpad.net/bugs/1844814
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> docs/devel/tracing.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
> index 8231bbf5d1..8c0376fefa 100644
> --- a/docs/devel/tracing.txt
> +++ b/docs/devel/tracing.txt
> @@ -317,7 +317,8 @@ probes:
> --binary path/to/qemu-binary \
> --target-type system \
> --target-name x86_64 \
> - <trace-events-all >qemu.stp
> + --group=all \
> + trace-events-all >qemu.stp
>
> To facilitate simple usage of systemtap where there merely needs to be printf
> logging of certain probes, a helper script "qemu-trace-stap" is provided.
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trace: add --group=all to tracing.txt
2019-10-09 13:51 [PATCH] trace: add --group=all to tracing.txt Stefan Hajnoczi
2019-10-09 13:53 ` Daniel P. Berrangé
2019-10-09 13:57 ` Philippe Mathieu-Daudé
@ 2019-10-09 17:47 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-10-09 17:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Daniel P . Berrange, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Wed, Oct 09, 2019 at 02:51:54PM +0100, Stefan Hajnoczi wrote:
> tracetool needs to know the group name ("all", "root", or a specific
> subdirectory). Also remove the stdin redirection because tracetool.py
> needs the path to the trace-events file. Update the documentation.
>
> Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
> ("trace: move setting of group name into Makefiles")
> Launchpad: https://bugs.launchpad.net/bugs/1844814
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> docs/devel/tracing.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-09 19:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 13:51 [PATCH] trace: add --group=all to tracing.txt Stefan Hajnoczi
2019-10-09 13:53 ` Daniel P. Berrangé
2019-10-09 13:57 ` Philippe Mathieu-Daudé
2019-10-09 17:47 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.