* [CI 1/2] drm/i915: Move SAGV block time to dev_priv
@ 2019-10-09 17:23 Lucas De Marchi
2019-10-09 17:23 ` [CI 2/2] drm/i915/tgl: Read SAGV block time from PCODE Lucas De Marchi
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Lucas De Marchi @ 2019-10-09 17:23 UTC (permalink / raw)
To: intel-gfx
From: James Ausmus <james.ausmus@intel.com>
In prep for newer platforms having more complicated ways to determine
the SAGV block time, move the variable to dev_priv, and extract the
setting to an initial setup function. While we're at it, update the if
ladder to follow the new gen -> old gen order preference, and warn on
any non-specified gen.
v2: Shorten the function name (Ville), return directly (Ville), move
sagv_block_time_us value to dev_priv (Ville)
v3: Change sagv_block_time_us to u32 (Lucas), Change fallback value to
-1 (Lucas), use intel_has_sagv for setup check rather than hand-rolling
(Lucas)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: James Ausmus <james.ausmus@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191004221449.1317-1-james.ausmus@intel.com
---
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/intel_pm.c | 33 ++++++++++++++++++++++++---------
2 files changed, 26 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index d284b04c492b..c46b339064c0 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1267,6 +1267,8 @@ struct drm_i915_private {
I915_SAGV_NOT_CONTROLLED
} sagv_status;
+ u32 sagv_block_time_us;
+
struct {
/*
* Raw watermark latency values:
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index bfcf03ab5245..0ffcafe97216 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3642,6 +3642,26 @@ intel_has_sagv(struct drm_i915_private *dev_priv)
dev_priv->sagv_status != I915_SAGV_NOT_CONTROLLED;
}
+static void
+skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
+{
+ if (IS_GEN(dev_priv, 11)) {
+ dev_priv->sagv_block_time_us = 10;
+ return;
+ } else if (IS_GEN(dev_priv, 10)) {
+ dev_priv->sagv_block_time_us = 20;
+ return;
+ } else if (IS_GEN(dev_priv, 9)) {
+ dev_priv->sagv_block_time_us = 30;
+ return;
+ } else {
+ MISSING_CASE(INTEL_GEN(dev_priv));
+ }
+
+ /* Default to an unusable block time */
+ dev_priv->sagv_block_time_us = -1;
+}
+
/*
* SAGV dynamically adjusts the system agent voltage and clock frequencies
* depending on power and performance requirements. The display engine access
@@ -3730,18 +3750,10 @@ bool intel_can_enable_sagv(struct intel_atomic_state *state)
struct intel_crtc_state *crtc_state;
enum pipe pipe;
int level, latency;
- int sagv_block_time_us;
if (!intel_has_sagv(dev_priv))
return false;
- if (IS_GEN(dev_priv, 9))
- sagv_block_time_us = 30;
- else if (IS_GEN(dev_priv, 10))
- sagv_block_time_us = 20;
- else
- sagv_block_time_us = 10;
-
/*
* If there are no active CRTCs, no additional checks need be performed
*/
@@ -3788,7 +3800,7 @@ bool intel_can_enable_sagv(struct intel_atomic_state *state)
* incur memory latencies higher than sagv_block_time_us we
* can't enable SAGV.
*/
- if (latency < sagv_block_time_us)
+ if (latency < dev_priv->sagv_block_time_us)
return false;
}
@@ -9013,6 +9025,9 @@ void intel_init_pm(struct drm_i915_private *dev_priv)
else if (IS_GEN(dev_priv, 5))
i915_ironlake_get_mem_freq(dev_priv);
+ if (intel_has_sagv(dev_priv))
+ skl_setup_sagv_block_time(dev_priv);
+
/* For FIFO watermark updates */
if (INTEL_GEN(dev_priv) >= 9) {
skl_setup_wm_latency(dev_priv);
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [CI 2/2] drm/i915/tgl: Read SAGV block time from PCODE
2019-10-09 17:23 [CI 1/2] drm/i915: Move SAGV block time to dev_priv Lucas De Marchi
@ 2019-10-09 17:23 ` Lucas De Marchi
2019-10-09 17:45 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Lucas De Marchi @ 2019-10-09 17:23 UTC (permalink / raw)
To: intel-gfx
From: James Ausmus <james.ausmus@intel.com>
Starting from TGL, we now need to read the SAGV block time via a PCODE
mailbox, rather than having a static value.
BSpec: 49326
v2: Fix up pcode val data type (Ville), tighten variable scope (Ville)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: James Ausmus <james.ausmus@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191004221449.1317-2-james.ausmus@intel.com
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_pm.c | 15 ++++++++++++++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 1dc067fc57ab..0fb9030b89f1 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -8878,6 +8878,7 @@ enum {
#define GEN9_SAGV_DISABLE 0x0
#define GEN9_SAGV_IS_DISABLED 0x1
#define GEN9_SAGV_ENABLE 0x3
+#define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23
#define GEN6_PCODE_DATA _MMIO(0x138128)
#define GEN6_PCODE_FREQ_IA_RATIO_SHIFT 8
#define GEN6_PCODE_FREQ_RING_RATIO_SHIFT 16
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 0ffcafe97216..e2aca3e81d28 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3645,7 +3645,20 @@ intel_has_sagv(struct drm_i915_private *dev_priv)
static void
skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)
{
- if (IS_GEN(dev_priv, 11)) {
+ if (INTEL_GEN(dev_priv) >= 12) {
+ u32 val = 0;
+ int ret;
+
+ ret = sandybridge_pcode_read(dev_priv,
+ GEN12_PCODE_READ_SAGV_BLOCK_TIME_US,
+ &val, NULL);
+ if (!ret) {
+ dev_priv->sagv_block_time_us = val;
+ return;
+ }
+
+ DRM_DEBUG_DRIVER("Couldn't read SAGV block time!\n");
+ } else if (IS_GEN(dev_priv, 11)) {
dev_priv->sagv_block_time_us = 10;
return;
} else if (IS_GEN(dev_priv, 10)) {
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv
2019-10-09 17:23 [CI 1/2] drm/i915: Move SAGV block time to dev_priv Lucas De Marchi
2019-10-09 17:23 ` [CI 2/2] drm/i915/tgl: Read SAGV block time from PCODE Lucas De Marchi
@ 2019-10-09 17:45 ` Patchwork
2019-10-09 18:15 ` ✗ Fi.CI.BAT: failure " Patchwork
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-09 17:45 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv
URL : https://patchwork.freedesktop.org/series/67799/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e6a4842921d1 drm/i915: Move SAGV block time to dev_priv
-:63: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#63: FILE: drivers/gpu/drm/i915/intel_pm.c:3657:
+ return;
+ } else {
total: 0 errors, 1 warnings, 0 checks, 69 lines checked
e95a4493c646 drm/i915/tgl: Read SAGV block time from PCODE
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv
2019-10-09 17:23 [CI 1/2] drm/i915: Move SAGV block time to dev_priv Lucas De Marchi
2019-10-09 17:23 ` [CI 2/2] drm/i915/tgl: Read SAGV block time from PCODE Lucas De Marchi
2019-10-09 17:45 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv Patchwork
@ 2019-10-09 18:15 ` Patchwork
2019-10-09 20:00 ` James Ausmus
2019-10-09 22:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2) Patchwork
` (2 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2019-10-09 18:15 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv
URL : https://patchwork.freedesktop.org/series/67799/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7043 -> Patchwork_14730
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14730 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14730, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14730:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_coherency:
- fi-glk-dsi: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-glk-dsi/igt@i915_selftest@live_coherency.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-glk-dsi/igt@i915_selftest@live_coherency.html
Known issues
------------
Here are the changes found in Patchwork_14730 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-bxt-dsi: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-bxt-dsi/igt@gem_close_race@basic-threads.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-bxt-dsi/igt@gem_close_race@basic-threads.html
* igt@gem_ctx_switch@legacy-render:
- fi-icl-u2: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#111381])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html
* igt@i915_selftest@live_hangcheck:
- fi-bsw-kefka: [PASS][7] -> [INCOMPLETE][8] ([fdo#105876])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-bsw-kefka/igt@i915_selftest@live_hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-bsw-kefka/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][9] -> [FAIL][10] ([fdo#111045] / [fdo#111096])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@gem_sync@basic-many-each:
- {fi-tgl-u}: [INCOMPLETE][11] ([fdo#111880]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-tgl-u/igt@gem_sync@basic-many-each.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-tgl-u/igt@gem_sync@basic-many-each.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
Participating hosts (54 -> 45)
------------------------------
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-u3 fi-icl-y fi-icl-dsi fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7043 -> Patchwork_14730
CI-20190529: 20190529
CI_DRM_7043: ed6c47dff498138cd3494c95a107c5787094b0b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5219: e501741f2e2b086a8c55d9f278c630ce68ad5fe1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14730: e95a4493c64678635694717b5bfb47c04faba383 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e95a4493c646 drm/i915/tgl: Read SAGV block time from PCODE
e6a4842921d1 drm/i915: Move SAGV block time to dev_priv
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv
2019-10-09 18:15 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2019-10-09 20:00 ` James Ausmus
0 siblings, 0 replies; 9+ messages in thread
From: James Ausmus @ 2019-10-09 20:00 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
On Wed, Oct 09, 2019 at 06:15:26PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv
> URL : https://patchwork.freedesktop.org/series/67799/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7043 -> Patchwork_14730
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with Patchwork_14730 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_14730, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/index.html
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in Patchwork_14730:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@i915_selftest@live_coherency:
> - fi-glk-dsi: [PASS][1] -> [TIMEOUT][2]
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-glk-dsi/igt@i915_selftest@live_coherency.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-glk-dsi/igt@i915_selftest@live_coherency.html
This isn't related - I'll hit the retest button...
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_14730 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_close_race@basic-threads:
> - fi-bxt-dsi: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927])
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-bxt-dsi/igt@gem_close_race@basic-threads.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-bxt-dsi/igt@gem_close_race@basic-threads.html
>
> * igt@gem_ctx_switch@legacy-render:
> - fi-icl-u2: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#111381])
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html
>
> * igt@i915_selftest@live_hangcheck:
> - fi-bsw-kefka: [PASS][7] -> [INCOMPLETE][8] ([fdo#105876])
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-bsw-kefka/igt@i915_selftest@live_hangcheck.html
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-bsw-kefka/igt@i915_selftest@live_hangcheck.html
>
> * igt@kms_chamelium@hdmi-hpd-fast:
> - fi-kbl-7500u: [PASS][9] -> [FAIL][10] ([fdo#111045] / [fdo#111096])
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
>
>
> #### Possible fixes ####
>
> * igt@gem_sync@basic-many-each:
> - {fi-tgl-u}: [INCOMPLETE][11] ([fdo#111880]) -> [PASS][12]
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7043/fi-tgl-u/igt@gem_sync@basic-many-each.html
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/fi-tgl-u/igt@gem_sync@basic-many-each.html
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> [fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
> [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
> [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
> [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
> [fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
> [fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
>
>
> Participating hosts (54 -> 45)
> ------------------------------
>
> Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-u3 fi-icl-y fi-icl-dsi fi-bdw-samus
>
>
> Build changes
> -------------
>
> * CI: CI-20190529 -> None
> * Linux: CI_DRM_7043 -> Patchwork_14730
>
> CI-20190529: 20190529
> CI_DRM_7043: ed6c47dff498138cd3494c95a107c5787094b0b9 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5219: e501741f2e2b086a8c55d9f278c630ce68ad5fe1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_14730: e95a4493c64678635694717b5bfb47c04faba383 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> e95a4493c646 drm/i915/tgl: Read SAGV block time from PCODE
> e6a4842921d1 drm/i915: Move SAGV block time to dev_priv
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14730/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
2019-10-09 17:23 [CI 1/2] drm/i915: Move SAGV block time to dev_priv Lucas De Marchi
` (2 preceding siblings ...)
2019-10-09 18:15 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2019-10-09 22:37 ` Patchwork
2019-10-10 17:10 ` Lucas De Marchi
2019-10-09 23:06 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-10 8:40 ` ✓ Fi.CI.IGT: " Patchwork
5 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2019-10-09 22:37 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
URL : https://patchwork.freedesktop.org/series/67799/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7da5381e3ab8 drm/i915: Move SAGV block time to dev_priv
-:63: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#63: FILE: drivers/gpu/drm/i915/intel_pm.c:3657:
+ return;
+ } else {
total: 0 errors, 1 warnings, 0 checks, 69 lines checked
cc743a676c3a drm/i915/tgl: Read SAGV block time from PCODE
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
2019-10-09 17:23 [CI 1/2] drm/i915: Move SAGV block time to dev_priv Lucas De Marchi
` (3 preceding siblings ...)
2019-10-09 22:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2) Patchwork
@ 2019-10-09 23:06 ` Patchwork
2019-10-10 8:40 ` ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-09 23:06 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
URL : https://patchwork.freedesktop.org/series/67799/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7046 -> Patchwork_14733
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/index.html
Known issues
------------
Here are the changes found in Patchwork_14733 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@create-close:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/fi-icl-u3/igt@gem_basic@create-close.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/fi-icl-u3/igt@gem_basic@create-close.html
* igt@gem_close_race@basic-threads:
- fi-icl-u3: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/fi-icl-u3/igt@gem_close_race@basic-threads.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/fi-icl-u3/igt@gem_close_race@basic-threads.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- {fi-icl-guc}: [INCOMPLETE][5] ([fdo#107713] / [fdo#108840]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/fi-icl-guc/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/fi-icl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_hugepages:
- fi-elk-e7500: [INCOMPLETE][7] ([fdo#103989]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/fi-elk-e7500/igt@i915_selftest@live_hugepages.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/fi-elk-e7500/igt@i915_selftest@live_hugepages.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-r: [INCOMPLETE][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/fi-kbl-r/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/fi-kbl-r/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111045] / [fdo#111096]) -> [FAIL][12] ([fdo#111407])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103989]: https://bugs.freedesktop.org/show_bug.cgi?id=103989
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
Participating hosts (53 -> 44)
------------------------------
Additional (1): fi-pnv-d510
Missing (10): fi-icl-u4 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-gdg-551 fi-icl-y fi-icl-dsi fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7046 -> Patchwork_14733
CI-20190529: 20190529
CI_DRM_7046: 136f98967ad06da28fd795aa83be314c7b641c49 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5220: 1e38e32d721210a780198c8293a6b8c8e881df68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14733: cc743a676c3acb583caf03127a69622eb28a6155 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
cc743a676c3a drm/i915/tgl: Read SAGV block time from PCODE
7da5381e3ab8 drm/i915: Move SAGV block time to dev_priv
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
2019-10-09 17:23 [CI 1/2] drm/i915: Move SAGV block time to dev_priv Lucas De Marchi
` (4 preceding siblings ...)
2019-10-09 23:06 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-10-10 8:40 ` Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-10 8:40 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
URL : https://patchwork.freedesktop.org/series/67799/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7046_full -> Patchwork_14733_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14733_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110841])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_switch@all-light:
- shard-apl: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-apl3/igt@gem_ctx_switch@all-light.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-apl6/igt@gem_ctx_switch@all-light.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb7/igt@gem_exec_schedule@reorder-wide-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [PASS][7] -> [DMESG-WARN][8] ([fdo#111870])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [PASS][9] -> [DMESG-WARN][10] ([fdo#111870])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-snb4/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +5 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-apl1/igt@i915_suspend@sysfs-reader.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-apl6/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-snb: [PASS][13] -> [SKIP][14] ([fdo#109271]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-snb2/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-snb7/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
* igt@kms_flip@2x-flip-vs-rmfb:
- shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([fdo#103540])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-hsw8/igt@kms_flip@2x-flip-vs-rmfb.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-hsw2/igt@kms_flip@2x-flip-vs-rmfb.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb2/igt@kms_psr@psr2_dpms.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb8/igt@kms_psr@psr2_dpms.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109276]) +19 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb3/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_eio@in-flight-contexts-immediate:
- shard-snb: [FAIL][23] ([fdo#111925]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-snb1/igt@gem_eio@in-flight-contexts-immediate.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-snb2/igt@gem_eio@in-flight-contexts-immediate.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][25] ([fdo#110854]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb8/igt@gem_exec_balancer@smoke.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@deep-bsd:
- shard-iclb: [SKIP][27] ([fdo#111325]) -> [PASS][28] +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb1/igt@gem_exec_schedule@deep-bsd.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb3/igt@gem_exec_schedule@deep-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][29] ([fdo#109276]) -> [PASS][30] +15 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb7/igt@gem_exec_schedule@preempt-queue-bsd1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [DMESG-WARN][31] ([fdo#111870]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-hsw4/igt@gem_userptr_blits@dmabuf-unsync.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-hsw4/igt@gem_userptr_blits@dmabuf-unsync.html
* {igt@i915_pm_dc@dc6-dpms}:
- shard-iclb: [FAIL][33] ([fdo#110548]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen:
- shard-skl: [FAIL][35] ([fdo#103232]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-skl10/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][37] ([fdo#105363]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [INCOMPLETE][39] ([fdo#103665]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible.html
- shard-hsw: [INCOMPLETE][41] ([fdo#103540]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt:
- shard-iclb: [FAIL][43] ([fdo#103167]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- {shard-tglb}: [FAIL][45] ([fdo#103167]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-iclb: [INCOMPLETE][47] ([fdo#106978] / [fdo#107713]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][51] ([fdo#108145] / [fdo#110403]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][53] ([fdo#103166]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][55] ([fdo#109642] / [fdo#111068]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb4/igt@kms_psr2_su@page_flip.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_cpu.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@perf_pmu@cpu-hotplug:
- shard-apl: [TIMEOUT][59] ([fdo#111546] / [fdo#111800]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-apl6/igt@perf_pmu@cpu-hotplug.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-apl3/igt@perf_pmu@cpu-hotplug.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][61] ([fdo#111329]) -> [SKIP][62] ([fdo#109276])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:
- shard-apl: [INCOMPLETE][63] ([fdo#103927]) -> [SKIP][64] ([fdo#109271])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7046/shard-apl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/shard-apl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111546]: https://bugs.freedesktop.org/show_bug.cgi?id=111546
[fdo#111800]: https://bugs.freedesktop.org/show_bug.cgi?id=111800
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111925]: https://bugs.freedesktop.org/show_bug.cgi?id=111925
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7046 -> Patchwork_14733
CI-20190529: 20190529
CI_DRM_7046: 136f98967ad06da28fd795aa83be314c7b641c49 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5220: 1e38e32d721210a780198c8293a6b8c8e881df68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14733: cc743a676c3acb583caf03127a69622eb28a6155 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14733/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
2019-10-09 22:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2) Patchwork
@ 2019-10-10 17:10 ` Lucas De Marchi
0 siblings, 0 replies; 9+ messages in thread
From: Lucas De Marchi @ 2019-10-10 17:10 UTC (permalink / raw)
To: intel-gfx
On Wed, Oct 09, 2019 at 10:37:21PM +0000, Patchwork wrote:
>== Series Details ==
>
>Series: series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2)
>URL : https://patchwork.freedesktop.org/series/67799/
>State : warning
>
>== Summary ==
>
>$ dim checkpatch origin/drm-tip
>7da5381e3ab8 drm/i915: Move SAGV block time to dev_priv
>-:63: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
>#63: FILE: drivers/gpu/drm/i915/intel_pm.c:3657:
>+ return;
>+ } else {
I agree, it's one of my pet peeves, but i915's codebase doesn't:
"if ladders" with returns inside are used all over the place.
Lucas De Marchi
>
>total: 0 errors, 1 warnings, 0 checks, 69 lines checked
>cc743a676c3a drm/i915/tgl: Read SAGV block time from PCODE
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-10-10 17:10 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 17:23 [CI 1/2] drm/i915: Move SAGV block time to dev_priv Lucas De Marchi
2019-10-09 17:23 ` [CI 2/2] drm/i915/tgl: Read SAGV block time from PCODE Lucas De Marchi
2019-10-09 17:45 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv Patchwork
2019-10-09 18:15 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-09 20:00 ` James Ausmus
2019-10-09 22:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Move SAGV block time to dev_priv (rev2) Patchwork
2019-10-10 17:10 ` Lucas De Marchi
2019-10-09 23:06 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-10 8:40 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.