* [PATCH] drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling
@ 2019-10-11 10:33 Chris Wilson
2019-10-11 11:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-11 12:00 ` [PATCH] " Tvrtko Ursulin
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2019-10-11 10:33 UTC (permalink / raw)
To: intel-gfx
Only the requests that have not completed do we want to change the
status of to signal the -EIO when cancelling the inflight set of requests
upon wedging.
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index b00499cc7586..1f4772329021 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -247,8 +247,12 @@ static void __context_pin_release(struct intel_context *ce)
static void mark_eio(struct i915_request *rq)
{
- if (!i915_request_signaled(rq))
- dma_fence_set_error(&rq->fence, -EIO);
+ if (i915_request_completed(rq))
+ return;
+
+ GEM_BUG_ON(i915_request_signaled(rq));
+
+ dma_fence_set_error(&rq->fence, -EIO);
i915_request_mark_complete(rq);
}
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling
2019-10-11 10:33 [PATCH] drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling Chris Wilson
@ 2019-10-11 11:12 ` Patchwork
2019-10-11 12:00 ` [PATCH] " Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2019-10-11 11:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling
URL : https://patchwork.freedesktop.org/series/67904/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7061 -> Patchwork_14766
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14766 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14766, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14766:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_workarounds:
- fi-cfl-8109u: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7061/fi-cfl-8109u/igt@i915_selftest@live_workarounds.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/fi-cfl-8109u/igt@i915_selftest@live_workarounds.html
Known issues
------------
Here are the changes found in Patchwork_14766 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_param@basic:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7061/fi-icl-u3/igt@gem_ctx_param@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/fi-icl-u3/igt@gem_ctx_param@basic.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][5] -> [INCOMPLETE][6] ([fdo#107718])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7061/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_coherency:
- fi-glk-dsi: [PASS][7] -> [TIMEOUT][8] ([fdo#111944])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7061/fi-glk-dsi/igt@i915_selftest@live_coherency.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/fi-glk-dsi/igt@i915_selftest@live_coherency.html
#### Possible fixes ####
* igt@gem_ctx_switch@rcs0:
- fi-icl-u2: [INCOMPLETE][9] ([fdo#107713]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7061/fi-icl-u2/igt@gem_ctx_switch@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/fi-icl-u2/igt@gem_ctx_switch@rcs0.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][11] ([fdo#107407]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7061/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@vgem_basic@unload:
- fi-icl-u3: [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7061/fi-icl-u3/igt@vgem_basic@unload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/fi-icl-u3/igt@vgem_basic@unload.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107407]: https://bugs.freedesktop.org/show_bug.cgi?id=107407
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111944]: https://bugs.freedesktop.org/show_bug.cgi?id=111944
Participating hosts (49 -> 43)
------------------------------
Additional (2): fi-gdg-551 fi-tgl-u2
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-tgl-u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7061 -> Patchwork_14766
CI-20190529: 20190529
CI_DRM_7061: 0204e2b48f2a9ae8aff60393755f8164f2fa1038 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5220: 1e38e32d721210a780198c8293a6b8c8e881df68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14766: c6c44f50de7b1266bf85b2889ccfdb60f3ed07ee @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c6c44f50de7b drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14766/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling
2019-10-11 10:33 [PATCH] drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling Chris Wilson
2019-10-11 11:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-10-11 12:00 ` Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Tvrtko Ursulin @ 2019-10-11 12:00 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 11/10/2019 11:33, Chris Wilson wrote:
> Only the requests that have not completed do we want to change the
> status of to signal the -EIO when cancelling the inflight set of requests
> upon wedging.
>
> Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_lrc.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index b00499cc7586..1f4772329021 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -247,8 +247,12 @@ static void __context_pin_release(struct intel_context *ce)
>
> static void mark_eio(struct i915_request *rq)
> {
> - if (!i915_request_signaled(rq))
> - dma_fence_set_error(&rq->fence, -EIO);
> + if (i915_request_completed(rq))
> + return;
> +
> + GEM_BUG_ON(i915_request_signaled(rq));
> +
> + dma_fence_set_error(&rq->fence, -EIO);
> i915_request_mark_complete(rq);
> }
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-11 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-11 10:33 [PATCH] drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling Chris Wilson
2019-10-11 11:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-11 12:00 ` [PATCH] " Tvrtko Ursulin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.