All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [arm-integrator:ixp4xx-test 22/23] drivers/crypto/ixp4xx_crypto.c:1060 aead_perform() error: uninitialized symbol 'icv_rev_aes'.
Date: Fri, 11 Oct 2019 13:41:17 +0300	[thread overview]
Message-ID: <20191011104117.GT13286@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 2649 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git ixp4xx-test
head:   1b826e686b390fd1eeb347def38185fefcbd5140
commit: 811c4aaa704314770fe5a70944100732fdc1f3b8 [22/23] crypto: ixp4xx: avoid BUILD_BUG_ON()

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/crypto/ixp4xx_crypto.c:1060 aead_perform() error: uninitialized symbol 'icv_rev_aes'.

# https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git/commit/?id=811c4aaa704314770fe5a70944100732fdc1f3b8
git remote add arm-integrator https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git
git remote update arm-integrator
git checkout 811c4aaa704314770fe5a70944100732fdc1f3b8
vim +/icv_rev_aes +1060 drivers/crypto/ixp4xx_crypto.c

d7295a8dc965ee Herbert Xu           2015-07-30  1054  	if (unlikely(lastlen < authsize)) {
811c4aaa704314 Arnd Bergmann        2019-08-27  1055  		dma_addr_t icv_rev_aes;
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1056  		/* The 12 hmac bytes are scattered,
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1057  		 * we need to copy them into a safe buffer */
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1058  		req_ctx->hmac_virt = dma_pool_alloc(buffer_pool, flags,
811c4aaa704314 Arnd Bergmann        2019-08-27  1059  						    &icv_rev_aes);
811c4aaa704314 Arnd Bergmann        2019-08-27 @1060  		crypt->icv_rev_aes = (u32)icv_rev_aes;
                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Assigned before error handling.

81bef0150074d6 Christian Hohnstaedt 2008-06-25  1061  		if (unlikely(!req_ctx->hmac_virt))
28389575a8cf93 Herbert Xu           2017-08-02  1062  			goto free_buf_dst;
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1063  		if (!encrypt) {
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1064  			scatterwalk_map_and_copy(req_ctx->hmac_virt,
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1065  				req->src, cryptlen, authsize, 0);
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1066  		}
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1067  		req_ctx->encrypt = encrypt;
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1068  	} else {
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1069  		req_ctx->hmac_virt = NULL;
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1070  	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [arm-integrator:ixp4xx-test 22/23] drivers/crypto/ixp4xx_crypto.c:1060 aead_perform() error: uninitialized symbol 'icv_rev_aes'.
Date: Fri, 11 Oct 2019 13:41:17 +0300	[thread overview]
Message-ID: <20191011104117.GT13286@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 2649 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git ixp4xx-test
head:   1b826e686b390fd1eeb347def38185fefcbd5140
commit: 811c4aaa704314770fe5a70944100732fdc1f3b8 [22/23] crypto: ixp4xx: avoid BUILD_BUG_ON()

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/crypto/ixp4xx_crypto.c:1060 aead_perform() error: uninitialized symbol 'icv_rev_aes'.

# https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git/commit/?id=811c4aaa704314770fe5a70944100732fdc1f3b8
git remote add arm-integrator https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git
git remote update arm-integrator
git checkout 811c4aaa704314770fe5a70944100732fdc1f3b8
vim +/icv_rev_aes +1060 drivers/crypto/ixp4xx_crypto.c

d7295a8dc965ee Herbert Xu           2015-07-30  1054  	if (unlikely(lastlen < authsize)) {
811c4aaa704314 Arnd Bergmann        2019-08-27  1055  		dma_addr_t icv_rev_aes;
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1056  		/* The 12 hmac bytes are scattered,
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1057  		 * we need to copy them into a safe buffer */
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1058  		req_ctx->hmac_virt = dma_pool_alloc(buffer_pool, flags,
811c4aaa704314 Arnd Bergmann        2019-08-27  1059  						    &icv_rev_aes);
811c4aaa704314 Arnd Bergmann        2019-08-27 @1060  		crypt->icv_rev_aes = (u32)icv_rev_aes;
                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Assigned before error handling.

81bef0150074d6 Christian Hohnstaedt 2008-06-25  1061  		if (unlikely(!req_ctx->hmac_virt))
28389575a8cf93 Herbert Xu           2017-08-02  1062  			goto free_buf_dst;
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1063  		if (!encrypt) {
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1064  			scatterwalk_map_and_copy(req_ctx->hmac_virt,
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1065  				req->src, cryptlen, authsize, 0);
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1066  		}
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1067  		req_ctx->encrypt = encrypt;
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1068  	} else {
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1069  		req_ctx->hmac_virt = NULL;
81bef0150074d6 Christian Hohnstaedt 2008-06-25  1070  	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

             reply	other threads:[~2019-10-11 10:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 10:41 Dan Carpenter [this message]
2019-10-11 10:41 ` [arm-integrator:ixp4xx-test 22/23] drivers/crypto/ixp4xx_crypto.c:1060 aead_perform() error: uninitialized symbol 'icv_rev_aes' Dan Carpenter
2019-10-11 21:48 ` Arnd Bergmann
2019-10-11 21:53   ` Arnd Bergmann
2019-10-18 14:49     ` Linus Walleij
2019-10-12  8:08   ` Dan Carpenter
2019-10-12  8:08     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011104117.GT13286@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.