* [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error
@ 2019-10-11 13:29 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2019-10-11 13:29 UTC (permalink / raw)
To: Hans Verkuil, Benoit Parrot, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There appears to be a copy-paste error on the access of
csc_coeffs.y2r.r601.full.coeff, I believe csc_coeffs.2yr.r601.full.coeff
should be used instead. This is a moot point as the code is never
reached, but at least use the correct structure element.
Addresses-Coverity: ("Copy-paste error")
Fixes: 3ff3a712a9ea ("media: ti-vpe: vpe: don't rely on colorspace member for conversion")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/platform/ti-vpe/csc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c
index bd923bee4a31..834114a4eebe 100644
--- a/drivers/media/platform/ti-vpe/csc.c
+++ b/drivers/media/platform/ti-vpe/csc.c
@@ -238,7 +238,7 @@ void csc_set_coeff(struct csc_data *csc, u32 *csc_reg0,
coeff = csc_coeffs.r2y.r709.limited.coeff;
} else {
/* Should never reach this, but it keeps gcc happy */
- coeff = csc_coeffs.y2r.r601.full.coeff;
+ coeff = csc_coeffs.r2y.r601.full.coeff;
}
} else {
*csc_reg5 |= CSC_BYPASS;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error
@ 2019-10-11 13:29 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2019-10-11 13:29 UTC (permalink / raw)
To: Hans Verkuil, Benoit Parrot, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There appears to be a copy-paste error on the access of
csc_coeffs.y2r.r601.full.coeff, I believe csc_coeffs.2yr.r601.full.coeff
should be used instead. This is a moot point as the code is never
reached, but at least use the correct structure element.
Addresses-Coverity: ("Copy-paste error")
Fixes: 3ff3a712a9ea ("media: ti-vpe: vpe: don't rely on colorspace member for conversion")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/platform/ti-vpe/csc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c
index bd923bee4a31..834114a4eebe 100644
--- a/drivers/media/platform/ti-vpe/csc.c
+++ b/drivers/media/platform/ti-vpe/csc.c
@@ -238,7 +238,7 @@ void csc_set_coeff(struct csc_data *csc, u32 *csc_reg0,
coeff = csc_coeffs.r2y.r709.limited.coeff;
} else {
/* Should never reach this, but it keeps gcc happy */
- coeff = csc_coeffs.y2r.r601.full.coeff;
+ coeff = csc_coeffs.r2y.r601.full.coeff;
}
} else {
*csc_reg5 |= CSC_BYPASS;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error
2019-10-11 13:29 ` Colin King
@ 2019-10-11 14:18 ` Benoit Parrot
-1 siblings, 0 replies; 4+ messages in thread
From: Benoit Parrot @ 2019-10-11 14:18 UTC (permalink / raw)
To: Colin King
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-media,
kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> wrote on Fri [2019-Oct-11 14:29:40 +0100]:
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a copy-paste error on the access of
> csc_coeffs.y2r.r601.full.coeff, I believe csc_coeffs.2yr.r601.full.coeff
> should be used instead. This is a moot point as the code is never
> reached, but at least use the correct structure element.
>
> Addresses-Coverity: ("Copy-paste error")
> Fixes: 3ff3a712a9ea ("media: ti-vpe: vpe: don't rely on colorspace member for conversion")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/platform/ti-vpe/csc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c
> index bd923bee4a31..834114a4eebe 100644
> --- a/drivers/media/platform/ti-vpe/csc.c
> +++ b/drivers/media/platform/ti-vpe/csc.c
> @@ -238,7 +238,7 @@ void csc_set_coeff(struct csc_data *csc, u32 *csc_reg0,
> coeff = csc_coeffs.r2y.r709.limited.coeff;
> } else {
> /* Should never reach this, but it keeps gcc happy */
> - coeff = csc_coeffs.y2r.r601.full.coeff;
> + coeff = csc_coeffs.r2y.r601.full.coeff;
> }
> } else {
> *csc_reg5 |= CSC_BYPASS;
Reviewed-by: Benoit Parrot <bparrot.ti.com>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error
@ 2019-10-11 14:18 ` Benoit Parrot
0 siblings, 0 replies; 4+ messages in thread
From: Benoit Parrot @ 2019-10-11 14:18 UTC (permalink / raw)
To: Colin King
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-media,
kernel-janitors, linux-kernel
Colin King <colin.king@canonical.com> wrote on Fri [2019-Oct-11 14:29:40 +0100]:
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a copy-paste error on the access of
> csc_coeffs.y2r.r601.full.coeff, I believe csc_coeffs.2yr.r601.full.coeff
> should be used instead. This is a moot point as the code is never
> reached, but at least use the correct structure element.
>
> Addresses-Coverity: ("Copy-paste error")
> Fixes: 3ff3a712a9ea ("media: ti-vpe: vpe: don't rely on colorspace member for conversion")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/platform/ti-vpe/csc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c
> index bd923bee4a31..834114a4eebe 100644
> --- a/drivers/media/platform/ti-vpe/csc.c
> +++ b/drivers/media/platform/ti-vpe/csc.c
> @@ -238,7 +238,7 @@ void csc_set_coeff(struct csc_data *csc, u32 *csc_reg0,
> coeff = csc_coeffs.r2y.r709.limited.coeff;
> } else {
> /* Should never reach this, but it keeps gcc happy */
> - coeff = csc_coeffs.y2r.r601.full.coeff;
> + coeff = csc_coeffs.r2y.r601.full.coeff;
> }
> } else {
> *csc_reg5 |= CSC_BYPASS;
Reviewed-by: Benoit Parrot <bparrot.ti.com>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-11 14:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-11 13:29 [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error Colin King
2019-10-11 13:29 ` Colin King
2019-10-11 14:18 ` Benoit Parrot
2019-10-11 14:18 ` Benoit Parrot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.