From: Miquel Raynal <miquel.raynal@bootlin.com> To: Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com> Cc: <devicetree@vger.kernel.org>, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [PATCH v4 0/8] Introduce max12xx ADC support Date: Fri, 11 Oct 2019 16:43:39 +0200 [thread overview] Message-ID: <20191011144347.19146-1-miquel.raynal@bootlin.com> (raw) Hello, here is a patchset updating the existing max1027.c driver (for 10-bit max1027/29/31 ADCs) with a few corrections/improvements and then introducing their 12-bit cousins named max1227/29/31. As on my hardware setup the "start conversion" and "end of conversion" pin are not wired (which is absolutely fine for this chip), I also updated the driver and the bindings to support optional interrupts. In this case, triggered buffers are not available and the user must poll the value from sysfs. Thanks, Miquèl Changes in v4: ============== * In the v3, I removed the bindings documentation for the max10xx devices, in favor of the trivial devices bindings. Unfortunately, I didn't spot that in the following patch adding support for the max12xx series, I was adding the compatibles to the trivial devices list but also re-introducing the bindings documentation with the three new compatibles. Just drop this part of the last patch to only have the trivial devices file, not the specific bindings. All the rest is the same. Changes in v3: ============== * Updated the commit message of the patch adding debugfs read access to better explain why I decided to limit the number of bytes read to two. * Updated the macros to define the number of channels per device as proposed by Jonathan. * Re-used the realbits entry instead of adding my own (called .depth). * Started doing DT-bindings yaml conversion, but realized that after the first patch offering the interrupt as optional, the documentation was fitting pretty well the trivial devices representation. Dropped the specific bindings files and updated the trivial devices list instead. Changes in v2: ============== * Removed the addition of three compatibles from patch 4 (the preparation patch) to add these lines back in patch 5 (the actual introduction). Miquel Raynal (8): iio: adc: max1027: Add debugfs register read support iio: adc: max1027: Make it optional to use interrupts iio: adc: max1027: Reset the device at probe time iio: adc: max1027: Prepare the introduction of different resolutions iio: adc: max1027: Introduce 12-bit devices support dt-bindings: iio: adc: max1027: Mark interrupts as optional dt-bindings: Add 1027/1029/1031 SPI ADCs as trivial devices dt-bindings: Add max12xx SPI ADC series as trivial devices .../bindings/iio/adc/max1027-adc.txt | 20 -- .../devicetree/bindings/trivial-devices.yaml | 12 ++ drivers/iio/adc/Kconfig | 4 +- drivers/iio/adc/max1027.c | 180 +++++++++++------- 4 files changed, 125 insertions(+), 91 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com> Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [PATCH v4 0/8] Introduce max12xx ADC support Date: Fri, 11 Oct 2019 16:43:39 +0200 [thread overview] Message-ID: <20191011144347.19146-1-miquel.raynal@bootlin.com> (raw) Hello, here is a patchset updating the existing max1027.c driver (for 10-bit max1027/29/31 ADCs) with a few corrections/improvements and then introducing their 12-bit cousins named max1227/29/31. As on my hardware setup the "start conversion" and "end of conversion" pin are not wired (which is absolutely fine for this chip), I also updated the driver and the bindings to support optional interrupts. In this case, triggered buffers are not available and the user must poll the value from sysfs. Thanks, Miquèl Changes in v4: ============== * In the v3, I removed the bindings documentation for the max10xx devices, in favor of the trivial devices bindings. Unfortunately, I didn't spot that in the following patch adding support for the max12xx series, I was adding the compatibles to the trivial devices list but also re-introducing the bindings documentation with the three new compatibles. Just drop this part of the last patch to only have the trivial devices file, not the specific bindings. All the rest is the same. Changes in v3: ============== * Updated the commit message of the patch adding debugfs read access to better explain why I decided to limit the number of bytes read to two. * Updated the macros to define the number of channels per device as proposed by Jonathan. * Re-used the realbits entry instead of adding my own (called .depth). * Started doing DT-bindings yaml conversion, but realized that after the first patch offering the interrupt as optional, the documentation was fitting pretty well the trivial devices representation. Dropped the specific bindings files and updated the trivial devices list instead. Changes in v2: ============== * Removed the addition of three compatibles from patch 4 (the preparation patch) to add these lines back in patch 5 (the actual introduction). Miquel Raynal (8): iio: adc: max1027: Add debugfs register read support iio: adc: max1027: Make it optional to use interrupts iio: adc: max1027: Reset the device at probe time iio: adc: max1027: Prepare the introduction of different resolutions iio: adc: max1027: Introduce 12-bit devices support dt-bindings: iio: adc: max1027: Mark interrupts as optional dt-bindings: Add 1027/1029/1031 SPI ADCs as trivial devices dt-bindings: Add max12xx SPI ADC series as trivial devices .../bindings/iio/adc/max1027-adc.txt | 20 -- .../devicetree/bindings/trivial-devices.yaml | 12 ++ drivers/iio/adc/Kconfig | 4 +- drivers/iio/adc/max1027.c | 180 +++++++++++------- 4 files changed, 125 insertions(+), 91 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt -- 2.20.1
next reply other threads:[~2019-10-11 14:44 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-11 14:43 Miquel Raynal [this message] 2019-10-11 14:43 ` [PATCH v4 0/8] Introduce max12xx ADC support Miquel Raynal 2019-10-11 14:43 ` [PATCH v4 1/8] iio: adc: max1027: Add debugfs register read support Miquel Raynal 2019-10-11 14:43 ` Miquel Raynal 2019-10-12 11:25 ` Jonathan Cameron 2019-10-12 11:25 ` Jonathan Cameron 2019-10-11 14:43 ` [PATCH v4 2/8] iio: adc: max1027: Make it optional to use interrupts Miquel Raynal 2019-10-11 14:43 ` Miquel Raynal 2019-10-12 11:34 ` Jonathan Cameron 2019-10-12 11:34 ` Jonathan Cameron 2019-10-11 14:43 ` [PATCH v4 3/8] iio: adc: max1027: Reset the device at probe time Miquel Raynal 2019-10-11 14:43 ` Miquel Raynal 2019-10-12 11:28 ` Jonathan Cameron 2019-10-12 11:28 ` Jonathan Cameron 2019-10-11 14:43 ` [PATCH v4 4/8] iio: adc: max1027: Prepare the introduction of different resolutions Miquel Raynal 2019-10-11 14:43 ` Miquel Raynal 2019-10-12 11:29 ` Jonathan Cameron 2019-10-12 11:29 ` Jonathan Cameron 2019-10-11 14:43 ` [PATCH v4 5/8] iio: adc: max1027: Introduce 12-bit devices support Miquel Raynal 2019-10-11 14:43 ` Miquel Raynal 2019-10-12 11:30 ` Jonathan Cameron 2019-10-12 11:30 ` Jonathan Cameron 2019-10-11 14:43 ` [PATCH v4 6/8] dt-bindings: iio: adc: max1027: Mark interrupts as optional Miquel Raynal 2019-10-11 14:43 ` Miquel Raynal 2019-10-12 11:31 ` Jonathan Cameron 2019-10-12 11:31 ` Jonathan Cameron 2019-10-11 14:43 ` [PATCH v4 7/8] dt-bindings: Add 1027/1029/1031 SPI ADCs as trivial devices Miquel Raynal 2019-10-11 14:43 ` Miquel Raynal 2019-10-14 15:38 ` Rob Herring 2019-10-14 15:38 ` Rob Herring 2019-10-11 14:43 ` [PATCH v4 8/8] dt-bindings: Add max12xx SPI ADC series " Miquel Raynal 2019-10-11 14:43 ` Miquel Raynal 2019-10-12 11:32 ` Jonathan Cameron 2019-10-12 11:32 ` Jonathan Cameron 2019-10-14 15:38 ` Rob Herring 2019-10-14 15:38 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191011144347.19146-1-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pmeerw@pmeerw.net \ --cc=robh+dt@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.