From: Rob Herring <robh@kernel.org> To: Tzung-Bi Shih <tzungbi@google.com> Cc: gwendal@google.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, cychiang@google.com, drinkcat@google.com, broonie@kernel.org, enric.balletbo@collabora.com, bleung@google.com, dgreid@google.com Subject: Re: [PATCH v2 06/10] ASoC: dt-bindings: cros_ec_codec: add SHM bindings Date: Fri, 11 Oct 2019 10:13:54 -0500 [thread overview] Message-ID: <20191011151354.GA12997@bogus> (raw) In-Reply-To: <20191005164320.06.I0df85fe54162426e31f60a589d9b461c65df2faa@changeid> On Sat, Oct 05, 2019 at 04:55:05PM +0800, Tzung-Bi Shih wrote: > - Add "ec-shm" for binding to shared memory exposed by EC. > - Add "memory-region" for binding to memory region shared by AP. > > Signed-off-by: Tzung-Bi Shih <tzungbi@google.com> > --- > .../bindings/sound/google,cros-ec-codec.txt | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > index 0ce9fafc78e2..cb46bc082b4b 100644 > --- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > +++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > @@ -10,8 +10,26 @@ Required properties: > - compatible: Must contain "google,cros-ec-codec" > - #sound-dai-cells: Should be 1. The cell specifies number of DAIs. > > +Optional properties: > +- ec-shm: Shared memory region from EC. It contains 3 unsigned 32-bit > + integer. The first 2 integers combine to become an unsigned > + 64-bit address. The last one integer is length of the shared > + memory. This is an address accessible to the main CPU? If so, then it really should be using 'reg' and be translatable. > +- memory-region: Shared memory region to EC. A "shared-dma-pool". See > + ../reserved-memory/reserved-memory.txt for details. > + > Example: > > +{ > + ... > + > + reserved_mem: reserved_mem { > + compatible = "shared-dma-pool"; > + reg = <0 0x52800000 0 0x100000>; > + no-map; > + }; > +} > + > cros-ec@0 { > compatible = "google,cros-ec-spi"; > > @@ -20,5 +38,7 @@ cros-ec@0 { > cros_ec_codec: ec-codec { > compatible = "google,cros-ec-codec"; > #sound-dai-cells = <1>; > + ec-shm = <0x0 0x10500000 0x80000>; > + memory-region = <&reserved_mem>; > }; > }; > -- > 2.23.0.581.g78d2f28ef7-goog >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Tzung-Bi Shih <tzungbi@google.com> Cc: gwendal@google.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, cychiang@google.com, drinkcat@google.com, broonie@kernel.org, enric.balletbo@collabora.com, bleung@google.com, dgreid@google.com Subject: Re: [alsa-devel] [PATCH v2 06/10] ASoC: dt-bindings: cros_ec_codec: add SHM bindings Date: Fri, 11 Oct 2019 10:13:54 -0500 [thread overview] Message-ID: <20191011151354.GA12997@bogus> (raw) In-Reply-To: <20191005164320.06.I0df85fe54162426e31f60a589d9b461c65df2faa@changeid> On Sat, Oct 05, 2019 at 04:55:05PM +0800, Tzung-Bi Shih wrote: > - Add "ec-shm" for binding to shared memory exposed by EC. > - Add "memory-region" for binding to memory region shared by AP. > > Signed-off-by: Tzung-Bi Shih <tzungbi@google.com> > --- > .../bindings/sound/google,cros-ec-codec.txt | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > index 0ce9fafc78e2..cb46bc082b4b 100644 > --- a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > +++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > @@ -10,8 +10,26 @@ Required properties: > - compatible: Must contain "google,cros-ec-codec" > - #sound-dai-cells: Should be 1. The cell specifies number of DAIs. > > +Optional properties: > +- ec-shm: Shared memory region from EC. It contains 3 unsigned 32-bit > + integer. The first 2 integers combine to become an unsigned > + 64-bit address. The last one integer is length of the shared > + memory. This is an address accessible to the main CPU? If so, then it really should be using 'reg' and be translatable. > +- memory-region: Shared memory region to EC. A "shared-dma-pool". See > + ../reserved-memory/reserved-memory.txt for details. > + > Example: > > +{ > + ... > + > + reserved_mem: reserved_mem { > + compatible = "shared-dma-pool"; > + reg = <0 0x52800000 0 0x100000>; > + no-map; > + }; > +} > + > cros-ec@0 { > compatible = "google,cros-ec-spi"; > > @@ -20,5 +38,7 @@ cros-ec@0 { > cros_ec_codec: ec-codec { > compatible = "google,cros-ec-codec"; > #sound-dai-cells = <1>; > + ec-shm = <0x0 0x10500000 0x80000>; > + memory-region = <&reserved_mem>; > }; > }; > -- > 2.23.0.581.g78d2f28ef7-goog > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-11 15:13 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-05 8:54 [PATCH v2 00/10] ASoC: mediatek: mt8183-mt6358-ts3a227-max98357: support WoV Tzung-Bi Shih 2019-10-05 8:54 ` [alsa-devel] " Tzung-Bi Shih 2019-10-05 8:55 ` [PATCH v2 01/10] platform/chrome: cros_ec: remove unused EC feature Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-05 8:55 ` [PATCH v2 02/10] ASoC: cros_ec_codec: refactor I2S RX Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-05 8:55 ` [PATCH v2 03/10] ASoC: cros_ec_codec: extract DMIC EC command from " Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-05 8:55 ` [PATCH v2 04/10] platform/chrome: cros_ec: add common commands for EC codec Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-05 8:55 ` [PATCH v2 05/10] ASoC: cros_ec_codec: read max DMIC gain from " Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-11 15:14 ` Rob Herring 2019-10-11 15:14 ` [alsa-devel] " Rob Herring 2019-10-05 8:55 ` [PATCH v2 06/10] ASoC: dt-bindings: cros_ec_codec: add SHM bindings Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-11 15:13 ` Rob Herring [this message] 2019-10-11 15:13 ` Rob Herring 2019-10-05 8:55 ` [PATCH v2 07/10] ASoC: cros_ec_codec: support WoV Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-05 16:53 ` kbuild test robot 2019-10-05 16:53 ` [alsa-devel] " kbuild test robot 2019-10-05 16:53 ` kbuild test robot 2019-10-07 7:04 ` Tzung-Bi Shih 2019-10-07 7:04 ` [alsa-devel] " Tzung-Bi Shih 2019-10-07 7:04 ` Tzung-Bi Shih 2019-10-09 7:25 ` [kbuild-all] " Rong Chen 2019-10-09 7:28 ` [alsa-devel] " Rong Chen 2019-10-09 7:25 ` [alsa-devel] [kbuild-all] " Rong Chen 2019-10-14 10:26 ` Tzung-Bi Shih 2019-10-14 10:26 ` [alsa-devel] " Tzung-Bi Shih 2019-10-14 10:26 ` [alsa-devel] [kbuild-all] " Tzung-Bi Shih 2019-10-05 8:55 ` [PATCH v2 08/10] ASoC: mediatek: mt6358: " Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-05 8:55 ` [PATCH v2 09/10] ASoC: dt-bindings: mt8183: add ec-codec Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih 2019-10-11 15:20 ` Rob Herring 2019-10-11 15:20 ` [alsa-devel] " Rob Herring 2019-10-12 15:15 ` Tzung-Bi Shih 2019-10-12 15:15 ` [alsa-devel] " Tzung-Bi Shih 2019-10-05 8:55 ` [PATCH v2 10/10] ASoC: mediatek: mt8183: support WoV Tzung-Bi Shih 2019-10-05 8:55 ` [alsa-devel] " Tzung-Bi Shih
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191011151354.GA12997@bogus \ --to=robh@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=bleung@google.com \ --cc=broonie@kernel.org \ --cc=cychiang@google.com \ --cc=devicetree@vger.kernel.org \ --cc=dgreid@google.com \ --cc=drinkcat@google.com \ --cc=enric.balletbo@collabora.com \ --cc=gwendal@google.com \ --cc=tzungbi@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.