All of lore.kernel.org
 help / color / mirror / Atom feed
* [dhowells-fs:keys-acl 1/2] drivers//md/dm-verity-verify-sig.c:38:8: error: too few arguments to function 'request_key'
@ 2019-10-11 14:45 kbuild test robot
  0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2019-10-11 14:45 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 10100 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git keys-acl
head:   9f9385fc35f5528b197970130e39e23ba82b3689
commit: addfb78802c0a5353c5f81a2bf10985302bc186e [1/2] keys: Replace uid/gid/perm permissions checking with an ACL
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout addfb78802c0a5353c5f81a2bf10985302bc186e
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

Note: the dhowells-fs/keys-acl HEAD 9f9385fc35f5528b197970130e39e23ba82b3689 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

   drivers//md/dm-verity-verify-sig.c: In function 'verity_verify_get_sig_from_key':
>> drivers//md/dm-verity-verify-sig.c:38:8: error: too few arguments to function 'request_key'
     key = request_key(&key_type_user,
           ^~~~~~~~~~~
   In file included from include/keys/user-type.h:11:0,
                    from drivers//md/dm-verity-verify-sig.c:10:
   include/linux/key.h:318:27: note: declared here
    static inline struct key *request_key(struct key_type *type,
                              ^~~~~~~~~~~
--
   In file included from include/linux/keyctl.h:11:0,
                    from include/linux/key.h:35,
                    from include/linux/key-type.h:11,
                    from fs//crypto/keyring.c:22:
   fs//crypto/keyring.c: In function 'allocate_filesystem_keyring':
>> include/uapi/linux/keyctl.h:52:24: warning: passing argument 5 of 'keyring_alloc' makes pointer from integer without a cast [-Wint-conversion]
    #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
                           ^
>> fs//crypto/keyring.c:206:21: note: in expansion of macro 'KEY_POS_SEARCH'
        current_cred(), KEY_POS_SEARCH |
                        ^~~~~~~~~~~~~~
   In file included from include/linux/key-type.h:11:0,
                    from fs//crypto/keyring.c:22:
   include/linux/key.h:387:20: note: expected 'struct key_acl *' but argument is of type 'int'
    extern struct key *keyring_alloc(const char *description, kuid_t uid, kgid_t gid,
                       ^~~~~~~~~~~~~
   In file included from include/linux/keyctl.h:11:0,
                    from include/linux/key.h:35,
                    from include/linux/key-type.h:11,
                    from fs//crypto/keyring.c:22:
   fs//crypto/keyring.c: In function 'allocate_master_key_users_keyring':
>> include/uapi/linux/keyctl.h:52:24: warning: passing argument 5 of 'keyring_alloc' makes pointer from integer without a cast [-Wint-conversion]
    #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
                           ^
   fs//crypto/keyring.c:250:21: note: in expansion of macro 'KEY_POS_SEARCH'
        current_cred(), KEY_POS_SEARCH |
                        ^~~~~~~~~~~~~~
   In file included from include/linux/key-type.h:11:0,
                    from fs//crypto/keyring.c:22:
   include/linux/key.h:387:20: note: expected 'struct key_acl *' but argument is of type 'int'
    extern struct key *keyring_alloc(const char *description, kuid_t uid, kgid_t gid,
                       ^~~~~~~~~~~~~
   In file included from include/linux/keyctl.h:11:0,
                    from include/linux/key.h:35,
                    from include/linux/key-type.h:11,
                    from fs//crypto/keyring.c:22:
   fs//crypto/keyring.c: In function 'add_master_key_user':
>> include/uapi/linux/keyctl.h:52:24: warning: passing argument 6 of 'key_alloc' makes pointer from integer without a cast [-Wint-conversion]
    #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
                           ^
   fs//crypto/keyring.c:288:8: note: in expansion of macro 'KEY_POS_SEARCH'
           KEY_POS_SEARCH | KEY_USR_VIEW, 0, NULL);
           ^~~~~~~~~~~~~~
   In file included from include/linux/key-type.h:11:0,
                    from fs//crypto/keyring.c:22:
   include/linux/key.h:253:20: note: expected 'struct key_acl *' but argument is of type 'int'
    extern struct key *key_alloc(struct key_type *type,
                       ^~~~~~~~~
   In file included from include/linux/keyctl.h:11:0,
                    from include/linux/key.h:35,
                    from include/linux/key-type.h:11,
                    from fs//crypto/keyring.c:22:
   fs//crypto/keyring.c: In function 'add_new_master_key':
>> include/uapi/linux/keyctl.h:52:24: warning: passing argument 6 of 'key_alloc' makes pointer from integer without a cast [-Wint-conversion]
    #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
                           ^
   fs//crypto/keyring.c:360:4: note: in expansion of macro 'KEY_POS_SEARCH'
       KEY_POS_SEARCH | KEY_USR_SEARCH | KEY_USR_VIEW,
       ^~~~~~~~~~~~~~
   In file included from include/linux/key-type.h:11:0,
                    from fs//crypto/keyring.c:22:
   include/linux/key.h:253:20: note: expected 'struct key_acl *' but argument is of type 'int'
    extern struct key *key_alloc(struct key_type *type,
                       ^~~~~~~~~
--
   fs//crypto/keysetup_v1.c: In function 'find_and_lock_process_key':
>> fs//crypto/keysetup_v1.c:107:8: error: too few arguments to function 'request_key'
     key = request_key(&key_type_logon, description, NULL);
           ^~~~~~~~~~~
   In file included from include/keys/user-type.h:11:0,
                    from fs//crypto/keysetup_v1.c:25:
   include/linux/key.h:318:27: note: declared here
    static inline struct key *request_key(struct key_type *type,
                              ^~~~~~~~~~~
--
   In file included from include/linux/keyctl.h:11:0,
                    from include/linux/key.h:35,
                    from include/linux/cred.h:13,
                    from fs//verity/signature.c:10:
   fs//verity/signature.c: In function 'fsverity_init_signature':
>> include/uapi/linux/keyctl.h:52:24: warning: passing argument 5 of 'keyring_alloc' makes pointer from integer without a cast [-Wint-conversion]
    #define KEY_POS_SEARCH 0x08000000 /* possessor can find a key in search / search a keyring */
                           ^
>> fs//verity/signature.c:140:25: note: in expansion of macro 'KEY_POS_SEARCH'
            current_cred(), KEY_POS_SEARCH |
                            ^~~~~~~~~~~~~~
   In file included from include/linux/cred.h:13:0,
                    from fs//verity/signature.c:10:
   include/linux/key.h:387:20: note: expected 'struct key_acl *' but argument is of type 'int'
    extern struct key *keyring_alloc(const char *description, kuid_t uid, kgid_t gid,
                       ^~~~~~~~~~~~~

vim +/request_key +38 drivers//md/dm-verity-verify-sig.c

88cd3e6cfac915 Jaskaran Khurana 2019-07-17  30  
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  31  static int verity_verify_get_sig_from_key(const char *key_desc,
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  32  					struct dm_verity_sig_opts *sig_opts)
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  33  {
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  34  	struct key *key;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  35  	const struct user_key_payload *ukp;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  36  	int ret = 0;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  37  
88cd3e6cfac915 Jaskaran Khurana 2019-07-17 @38  	key = request_key(&key_type_user,
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  39  			key_desc, NULL);
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  40  	if (IS_ERR(key))
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  41  		return PTR_ERR(key);
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  42  
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  43  	down_read(&key->sem);
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  44  
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  45  	ukp = user_key_payload_locked(key);
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  46  	if (!ukp) {
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  47  		ret = -EKEYREVOKED;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  48  		goto end;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  49  	}
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  50  
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  51  	sig_opts->sig = kmalloc(ukp->datalen, GFP_KERNEL);
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  52  	if (!sig_opts->sig) {
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  53  		ret = -ENOMEM;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  54  		goto end;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  55  	}
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  56  	sig_opts->sig_size = ukp->datalen;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  57  
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  58  	memcpy(sig_opts->sig, ukp->data, sig_opts->sig_size);
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  59  
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  60  end:
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  61  	up_read(&key->sem);
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  62  	key_put(key);
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  63  
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  64  	return ret;
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  65  }
88cd3e6cfac915 Jaskaran Khurana 2019-07-17  66  

:::::: The code at line 38 was first introduced by commit
:::::: 88cd3e6cfac915f50f7aa7b699bdf053afec866e dm verity: add root hash pkcs#7 signature verification

:::::: TO: Jaskaran Khurana <jaskarankhurana@linux.microsoft.com>
:::::: CC: Mike Snitzer <snitzer@redhat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54928 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2019-10-11 14:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-11 14:45 [dhowells-fs:keys-acl 1/2] drivers//md/dm-verity-verify-sig.c:38:8: error: too few arguments to function 'request_key' kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.