From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, brgl@bgdev.pl,
linus.walleij@linaro.org, bamv2005@gmail.com
Cc: drew@pdp7.com, Kent Gibson <warthog618@gmail.com>
Subject: [PATCH v2 4/6] gpiolib: pull requires explicit input mode
Date: Sat, 12 Oct 2019 09:56:26 +0800 [thread overview]
Message-ID: <20191012015628.9604-5-warthog618@gmail.com> (raw)
In-Reply-To: <20191012015628.9604-1-warthog618@gmail.com>
This patch prevents pull up/down flags being applied to as-is line
requests, which should be left as-is, and for output mode for which
setting pulls is not currently supported.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
drivers/gpio/gpiolib.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 053847b6187f..647334f53622 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -559,6 +559,12 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
(lflags & GPIOHANDLE_REQUEST_OPEN_SOURCE)))
return -EINVAL;
+ /* PULL_UP and PULL_DOWN flags only make sense for input mode. */
+ if (!(lflags & GPIOHANDLE_REQUEST_INPUT) &&
+ ((lflags & GPIOHANDLE_REQUEST_PULL_UP) ||
+ (lflags & GPIOHANDLE_REQUEST_PULL_DOWN)))
+ return -EINVAL;
+
lh = kzalloc(sizeof(*lh), GFP_KERNEL);
if (!lh)
return -ENOMEM;
--
2.23.0
next prev parent reply other threads:[~2019-10-12 1:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 1:56 [PATCH v2 0/6] gpio: expose pull-up/pull-down line flags to userspace Kent Gibson
2019-10-12 1:56 ` [PATCH v2 1/6] " Kent Gibson
2019-10-12 1:56 ` [PATCH v2 2/6] gpiolib: add support for pull up/down to lineevent_create Kent Gibson
2019-10-14 12:35 ` Bartosz Golaszewski
2019-10-14 12:58 ` Kent Gibson
2019-10-14 16:44 ` Bartosz Golaszewski
2019-10-12 1:56 ` [PATCH v2 3/6] gpio: mockup: add set_config to support pull up/down Kent Gibson
2019-10-12 1:56 ` Kent Gibson [this message]
2019-10-14 12:38 ` [PATCH v2 4/6] gpiolib: pull requires explicit input mode Bartosz Golaszewski
2019-10-14 12:54 ` Kent Gibson
2019-10-14 17:00 ` Bartosz Golaszewski
2019-10-15 0:52 ` Kent Gibson
2019-10-12 1:56 ` [PATCH v2 5/6] gpiolib: disable bias on inputs when pull up/down are both set Kent Gibson
2019-10-14 12:43 ` Bartosz Golaszewski
2019-10-14 13:04 ` Kent Gibson
2019-10-14 16:50 ` Bartosz Golaszewski
2019-10-15 0:58 ` Kent Gibson
2019-10-15 12:51 ` Bartosz Golaszewski
2019-10-16 1:01 ` Kent Gibson
2019-10-17 5:06 ` Kent Gibson
2019-10-18 8:03 ` Bartosz Golaszewski
2019-10-18 10:13 ` Kent Gibson
2019-10-21 14:57 ` Bartosz Golaszewski
2019-10-21 23:14 ` Kent Gibson
2019-10-22 3:11 ` Kent Gibson
2019-10-18 7:48 ` Bartosz Golaszewski
2019-10-18 9:42 ` Kent Gibson
2019-10-12 1:56 ` [PATCH v2 6/6] gpiolib: allow pull up/down on outputs Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012015628.9604-5-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=bamv2005@gmail.com \
--cc=brgl@bgdev.pl \
--cc=drew@pdp7.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.