From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bamvor Jian Zhang <bamv2005@gmail.com>,
Drew Fustini <drew@pdp7.com>
Subject: Re: [PATCH v2 4/6] gpiolib: pull requires explicit input mode
Date: Mon, 14 Oct 2019 20:54:57 +0800 [thread overview]
Message-ID: <20191014125457.GA28012@sol> (raw)
In-Reply-To: <CAMRc=Me+u2brQVo2HwLS+gSDSZWXvsjT59qP75aKRi3PHqMbvg@mail.gmail.com>
On Mon, Oct 14, 2019 at 02:38:38PM +0200, Bartosz Golaszewski wrote:
> sob., 12 paź 2019 o 03:57 Kent Gibson <warthog618@gmail.com> napisał(a):
> >
> > This patch prevents pull up/down flags being applied to as-is line
> > requests, which should be left as-is, and for output mode for which
> > setting pulls is not currently supported.
> >
>
> This again looks like it should be done right in patch 1/6 instead of
> being fixed later in the same series. Or is there some reason to do it
> this way I'm not seeing?
>
The patch series adds full support for pull up/down in stages - in order
of increasing level of controversy, at least IMHO.
That way you can drop the more contraversial components if you disagree
with them by rejecting individual patches, and most likely all the
ones that follow.
And I certainly wasn't going to bundle everything into Drew's patch.
Cheers,
Kent.
next prev parent reply other threads:[~2019-10-14 12:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 1:56 [PATCH v2 0/6] gpio: expose pull-up/pull-down line flags to userspace Kent Gibson
2019-10-12 1:56 ` [PATCH v2 1/6] " Kent Gibson
2019-10-12 1:56 ` [PATCH v2 2/6] gpiolib: add support for pull up/down to lineevent_create Kent Gibson
2019-10-14 12:35 ` Bartosz Golaszewski
2019-10-14 12:58 ` Kent Gibson
2019-10-14 16:44 ` Bartosz Golaszewski
2019-10-12 1:56 ` [PATCH v2 3/6] gpio: mockup: add set_config to support pull up/down Kent Gibson
2019-10-12 1:56 ` [PATCH v2 4/6] gpiolib: pull requires explicit input mode Kent Gibson
2019-10-14 12:38 ` Bartosz Golaszewski
2019-10-14 12:54 ` Kent Gibson [this message]
2019-10-14 17:00 ` Bartosz Golaszewski
2019-10-15 0:52 ` Kent Gibson
2019-10-12 1:56 ` [PATCH v2 5/6] gpiolib: disable bias on inputs when pull up/down are both set Kent Gibson
2019-10-14 12:43 ` Bartosz Golaszewski
2019-10-14 13:04 ` Kent Gibson
2019-10-14 16:50 ` Bartosz Golaszewski
2019-10-15 0:58 ` Kent Gibson
2019-10-15 12:51 ` Bartosz Golaszewski
2019-10-16 1:01 ` Kent Gibson
2019-10-17 5:06 ` Kent Gibson
2019-10-18 8:03 ` Bartosz Golaszewski
2019-10-18 10:13 ` Kent Gibson
2019-10-21 14:57 ` Bartosz Golaszewski
2019-10-21 23:14 ` Kent Gibson
2019-10-22 3:11 ` Kent Gibson
2019-10-18 7:48 ` Bartosz Golaszewski
2019-10-18 9:42 ` Kent Gibson
2019-10-12 1:56 ` [PATCH v2 6/6] gpiolib: allow pull up/down on outputs Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014125457.GA28012@sol \
--to=warthog618@gmail.com \
--cc=bamv2005@gmail.com \
--cc=brgl@bgdev.pl \
--cc=drew@pdp7.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.