* [PATCH] drm/i915/execlists: Clear semaphore immediately upon ELSP promotion @ 2019-10-13 18:38 Chris Wilson 2019-10-14 16:15 ` ✗ Fi.CI.BAT: failure for " Patchwork 0 siblings, 1 reply; 2+ messages in thread From: Chris Wilson @ 2019-10-13 18:38 UTC (permalink / raw) To: intel-gfx There is no significance to our delay before clearing the semaphore the engine is waiting on, so release it as soon as we acknowledge the CS update following our preemption request. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_lrc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 16b878d35814..32a30d36eb7b 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -1903,6 +1903,9 @@ static void process_csb(struct intel_engine_cs *engine) else promote = gen8_csb_parse(execlists, buf + 2 * head); if (promote) { + if (!inject_preempt_hang(execlists)) + ring_set_paused(engine, 0); + /* cancel old inflight, prepare for switch */ trace_ports(execlists, "preempted", execlists->active); while (*execlists->active) @@ -1919,9 +1922,6 @@ static void process_csb(struct intel_engine_cs *engine) if (enable_timeslice(execlists)) mod_timer(&execlists->timer, jiffies + 1); - if (!inject_preempt_hang(execlists)) - ring_set_paused(engine, 0); - WRITE_ONCE(execlists->pending[0], NULL); } else { GEM_BUG_ON(!*execlists->active); -- 2.23.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 2+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/execlists: Clear semaphore immediately upon ELSP promotion 2019-10-13 18:38 [PATCH] drm/i915/execlists: Clear semaphore immediately upon ELSP promotion Chris Wilson @ 2019-10-14 16:15 ` Patchwork 0 siblings, 0 replies; 2+ messages in thread From: Patchwork @ 2019-10-14 16:15 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/execlists: Clear semaphore immediately upon ELSP promotion URL : https://patchwork.freedesktop.org/series/67955/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7086 -> Patchwork_14789 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_14789 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_14789, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14789/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_14789: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live_coherency: - fi-icl-u2: [PASS][1] -> [TIMEOUT][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-icl-u2/igt@i915_selftest@live_coherency.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14789/fi-icl-u2/igt@i915_selftest@live_coherency.html Known issues ------------ Here are the changes found in Patchwork_14789 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([fdo#111045] / [fdo#111096]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14789/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html * igt@vgem_basic@dmabuf-fence: - fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-icl-u3/igt@vgem_basic@dmabuf-fence.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14789/fi-icl-u3/igt@vgem_basic@dmabuf-fence.html #### Possible fixes #### * igt@gem_flink_basic@flink-lifetime: - fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14789/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html * igt@i915_module_load@reload: - fi-blb-e6850: [INCOMPLETE][9] ([fdo#107718]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-blb-e6850/igt@i915_module_load@reload.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14789/fi-blb-e6850/igt@i915_module_load@reload.html * igt@kms_busy@basic-flip-a: - {fi-tgl-u2}: [DMESG-WARN][11] ([fdo#111600]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7086/fi-tgl-u2/igt@kms_busy@basic-flip-a.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14789/fi-tgl-u2/igt@kms_busy@basic-flip-a.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600 [fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880 Participating hosts (52 -> 46) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7086 -> Patchwork_14789 CI-20190529: 20190529 CI_DRM_7086: cb64ca78fe223a03a902aa10ddbfb672ccad1630 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5225: 991ce4eede1c52f76378aebf162a13c20d6f6293 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14789: 331a8c3bc5fe3fe17edccf2ef38717183d5363b6 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 331a8c3bc5fe drm/i915/execlists: Clear semaphore immediately upon ELSP promotion == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14789/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-14 16:15 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-13 18:38 [PATCH] drm/i915/execlists: Clear semaphore immediately upon ELSP promotion Chris Wilson 2019-10-14 16:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.