All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: andmike@us.ibm.com, sukadev@linux.vnet.ibm.com,
	b.zolnierkie@samsung.com, benh@kernel.crashing.org,
	aik@linux.ibm.com, Ram Pai <linuxram@us.ibm.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, paulus@ozlabs.org,
	iommu@lists.linux-foundation.org, paul.burton@mips.com,
	mpe@ellerman.id.au, m.szyprowski@samsung.com,
	linuxppc-dev@lists.ozlabs.org, hch@lst.de,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 1/2] dma-mapping: Add dma_addr_is_phys_addr()
Date: Tue, 15 Oct 2019 09:31:04 +0200	[thread overview]
Message-ID: <20191015073104.GA32252__25733.4757408657$1571124689$gmane$org@lst.de> (raw)
In-Reply-To: <37609731-5539-b906-aa94-2ef0242795ac@arm.com>

On Mon, Oct 14, 2019 at 11:29:24AM +0100, Robin Murphy wrote:
>> However, I would like to see the commit message (and maybe the inline
>> comments) expanded a bit on what the distinction here is about.  Some
>> of the text from the next patch would be suitable, about DMA addresses
>> usually being in a different address space but not in the case of
>> bounce buffering.
>
> Right, this needs a much tighter definition. "DMA address happens to be a 
> valid physical address" is true of various IOMMU setups too, but I can't 
> believe it's meaningful in such cases.
>
> If what you actually want is "DMA is direct or SWIOTLB" - i.e. "DMA address 
> is physical address of DMA data (not necessarily the original buffer)" - 
> wouldn't dma_is_direct() suffice?

It would.  But drivers have absolutely no business knowing any of this.

  parent reply	other threads:[~2019-10-15  7:31 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12  1:25 [PATCH 0/2] virtio: Support encrypted memory on powerpc secure guests Ram Pai
2019-10-12  1:25 ` Ram Pai
2019-10-12  1:25 ` Ram Pai
2019-10-12  1:25 ` [PATCH 1/2] dma-mapping: Add dma_addr_is_phys_addr() Ram Pai
2019-10-12  1:25   ` Ram Pai
2019-10-12  1:25   ` Ram Pai
2019-10-12  1:25   ` [PATCH 2/2] virtio_ring: Use DMA API if memory is encrypted Ram Pai
2019-10-12  1:25     ` Ram Pai
2019-10-12  1:25     ` Ram Pai
2019-10-14  4:52     ` David Gibson
2019-10-14  4:52       ` David Gibson
2019-10-14  4:52       ` David Gibson
2019-10-14  4:52     ` David Gibson
2019-10-15  7:35     ` Christoph Hellwig
2019-10-15  7:35     ` Christoph Hellwig
2019-10-15  7:35       ` Christoph Hellwig
2019-10-15  7:35       ` Christoph Hellwig
2019-10-16  7:55       ` Ram Pai
2019-10-16  7:55       ` Ram Pai
2019-10-16  7:55         ` Ram Pai
2019-10-16  7:55         ` Ram Pai
2019-10-17  2:33       ` Jason Wang
2019-10-17  2:33       ` Jason Wang
2019-10-17  2:33         ` Jason Wang
2019-10-17  2:33         ` Jason Wang
2019-10-21  8:36       ` David Gibson
2019-10-21  8:36         ` David Gibson
2019-10-21  8:36         ` David Gibson
2019-10-21  8:36       ` David Gibson
2019-10-12  1:25   ` Ram Pai
2019-10-14  4:51   ` [PATCH 1/2] dma-mapping: Add dma_addr_is_phys_addr() David Gibson
2019-10-14  4:51     ` David Gibson
2019-10-14  4:51     ` David Gibson
2019-10-14 10:29     ` Robin Murphy
2019-10-14 10:29     ` Robin Murphy
2019-10-14 10:29       ` Robin Murphy
2019-10-14 10:29       ` Robin Murphy
2019-10-15  7:30       ` Ram Pai
2019-10-15  7:30         ` Ram Pai
2019-10-15  7:30         ` Ram Pai
2019-10-15  7:30         ` Ram Pai
2019-10-15  7:31       ` Christoph Hellwig [this message]
2019-10-15  7:31       ` Christoph Hellwig
2019-10-15  7:31         ` Christoph Hellwig
2019-10-15  7:31         ` Christoph Hellwig
2019-10-14  4:51   ` David Gibson
2019-10-12  1:25 ` Ram Pai
2019-10-12  1:36 ` [PATCH 0/2] virtio: Support encrypted memory on powerpc secure guests Ram Pai
2019-10-12  1:36 ` Ram Pai
2019-10-12  1:36   ` Ram Pai
2019-10-12  1:36   ` Ram Pai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20191015073104.GA32252__25733.4757408657$1571124689$gmane$org@lst.de' \
    --to=hch@lst.de \
    --cc=aik@linux.ibm.com \
    --cc=andmike@us.ibm.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=benh@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=linuxram@us.ibm.com \
    --cc=m.szyprowski@samsung.com \
    --cc=mpe@ellerman.id.au \
    --cc=paul.burton@mips.com \
    --cc=paulus@ozlabs.org \
    --cc=robin.murphy@arm.com \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.