All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Ram Pai <linuxram@us.ibm.com>
Cc: andmike@us.ibm.com, sukadev@linux.vnet.ibm.com,
	b.zolnierkie@samsung.com, benh@kernel.crashing.org,
	aik@linux.ibm.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, paulus@ozlabs.org,
	iommu@lists.linux-foundation.org, paul.burton@mips.com,
	mpe@ellerman.id.au, robin.murphy@arm.com,
	m.szyprowski@samsung.com, linuxppc-dev@lists.ozlabs.org,
	david@gibson.dropbear.id.au
Subject: Re: [PATCH 2/2] virtio_ring: Use DMA API if memory is encrypted
Date: Thu, 17 Oct 2019 10:33:59 +0800	[thread overview]
Message-ID: <398dce4b-9290-0b14-28b1-e521331ec309__40494.67792954$1571279666$gmane$org@redhat.com> (raw)
In-Reply-To: <20191015073501.GA32345@lst.de>


On 2019/10/15 下午3:35, Christoph Hellwig wrote:
> On Fri, Oct 11, 2019 at 06:25:19PM -0700, Ram Pai wrote:
>> From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>>
>> Normally, virtio enables DMA API with VIRTIO_F_IOMMU_PLATFORM, which must
>> be set by both device and guest driver. However, as a hack, when DMA API
>> returns physical addresses, guest driver can use the DMA API; even though
>> device does not set VIRTIO_F_IOMMU_PLATFORM and just uses physical
>> addresses.
> Sorry, but this is a complete bullshit hack.  Driver must always use
> the DMA API if they do DMA, and if virtio devices use physical addresses
> that needs to be returned through the platform firmware interfaces for
> the dma setup.  If you don't do that yet (which based on previous
> informations you don't), you need to fix it, and we can then quirk
> old implementations that already are out in the field.
>
> In other words: we finally need to fix that virtio mess and not pile
> hacks on top of hacks.


I agree, the only reason for IOMMU_PLATFORM is to make sure guest works 
for some old and buggy qemu when vIOMMU is enabled which seems useless 
(note we don't even support vIOMMU migration in that case).

Thanks

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2019-10-17  2:33 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12  1:25 [PATCH 0/2] virtio: Support encrypted memory on powerpc secure guests Ram Pai
2019-10-12  1:25 ` Ram Pai
2019-10-12  1:25 ` Ram Pai
2019-10-12  1:25 ` [PATCH 1/2] dma-mapping: Add dma_addr_is_phys_addr() Ram Pai
2019-10-12  1:25   ` Ram Pai
2019-10-12  1:25   ` Ram Pai
2019-10-12  1:25   ` [PATCH 2/2] virtio_ring: Use DMA API if memory is encrypted Ram Pai
2019-10-12  1:25     ` Ram Pai
2019-10-12  1:25     ` Ram Pai
2019-10-14  4:52     ` David Gibson
2019-10-14  4:52       ` David Gibson
2019-10-14  4:52       ` David Gibson
2019-10-14  4:52     ` David Gibson
2019-10-15  7:35     ` Christoph Hellwig
2019-10-15  7:35     ` Christoph Hellwig
2019-10-15  7:35       ` Christoph Hellwig
2019-10-15  7:35       ` Christoph Hellwig
2019-10-16  7:55       ` Ram Pai
2019-10-16  7:55       ` Ram Pai
2019-10-16  7:55         ` Ram Pai
2019-10-16  7:55         ` Ram Pai
2019-10-17  2:33       ` Jason Wang [this message]
2019-10-17  2:33       ` Jason Wang
2019-10-17  2:33         ` Jason Wang
2019-10-17  2:33         ` Jason Wang
2019-10-21  8:36       ` David Gibson
2019-10-21  8:36         ` David Gibson
2019-10-21  8:36         ` David Gibson
2019-10-21  8:36       ` David Gibson
2019-10-12  1:25   ` Ram Pai
2019-10-14  4:51   ` [PATCH 1/2] dma-mapping: Add dma_addr_is_phys_addr() David Gibson
2019-10-14  4:51     ` David Gibson
2019-10-14  4:51     ` David Gibson
2019-10-14 10:29     ` Robin Murphy
2019-10-14 10:29     ` Robin Murphy
2019-10-14 10:29       ` Robin Murphy
2019-10-14 10:29       ` Robin Murphy
2019-10-15  7:30       ` Ram Pai
2019-10-15  7:30         ` Ram Pai
2019-10-15  7:30         ` Ram Pai
2019-10-15  7:30         ` Ram Pai
2019-10-15  7:31       ` Christoph Hellwig
2019-10-15  7:31       ` Christoph Hellwig
2019-10-15  7:31         ` Christoph Hellwig
2019-10-15  7:31         ` Christoph Hellwig
2019-10-14  4:51   ` David Gibson
2019-10-12  1:25 ` Ram Pai
2019-10-12  1:36 ` [PATCH 0/2] virtio: Support encrypted memory on powerpc secure guests Ram Pai
2019-10-12  1:36 ` Ram Pai
2019-10-12  1:36   ` Ram Pai
2019-10-12  1:36   ` Ram Pai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='398dce4b-9290-0b14-28b1-e521331ec309__40494.67792954$1571279666$gmane$org@redhat.com' \
    --to=jasowang@redhat.com \
    --cc=aik@linux.ibm.com \
    --cc=andmike@us.ibm.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=benh@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=linuxram@us.ibm.com \
    --cc=m.szyprowski@samsung.com \
    --cc=mpe@ellerman.id.au \
    --cc=paul.burton@mips.com \
    --cc=paulus@ozlabs.org \
    --cc=robin.murphy@arm.com \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.