* [PATCH] drm/komeda: Dump SC_ENH_* registers from scaler block
@ 2019-10-15 11:00 ` Mihail Atanassov
0 siblings, 0 replies; 6+ messages in thread
From: Mihail Atanassov @ 2019-10-15 11:00 UTC (permalink / raw)
Cc: Mihail Atanassov, nd, Sean Paul, Maarten Lankhorst,
Maxime Ripard, james qian wang (Arm Technology China),
Liviu Dudau, Brian Starkey, David Airlie, Daniel Vetter,
Lowry Li (Arm Technology China),
dri-devel, linux-kernel
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
.../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
index c3d29c0b051b..7252fc387fba 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
@@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
{
- u32 v[9];
+ u32 v[10];
dump_block_header(sf, c->reg);
@@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
+
+ get_values_from_reg(c->reg, 0x130, 10, v);
+ seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
+ seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
+ seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
+ seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
+ seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
+ seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
+ seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
+ seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
+ seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
+ seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
}
static const struct komeda_component_funcs d71_scaler_funcs = {
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm/komeda: Dump SC_ENH_* registers from scaler block
@ 2019-10-15 11:00 ` Mihail Atanassov
0 siblings, 0 replies; 6+ messages in thread
From: Mihail Atanassov @ 2019-10-15 11:00 UTC (permalink / raw)
Cc: Mihail Atanassov, David Airlie, Liviu Dudau, linux-kernel,
james qian wang (Arm Technology China),
dri-devel, Lowry Li (Arm Technology China),
nd, Sean Paul
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
.../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
index c3d29c0b051b..7252fc387fba 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
@@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
{
- u32 v[9];
+ u32 v[10];
dump_block_header(sf, c->reg);
@@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
+
+ get_values_from_reg(c->reg, 0x130, 10, v);
+ seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
+ seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
+ seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
+ seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
+ seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
+ seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
+ seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
+ seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
+ seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
+ seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
}
static const struct komeda_component_funcs d71_scaler_funcs = {
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: drm/komeda: Dump SC_ENH_* registers from scaler block
2019-10-15 11:00 ` Mihail Atanassov
@ 2019-10-16 8:17 ` james qian wang (Arm Technology China)
-1 siblings, 0 replies; 6+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-10-16 8:17 UTC (permalink / raw)
To: Mihail Atanassov
Cc: David Airlie, Liviu Dudau, linux-kernel, dri-devel,
Lowry Li (Arm Technology China),
nd, Sean Paul
On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote:
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> index c3d29c0b051b..7252fc387fba 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> @@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
>
> static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> {
> - u32 v[9];
> + u32 v[10];
>
> dump_block_header(sf, c->reg);
>
> @@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
> seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
> seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
> +
> + get_values_from_reg(c->reg, 0x130, 10, v);
> + seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
> + seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
> + seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
> + seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
> + seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
> + seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
> + seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
> + seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
> + seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
> + seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
> }
>
Looks good to me.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> static const struct komeda_component_funcs d71_scaler_funcs = {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drm/komeda: Dump SC_ENH_* registers from scaler block
@ 2019-10-16 8:17 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 6+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-10-16 8:17 UTC (permalink / raw)
To: Mihail Atanassov
Cc: Lowry Li (Arm Technology China),
David Airlie, Liviu Dudau, linux-kernel, dri-devel, nd,
Sean Paul
On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote:
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
> .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> index c3d29c0b051b..7252fc387fba 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> @@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
>
> static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> {
> - u32 v[9];
> + u32 v[10];
>
> dump_block_header(sf, c->reg);
>
> @@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
> seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
> seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
> +
> + get_values_from_reg(c->reg, 0x130, 10, v);
> + seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
> + seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
> + seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
> + seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
> + seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
> + seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
> + seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
> + seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
> + seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
> + seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
> }
>
Looks good to me.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> static const struct komeda_component_funcs d71_scaler_funcs = {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drm/komeda: Dump SC_ENH_* registers from scaler block
2019-10-16 8:17 ` james qian wang (Arm Technology China)
@ 2019-10-21 13:42 ` Mihail Atanassov
-1 siblings, 0 replies; 6+ messages in thread
From: Mihail Atanassov @ 2019-10-21 13:42 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: David Airlie, Liviu Dudau, linux-kernel, dri-devel,
Lowry Li (Arm Technology China),
nd, Sean Paul
On Wednesday, 16 October 2019 09:17:39 BST james qian wang (Arm Technology China) wrote:
> On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote:
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > index c3d29c0b051b..7252fc387fba 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > @@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
> >
> > static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> > {
> > - u32 v[9];
> > + u32 v[10];
> >
> > dump_block_header(sf, c->reg);
> >
> > @@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> > seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
> > seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
> > seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
> > +
> > + get_values_from_reg(c->reg, 0x130, 10, v);
> > + seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
> > + seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
> > + seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
> > + seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
> > + seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
> > + seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
> > + seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
> > + seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
> > + seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
> > + seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
> > }
> >
>
> Looks good to me.
>
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Thanks, applied to drm-misc-next -
2b6f5883edcc47ef6146832112a0125810d28f78.
>
> > static const struct komeda_component_funcs d71_scaler_funcs = {
>
--
Mihail
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drm/komeda: Dump SC_ENH_* registers from scaler block
@ 2019-10-21 13:42 ` Mihail Atanassov
0 siblings, 0 replies; 6+ messages in thread
From: Mihail Atanassov @ 2019-10-21 13:42 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: Lowry Li (Arm Technology China),
David Airlie, Liviu Dudau, linux-kernel, dri-devel, nd,
Sean Paul
On Wednesday, 16 October 2019 09:17:39 BST james qian wang (Arm Technology China) wrote:
> On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote:
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > index c3d29c0b051b..7252fc387fba 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> > @@ -703,7 +703,7 @@ static void d71_scaler_update(struct komeda_component *c,
> >
> > static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> > {
> > - u32 v[9];
> > + u32 v[10];
> >
> > dump_block_header(sf, c->reg);
> >
> > @@ -723,6 +723,18 @@ static void d71_scaler_dump(struct komeda_component *c, struct seq_file *sf)
> > seq_printf(sf, "SC_H_DELTA_PH:\t\t0x%X\n", v[6]);
> > seq_printf(sf, "SC_V_INIT_PH:\t\t0x%X\n", v[7]);
> > seq_printf(sf, "SC_V_DELTA_PH:\t\t0x%X\n", v[8]);
> > +
> > + get_values_from_reg(c->reg, 0x130, 10, v);
> > + seq_printf(sf, "SC_ENH_LIMITS:\t\t0x%X\n", v[0]);
> > + seq_printf(sf, "SC_ENH_COEFF0:\t\t0x%X\n", v[1]);
> > + seq_printf(sf, "SC_ENH_COEFF1:\t\t0x%X\n", v[2]);
> > + seq_printf(sf, "SC_ENH_COEFF2:\t\t0x%X\n", v[3]);
> > + seq_printf(sf, "SC_ENH_COEFF3:\t\t0x%X\n", v[4]);
> > + seq_printf(sf, "SC_ENH_COEFF4:\t\t0x%X\n", v[5]);
> > + seq_printf(sf, "SC_ENH_COEFF5:\t\t0x%X\n", v[6]);
> > + seq_printf(sf, "SC_ENH_COEFF6:\t\t0x%X\n", v[7]);
> > + seq_printf(sf, "SC_ENH_COEFF7:\t\t0x%X\n", v[8]);
> > + seq_printf(sf, "SC_ENH_COEFF8:\t\t0x%X\n", v[9]);
> > }
> >
>
> Looks good to me.
>
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Thanks, applied to drm-misc-next -
2b6f5883edcc47ef6146832112a0125810d28f78.
>
> > static const struct komeda_component_funcs d71_scaler_funcs = {
>
--
Mihail
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-21 13:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 11:00 [PATCH] drm/komeda: Dump SC_ENH_* registers from scaler block Mihail Atanassov
2019-10-15 11:00 ` Mihail Atanassov
2019-10-16 8:17 ` james qian wang (Arm Technology China)
2019-10-16 8:17 ` james qian wang (Arm Technology China)
2019-10-21 13:42 ` Mihail Atanassov
2019-10-21 13:42 ` Mihail Atanassov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.