* [Buildroot] [PATCH 1/1] package/libopenssl: fix static build on x86_64
@ 2019-10-15 21:46 Fabrice Fontaine
2019-10-16 7:15 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2019-10-15 21:46 UTC (permalink / raw)
To: buildroot
Use no-asm when building statically on x86_64, see
https://github.com/openssl/openssl/issues/9839
Fixes:
- http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libopenssl/libopenssl.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk
index 4a430bcb4d..ff9b52a002 100644
--- a/package/libopenssl/libopenssl.mk
+++ b/package/libopenssl/libopenssl.mk
@@ -56,6 +56,10 @@ endif
ifeq ($(BR2_STATIC_LIBS),y)
# Use "gcc" minimalistic target to disable DSO
LIBOPENSSL_TARGET_ARCH = gcc
+# See https://github.com/openssl/openssl/issues/9839
+ifeq ($(ARCH),x86_64)
+LIBOPENSSL_TARGET_ARCH += no-asm
+endif
else
# Some architectures are optimized in OpenSSL
# Doesn't work for thumb-only (Cortex-M?)
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/libopenssl: fix static build on x86_64
2019-10-15 21:46 [Buildroot] [PATCH 1/1] package/libopenssl: fix static build on x86_64 Fabrice Fontaine
@ 2019-10-16 7:15 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-10-16 7:15 UTC (permalink / raw)
To: buildroot
On Tue, 15 Oct 2019 23:46:44 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Use no-asm when building statically on x86_64, see
> https://github.com/openssl/openssl/issues/9839
>
> Fixes:
> - http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Is the problem specific to x86-64 ? Reading the Github issue, the
OpenSSL developer apparently says that whenever the "generic"
architecture variants are used, no-asm should be passed as well. This
is not really what your patch is doing.
Could you clarify this ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-16 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 21:46 [Buildroot] [PATCH 1/1] package/libopenssl: fix static build on x86_64 Fabrice Fontaine
2019-10-16 7:15 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.