* [PATCH linux dev-5.3 0/3] AST2600 UARTs
@ 2019-10-16 11:59 Joel Stanley
2019-10-16 11:59 ` [PATCH linux dev-5.3 1/3] ARM: dts: aspeed-g6: Add remaining UARTs Joel Stanley
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Joel Stanley @ 2019-10-16 11:59 UTC (permalink / raw)
To: openbmc; +Cc: Andrew Jeffery
Add the rest of the AST2600 uarts and enable the workaround as suggested
by aspeed.
Joel Stanley (3):
ARM: dts: aspeed-g6: Add remaining UARTs
ARM: dts: aspeed: tacoma: Add UART1 and workaround
ARM: dts: ast2600evb: Enable UART workaround
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 5 ++
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 15 ++++--
arch/arm/boot/dts/aspeed-g6.dtsi | 60 +++++++++++++++++++++
3 files changed, 76 insertions(+), 4 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH linux dev-5.3 1/3] ARM: dts: aspeed-g6: Add remaining UARTs
2019-10-16 11:59 [PATCH linux dev-5.3 0/3] AST2600 UARTs Joel Stanley
@ 2019-10-16 11:59 ` Joel Stanley
2019-10-16 20:50 ` Eddie James
2019-10-16 11:59 ` [PATCH linux dev-5.3 2/3] ARM: dts: aspeed: tacoma: Add UART1 and workaround Joel Stanley
2019-10-16 11:59 ` [PATCH linux dev-5.3 3/3] ARM: dts: ast2600evb: Enable UART workaround Joel Stanley
2 siblings, 1 reply; 7+ messages in thread
From: Joel Stanley @ 2019-10-16 11:59 UTC (permalink / raw)
To: openbmc; +Cc: Andrew Jeffery
The AST2600 has five UARTs. Add UART 1 to 4.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
arch/arm/boot/dts/aspeed-g6.dtsi | 60 ++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 16dec4e08d8f..6db29ee769d5 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -28,6 +28,10 @@
i2c13 = &i2c13;
i2c14 = &i2c14;
i2c15 = &i2c15;
+ serial0 = &uart1;
+ serial1 = &uart2;
+ serial2 = &uart3;
+ serial3 = &uart4;
serial4 = &uart5;
serial5 = &vuart1;
serial6 = &vuart2;
@@ -306,6 +310,20 @@
status = "disabled";
};
+ uart1: serial@1e783000 {
+ compatible = "ns16550a";
+ reg = <0x1e783000 0x20>;
+ reg-shift = <2>;
+ reg-io-width = <4>;
+ interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_UART1CLK>;
+ resets = <&lpc_reset 4>;
+ no-loopback-test;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_txd1_default &pinctrl_rxd1_default>;
+ status = "disabled";
+ };
+
uart5: serial@1e784000 {
compatible = "ns16550a";
reg = <0x1e784000 0x1000>;
@@ -497,6 +515,48 @@
status = "disabled";
};
+ uart2: serial@1e78d000 {
+ compatible = "ns16550a";
+ reg = <0x1e78d000 0x20>;
+ reg-shift = <2>;
+ reg-io-width = <4>;
+ interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_UART2CLK>;
+ resets = <&lpc_reset 5>;
+ no-loopback-test;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>;
+ status = "disabled";
+ };
+
+ uart3: serial@1e78e000 {
+ compatible = "ns16550a";
+ reg = <0x1e78e000 0x20>;
+ reg-shift = <2>;
+ reg-io-width = <4>;
+ interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_UART3CLK>;
+ resets = <&lpc_reset 6>;
+ no-loopback-test;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_txd3_default &pinctrl_rxd3_default>;
+ status = "disabled";
+ };
+
+ uart4: serial@1e78f000 {
+ compatible = "ns16550a";
+ reg = <0x1e78f000 0x20>;
+ reg-shift = <2>;
+ reg-io-width = <4>;
+ interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&syscon ASPEED_CLK_GATE_UART4CLK>;
+ resets = <&lpc_reset 7>;
+ no-loopback-test;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_txd4_default &pinctrl_rxd4_default>;
+ status = "disabled";
+ };
+
i2c: bus@1e78a000 {
compatible = "simple-bus";
#address-cells = <1>;
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH linux dev-5.3 2/3] ARM: dts: aspeed: tacoma: Add UART1 and workaround
2019-10-16 11:59 [PATCH linux dev-5.3 0/3] AST2600 UARTs Joel Stanley
2019-10-16 11:59 ` [PATCH linux dev-5.3 1/3] ARM: dts: aspeed-g6: Add remaining UARTs Joel Stanley
@ 2019-10-16 11:59 ` Joel Stanley
2019-10-16 20:49 ` Eddie James
2019-10-16 11:59 ` [PATCH linux dev-5.3 3/3] ARM: dts: ast2600evb: Enable UART workaround Joel Stanley
2 siblings, 1 reply; 7+ messages in thread
From: Joel Stanley @ 2019-10-16 11:59 UTC (permalink / raw)
To: openbmc; +Cc: Andrew Jeffery
The UARTs on the AST2600 A0 have a known issue that can be worked around
by using the Synopsys driver.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
index cdc14773ddda..b38498a317ce 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
@@ -10,10 +10,6 @@
model = "Tacoma";
compatible = "ibm,tacoma-bmc", "aspeed,ast2600";
- aliases {
- serial4 = &uart5;
- };
-
chosen {
stdout-path = &uart5;
bootargs = "console=ttyS4,115200n8";
@@ -515,6 +511,17 @@
status = "okay";
};
+&uart1 {
+ status = "okay";
+ // Workaround for A0
+ compatible = "snps,dw-apb-uart";
+};
+
+&uart5 {
+ // Workaround for A0
+ compatible = "snps,dw-apb-uart";
+};
+
&vuart1 {
status = "okay";
};
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH linux dev-5.3 3/3] ARM: dts: ast2600evb: Enable UART workaround
2019-10-16 11:59 [PATCH linux dev-5.3 0/3] AST2600 UARTs Joel Stanley
2019-10-16 11:59 ` [PATCH linux dev-5.3 1/3] ARM: dts: aspeed-g6: Add remaining UARTs Joel Stanley
2019-10-16 11:59 ` [PATCH linux dev-5.3 2/3] ARM: dts: aspeed: tacoma: Add UART1 and workaround Joel Stanley
@ 2019-10-16 11:59 ` Joel Stanley
2019-10-16 20:48 ` Eddie James
2 siblings, 1 reply; 7+ messages in thread
From: Joel Stanley @ 2019-10-16 11:59 UTC (permalink / raw)
To: openbmc; +Cc: Andrew Jeffery
The UART has an issue on A0 that can be worked around by using the
Synopsis driver.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
index 0392e9162f11..94fe2611fe76 100644
--- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
+++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
@@ -151,3 +151,8 @@
spi-max-frequency = <100000000>;
};
};
+
+&uart5 {
+ // Workaround for A0
+ compatible = "snps,dw-apb-uart";
+};
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-5.3 3/3] ARM: dts: ast2600evb: Enable UART workaround
2019-10-16 11:59 ` [PATCH linux dev-5.3 3/3] ARM: dts: ast2600evb: Enable UART workaround Joel Stanley
@ 2019-10-16 20:48 ` Eddie James
0 siblings, 0 replies; 7+ messages in thread
From: Eddie James @ 2019-10-16 20:48 UTC (permalink / raw)
To: Joel Stanley, openbmc; +Cc: Andrew Jeffery
On 10/16/19 6:59 AM, Joel Stanley wrote:
> The UART has an issue on A0 that can be worked around by using the
> Synopsis driver.
Tested-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-ast2600-evb.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> index 0392e9162f11..94fe2611fe76 100644
> --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> @@ -151,3 +151,8 @@
> spi-max-frequency = <100000000>;
> };
> };
> +
> +&uart5 {
> + // Workaround for A0
> + compatible = "snps,dw-apb-uart";
> +};
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-5.3 2/3] ARM: dts: aspeed: tacoma: Add UART1 and workaround
2019-10-16 11:59 ` [PATCH linux dev-5.3 2/3] ARM: dts: aspeed: tacoma: Add UART1 and workaround Joel Stanley
@ 2019-10-16 20:49 ` Eddie James
0 siblings, 0 replies; 7+ messages in thread
From: Eddie James @ 2019-10-16 20:49 UTC (permalink / raw)
To: Joel Stanley, openbmc; +Cc: Andrew Jeffery
On 10/16/19 6:59 AM, Joel Stanley wrote:
> The UARTs on the AST2600 A0 have a known issue that can be worked around
> by using the Synopsys driver.
Tested-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> index cdc14773ddda..b38498a317ce 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> @@ -10,10 +10,6 @@
> model = "Tacoma";
> compatible = "ibm,tacoma-bmc", "aspeed,ast2600";
>
> - aliases {
> - serial4 = &uart5;
> - };
> -
> chosen {
> stdout-path = &uart5;
> bootargs = "console=ttyS4,115200n8";
> @@ -515,6 +511,17 @@
> status = "okay";
> };
>
> +&uart1 {
> + status = "okay";
> + // Workaround for A0
> + compatible = "snps,dw-apb-uart";
> +};
> +
> +&uart5 {
> + // Workaround for A0
> + compatible = "snps,dw-apb-uart";
> +};
> +
> &vuart1 {
> status = "okay";
> };
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH linux dev-5.3 1/3] ARM: dts: aspeed-g6: Add remaining UARTs
2019-10-16 11:59 ` [PATCH linux dev-5.3 1/3] ARM: dts: aspeed-g6: Add remaining UARTs Joel Stanley
@ 2019-10-16 20:50 ` Eddie James
0 siblings, 0 replies; 7+ messages in thread
From: Eddie James @ 2019-10-16 20:50 UTC (permalink / raw)
To: Joel Stanley, openbmc; +Cc: Andrew Jeffery
On 10/16/19 6:59 AM, Joel Stanley wrote:
> The AST2600 has five UARTs. Add UART 1 to 4.
Tested-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-g6.dtsi | 60 ++++++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 16dec4e08d8f..6db29ee769d5 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -28,6 +28,10 @@
> i2c13 = &i2c13;
> i2c14 = &i2c14;
> i2c15 = &i2c15;
> + serial0 = &uart1;
> + serial1 = &uart2;
> + serial2 = &uart3;
> + serial3 = &uart4;
> serial4 = &uart5;
> serial5 = &vuart1;
> serial6 = &vuart2;
> @@ -306,6 +310,20 @@
> status = "disabled";
> };
>
> + uart1: serial@1e783000 {
> + compatible = "ns16550a";
> + reg = <0x1e783000 0x20>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_UART1CLK>;
> + resets = <&lpc_reset 4>;
> + no-loopback-test;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_txd1_default &pinctrl_rxd1_default>;
> + status = "disabled";
> + };
> +
> uart5: serial@1e784000 {
> compatible = "ns16550a";
> reg = <0x1e784000 0x1000>;
> @@ -497,6 +515,48 @@
> status = "disabled";
> };
>
> + uart2: serial@1e78d000 {
> + compatible = "ns16550a";
> + reg = <0x1e78d000 0x20>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_UART2CLK>;
> + resets = <&lpc_reset 5>;
> + no-loopback-test;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>;
> + status = "disabled";
> + };
> +
> + uart3: serial@1e78e000 {
> + compatible = "ns16550a";
> + reg = <0x1e78e000 0x20>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_UART3CLK>;
> + resets = <&lpc_reset 6>;
> + no-loopback-test;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_txd3_default &pinctrl_rxd3_default>;
> + status = "disabled";
> + };
> +
> + uart4: serial@1e78f000 {
> + compatible = "ns16550a";
> + reg = <0x1e78f000 0x20>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_UART4CLK>;
> + resets = <&lpc_reset 7>;
> + no-loopback-test;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_txd4_default &pinctrl_rxd4_default>;
> + status = "disabled";
> + };
> +
> i2c: bus@1e78a000 {
> compatible = "simple-bus";
> #address-cells = <1>;
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-16 20:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 11:59 [PATCH linux dev-5.3 0/3] AST2600 UARTs Joel Stanley
2019-10-16 11:59 ` [PATCH linux dev-5.3 1/3] ARM: dts: aspeed-g6: Add remaining UARTs Joel Stanley
2019-10-16 20:50 ` Eddie James
2019-10-16 11:59 ` [PATCH linux dev-5.3 2/3] ARM: dts: aspeed: tacoma: Add UART1 and workaround Joel Stanley
2019-10-16 20:49 ` Eddie James
2019-10-16 11:59 ` [PATCH linux dev-5.3 3/3] ARM: dts: ast2600evb: Enable UART workaround Joel Stanley
2019-10-16 20:48 ` Eddie James
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.