From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [alexandrebelloni:rtc-misc 34/39] drivers/rtc/rtc-cros-ec.c:112 cros_ec_rtc_set_time() error: uninitialized symbol 'time'.
Date: Wed, 16 Oct 2019 15:32:14 +0300 [thread overview]
Message-ID: <20191016123214.GH21344@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 2331 bytes --]
tree: https://github.com/alexandrebelloni/linux rtc-misc
head: bb9a5d739ffaf1c6f33d267e865c02b123b4792f
commit: f8d8bea4a97442957ea627754319f0b7a05f399c [34/39] rtc: cros-ec: let the core handle rtc range
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/rtc/rtc-cros-ec.c:112 cros_ec_rtc_set_time() error: uninitialized symbol 'time'.
# https://github.com/alexandrebelloni/linux/commit/f8d8bea4a97442957ea627754319f0b7a05f399c
git remote add alexandrebelloni https://github.com/alexandrebelloni/linux
git remote update alexandrebelloni
git checkout f8d8bea4a97442957ea627754319f0b7a05f399c
vim +/time +112 drivers/rtc/rtc-cros-ec.c
6f2a71a31afd73 Stephen Barber 2017-11-10 104 /* Set the current EC time. */
6f2a71a31afd73 Stephen Barber 2017-11-10 105 static int cros_ec_rtc_set_time(struct device *dev, struct rtc_time *tm)
6f2a71a31afd73 Stephen Barber 2017-11-10 106 {
6f2a71a31afd73 Stephen Barber 2017-11-10 107 struct cros_ec_rtc *cros_ec_rtc = dev_get_drvdata(dev);
6f2a71a31afd73 Stephen Barber 2017-11-10 108 struct cros_ec_device *cros_ec = cros_ec_rtc->cros_ec;
6f2a71a31afd73 Stephen Barber 2017-11-10 109 int ret;
6f2a71a31afd73 Stephen Barber 2017-11-10 110 time64_t time;
^^^^^^^^^^^^^
Part of the commit is missing?
6f2a71a31afd73 Stephen Barber 2017-11-10 111
6f2a71a31afd73 Stephen Barber 2017-11-10 @112 ret = cros_ec_rtc_set(cros_ec, EC_CMD_RTC_SET_VALUE, (u32)time);
^^^^^^^^^
6f2a71a31afd73 Stephen Barber 2017-11-10 113 if (ret < 0) {
6f2a71a31afd73 Stephen Barber 2017-11-10 114 dev_err(dev, "error setting time: %d\n", ret);
6f2a71a31afd73 Stephen Barber 2017-11-10 115 return ret;
6f2a71a31afd73 Stephen Barber 2017-11-10 116 }
6f2a71a31afd73 Stephen Barber 2017-11-10 117
6f2a71a31afd73 Stephen Barber 2017-11-10 118 return 0;
6f2a71a31afd73 Stephen Barber 2017-11-10 119 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [alexandrebelloni:rtc-misc 34/39] drivers/rtc/rtc-cros-ec.c:112 cros_ec_rtc_set_time() error: uninitialized symbol 'time'.
Date: Wed, 16 Oct 2019 15:32:14 +0300 [thread overview]
Message-ID: <20191016123214.GH21344@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 2331 bytes --]
tree: https://github.com/alexandrebelloni/linux rtc-misc
head: bb9a5d739ffaf1c6f33d267e865c02b123b4792f
commit: f8d8bea4a97442957ea627754319f0b7a05f399c [34/39] rtc: cros-ec: let the core handle rtc range
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/rtc/rtc-cros-ec.c:112 cros_ec_rtc_set_time() error: uninitialized symbol 'time'.
# https://github.com/alexandrebelloni/linux/commit/f8d8bea4a97442957ea627754319f0b7a05f399c
git remote add alexandrebelloni https://github.com/alexandrebelloni/linux
git remote update alexandrebelloni
git checkout f8d8bea4a97442957ea627754319f0b7a05f399c
vim +/time +112 drivers/rtc/rtc-cros-ec.c
6f2a71a31afd73 Stephen Barber 2017-11-10 104 /* Set the current EC time. */
6f2a71a31afd73 Stephen Barber 2017-11-10 105 static int cros_ec_rtc_set_time(struct device *dev, struct rtc_time *tm)
6f2a71a31afd73 Stephen Barber 2017-11-10 106 {
6f2a71a31afd73 Stephen Barber 2017-11-10 107 struct cros_ec_rtc *cros_ec_rtc = dev_get_drvdata(dev);
6f2a71a31afd73 Stephen Barber 2017-11-10 108 struct cros_ec_device *cros_ec = cros_ec_rtc->cros_ec;
6f2a71a31afd73 Stephen Barber 2017-11-10 109 int ret;
6f2a71a31afd73 Stephen Barber 2017-11-10 110 time64_t time;
^^^^^^^^^^^^^
Part of the commit is missing?
6f2a71a31afd73 Stephen Barber 2017-11-10 111
6f2a71a31afd73 Stephen Barber 2017-11-10 @112 ret = cros_ec_rtc_set(cros_ec, EC_CMD_RTC_SET_VALUE, (u32)time);
^^^^^^^^^
6f2a71a31afd73 Stephen Barber 2017-11-10 113 if (ret < 0) {
6f2a71a31afd73 Stephen Barber 2017-11-10 114 dev_err(dev, "error setting time: %d\n", ret);
6f2a71a31afd73 Stephen Barber 2017-11-10 115 return ret;
6f2a71a31afd73 Stephen Barber 2017-11-10 116 }
6f2a71a31afd73 Stephen Barber 2017-11-10 117
6f2a71a31afd73 Stephen Barber 2017-11-10 118 return 0;
6f2a71a31afd73 Stephen Barber 2017-11-10 119 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next reply other threads:[~2019-10-16 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 12:32 Dan Carpenter [this message]
2019-10-16 12:32 ` [alexandrebelloni:rtc-misc 34/39] drivers/rtc/rtc-cros-ec.c:112 cros_ec_rtc_set_time() error: uninitialized symbol 'time' Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016123214.GH21344@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.