All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ben.dooks@codethink.co.uk
Cc: linux-kernel@lists.codethink.co.uk, peppe.cavallaro@st.com,
	alexandre.torgue@st.com, joabreu@synopsys.com,
	mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: fix argument to stmmac_pcs_ctrl_ane()
Date: Thu, 17 Oct 2019 15:31:50 -0400 (EDT)	[thread overview]
Message-ID: <20191017.153150.1433354673381849692.davem@davemloft.net> (raw)
In-Reply-To: <20191016082205.26899-1-ben.dooks@codethink.co.uk>

From: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Date: Wed, 16 Oct 2019 09:22:05 +0100

> The stmmac_pcs_ctrl_ane() expects a register address as
> argument 1, but for some reason the mac_device_info is
> being passed.
> 
> Fix the warning (and possible bug) from sparse:
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17:    expected void [noderef] <asn:2> *ioaddr
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17:    got struct mac_device_info *hw
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Applied, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: ben.dooks@codethink.co.uk
Cc: linux-kernel@lists.codethink.co.uk, alexandre.torgue@st.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
	peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: stmmac: fix argument to stmmac_pcs_ctrl_ane()
Date: Thu, 17 Oct 2019 15:31:50 -0400 (EDT)	[thread overview]
Message-ID: <20191017.153150.1433354673381849692.davem@davemloft.net> (raw)
In-Reply-To: <20191016082205.26899-1-ben.dooks@codethink.co.uk>

From: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Date: Wed, 16 Oct 2019 09:22:05 +0100

> The stmmac_pcs_ctrl_ane() expects a register address as
> argument 1, but for some reason the mac_device_info is
> being passed.
> 
> Fix the warning (and possible bug) from sparse:
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17:    expected void [noderef] <asn:2> *ioaddr
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17:    got struct mac_device_info *hw
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-10-17 19:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16  8:22 [PATCH] net: stmmac: fix argument to stmmac_pcs_ctrl_ane() Ben Dooks (Codethink)
2019-10-16  8:22 ` Ben Dooks (Codethink)
2019-10-16  8:43 ` Ben Dooks
2019-10-16  8:43   ` Ben Dooks
2019-10-16 20:28 ` David Miller
2019-10-16 20:28   ` David Miller
2019-10-17  7:40   ` Ben Dooks
2019-10-17  7:40     ` Ben Dooks
2019-10-17 19:31 ` David Miller [this message]
2019-10-17 19:31   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2019-10-15 16:23 Ben Dooks (Codethink)
2019-10-15 16:23 ` Ben Dooks (Codethink)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017.153150.1433354673381849692.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexandre.torgue@st.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=joabreu@synopsys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.