* [Buildroot] [RFC PATCH v2 01/30] pkgconf: Split pkgconf command into multi-line
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 02/30] pkgconf: Add pkgconf system lib and include path Michael Drake
` (29 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Thomas Preston <thomas.preston@codethink.co.uk>
The pkgconf command is a long and confusing line, which is about to get
longer. Split it up into logical stages so that it is easier to
visualise changes.
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/pkgconf/pkg-config.in | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/pkgconf/pkg-config.in b/package/pkgconf/pkg-config.in
index 99c0add8fb..8795f64b68 100644
--- a/package/pkgconf/pkg-config.in
+++ b/package/pkgconf/pkg-config.in
@@ -2,4 +2,7 @@
PKGCONFDIR=$(dirname $0)
DEFAULT_PKG_CONFIG_LIBDIR=${PKGCONFDIR}/../@STAGING_SUBDIR@/usr/lib/pkgconfig:${PKGCONFDIR}/../@STAGING_SUBDIR@/usr/share/pkgconfig
DEFAULT_PKG_CONFIG_SYSROOT_DIR=${PKGCONFDIR}/../@STAGING_SUBDIR@
-PKG_CONFIG_LIBDIR=${PKG_CONFIG_LIBDIR:-${DEFAULT_PKG_CONFIG_LIBDIR}} PKG_CONFIG_SYSROOT_DIR=${PKG_CONFIG_SYSROOT_DIR:-${DEFAULT_PKG_CONFIG_SYSROOT_DIR}} exec ${PKGCONFDIR}/pkgconf @STATIC@ "$@"
+
+PKG_CONFIG_LIBDIR=${PKG_CONFIG_LIBDIR:-${DEFAULT_PKG_CONFIG_LIBDIR}} \
+ PKG_CONFIG_SYSROOT_DIR=${PKG_CONFIG_SYSROOT_DIR:-${DEFAULT_PKG_CONFIG_SYSROOT_DIR}} \
+ exec ${PKGCONFDIR}/pkgconf @STATIC@ "$@"
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 02/30] pkgconf: Add pkgconf system lib and include path
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 01/30] pkgconf: Split pkgconf command into multi-line Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 03/30] package/libkrb5: Add host tools package Michael Drake
` (28 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Thomas Preston <thomas.preston@codethink.co.uk>
Buildroot does not reconfigure pkgconf system library and system include
dirs to STAGING_DIR. This means that pkgconf prints the sysroot system
library and system include dirs instead of letting the compiler handle
the logical sysroot. This breaks the -isystem compiler flag, as it
increases the priority of the system library and system include
directories. For example:
$ output/host/bin/pkg-config --cflags glib-2.0
-Ioutput/host/bin/../x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0
-Ioutput/host/bin/../x86_64-buildroot-linux-gnu/sysroot/usr/lib/glib-2.0/include
-Ioutput/host/bin/../x86_64-buildroot-linux-gnu/sysroot/usr/include
A header in `.../sysroot/usr/include` will be included before a header
in any directory specified with -isystem flags. Specifically, this
breaks the Chromium build system, which expects a C++ math.h in a
bundled LLVM C++ library, and gets a GNU C math.h instead.
Fix this by telling pkgconf about the sysroot's system library and
system include directories, so that it doesn't accidentally print them.
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/pkgconf/pkg-config.in | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/package/pkgconf/pkg-config.in b/package/pkgconf/pkg-config.in
index 8795f64b68..894069c492 100644
--- a/package/pkgconf/pkg-config.in
+++ b/package/pkgconf/pkg-config.in
@@ -1,8 +1,12 @@
#!/bin/sh
PKGCONFDIR=$(dirname $0)
+DEFAULT_PKG_CONFIG_SYSTEM_LIBRARY_PATH=${PKGCONFDIR}/../@STAGING_SUBDIR@/usr/lib
+DEFAULT_PKG_CONFIG_SYSTEM_INCLUDE_PATH=${PKGCONFDIR}/../@STAGING_SUBDIR@/usr/include
DEFAULT_PKG_CONFIG_LIBDIR=${PKGCONFDIR}/../@STAGING_SUBDIR@/usr/lib/pkgconfig:${PKGCONFDIR}/../@STAGING_SUBDIR@/usr/share/pkgconfig
DEFAULT_PKG_CONFIG_SYSROOT_DIR=${PKGCONFDIR}/../@STAGING_SUBDIR@
-PKG_CONFIG_LIBDIR=${PKG_CONFIG_LIBDIR:-${DEFAULT_PKG_CONFIG_LIBDIR}} \
+PKG_CONFIG_SYSTEM_LIBRARY_PATH=${PKG_CONFIG_SYSTEM_LIBRARY_PATH:-${DEFAULT_PKG_CONFIG_SYSTEM_LIBRARY_PATH}} \
+ PKG_CONFIG_SYSTEM_INCLUDE_PATH=${PKG_CONFIG_SYSTEM_INCLUDE_PATH:-${DEFAULT_PKG_CONFIG_SYSTEM_INCLUDE_PATH}} \
+ PKG_CONFIG_LIBDIR=${PKG_CONFIG_LIBDIR:-${DEFAULT_PKG_CONFIG_LIBDIR}} \
PKG_CONFIG_SYSROOT_DIR=${PKG_CONFIG_SYSROOT_DIR:-${DEFAULT_PKG_CONFIG_SYSROOT_DIR}} \
exec ${PKGCONFDIR}/pkgconf @STATIC@ "$@"
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 03/30] package/libkrb5: Add host tools package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 01/30] pkgconf: Split pkgconf command into multi-line Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 02/30] pkgconf: Add pkgconf system lib and include path Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 04/30] jpeg-turbo: Add host install Michael Drake
` (27 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/libkrb5/libkrb5.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
index 56345416aa..43b15f0c13 100644
--- a/package/libkrb5/libkrb5.mk
+++ b/package/libkrb5/libkrb5.mk
@@ -58,3 +58,4 @@ LIBKRB5_CONF_OPTS += --disable-thread-support
endif
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 04/30] jpeg-turbo: Add host install
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (2 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 03/30] package/libkrb5: Add host tools package Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 05/30] llvm: add config to build backend for host arch Michael Drake
` (26 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Thomas Preston <thomas.preston@codethink.co.uk>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/jpeg-turbo/jpeg-turbo.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/jpeg-turbo/jpeg-turbo.mk b/package/jpeg-turbo/jpeg-turbo.mk
index 3735132b2e..aafcc6c222 100644
--- a/package/jpeg-turbo/jpeg-turbo.mk
+++ b/package/jpeg-turbo/jpeg-turbo.mk
@@ -38,3 +38,4 @@ endef
JPEG_TURBO_POST_INSTALL_TARGET_HOOKS += JPEG_TURBO_REMOVE_USELESS_TOOLS
$(eval $(cmake-package))
+$(eval $(host-cmake-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 05/30] llvm: add config to build backend for host arch
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (3 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 04/30] jpeg-turbo: Add host install Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-19 22:04 ` Arnout Vandecappelle
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 06/30] lld: new package Michael Drake
` (25 subsequent siblings)
30 siblings, 1 reply; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Joseph Kogut <joseph.kogut@gmail.com>
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/Config.in.host | 1 +
package/llvm/Config.in.host | 18 ++++++++++++++++++
package/llvm/llvm.mk | 9 ++++++++-
3 files changed, 27 insertions(+), 1 deletion(-)
create mode 100644 package/llvm/Config.in.host
diff --git a/package/Config.in.host b/package/Config.in.host
index 1501889b72..3122f5abca 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -34,6 +34,7 @@ menu "Host utilities"
source "package/jq/Config.in.host"
source "package/jsmin/Config.in.host"
source "package/libp11/Config.in.host"
+ source "package/llvm/Config.in.host"
source "package/lpc3250loader/Config.in.host"
source "package/lttng-babeltrace/Config.in.host"
source "package/mender-artifact/Config.in.host"
diff --git a/package/llvm/Config.in.host b/package/llvm/Config.in.host
new file mode 100644
index 0000000000..4d73fb8c75
--- /dev/null
+++ b/package/llvm/Config.in.host
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_HOST_LLVM
+ bool "host llvm"
+ depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
+ depends on BR2_HOST_GCC_AT_LEAST_4_8
+ help
+ The LLVM Project is a collection of modular and reusable
+ compiler and toolchain technologies.
+
+ http://llvm.org
+
+config BR2_PACKAGE_HOST_LLVM_HOST_ARCH
+ string
+ default "AArch64" if BR2_HOSTARCH="aarch64"
+ default "X86" if BR2_HOSTARCH = "x86" || BR2_HOSTARCH = "x86_64"
+ default "ARM" if BR2_HOSTARCH = "arm"
+
+config BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH
+ bool
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index 3c62285188..5c413064c0 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -41,8 +41,9 @@ HOST_LLVM_CONF_OPTS += -DCMAKE_INSTALL_RPATH="$(HOST_DIR)/lib"
LLVM_TARGET_ARCH = $(call qstrip,$(BR2_PACKAGE_LLVM_TARGET_ARCH))
# Build backend for target architecture. This include backends like AMDGPU.
+HOST_LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
-HOST_LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
+HOST_LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(HOST_LLVM_TARGETS_TO_BUILD))"
LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
# LLVM target to use for native code generation. This is required for JIT generation.
@@ -58,9 +59,15 @@ LLVM_CONF_OPTS += -DLLVM_TARGET_ARCH=$(LLVM_TARGET_ARCH)
# output only $(LLVM_TARGET_ARCH) if not, and mesa3d won't build as
# it thinks AMDGPU backend is not installed on the target.
ifeq ($(BR2_PACKAGE_LLVM_AMDGPU),y)
+HOST_LLVM_TARGETS_TO_BUILD += AMDGPU
LLVM_TARGETS_TO_BUILD += AMDGPU
endif
+# Build backend for host architecture
+ifeq ($(BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH),y)
+HOST_LLVM_TARGETS_TO_BUILD += $(call qstrip,$(BR2_PACKAGE_HOST_LLVM_HOST_ARCH))
+endif
+
# Use native llvm-tblgen from host-llvm (needed for cross-compilation)
LLVM_CONF_OPTS += -DLLVM_TABLEGEN=$(HOST_DIR)/bin/llvm-tblgen
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 05/30] llvm: add config to build backend for host arch
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 05/30] llvm: add config to build backend for host arch Michael Drake
@ 2019-10-19 22:04 ` Arnout Vandecappelle
2019-10-19 22:20 ` Arnout Vandecappelle
0 siblings, 1 reply; 52+ messages in thread
From: Arnout Vandecappelle @ 2019-10-19 22:04 UTC (permalink / raw)
To: buildroot
On 17/10/2019 17:29, Michael Drake wrote:
> From: Joseph Kogut <joseph.kogut@gmail.com>
We need a bit more explanation why this option is useful/needed.
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
> ---
> package/Config.in.host | 1 +
> package/llvm/Config.in.host | 18 ++++++++++++++++++
> package/llvm/llvm.mk | 9 ++++++++-
> 3 files changed, 27 insertions(+), 1 deletion(-)
> create mode 100644 package/llvm/Config.in.host
>
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 1501889b72..3122f5abca 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -34,6 +34,7 @@ menu "Host utilities"
> source "package/jq/Config.in.host"
> source "package/jsmin/Config.in.host"
> source "package/libp11/Config.in.host"
> + source "package/llvm/Config.in.host"
> source "package/lpc3250loader/Config.in.host"
> source "package/lttng-babeltrace/Config.in.host"
> source "package/mender-artifact/Config.in.host"
> diff --git a/package/llvm/Config.in.host b/package/llvm/Config.in.host
> new file mode 100644
> index 0000000000..4d73fb8c75
> --- /dev/null
> +++ b/package/llvm/Config.in.host
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_HOST_LLVM
> + bool "host llvm"
> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
Why does host llvm depend on target architecture? Yes, if you want to use it to
build something for the target, obviously that is needed. But you might just as
well need host-llvm for building some host tool, so I don't think this depends
is appropriate here.
You do need a condition that the host arch is supported. That can be as simple as
depends on BR2_PACKAGE_HOST_LLVM_HOST_ARCH != ""
> + depends on BR2_HOST_GCC_AT_LEAST_4_8
> + help
> + The LLVM Project is a collection of modular and reusable
> + compiler and toolchain technologies.
> +
> + http://llvm.org
> +
> +config BR2_PACKAGE_HOST_LLVM_HOST_ARCH
> + string
> + default "AArch64" if BR2_HOSTARCH="aarch64"
> + default "X86" if BR2_HOSTARCH = "x86" || BR2_HOSTARCH = "x86_64"
> + default "ARM" if BR2_HOSTARCH = "arm"
> +
> +config BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH
> + bool
Is it worth making a symbol for this? It would make more sense to always enable
it IMO.
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index 3c62285188..5c413064c0 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -41,8 +41,9 @@ HOST_LLVM_CONF_OPTS += -DCMAKE_INSTALL_RPATH="$(HOST_DIR)/lib"
> LLVM_TARGET_ARCH = $(call qstrip,$(BR2_PACKAGE_LLVM_TARGET_ARCH))
>
> # Build backend for target architecture. This include backends like AMDGPU.
> +HOST_LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
Okay, *this* shows that you need the arch dependency. Still, I think it's more
appropriate to add that dependency here, i.e. only add the target architecture
if it is supported.
Also, this assignment should move down to where the host architecture is set.
> LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
> -HOST_LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
> +HOST_LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(HOST_LLVM_TARGETS_TO_BUILD))"
Ah, now I see, there was already a host-llvm that would build for the target...
I think the appropriate thing to do is a whole lot simpler:
HOST_LLVM_TARGETS_TO_BUILD = \
$(LLVM_TARGETS_TO_BUILD) \
$(call qstrip,$(BR2_PACKAGE_HOST_LLVM_HOST_ARCH))
No Config.in option needed as far as I'm concerned... Unless it makes a
significant difference in build time, but I doubt that.
Note that the above doesn't even need to take into account a non-supported host
arch, because in that case BR2_PACKAGE_HOST_LLVM_HOST_ARCH will be empty so
nothing is added.
Regards,
Arnout
> LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
>
> # LLVM target to use for native code generation. This is required for JIT generation.
> @@ -58,9 +59,15 @@ LLVM_CONF_OPTS += -DLLVM_TARGET_ARCH=$(LLVM_TARGET_ARCH)
> # output only $(LLVM_TARGET_ARCH) if not, and mesa3d won't build as
> # it thinks AMDGPU backend is not installed on the target.
> ifeq ($(BR2_PACKAGE_LLVM_AMDGPU),y)
> +HOST_LLVM_TARGETS_TO_BUILD += AMDGPU
> LLVM_TARGETS_TO_BUILD += AMDGPU
> endif
>
> +# Build backend for host architecture
> +ifeq ($(BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH),y)
> +HOST_LLVM_TARGETS_TO_BUILD += $(call qstrip,$(BR2_PACKAGE_HOST_LLVM_HOST_ARCH))
> +endif
> +
> # Use native llvm-tblgen from host-llvm (needed for cross-compilation)
> LLVM_CONF_OPTS += -DLLVM_TABLEGEN=$(HOST_DIR)/bin/llvm-tblgen
>
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 05/30] llvm: add config to build backend for host arch
2019-10-19 22:04 ` Arnout Vandecappelle
@ 2019-10-19 22:20 ` Arnout Vandecappelle
2019-11-05 12:02 ` Thomas Preston
0 siblings, 1 reply; 52+ messages in thread
From: Arnout Vandecappelle @ 2019-10-19 22:20 UTC (permalink / raw)
To: buildroot
On 20/10/2019 00:04, Arnout Vandecappelle wrote:
>
> On 17/10/2019 17:29, Michael Drake wrote:
>> From: Joseph Kogut <joseph.kogut@gmail.com>
> We need a bit more explanation why this option is useful/needed.
>
>
>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
>> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
I think I should clarify my review a little...
I think this should be split into two patches, where I doubt the second one is
relevant:
1. Add the host arch as a target for the host-llvm build. I think this can be
done unconditionally, which makes the patch a whole lot simpler.
2. Add a Config.in.host option for llvm. This is only useful if you want to use
host-llvm outside of Buildroot, in a post-build/image script. I don't think this
is the case.
If the patch is reduced to the first bit, then I think the
BR2_PACKAGE_HOST_LLVM_HOST_ARCH symbol (the only bit remaining in
Config.in.host) should move to Config.in. And the change to the .mk file becomes
very simple, as I indicated.
Regards,
Arnout
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 05/30] llvm: add config to build backend for host arch
2019-10-19 22:20 ` Arnout Vandecappelle
@ 2019-11-05 12:02 ` Thomas Preston
2019-11-07 21:22 ` Romain Naour
0 siblings, 1 reply; 52+ messages in thread
From: Thomas Preston @ 2019-11-05 12:02 UTC (permalink / raw)
To: buildroot
+Romain Naour, as we discussed this on the #buildroot channel yesterday.
Hi all,
On 19/10/2019 23:20, Arnout Vandecappelle wrote:
> On 20/10/2019 00:04, Arnout Vandecappelle wrote:
>> On 17/10/2019 17:29, Michael Drake wrote:
>>> From: Joseph Kogut <joseph.kogut@gmail.com>
>> We need a bit more explanation why this option is useful/needed.
>>
>>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>>> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
>>> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
>
> I think I should clarify my review a little...
>
> I think this should be split into two patches, where I doubt the second one is
> relevant:
>
> 1. Add the host arch as a target for the host-llvm build. I think this can be
> done unconditionally, which makes the patch a whole lot simpler.
>
> 2. Add a Config.in.host option for llvm. This is only useful if you want to use
> host-llvm outside of Buildroot, in a post-build/image script. I don't think this
> is the case.
>
> If the patch is reduced to the first bit, then I think the
> BR2_PACKAGE_HOST_LLVM_HOST_ARCH symbol (the only bit remaining in
> Config.in.host) should move to Config.in. And the change to the .mk file becomes
> very simple, as I indicated.
>
We agree that the above changes simplify this patch, and have rolled them in. Thanks!
We had an issue yesterday where this didn't actually allow LLVM to build for the host
architecture, but rebuilding all of the LLVM packages fixed that:
host-llvm, host-clang, host-lld
We also have to explicitly use lld, as clang tries to use the
arm-buildroot-linux-gnueabihf-ld linker. We noticed this is turned off in
llvm.mk:
HOST_LLVM_CONF_OPTS += -DLLVM_ENABLE_LLD=OFF
Is there still a reason for this now that host-lld exists?
Many thanks,
Thomas
P.s. Here is some working output:
$ codethink/docker-run.sh ./output/host/bin/llc --version
LLVM (http://llvm.org/):
LLVM version 9.0.0
Optimized build.
Default target: arm-buildroot-linux-gnueabihf
Host CPU: znver1
Registered Targets:
arm - ARM
armeb - ARM (big endian)
thumb - Thumb
thumbeb - Thumb (big endian)
x86 - 32-bit X86: Pentium-Pro and above
x86-64 - 64-bit X86: EM64T and AMD64
$ ./codethink/docker-run.sh output/host/bin/clang -target x86_64-linux-gnu -fuse-ld=/mnt/output/host/bin/ld.lld -o hello hello.c
$ ./hello
Hello, world
^ permalink raw reply [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 05/30] llvm: add config to build backend for host arch
2019-11-05 12:02 ` Thomas Preston
@ 2019-11-07 21:22 ` Romain Naour
0 siblings, 0 replies; 52+ messages in thread
From: Romain Naour @ 2019-11-07 21:22 UTC (permalink / raw)
To: buildroot
Hi Thomas,
Le 05/11/2019 ? 13:02, Thomas Preston a ?crit?:
> +Romain Naour, as we discussed this on the #buildroot channel yesterday.
>
> Hi all,
>
> On 19/10/2019 23:20, Arnout Vandecappelle wrote:
>> On 20/10/2019 00:04, Arnout Vandecappelle wrote:
>>> On 17/10/2019 17:29, Michael Drake wrote:
>>>> From: Joseph Kogut <joseph.kogut@gmail.com>
>>> We need a bit more explanation why this option is useful/needed.
>>>
>>>> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>>>> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
>>>> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
>>
>> I think I should clarify my review a little...
>>
>> I think this should be split into two patches, where I doubt the second one is
>> relevant:
>>
>> 1. Add the host arch as a target for the host-llvm build. I think this can be
>> done unconditionally, which makes the patch a whole lot simpler.
>>
>> 2. Add a Config.in.host option for llvm. This is only useful if you want to use
>> host-llvm outside of Buildroot, in a post-build/image script. I don't think this
>> is the case.
>>
>> If the patch is reduced to the first bit, then I think the
>> BR2_PACKAGE_HOST_LLVM_HOST_ARCH symbol (the only bit remaining in
>> Config.in.host) should move to Config.in. And the change to the .mk file becomes
>> very simple, as I indicated.
>>
>
> We agree that the above changes simplify this patch, and have rolled them in. Thanks!
>
> We had an issue yesterday where this didn't actually allow LLVM to build for the host
> architecture, but rebuilding all of the LLVM packages fixed that:
>
> host-llvm, host-clang, host-lld
>
> We also have to explicitly use lld, as clang tries to use the
> arm-buildroot-linux-gnueabihf-ld linker. We noticed this is turned off in
> llvm.mk:
>
> HOST_LLVM_CONF_OPTS += -DLLVM_ENABLE_LLD=OFF
>
> Is there still a reason for this now that host-lld exists?
For now, lld is not yet used as C and C++ linker. Only the host-lld package was
added but we need to check/modify the infrastructure to be sure to use ldd
instead of the GNU ld.
>
> Many thanks,
> Thomas
>
> P.s. Here is some working output:
>
> $ codethink/docker-run.sh ./output/host/bin/llc --version
>
> LLVM (http://llvm.org/):
> LLVM version 9.0.0
> Optimized build.
> Default target: arm-buildroot-linux-gnueabihf
> Host CPU: znver1
>
> Registered Targets:
> arm - ARM
> armeb - ARM (big endian)
> thumb - Thumb
> thumbeb - Thumb (big endian)
> x86 - 32-bit X86: Pentium-Pro and above
> x86-64 - 64-bit X86: EM64T and AMD64
>
> $ ./codethink/docker-run.sh output/host/bin/clang -target x86_64-linux-gnu -fuse-ld=/mnt/output/host/bin/ld.lld -o hello hello.c
Indeed, you need to provide the -target flag to clang in order to compile for
the host machine. By default clang build for the target.
>
> $ ./hello
> Hello, world
Nice!
Best regards,
Romain
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 06/30] lld: new package
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (4 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 05/30] llvm: add config to build backend for host arch Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-19 22:39 ` Arnout Vandecappelle
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 07/30] package/llvm: install target binary/debug tools Michael Drake
` (24 subsequent siblings)
30 siblings, 1 reply; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Joseph Kogut <joseph.kogut@gmail.com>
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
DEVELOPERS | 1 +
package/Config.in.host | 1 +
package/lld/Config.in.host | 16 ++++++++++++++++
package/lld/lld.hash | 2 ++
package/lld/lld.mk | 15 +++++++++++++++
5 files changed, 35 insertions(+)
create mode 100644 package/lld/Config.in.host
create mode 100644 package/lld/lld.hash
create mode 100644 package/lld/lld.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 4ab4e36593..bdc98edd12 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1221,6 +1221,7 @@ F: package/at-spi2-core/
F: package/clang/
F: package/gconf/
F: package/libnss/
+F: package/lld/
F: package/llvm/
F: package/python-cython/
F: package/python-raven/
diff --git a/package/Config.in.host b/package/Config.in.host
index 3122f5abca..18074ae1a7 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -34,6 +34,7 @@ menu "Host utilities"
source "package/jq/Config.in.host"
source "package/jsmin/Config.in.host"
source "package/libp11/Config.in.host"
+ source "package/lld/Config.in.host"
source "package/llvm/Config.in.host"
source "package/lpc3250loader/Config.in.host"
source "package/lttng-babeltrace/Config.in.host"
diff --git a/package/lld/Config.in.host b/package/lld/Config.in.host
new file mode 100644
index 0000000000..c04b7924fa
--- /dev/null
+++ b/package/lld/Config.in.host
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_HOST_LLD
+ bool "host lld"
+ depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
+ depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
+ select BR2_PACKAGE_HOST_LLVM
+ help
+ LLD is a linker from the LLVM project that is a drop-in
+ replacement for system linkers, and runs much faster than
+ them. It also provides features that are useful for
+ toolchain developers.
+
+ https://lld.llvm.org/
+
+comment "lld needs a toolchain w/ host gcc >= 4.8"
+ depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
+ depends on !BR2_HOST_GCC_AT_LEAST_4_8
diff --git a/package/lld/lld.hash b/package/lld/lld.hash
new file mode 100644
index 0000000000..ebec212041
--- /dev/null
+++ b/package/lld/lld.hash
@@ -0,0 +1,2 @@
+sha256 9caec8ec922e32ffa130f0fb08e4c5a242d7e68ce757631e425e9eba2e1a6e37 lld-8.0.0.src.tar.xz
+sha256 a6c2a7ad246b567fd1828561ee8c244e35f73f164f031c82a7f28eff9634d23d LICENSE.TXT
diff --git a/package/lld/lld.mk b/package/lld/lld.mk
new file mode 100644
index 0000000000..6c3b10a667
--- /dev/null
+++ b/package/lld/lld.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# lld
+#
+################################################################################
+
+LLD_VERSION = 8.0.0
+LLD_SITE = https://llvm.org/releases/$(LLD_VERSION)
+LLD_SOURCE = lld-$(LLD_VERSION).src.tar.xz
+LLD_LICENSE = NCSA
+LLD_LICENSE_FILES = LICENSE.TXT
+LLD_SUPPORTS_IN_SOURCE_BUILD = NO
+HOST_LLD_DEPENDENCIES = host-llvm
+
+$(eval $(host-cmake-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 06/30] lld: new package
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 06/30] lld: new package Michael Drake
@ 2019-10-19 22:39 ` Arnout Vandecappelle
2019-10-24 19:35 ` Romain Naour
0 siblings, 1 reply; 52+ messages in thread
From: Arnout Vandecappelle @ 2019-10-19 22:39 UTC (permalink / raw)
To: buildroot
On 17/10/2019 17:29, Michael Drake wrote:
> From: Joseph Kogut <joseph.kogut@gmail.com>
>
For lld, I completely agree that a Config.in.host option is needed - not for a
post-build script, but rather to use lld in external packages.
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
> ---
> DEVELOPERS | 1 +
> package/Config.in.host | 1 +
> package/lld/Config.in.host | 16 ++++++++++++++++
> package/lld/lld.hash | 2 ++
> package/lld/lld.mk | 15 +++++++++++++++
> 5 files changed, 35 insertions(+)
> create mode 100644 package/lld/Config.in.host
> create mode 100644 package/lld/lld.hash
> create mode 100644 package/lld/lld.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 4ab4e36593..bdc98edd12 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1221,6 +1221,7 @@ F: package/at-spi2-core/
> F: package/clang/
> F: package/gconf/
> F: package/libnss/
> +F: package/lld/
> F: package/llvm/
> F: package/python-cython/
> F: package/python-raven/
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 3122f5abca..18074ae1a7 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -34,6 +34,7 @@ menu "Host utilities"
> source "package/jq/Config.in.host"
> source "package/jsmin/Config.in.host"
> source "package/libp11/Config.in.host"
> + source "package/lld/Config.in.host"
> source "package/llvm/Config.in.host"
> source "package/lpc3250loader/Config.in.host"
> source "package/lttng-babeltrace/Config.in.host"
> diff --git a/package/lld/Config.in.host b/package/lld/Config.in.host
> new file mode 100644
> index 0000000000..c04b7924fa
> --- /dev/null
> +++ b/package/lld/Config.in.host
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_HOST_LLD
> + bool "host lld"
> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
> + depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
> + select BR2_PACKAGE_HOST_LLVM
I'm confused now... I thought the previous patch would be needed to support
lld, but you don't select BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH here, so the
option introduced in the previous patch is not used at all... Why is that patch
needed then?
Also, in Joseph's original submission, [1] was included. Now it is no longer
there. Was it not needed after all?
Anyway, I think I'll apply Joseph's original patch now.
Regards,
Arnout
[1] http://patchwork.ozlabs.org/patch/1136469/
> + help
> + LLD is a linker from the LLVM project that is a drop-in
> + replacement for system linkers, and runs much faster than
> + them. It also provides features that are useful for
> + toolchain developers.
> +
> + https://lld.llvm.org/
> +
> +comment "lld needs a toolchain w/ host gcc >= 4.8"
> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
> + depends on !BR2_HOST_GCC_AT_LEAST_4_8
> diff --git a/package/lld/lld.hash b/package/lld/lld.hash
> new file mode 100644
> index 0000000000..ebec212041
> --- /dev/null
> +++ b/package/lld/lld.hash
> @@ -0,0 +1,2 @@
> +sha256 9caec8ec922e32ffa130f0fb08e4c5a242d7e68ce757631e425e9eba2e1a6e37 lld-8.0.0.src.tar.xz
> +sha256 a6c2a7ad246b567fd1828561ee8c244e35f73f164f031c82a7f28eff9634d23d LICENSE.TXT
> diff --git a/package/lld/lld.mk b/package/lld/lld.mk
> new file mode 100644
> index 0000000000..6c3b10a667
> --- /dev/null
> +++ b/package/lld/lld.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# lld
> +#
> +################################################################################
> +
> +LLD_VERSION = 8.0.0
> +LLD_SITE = https://llvm.org/releases/$(LLD_VERSION)
> +LLD_SOURCE = lld-$(LLD_VERSION).src.tar.xz
> +LLD_LICENSE = NCSA
> +LLD_LICENSE_FILES = LICENSE.TXT
> +LLD_SUPPORTS_IN_SOURCE_BUILD = NO
> +HOST_LLD_DEPENDENCIES = host-llvm
> +
> +$(eval $(host-cmake-package))
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 06/30] lld: new package
2019-10-19 22:39 ` Arnout Vandecappelle
@ 2019-10-24 19:35 ` Romain Naour
2019-10-24 19:38 ` Romain Naour
0 siblings, 1 reply; 52+ messages in thread
From: Romain Naour @ 2019-10-24 19:35 UTC (permalink / raw)
To: buildroot
Hi Arnout,
Le 20/10/2019 ? 00:39, Arnout Vandecappelle a ?crit?:
>> +++ b/package/lld/Config.in.host
>> @@ -0,0 +1,16 @@
>> +config BR2_PACKAGE_HOST_LLD
>> + bool "host lld"
>> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
>> + depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
>> + select BR2_PACKAGE_HOST_LLVM
>
> I'm confused now... I thought the previous patch would be needed to support
> lld, but you don't select BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH here, so the
> option introduced in the previous patch is not used at all... Why is that patch
> needed then?
>
>
> Also, in Joseph's original submission, [1] was included. Now it is no longer
> there. Was it not needed after all?
>
> Anyway, I think I'll apply Joseph's original patch now.
Thanks for merging lld :)
But lld package needs to be at the same version as llvm (currently 9.0.0).
lld package was sent to the mailing list at the time where llvm package was
using 8.0.0.
I'm not sure how it's related but the are some build issues with host-lld package:
http://autobuild.buildroot.org/results/9a0/9a0534c4206b40963d32494ff9675543e78125d1/build-end.log
I believe we need to bump lld version and add a small comment like for llvm and
clang package.
Best regards,
Romain
>
>
> Regards,
> Arnout
>
> [1] http://patchwork.ozlabs.org/patch/1136469/
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 06/30] lld: new package
2019-10-24 19:35 ` Romain Naour
@ 2019-10-24 19:38 ` Romain Naour
2019-10-24 19:56 ` Joseph Kogut
0 siblings, 1 reply; 52+ messages in thread
From: Romain Naour @ 2019-10-24 19:38 UTC (permalink / raw)
To: buildroot
Le 24/10/2019 ? 21:35, Romain Naour a ?crit?:
> Hi Arnout,
>
> Le 20/10/2019 ? 00:39, Arnout Vandecappelle a ?crit?:
>>> +++ b/package/lld/Config.in.host
>>> @@ -0,0 +1,16 @@
>>> +config BR2_PACKAGE_HOST_LLD
>>> + bool "host lld"
>>> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
>>> + depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
>>> + select BR2_PACKAGE_HOST_LLVM
>>
>> I'm confused now... I thought the previous patch would be needed to support
>> lld, but you don't select BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH here, so the
>> option introduced in the previous patch is not used at all... Why is that patch
>> needed then?
>>
>>
>> Also, in Joseph's original submission, [1] was included. Now it is no longer
>> there. Was it not needed after all?
>>
>> Anyway, I think I'll apply Joseph's original patch now.
>
> Thanks for merging lld :)
>
> But lld package needs to be at the same version as llvm (currently 9.0.0).
> lld package was sent to the mailing list at the time where llvm package was
> using 8.0.0.
>
> I'm not sure how it's related but the are some build issues with host-lld package:
> http://autobuild.buildroot.org/results/9a0/9a0534c4206b40963d32494ff9675543e78125d1/build-end.log
It's related, there is a refactoring in llvm.
See:
https://github.com/llvm-mirror/lld/commit/66fca3a6b8cc0112a4c72237ffaea5eb4b659e3f
Best regards,
Romain
>
> I believe we need to bump lld version and add a small comment like for llvm and
> clang package.
>
> Best regards,
> Romain
>
>>
>>
>> Regards,
>> Arnout
>>
>> [1] http://patchwork.ozlabs.org/patch/1136469/
>>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 06/30] lld: new package
2019-10-24 19:38 ` Romain Naour
@ 2019-10-24 19:56 ` Joseph Kogut
2019-10-24 20:05 ` Romain Naour
0 siblings, 1 reply; 52+ messages in thread
From: Joseph Kogut @ 2019-10-24 19:56 UTC (permalink / raw)
To: buildroot
On Thu, Oct 24, 2019 at 12:38 PM Romain Naour <romain.naour@smile.fr> wrote:
>
> Le 24/10/2019 ? 21:35, Romain Naour a ?crit :
> > Hi Arnout,
> >
> > Le 20/10/2019 ? 00:39, Arnout Vandecappelle a ?crit :
> >>> +++ b/package/lld/Config.in.host
> >>> @@ -0,0 +1,16 @@
> >>> +config BR2_PACKAGE_HOST_LLD
> >>> + bool "host lld"
> >>> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
> >>> + depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
> >>> + select BR2_PACKAGE_HOST_LLVM
> >>
> >> I'm confused now... I thought the previous patch would be needed to support
> >> lld, but you don't select BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH here, so the
> >> option introduced in the previous patch is not used at all... Why is that patch
> >> needed then?
> >>
> >>
> >> Also, in Joseph's original submission, [1] was included. Now it is no longer
> >> there. Was it not needed after all?
> >>
> >> Anyway, I think I'll apply Joseph's original patch now.
> >
> > Thanks for merging lld :)
> >
> > But lld package needs to be at the same version as llvm (currently 9.0.0).
> > lld package was sent to the mailing list at the time where llvm package was
> > using 8.0.0.
> >
I've been getting emails about the build failures, and I arrived at
the same conclusion yesterday. If nobody else is working on this, I
can send patches in to fix these issues later today.
> > I'm not sure how it's related but the are some build issues with host-lld package:
> > http://autobuild.buildroot.org/results/9a0/9a0534c4206b40963d32494ff9675543e78125d1/build-end.log
>
> It's related, there is a refactoring in llvm.
> See:
> https://github.com/llvm-mirror/lld/commit/66fca3a6b8cc0112a4c72237ffaea5eb4b659e3f
>
> Best regards,
> Romain
>
> >
> > I believe we need to bump lld version and add a small comment like for llvm and
> > clang package.
> >
> > Best regards,
> > Romain
> >
> >>
> >>
> >> Regards,
> >> Arnout
> >>
> >> [1] http://patchwork.ozlabs.org/patch/1136469/
> >>
>
Additionally, it seems we need to apply a similar fix to 2a17fb6 to
LLD, enabling LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN to fix build issues
with GCC versions between 4.8 and 5.1.
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 06/30] lld: new package
2019-10-24 19:56 ` Joseph Kogut
@ 2019-10-24 20:05 ` Romain Naour
2019-10-24 20:18 ` Joseph Kogut
0 siblings, 1 reply; 52+ messages in thread
From: Romain Naour @ 2019-10-24 20:05 UTC (permalink / raw)
To: buildroot
Hello Joseph,
Le 24/10/2019 ? 21:56, Joseph Kogut a ?crit?:
> On Thu, Oct 24, 2019 at 12:38 PM Romain Naour <romain.naour@smile.fr> wrote:
>>
>> Le 24/10/2019 ? 21:35, Romain Naour a ?crit :
>>> Hi Arnout,
>>>
>>> Le 20/10/2019 ? 00:39, Arnout Vandecappelle a ?crit :
>>>>> +++ b/package/lld/Config.in.host
>>>>> @@ -0,0 +1,16 @@
>>>>> +config BR2_PACKAGE_HOST_LLD
>>>>> + bool "host lld"
>>>>> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
>>>>> + depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
>>>>> + select BR2_PACKAGE_HOST_LLVM
>>>>
>>>> I'm confused now... I thought the previous patch would be needed to support
>>>> lld, but you don't select BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH here, so the
>>>> option introduced in the previous patch is not used at all... Why is that patch
>>>> needed then?
>>>>
>>>>
>>>> Also, in Joseph's original submission, [1] was included. Now it is no longer
>>>> there. Was it not needed after all?
>>>>
>>>> Anyway, I think I'll apply Joseph's original patch now.
>>>
>>> Thanks for merging lld :)
>>>
>>> But lld package needs to be at the same version as llvm (currently 9.0.0).
>>> lld package was sent to the mailing list at the time where llvm package was
>>> using 8.0.0.
>>>
>
> I've been getting emails about the build failures, and I arrived at
> the same conclusion yesterday. If nobody else is working on this, I
> can send patches in to fix these issues later today.
Bumping the package version is easy, I'm doing it right now.
But I don't have time to do a runtime test, can you do it?
Best regards,
Romain
>
>>> I'm not sure how it's related but the are some build issues with host-lld package:
>>> http://autobuild.buildroot.org/results/9a0/9a0534c4206b40963d32494ff9675543e78125d1/build-end.log
>>
>> It's related, there is a refactoring in llvm.
>> See:
>> https://github.com/llvm-mirror/lld/commit/66fca3a6b8cc0112a4c72237ffaea5eb4b659e3f
>>
>> Best regards,
>> Romain
>>
>>>
>>> I believe we need to bump lld version and add a small comment like for llvm and
>>> clang package.
>>>
>>> Best regards,
>>> Romain
>>>
>>>>
>>>>
>>>> Regards,
>>>> Arnout
>>>>
>>>> [1] http://patchwork.ozlabs.org/patch/1136469/
>>>>
>>
>
> Additionally, it seems we need to apply a similar fix to 2a17fb6 to
> LLD, enabling LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN to fix build issues
> with GCC versions between 4.8 and 5.1.
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 06/30] lld: new package
2019-10-24 20:05 ` Romain Naour
@ 2019-10-24 20:18 ` Joseph Kogut
2019-10-24 20:23 ` Romain Naour
0 siblings, 1 reply; 52+ messages in thread
From: Joseph Kogut @ 2019-10-24 20:18 UTC (permalink / raw)
To: buildroot
Hello Romain,
On Thu, Oct 24, 2019 at 1:05 PM Romain Naour <romain.naour@smile.fr> wrote:
>
> Hello Joseph,
>
> Le 24/10/2019 ? 21:56, Joseph Kogut a ?crit :
> > On Thu, Oct 24, 2019 at 12:38 PM Romain Naour <romain.naour@smile.fr> wrote:
> >>
> >> Le 24/10/2019 ? 21:35, Romain Naour a ?crit :
> >>> Hi Arnout,
> >>>
> >>> Le 20/10/2019 ? 00:39, Arnout Vandecappelle a ?crit :
> >>>>> +++ b/package/lld/Config.in.host
> >>>>> @@ -0,0 +1,16 @@
> >>>>> +config BR2_PACKAGE_HOST_LLD
> >>>>> + bool "host lld"
> >>>>> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
> >>>>> + depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
> >>>>> + select BR2_PACKAGE_HOST_LLVM
> >>>>
> >>>> I'm confused now... I thought the previous patch would be needed to support
> >>>> lld, but you don't select BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH here, so the
> >>>> option introduced in the previous patch is not used at all... Why is that patch
> >>>> needed then?
> >>>>
> >>>>
> >>>> Also, in Joseph's original submission, [1] was included. Now it is no longer
> >>>> there. Was it not needed after all?
> >>>>
> >>>> Anyway, I think I'll apply Joseph's original patch now.
> >>>
> >>> Thanks for merging lld :)
> >>>
> >>> But lld package needs to be at the same version as llvm (currently 9.0.0).
> >>> lld package was sent to the mailing list at the time where llvm package was
> >>> using 8.0.0.
> >>>
> >
> > I've been getting emails about the build failures, and I arrived at
> > the same conclusion yesterday. If nobody else is working on this, I
> > can send patches in to fix these issues later today.
>
> Bumping the package version is easy, I'm doing it right now.
> But I don't have time to do a runtime test, can you do it?
>
Yes, I can handle that.
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 06/30] lld: new package
2019-10-24 20:18 ` Joseph Kogut
@ 2019-10-24 20:23 ` Romain Naour
0 siblings, 0 replies; 52+ messages in thread
From: Romain Naour @ 2019-10-24 20:23 UTC (permalink / raw)
To: buildroot
Hello Joseph,
Le 24/10/2019 ? 22:18, Joseph Kogut a ?crit?:
> Hello Romain,
>
> On Thu, Oct 24, 2019 at 1:05 PM Romain Naour <romain.naour@smile.fr> wrote:
>>
>> Hello Joseph,
>>
>> Le 24/10/2019 ? 21:56, Joseph Kogut a ?crit :
>>> On Thu, Oct 24, 2019 at 12:38 PM Romain Naour <romain.naour@smile.fr> wrote:
>>>>
>>>> Le 24/10/2019 ? 21:35, Romain Naour a ?crit :
>>>>> Hi Arnout,
>>>>>
>>>>> Le 20/10/2019 ? 00:39, Arnout Vandecappelle a ?crit :
>>>>>>> +++ b/package/lld/Config.in.host
>>>>>>> @@ -0,0 +1,16 @@
>>>>>>> +config BR2_PACKAGE_HOST_LLD
>>>>>>> + bool "host lld"
>>>>>>> + depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
>>>>>>> + depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
>>>>>>> + select BR2_PACKAGE_HOST_LLVM
>>>>>>
>>>>>> I'm confused now... I thought the previous patch would be needed to support
>>>>>> lld, but you don't select BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH here, so the
>>>>>> option introduced in the previous patch is not used at all... Why is that patch
>>>>>> needed then?
>>>>>>
>>>>>>
>>>>>> Also, in Joseph's original submission, [1] was included. Now it is no longer
>>>>>> there. Was it not needed after all?
>>>>>>
>>>>>> Anyway, I think I'll apply Joseph's original patch now.
>>>>>
>>>>> Thanks for merging lld :)
>>>>>
>>>>> But lld package needs to be at the same version as llvm (currently 9.0.0).
>>>>> lld package was sent to the mailing list at the time where llvm package was
>>>>> using 8.0.0.
>>>>>
>>>
>>> I've been getting emails about the build failures, and I arrived at
>>> the same conclusion yesterday. If nobody else is working on this, I
>>> can send patches in to fix these issues later today.
>>
>> Bumping the package version is easy, I'm doing it right now.
>> But I don't have time to do a runtime test, can you do it?
>>
>
> Yes, I can handle that.
>
You're welcome :)
See: http://patchwork.ozlabs.org/project/buildroot/list/?series=138492
Best regards,
Romain
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 07/30] package/llvm: install target binary/debug tools
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (5 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 06/30] lld: new package Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 08/30] package/llvm/clang: note about version bumping dep Michael Drake
` (23 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Matt Weber <matthew.weber@rockwellcollins.com>
The compiler-rt fuzzer and address sanitizer tools require additional
LLVM binary tools installed to allow stack trace decoding actively during
executable analysis.
https://github.com/google/sanitizers/wiki/AddressSanitizerCallStack
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Reviewed-by: Romain Naour <romain.naour@smile.fr>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/llvm/llvm.mk | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index 5c413064c0..e20c909175 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -214,8 +214,17 @@ HOST_LLVM_CONF_OPTS += \
# We need to activate LLVM_INCLUDE_TOOLS, otherwise it does not generate
# libLLVM.so
LLVM_CONF_OPTS += \
- -DLLVM_INCLUDE_TOOLS=ON \
+ -DLLVM_INCLUDE_TOOLS=ON
+
+# The llvm-symbolizer binary is used by the Compiler-RT Fuzzer
+# and AddressSanitizer tools for stack traces.
+ifeq ($(BR2_PACKAGE_COMPILER_RT),y)
+LLVM_CONF_OPTS += \
+ -DLLVM_BUILD_TOOLS=ON
+else
+LLVM_CONF_OPTS += \
-DLLVM_BUILD_TOOLS=OFF
+endif
# Compiler-rt not in the source tree.
# llvm runtime libraries are not in the source tree.
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 08/30] package/llvm/clang: note about version bumping dep
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (6 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 07/30] package/llvm: install target binary/debug tools Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-19 23:05 ` Arnout Vandecappelle
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 09/30] package/llvm: disable libxml2 Michael Drake
` (22 subsequent siblings)
30 siblings, 1 reply; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Matt Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Acked-by: Romain Naour <romain.naour@smile.fr>
Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/clang/clang.mk | 1 +
package/llvm/llvm.mk | 1 +
2 files changed, 2 insertions(+)
diff --git a/package/clang/clang.mk b/package/clang/clang.mk
index 0cab1c7f89..07e7fced2a 100644
--- a/package/clang/clang.mk
+++ b/package/clang/clang.mk
@@ -4,6 +4,7 @@
#
################################################################################
+# LLVM and Clang should be version bumped together
CLANG_VERSION = 8.0.0
CLANG_SITE = http://llvm.org/releases/$(CLANG_VERSION)
CLANG_SOURCE = cfe-$(CLANG_VERSION).src.tar.xz
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index e20c909175..aa70a85490 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -4,6 +4,7 @@
#
################################################################################
+# LLVM and Clang should be version bumped together
LLVM_VERSION = 8.0.0
LLVM_SITE = http://llvm.org/releases/$(LLVM_VERSION)
LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 08/30] package/llvm/clang: note about version bumping dep
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 08/30] package/llvm/clang: note about version bumping dep Michael Drake
@ 2019-10-19 23:05 ` Arnout Vandecappelle
0 siblings, 0 replies; 52+ messages in thread
From: Arnout Vandecappelle @ 2019-10-19 23:05 UTC (permalink / raw)
To: buildroot
On 17/10/2019 17:29, Michael Drake wrote:
> From: Matt Weber <matthew.weber@rockwellcollins.com>
>
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> Acked-by: Romain Naour <romain.naour@smile.fr>
> Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
This and the following patch were already merged on August 1. Please base your
patches on master before sending them.
Regards,
Arnout
> ---
> package/clang/clang.mk | 1 +
> package/llvm/llvm.mk | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/package/clang/clang.mk b/package/clang/clang.mk
> index 0cab1c7f89..07e7fced2a 100644
> --- a/package/clang/clang.mk
> +++ b/package/clang/clang.mk
> @@ -4,6 +4,7 @@
> #
> ################################################################################
>
> +# LLVM and Clang should be version bumped together
> CLANG_VERSION = 8.0.0
> CLANG_SITE = http://llvm.org/releases/$(CLANG_VERSION)
> CLANG_SOURCE = cfe-$(CLANG_VERSION).src.tar.xz
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index e20c909175..aa70a85490 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -4,6 +4,7 @@
> #
> ################################################################################
>
> +# LLVM and Clang should be version bumped together
> LLVM_VERSION = 8.0.0
> LLVM_SITE = http://llvm.org/releases/$(LLVM_VERSION)
> LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 09/30] package/llvm: disable libxml2
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (7 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 08/30] package/llvm/clang: note about version bumping dep Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package Michael Drake
` (21 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Matt Weber <matthew.weber@rockwellcollins.com>
libxml2 is needed during Windows builds to populate the COFF
file manifest info. This isn't required for Linux builds.
Cc: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/llvm/llvm.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index aa70a85490..44882d39a6 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -140,6 +140,11 @@ HOST_LLVM_CONF_OPTS += -DLLVM_ENABLE_ZLIB=ON
HOST_LLVM_DEPENDENCIES += host-zlib
LLVM_CONF_OPTS += -DLLVM_ENABLE_ZLIB=OFF
+# libxml2 can be disabled as it is used for LLVM Windows builds where COFF
+# files include manifest info
+HOST_LLVM_CONF_OPTS += -DLLVM_ENABLE_LIBXML2=OFF
+LLVM_CONF_OPTS += -DLLVM_ENABLE_LIBXML2=OFF
+
# We don't use llvm for static only build, so enable PIC
HOST_LLVM_CONF_OPTS += -DLLVM_ENABLE_PIC=ON
LLVM_CONF_OPTS += -DLLVM_ENABLE_PIC=ON
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (8 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 09/30] package/llvm: disable libxml2 Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 19:17 ` Matthew Weber
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 11/30] package/libpangox: " Michael Drake
` (20 subsequent siblings)
30 siblings, 1 reply; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Matt Weber <matthew.weber@rockwellcollins.com>
This patch adds support for the compiler-rt (CLANG runtime) library.
It builds a set of static libraries and installs them into the
CLANG/LLVM toolchain resource folder.
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Cc: Romain Naour <romain.naour@smile.fr>
Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Valentin Korenblit <valentinkorenblit@gmail.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
DEVELOPERS | 1 +
package/Config.in | 1 +
package/clang/clang.mk | 2 +-
package/compiler-rt/Config.in | 14 +++++++++++
package/compiler-rt/compiler-rt.hash | 2 ++
package/compiler-rt/compiler-rt.mk | 36 ++++++++++++++++++++++++++++
package/llvm/llvm.mk | 2 +-
7 files changed, 56 insertions(+), 2 deletions(-)
create mode 100644 package/compiler-rt/Config.in
create mode 100644 package/compiler-rt/compiler-rt.hash
create mode 100644 package/compiler-rt/compiler-rt.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index bdc98edd12..abaa710ccb 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1476,6 +1476,7 @@ F: package/bridge-utils/
F: package/checkpolicy/
F: package/checksec/
F: package/cgroupfs-mount/
+F: package/compiler-rt/
F: package/crda/
F: package/cunit/
F: package/dacapo/
diff --git a/package/Config.in b/package/Config.in
index 90dddfd346..ab9335a055 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1666,6 +1666,7 @@ menu "Other"
source "package/clapack/Config.in"
source "package/classpath/Config.in"
source "package/cmocka/Config.in"
+ source "package/compiler-rt/Config.in"
source "package/cppcms/Config.in"
source "package/cracklib/Config.in"
source "package/dawgdic/Config.in"
diff --git a/package/clang/clang.mk b/package/clang/clang.mk
index 07e7fced2a..87a80ab258 100644
--- a/package/clang/clang.mk
+++ b/package/clang/clang.mk
@@ -4,7 +4,7 @@
#
################################################################################
-# LLVM and Clang should be version bumped together
+# LLVM, Compiler-rt and Clang should be version bumped together
CLANG_VERSION = 8.0.0
CLANG_SITE = http://llvm.org/releases/$(CLANG_VERSION)
CLANG_SOURCE = cfe-$(CLANG_VERSION).src.tar.xz
diff --git a/package/compiler-rt/Config.in b/package/compiler-rt/Config.in
new file mode 100644
index 0000000000..9afc0d9d60
--- /dev/null
+++ b/package/compiler-rt/Config.in
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_COMPILER_RT
+ bool "compiler-rt"
+ depends on BR2_PACKAGE_LLVM
+ depends on BR2_TOOLCHAIN_USES_GLIBC # asan lib requires
+ help
+ A collection of runtime libraries primarily used by clang and
+ llvm to provide builtins, sanitizer runtimes, and profiling
+ at runtime.
+
+ https://compiler-rt.llvm.org/
+
+comment "compiler-rt requires llvm to be enabled and a glibc toolchain"
+ depends on !BR2_PACKAGE_LLVM
+ depends on !BR2_TOOLCHAIN_USES_GLIBC
diff --git a/package/compiler-rt/compiler-rt.hash b/package/compiler-rt/compiler-rt.hash
new file mode 100644
index 0000000000..24ebdf206b
--- /dev/null
+++ b/package/compiler-rt/compiler-rt.hash
@@ -0,0 +1,2 @@
+sha256 b435c7474f459e71b2831f1a4e3f1d21203cb9c0172e94e9d9b69f50354f21b1 compiler-rt-8.0.0.src.tar.xz
+sha256 dd27f8c290bcdc8368549cd7cd98710a9dbdc34122f2e096a1edb97824ed4148 LICENSE.TXT
diff --git a/package/compiler-rt/compiler-rt.mk b/package/compiler-rt/compiler-rt.mk
new file mode 100644
index 0000000000..7eda3bc4fe
--- /dev/null
+++ b/package/compiler-rt/compiler-rt.mk
@@ -0,0 +1,36 @@
+################################################################################
+#
+# compiler-rt
+#
+################################################################################
+
+# Compiler-RT should be bumped together with LLVM and Clang as the run-time is
+# tied to the version of those tools
+COMPILER_RT_VERSION = 8.0.0
+COMPILER_RT_SOURCE = compiler-rt-$(COMPILER_RT_VERSION).src.tar.xz
+COMPILER_RT_SITE = http://llvm.org/releases/$(COMPILER_RT_VERSION)
+COMPILER_RT_LICENSE = NCSA MIT
+COMPILER_RT_LICENSE_FILES = LICENSE.TXT
+COMPILER_RT_DEPENDENCIES = host-clang llvm
+
+COMPILER_RT_INSTALL_STAGING = YES
+COMPILER_RT_INSTALL_TARGET = NO
+
+COMPILER_RT_CONF_OPTS=-DCOMPILER_RT_STANDALONE_BUILD=OFF \
+ -DCOMPILER_RT_STANDALONE_BUILD=ON \
+ -DCOMPILER_RT_DEFAULT_TARGET_TRIPLE=$(GNU_TARGET_NAME) \
+ -DLLVM_CONFIG_PATH=$(HOST_DIR)/usr/bin/llvm-config
+
+# The installation of the target runtime libraries defaults to DESTDIR, however
+# host-clang resources directory needs a link so Clang can find the runtime
+# libraries in the same location they would be if built as part of the Clang
+# build. The "resources" directory is loosely documented and seems to be
+# assumed, as compiler-rt is usually build at the same time as Clang and not
+# standalone.
+define COMPILER_RT_SETUP_RUNTIME_LIBS
+ mkdir -p $(HOST_DIR)/lib/clang/$(HOST_CLANG_VERSION)/lib
+ ln -sf ../../../../$(GNU_TARGET_NAME)/sysroot/usr/lib/linux $(HOST_DIR)/lib/clang/$(HOST_CLANG_VERSION)/lib/linux
+endef
+COMPILER_RT_POST_INSTALL_STAGING_HOOKS += COMPILER_RT_SETUP_RUNTIME_LIBS
+
+$(eval $(cmake-package))
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index 44882d39a6..4fce59b95b 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -4,7 +4,7 @@
#
################################################################################
-# LLVM and Clang should be version bumped together
+# LLVM, Compiler-rt and Clang should be version bumped together
LLVM_VERSION = 8.0.0
LLVM_SITE = http://llvm.org/releases/$(LLVM_VERSION)
LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package Michael Drake
@ 2019-10-17 19:17 ` Matthew Weber
2019-10-18 8:51 ` Michael Drake
2019-10-19 21:48 ` Arnout Vandecappelle
0 siblings, 2 replies; 52+ messages in thread
From: Matthew Weber @ 2019-10-17 19:17 UTC (permalink / raw)
To: buildroot
On Thu, Oct 17, 2019 at 10:30 AM Michael Drake
<michael.drake@codethink.co.uk> wrote:
>
> From: Matt Weber <matthew.weber@rockwellcollins.com>
>
> This patch adds support for the compiler-rt (CLANG runtime) library.
> It builds a set of static libraries and installs them into the
> CLANG/LLVM toolchain resource folder.
>
FYI, I plan to publish (soon) a cleaned up version of my original
series which add the compiler-rt feature. That refreshed patchset
would have the feedback from my last series that's missing here.
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> Cc: Romain Naour <romain.naour@smile.fr>
> Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Valentin Korenblit <valentinkorenblit@gmail.com>
> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
> ---
> DEVELOPERS | 1 +
> package/Config.in | 1 +
> package/clang/clang.mk | 2 +-
> package/compiler-rt/Config.in | 14 +++++++++++
> package/compiler-rt/compiler-rt.hash | 2 ++
> package/compiler-rt/compiler-rt.mk | 36 ++++++++++++++++++++++++++++
> package/llvm/llvm.mk | 2 +-
> 7 files changed, 56 insertions(+), 2 deletions(-)
> create mode 100644 package/compiler-rt/Config.in
> create mode 100644 package/compiler-rt/compiler-rt.hash
> create mode 100644 package/compiler-rt/compiler-rt.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index bdc98edd12..abaa710ccb 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1476,6 +1476,7 @@ F: package/bridge-utils/
> F: package/checkpolicy/
> F: package/checksec/
> F: package/cgroupfs-mount/
> +F: package/compiler-rt/
> F: package/crda/
> F: package/cunit/
> F: package/dacapo/
> diff --git a/package/Config.in b/package/Config.in
> index 90dddfd346..ab9335a055 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1666,6 +1666,7 @@ menu "Other"
> source "package/clapack/Config.in"
> source "package/classpath/Config.in"
> source "package/cmocka/Config.in"
> + source "package/compiler-rt/Config.in"
> source "package/cppcms/Config.in"
> source "package/cracklib/Config.in"
> source "package/dawgdic/Config.in"
> diff --git a/package/clang/clang.mk b/package/clang/clang.mk
> index 07e7fced2a..87a80ab258 100644
> --- a/package/clang/clang.mk
> +++ b/package/clang/clang.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -# LLVM and Clang should be version bumped together
> +# LLVM, Compiler-rt and Clang should be version bumped together
> CLANG_VERSION = 8.0.0
> CLANG_SITE = http://llvm.org/releases/$(CLANG_VERSION)
> CLANG_SOURCE = cfe-$(CLANG_VERSION).src.tar.xz
> diff --git a/package/compiler-rt/Config.in b/package/compiler-rt/Config.in
> new file mode 100644
> index 0000000000..9afc0d9d60
> --- /dev/null
> +++ b/package/compiler-rt/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_COMPILER_RT
> + bool "compiler-rt"
> + depends on BR2_PACKAGE_LLVM
> + depends on BR2_TOOLCHAIN_USES_GLIBC # asan lib requires
> + help
> + A collection of runtime libraries primarily used by clang and
> + llvm to provide builtins, sanitizer runtimes, and profiling
> + at runtime.
> +
> + https://compiler-rt.llvm.org/
> +
> +comment "compiler-rt requires llvm to be enabled and a glibc toolchain"
> + depends on !BR2_PACKAGE_LLVM
> + depends on !BR2_TOOLCHAIN_USES_GLIBC
> diff --git a/package/compiler-rt/compiler-rt.hash b/package/compiler-rt/compiler-rt.hash
> new file mode 100644
> index 0000000000..24ebdf206b
> --- /dev/null
> +++ b/package/compiler-rt/compiler-rt.hash
> @@ -0,0 +1,2 @@
> +sha256 b435c7474f459e71b2831f1a4e3f1d21203cb9c0172e94e9d9b69f50354f21b1 compiler-rt-8.0.0.src.tar.xz
> +sha256 dd27f8c290bcdc8368549cd7cd98710a9dbdc34122f2e096a1edb97824ed4148 LICENSE.TXT
> diff --git a/package/compiler-rt/compiler-rt.mk b/package/compiler-rt/compiler-rt.mk
> new file mode 100644
> index 0000000000..7eda3bc4fe
> --- /dev/null
> +++ b/package/compiler-rt/compiler-rt.mk
> @@ -0,0 +1,36 @@
> +################################################################################
> +#
> +# compiler-rt
> +#
> +################################################################################
> +
> +# Compiler-RT should be bumped together with LLVM and Clang as the run-time is
> +# tied to the version of those tools
> +COMPILER_RT_VERSION = 8.0.0
> +COMPILER_RT_SOURCE = compiler-rt-$(COMPILER_RT_VERSION).src.tar.xz
> +COMPILER_RT_SITE = http://llvm.org/releases/$(COMPILER_RT_VERSION)
> +COMPILER_RT_LICENSE = NCSA MIT
> +COMPILER_RT_LICENSE_FILES = LICENSE.TXT
> +COMPILER_RT_DEPENDENCIES = host-clang llvm
> +
> +COMPILER_RT_INSTALL_STAGING = YES
> +COMPILER_RT_INSTALL_TARGET = NO
> +
> +COMPILER_RT_CONF_OPTS=-DCOMPILER_RT_STANDALONE_BUILD=OFF \
> + -DCOMPILER_RT_STANDALONE_BUILD=ON \
> + -DCOMPILER_RT_DEFAULT_TARGET_TRIPLE=$(GNU_TARGET_NAME) \
> + -DLLVM_CONFIG_PATH=$(HOST_DIR)/usr/bin/llvm-config
> +
> +# The installation of the target runtime libraries defaults to DESTDIR, however
> +# host-clang resources directory needs a link so Clang can find the runtime
> +# libraries in the same location they would be if built as part of the Clang
> +# build. The "resources" directory is loosely documented and seems to be
> +# assumed, as compiler-rt is usually build at the same time as Clang and not
> +# standalone.
> +define COMPILER_RT_SETUP_RUNTIME_LIBS
> + mkdir -p $(HOST_DIR)/lib/clang/$(HOST_CLANG_VERSION)/lib
> + ln -sf ../../../../$(GNU_TARGET_NAME)/sysroot/usr/lib/linux $(HOST_DIR)/lib/clang/$(HOST_CLANG_VERSION)/lib/linux
> +endef
> +COMPILER_RT_POST_INSTALL_STAGING_HOOKS += COMPILER_RT_SETUP_RUNTIME_LIBS
> +
> +$(eval $(cmake-package))
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index 44882d39a6..4fce59b95b 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -# LLVM and Clang should be version bumped together
> +# LLVM, Compiler-rt and Clang should be version bumped together
> LLVM_VERSION = 8.0.0
> LLVM_SITE = http://llvm.org/releases/$(LLVM_VERSION)
> LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
> --
> 2.20.1
>
--
Matthew Weber | Associate Director Software Engineer | Commercial Avionics
COLLINS AEROSPACE
400 Collins Road NE, Cedar Rapids, Iowa 52498, USA
Tel: +1 319 295 7349 | FAX: +1 319 263 6099
matthew.weber at collins.com | collinsaerospace.com
CONFIDENTIALITY WARNING: This message may contain proprietary and/or
privileged information of Collins Aerospace and its affiliated
companies. If you are not the intended recipient, please 1) Do not
disclose, copy, distribute or use this message or its contents. 2)
Advise the sender by return email. 3) Delete all copies (including all
attachments) from your computer. Your cooperation is greatly
appreciated.
Any export restricted material should be shared using my
matthew.weber at corp.rockwellcollins.com address.
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package
2019-10-17 19:17 ` Matthew Weber
@ 2019-10-18 8:51 ` Michael Drake
2019-10-18 15:18 ` Michael Drake
2019-10-19 21:48 ` Arnout Vandecappelle
1 sibling, 1 reply; 52+ messages in thread
From: Michael Drake @ 2019-10-18 8:51 UTC (permalink / raw)
To: buildroot
Hi Matt,
On 17/10/2019 20:17, Matthew Weber wrote:
> On Thu, Oct 17, 2019 at 10:30 AM Michael Drake
> <michael.drake@codethink.co.uk> wrote:
>>
>> From: Matt Weber <matthew.weber@rockwellcollins.com>
>>
>> This patch adds support for the compiler-rt (CLANG runtime) library.
>> It builds a set of static libraries and installs them into the
>> CLANG/LLVM toolchain resource folder.
>>
>
> FYI, I plan to publish (soon) a cleaned up version of my original
> series which add the compiler-rt feature. That refreshed patchset
> would have the feedback from my last series that's missing here.
Ooh, that's really interesting. At this very moment I am actually
working on adding a host-compiler-rt. Currently I'm disabling
CFI[1] in the CEF/Chromium build with `is_cfi=false`.
When I enable that feature, I get clang errors like:
clang++: error: no such file or directory:
'/home/tlsa/buildroot/output/host/lib/clang/8.0.0/share/cfi_blacklist.txt'
And I believe the missing cfi_blacklist.txt should come with
compiler-rt.
I'll have a look for the feedback from the last series.
Thanks very much for the pointer for and the original patch!
[1] http://clang.llvm.org/docs/ControlFlowIntegrity.html
Best regards,
Michael
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package
2019-10-18 8:51 ` Michael Drake
@ 2019-10-18 15:18 ` Michael Drake
2019-10-23 21:54 ` Matthew Weber
0 siblings, 1 reply; 52+ messages in thread
From: Michael Drake @ 2019-10-18 15:18 UTC (permalink / raw)
To: buildroot
Hi Matthew,
On 18/10/2019 09:51, Michael Drake wrote:
> On 17/10/2019 20:17, Matthew Weber wrote:
>> FYI, I plan to publish (soon) a cleaned up version of my original
>> series which add the compiler-rt feature. That refreshed patchset
>> would have the feedback from my last series that's missing here.
>
> Ooh, that's really interesting. At this very moment I am actually
> working on adding a host-compiler-rt. Currently I'm disabling
> CFI[1] in the CEF/Chromium build with `is_cfi=false`.
>
> When I enable that feature, I get clang errors like:
>
> clang++: error: no such file or directory:
> '/home/tlsa/buildroot/output/host/lib/clang/8.0.0/share/cfi_blacklist.txt'
I tracked this down, btw. The attached patch fixes it.
Basically, we create links for all the libclang_rt.* stuff
for host-clang, but they use some data files in the share
directory too, that weren't getting copied.
Cheers,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cfi-fix.diff
Type: text/x-patch
Size: 1928 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191018/fa4cb02c/attachment.bin>
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package
2019-10-18 15:18 ` Michael Drake
@ 2019-10-23 21:54 ` Matthew Weber
0 siblings, 0 replies; 52+ messages in thread
From: Matthew Weber @ 2019-10-23 21:54 UTC (permalink / raw)
To: buildroot
Michael / Romain / Arnout,
On Fri, Oct 18, 2019 at 10:18 AM Michael Drake
<michael.drake@codethink.co.uk> wrote:
>
> Hi Matthew,
>
> On 18/10/2019 09:51, Michael Drake wrote:
> > On 17/10/2019 20:17, Matthew Weber wrote:
>
> >> FYI, I plan to publish (soon) a cleaned up version of my original
> >> series which add the compiler-rt feature. That refreshed patchset
> >> would have the feedback from my last series that's missing here.
> >
> > Ooh, that's really interesting. At this very moment I am actually
> > working on adding a host-compiler-rt. Currently I'm disabling
> > CFI[1] in the CEF/Chromium build with `is_cfi=false`.
> >
> > When I enable that feature, I get clang errors like:
> >
> > clang++: error: no such file or directory:
> > '/home/tlsa/buildroot/output/host/lib/clang/8.0.0/share/cfi_blacklist.txt'
>
> I tracked this down, btw. The attached patch fixes it.
>
> Basically, we create links for all the libclang_rt.* stuff
> for host-clang, but they use some data files in the share
> directory too, that weren't getting copied.
I incorporated that symlink fix into the clang v8 series [1]. The new
series is now just two patches as it leverages a new clang
cross-compiler framework. The new framework is provided in Romain's
clang cross-compiler series [2] and needs to be applied first (or the
core parts of it).
Regards,
Matt
[1] http://patchwork.ozlabs.org/project/buildroot/list/?series=138196
[2] http://patchwork.ozlabs.org/project/buildroot/list/?series=129565
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package
2019-10-17 19:17 ` Matthew Weber
2019-10-18 8:51 ` Michael Drake
@ 2019-10-19 21:48 ` Arnout Vandecappelle
2019-10-21 13:02 ` Matthew Weber
1 sibling, 1 reply; 52+ messages in thread
From: Arnout Vandecappelle @ 2019-10-19 21:48 UTC (permalink / raw)
To: buildroot
Hi Matt,
On 17/10/2019 21:17, Matthew Weber wrote:
> On Thu, Oct 17, 2019 at 10:30 AM Michael Drake
> <michael.drake@codethink.co.uk> wrote:
>> From: Matt Weber <matthew.weber@rockwellcollins.com>
>>
>> This patch adds support for the compiler-rt (CLANG runtime) library.
>> It builds a set of static libraries and installs them into the
>> CLANG/LLVM toolchain resource folder.
>>
> FYI, I plan to publish (soon) a cleaned up version of my original
> series which add the compiler-rt feature. That refreshed patchset
> would have the feedback from my last series that's missing here.
There are probably interactions with Romain's clang series and Joseph's LLD
series, so it would be nice if all of that could be combined in one series or at
least ordered somewhat...
Regards,
Arnout
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package
2019-10-19 21:48 ` Arnout Vandecappelle
@ 2019-10-21 13:02 ` Matthew Weber
0 siblings, 0 replies; 52+ messages in thread
From: Matthew Weber @ 2019-10-21 13:02 UTC (permalink / raw)
To: buildroot
Arnout,
On Sat, Oct 19, 2019 at 4:48 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
> Hi Matt,
>
> On 17/10/2019 21:17, Matthew Weber wrote:
> > On Thu, Oct 17, 2019 at 10:30 AM Michael Drake
> > <michael.drake@codethink.co.uk> wrote:
> >> From: Matt Weber <matthew.weber@rockwellcollins.com>
> >>
> >> This patch adds support for the compiler-rt (CLANG runtime) library.
> >> It builds a set of static libraries and installs them into the
> >> CLANG/LLVM toolchain resource folder.
> >>
> > FYI, I plan to publish (soon) a cleaned up version of my original
> > series which add the compiler-rt feature. That refreshed patchset
> > would have the feedback from my last series that's missing here.
>
> There are probably interactions with Romain's clang series and Joseph's LLD
> series, so it would be nice if all of that could be combined in one series or at
> least ordered somewhat...
>
Agree, I'll get something together today ahead of the working meeting this week.
Right now, I've got a working copy pulling in Romain's series, however
its out of date with respect to current master. Plus I need to review
Michael's reuse of compiler-rt and any changes.
Regards,
Matt
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 11/30] package/libpangox: new package
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (9 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 10/30] package/compiler-rt: new package Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 12/30] package/libgtkglext: " Michael Drake
` (19 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/Config.in | 1 +
package/libpangox/Config.in | 14 ++++++++++++++
package/libpangox/libpangox.mk | 12 ++++++++++++
3 files changed, 27 insertions(+)
create mode 100644 package/libpangox/Config.in
create mode 100644 package/libpangox/libpangox.mk
diff --git a/package/Config.in b/package/Config.in
index ab9335a055..56b01b3b31 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1325,6 +1325,7 @@ menu "Graphics"
source "package/libgtk3/Config.in"
source "package/libmediaart/Config.in"
source "package/libmng/Config.in"
+ source "package/libpangox/Config.in"
source "package/libpng/Config.in"
source "package/libqrencode/Config.in"
source "package/libraw/Config.in"
diff --git a/package/libpangox/Config.in b/package/libpangox/Config.in
new file mode 100644
index 0000000000..5575081a4e
--- /dev/null
+++ b/package/libpangox/Config.in
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_LIBPANGOX
+ bool "libpangox"
+ depends on BR2_USE_WCHAR # gettext
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ select BR2_PACKAGE_LIBGTK2
+ select BR2_PACKAGE_PANGO
+ select BR2_PACKAGE_XLIB_LIBICE
+ select BR2_PACKAGE_XLIB_LIBSM
+ select BR2_PACKAGE_XLIB_LIBXMU
+ select BR2_PACKAGE_XLIB_LIBXMU
+ select BR2_PACKAGE_XLIB_LIBXT
+ help
+ This is a compatibility library providing the obsolete pangox
+ library that is not shipped by Pango itself anymore.
diff --git a/package/libpangox/libpangox.mk b/package/libpangox/libpangox.mk
new file mode 100644
index 0000000000..35d7720302
--- /dev/null
+++ b/package/libpangox/libpangox.mk
@@ -0,0 +1,12 @@
+################################################################################
+#
+# libpangox
+#
+################################################################################
+LIBPANGOX_VERSION = 0.0.2
+LIBPANGOX_SOURCE = pangox-compat-$(LIBPANGOX_VERSION).tar.xz
+LIBPANGOX_SITE = http://ftp.gnome.org/pub/GNOME/sources/pangox-compat/0.0
+LIBPANGOX_INSTALL_STAGING = YES
+LIBPANGOX_DEPENDENCIES = libglib2 host-pkgconf pango
+
+$(eval $(autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 12/30] package/libgtkglext: new package
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (10 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 11/30] package/libpangox: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 13/30] package/webp: Enable host package build Michael Drake
` (18 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/Config.in | 1 +
package/libgtkglext/Config.in | 18 ++++++++++++++++++
package/libgtkglext/libgtkglext.mk | 29 +++++++++++++++++++++++++++++
3 files changed, 48 insertions(+)
create mode 100644 package/libgtkglext/Config.in
create mode 100644 package/libgtkglext/libgtkglext.mk
diff --git a/package/Config.in b/package/Config.in
index 56b01b3b31..79933bfa8c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1323,6 +1323,7 @@ menu "Graphics"
source "package/libgta/Config.in"
source "package/libgtk2/Config.in"
source "package/libgtk3/Config.in"
+ source "package/libgtkglext/Config.in"
source "package/libmediaart/Config.in"
source "package/libmng/Config.in"
source "package/libpangox/Config.in"
diff --git a/package/libgtkglext/Config.in b/package/libgtkglext/Config.in
new file mode 100644
index 0000000000..9502335eab
--- /dev/null
+++ b/package/libgtkglext/Config.in
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_LIBGTKGLEXT
+ bool "libgtkglext"
+ depends on BR2_PACKAGE_HAS_LIBGL
+ depends on BR2_USE_WCHAR # gettext
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ select BR2_PACKAGE_LIBGLU
+ select BR2_PACKAGE_LIBGTK2
+ select BR2_PACKAGE_PANGO
+ select BR2_PACKAGE_LIBPANGOX
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBICE
+ select BR2_PACKAGE_XLIB_LIBSM
+ select BR2_PACKAGE_XLIB_LIBXMU
+ select BR2_PACKAGE_XLIB_LIBXT
+ help
+ GtkGLExt is an OpenGL extension to GTK+.
+
+ https://projects-old.gnome.org/gtkglext/index.html
diff --git a/package/libgtkglext/libgtkglext.mk b/package/libgtkglext/libgtkglext.mk
new file mode 100644
index 0000000000..93a5d6382d
--- /dev/null
+++ b/package/libgtkglext/libgtkglext.mk
@@ -0,0 +1,29 @@
+################################################################################
+#
+# libgtkglext
+#
+################################################################################
+LIBGTKGLEXT_VERSION = 1.2.0
+LIBGTKGLEXT_SOURCE = gtkglext-$(LIBGTKGLEXT_VERSION).tar.gz
+LIBGTKGLEXT_SITE = http://downloads.sourceforge.net/gtkglext
+LIBGTKGLEXT_INSTALL_STAGING = YES
+LIBGTKGLEXT_DEPENDENCIES = \
+ host-pkgconf \
+ libglib2 \
+ libpangox \
+ pango \
+ xlib_libICE \
+ xlib_libSM \
+ xlib_libX11 \
+ xlib_libXmu \
+ xlib_libXt \
+ libglu \
+ libgtk2
+
+LIBGTKGLEXT_PATCH = \
+ https://sources.debian.org/data/main/g/gtkglext/1.2.0-9/debian/patches/01_fix_fontcache_nullderef.diff \
+ https://sources.debian.org/data/main/g/gtkglext/1.2.0-9/debian/patches/02_fix_gtk-2.20_deprecated_symbols.diff \
+ https://sources.debian.org/data/main/g/gtkglext/1.2.0-9/debian/patches/04_glibc2.27-ftbfs.diff \
+ https://sources.debian.org/data/main/g/gtkglext/1.2.0-9/debian/patches/libGL.so.1.diff
+
+$(eval $(autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 13/30] package/webp: Enable host package build.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (11 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 12/30] package/libgtkglext: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 14/30] package/libcef: New package Michael Drake
` (17 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/webp/webp.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/webp/webp.mk b/package/webp/webp.mk
index e7235f48f4..2fb42613ec 100644
--- a/package/webp/webp.mk
+++ b/package/webp/webp.mk
@@ -11,6 +11,10 @@ WEBP_LICENSE = BSD-3-Clause
WEBP_LICENSE_FILES = COPYING
WEBP_INSTALL_STAGING = YES
+HOST_WEBP_CONF_OPTS += \
+ --enable-libwebpmux \
+ --enable-libwebpdemux
+
WEBP_CONF_OPTS += \
--with-jpegincludedir=$(STAGING_DIR)/usr/include \
--with-jpeglibdir=$(STAGING_DIR)/usr/lib \
@@ -54,3 +58,4 @@ WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg)
WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 14/30] package/libcef: New package
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (12 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 13/30] package/webp: Enable host package build Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-19 23:55 ` Arnout Vandecappelle
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 15/30] package/libcef: Add option to build cefclient and cefsimple Michael Drake
` (16 subsequent siblings)
30 siblings, 1 reply; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Coauthored-by: Thomas Preston <thomas.preston@codethink.co.uk>
Cc: Patrick Glaser <pglaser@tesla.com>
Cc: Jon duSaint <jdusaint@tesla.com>
Cc: Enis Lavery <elavery@tesla.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/Config.in | 1 +
.../0001-fix-one-euro-filter-build.patch | 33 +
.../0002-link-against-harfbuzz-subset.patch | 50 +
package/libcef/Config.in | 75 ++
package/libcef/libcef.license-files.inc | 1130 +++++++++++++++++
package/libcef/libcef.mk | 372 ++++++
.../libcef/scripts/gather-license-files.sh | 53 +
package/libcef/scripts/version.sh | 48 +
package/libcef/templates/cef_version.h | 70 +
package/libcef/toolchain/BUILD.gn | 70 +
10 files changed, 1902 insertions(+)
create mode 100644 package/libcef/0001-fix-one-euro-filter-build.patch
create mode 100644 package/libcef/0002-link-against-harfbuzz-subset.patch
create mode 100644 package/libcef/Config.in
create mode 100644 package/libcef/libcef.license-files.inc
create mode 100644 package/libcef/libcef.mk
create mode 100755 package/libcef/scripts/gather-license-files.sh
create mode 100755 package/libcef/scripts/version.sh
create mode 100644 package/libcef/templates/cef_version.h
create mode 100644 package/libcef/toolchain/BUILD.gn
diff --git a/package/Config.in b/package/Config.in
index 79933bfa8c..5fc2b8a635 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1562,6 +1562,7 @@ menu "Networking"
source "package/gupnp-dlna/Config.in"
source "package/ibrcommon/Config.in"
source "package/ibrdtn/Config.in"
+ source "package/libcef/Config.in"
source "package/libcgi/Config.in"
source "package/libcgicc/Config.in"
source "package/libcoap/Config.in"
diff --git a/package/libcef/0001-fix-one-euro-filter-build.patch b/package/libcef/0001-fix-one-euro-filter-build.patch
new file mode 100644
index 0000000000..7789a66a11
--- /dev/null
+++ b/package/libcef/0001-fix-one-euro-filter-build.patch
@@ -0,0 +1,33 @@
+From 8c747a9c14ed4905f60f6680e2e09e33ea34163e Mon Sep 17 00:00:00 2001
+From: Jose Dapena Paz <jose.dapena@lge.com>
+Date: Fri, 26 Jul 2019 16:18:17 +0000
+Subject: [PATCH] IWYU: include <memory> in one_euro_filter.h as it uses
+ std::unique_ptr
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Bug: 819294
+Change-Id: Ie1530f7046b0c8eb76e26adca530fa57c67ed876
+Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720637
+Reviewed-by: Ella Ge <eirage@chromium.org>
+Commit-Queue: Jos? Dapena Paz <jose.dapena@lge.com>
+Cr-Commit-Position: refs/heads/master@{#681321}
+---
+ third_party/one_euro_filter/src/one_euro_filter.h | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/third_party/one_euro_filter/src/one_euro_filter.h b/third_party/one_euro_filter/src/one_euro_filter.h
+index 7f8d15b62afa2..a8cd0ab9a2560 100644
+--- a/third_party/one_euro_filter/src/one_euro_filter.h
++++ b/third_party/one_euro_filter/src/one_euro_filter.h
+@@ -1,6 +1,8 @@
+ #ifndef ONE_EURO_ONE_EURO_FILTER_H_
+ #define ONE_EURO_ONE_EURO_FILTER_H_
+
++#include <memory>
++
+ #include "low_pass_filter.h"
+
+ namespace one_euro_filter {
+
diff --git a/package/libcef/0002-link-against-harfbuzz-subset.patch b/package/libcef/0002-link-against-harfbuzz-subset.patch
new file mode 100644
index 0000000000..9e10066cbd
--- /dev/null
+++ b/package/libcef/0002-link-against-harfbuzz-subset.patch
@@ -0,0 +1,50 @@
+From 27e25336b8316ff3ec4e464058682ed85801fd06 Mon Sep 17 00:00:00 2001
+From: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
+Date: Mon, 29 Jul 2019 10:54:28 +0000
+Subject: [PATCH] Also link against libharfbuzz-subset when use_system_harfbuzz is true
+
+When building HarfBuzz as part of Chromium, there is a single source set
+with all the files we need in the build.
+
+Upstream HarfBuzz, on the other hand, produces a few different libraries:
+harfbuzz, harfbuzz-icu and harfbuzz-subset. When |use_system_harfbuzz| is
+true, we were only looking for (and using) harfbuzz.pc with pkg-config even
+though we also use symbols from libharfbuzz-subset.so. This resulted in
+errors when linking:
+
+ ld: obj/skia/skia/SkPDFSubsetFont.o: in function `SkPDFSubsetFont(sk_sp<SkData>, SkPDFGlyphUse const&, SkPDF::Metadata::Subsetter, char const*, int)':
+ SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x48a): undefined reference to `hb_subset_input_create_or_fail'
+ ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x4af): undefined reference to `hb_subset_input_glyph_set'
+ ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x5d7): undefined reference to `hb_subset_input_set_retain_gids'
+ ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x5e4): undefined reference to `hb_subset_input_set_drop_hints'
+ ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x5f3): undefined reference to `hb_subset'
+ ld: SkPDFSubsetFont.cpp:(.text._Z15SkPDFSubsetFont5sk_spI6SkDataERK13SkPDFGlyphUseN5SkPDF8Metadata9SubsetterEPKci+0x66f): undefined reference to `hb_subset_input_destroy'
+
+as reported in
+https://groups.google.com/a/chromium.org/d/msg/chromium-packagers/UyJsVJ5QqWo/jSv5z7-rEQAJ
+
+Change-Id: I997af075c7b7263cd7cc71a63db5b0f93bd1ab59
+Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715288
+Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
+Commit-Queue: Dominik R??ttsches <drott@chromium.org>
+Reviewed-by: Dominik R??ttsches <drott@chromium.org>
+Cr-Commit-Position: refs/heads/master@{#681760}
+---
+
+diff --git a/third_party/harfbuzz-ng/BUILD.gn b/third_party/harfbuzz-ng/BUILD.gn
+index 37d8e33..72013eb1d 100644
+--- a/third_party/harfbuzz-ng/BUILD.gn
++++ b/third_party/harfbuzz-ng/BUILD.gn
+@@ -16,7 +16,10 @@
+ "//third_party:freetype_harfbuzz",
+ "//third_party/freetype:freetype_source",
+ ]
+- packages = [ "harfbuzz" ]
++ packages = [
++ "harfbuzz",
++ "harfbuzz-subset",
++ ]
+ }
+ } else {
+ config("harfbuzz_config") {
+
diff --git a/package/libcef/Config.in b/package/libcef/Config.in
new file mode 100644
index 0000000000..85a993bb93
--- /dev/null
+++ b/package/libcef/Config.in
@@ -0,0 +1,75 @@
+config BR2_PACKAGE_LIBCEF
+ bool "libcef"
+ depends on BR2_HOST_GCC_AT_LEAST_4_9 # gn requires -std=c++14
+ depends on BR2_INSTALL_LIBSTDCPP # icu
+ depends on BR2_USE_WCHAR # icu
+ depends on BR2_PACKAGE_HAS_LIBGL
+ depends on BR2_PACKAGE_XORG7
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
+ depends on BR2_TOOLCHAIN_USES_GLIBC
+ depends on BR2_TOOLCHAIN_HAS_THREADS # icu
+ depends on !BR2_BINFMT_FLAT # icu
+ select BR2_PACKAGE_AT_SPI2_ATK
+ select BR2_PACKAGE_ALSA_LIB
+ select BR2_PACKAGE_COMPILER_RT
+ select BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_FFMPEG
+ select BR2_PACKAGE_FLAC
+ select BR2_PACKAGE_FREETYPE
+ select BR2_PACKAGE_HARFBUZZ
+ select BR2_PACKAGE_LLVM_ENABLE_HOST_ARCH
+ select BR2_PACKAGE_HOST_CLANG
+ select BR2_PACKAGE_HOST_JPEG_TURBO
+ select BR2_PACKAGE_HOST_ICU
+ select BR2_PACKAGE_HOST_LLD
+ select BR2_PACKAGE_HOST_LLVM
+ select BR2_PACKAGE_HOST_NINJA
+ select BR2_PACKAGE_HOST_LIBKRB5
+ select BR2_PACKAGE_HOST_LIBNSS
+ select BR2_PACKAGE_HOST_NODEJS
+ select BR2_PACKAGE_HOST_PKGCONF
+ select BR2_PACKAGE_HOST_PYTHON
+ select BR2_PACKAGE_HOST_WEBP
+ select BR2_PACKAGE_ICU
+ select BR2_PACKAGE_JPEG_TURBO
+ select BR2_PACKAGE_LIBDRM
+ select BR2_PACKAGE_LIBERATION # runtime
+ select BR2_PACKAGE_LIBGLIB2
+ select BR2_PACKAGE_LIBGTK3_X11
+ select BR2_PACKAGE_LIBGTKGLEXT
+ select BR2_PACKAGE_LIBKRB5
+ select BR2_PACKAGE_LIBNSS
+ select BR2_PACKAGE_LIBPNG
+ select BR2_PACKAGE_PCIUTILS
+ select BR2_PACKAGE_PANGO
+ select BR2_PACKAGE_WEBP
+ select BR2_PACKAGE_WEBP_MUX
+ select BR2_PACKAGE_WEBP_DEMUX
+ select BR2_PACKAGE_LIBXML2
+ select BR2_PACKAGE_LIBXSLT
+ select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
+ select BR2_PACKAGE_XLIB_LIBXCURSOR
+ select BR2_PACKAGE_XLIB_LIBXRANDR
+ select BR2_PACKAGE_XLIB_LIBXSCRNSAVER
+ select BR2_PACKAGE_XLIB_LIBXV
+ select BR2_PACKAGE_ZLIB
+ help
+ Chromium Embedded Framework
+
+if BR2_PACKAGE_LIBCEF
+
+config BR2_PACKAGE_LIBCEF_TARGET_ARCH
+ string
+ default "arm" if BR2_arm
+ default "arm64" if BR2_aarch64
+ default "mips" if BR2_mips
+ default "x86" if BR2_i386
+ default "x64" if BR2_x86_64
+
+comment "CEF needs toolchain w/ Glibc"
+ depends on !BR2_TOOLCHAIN_USES_GLIBC
+
+comment "CEF depends on X.org and needs an OpenGL backend"
+ depends on !BR2_PACKAGE_XORG7 || !BR2_PACKAGE_HAS_LIBGL
+
+endif
diff --git a/package/libcef/libcef.license-files.inc b/package/libcef/libcef.license-files.inc
new file mode 100644
index 0000000000..03fd700f24
--- /dev/null
+++ b/package/libcef/libcef.license-files.inc
@@ -0,0 +1,1130 @@
+LIBCEF_LICENSE_FILES = \
+ base/third_party/cityhash/COPYING \
+ base/third_party/dmg_fp/LICENSE \
+ base/third_party/dynamic_annotations/LICENSE \
+ base/third_party/icu/LICENSE \
+ base/third_party/libevent/LICENSE \
+ base/third_party/nspr/LICENSE \
+ base/third_party/superfasthash/LICENSE \
+ base/third_party/symbolize/LICENSE \
+ base/third_party/valgrind/LICENSE \
+ base/third_party/xdg_mime/LICENSE \
+ base/third_party/xdg_user_dirs/LICENSE \
+ build/fuchsia/fidlgen_js/third_party/enum34/LICENSE \
+ buildtools/LICENSE \
+ buildtools/third_party/libc++abi/trunk/LICENSE.TXT \
+ buildtools/third_party/libc++/trunk/LICENSE.TXT \
+ buildtools/third_party/libc++/trunk/utils/google-benchmark/LICENSE \
+ buildtools/third_party/libunwind/trunk/LICENSE.TXT \
+ cef/LICENSE.txt \
+ cef/tools/yapf/LICENSE \
+ chrome/android/third_party/compositor_animator/LICENSE \
+ chrome/browser/resources/chromeos/camera/src/LICENSE \
+ chrome/browser/resources/chromeos/zip_archiver/LICENSE \
+ chrome/installer/mac/third_party/bsdiff/LICENSE \
+ chrome/installer/mac/third_party/xz/LICENSE \
+ chrome/test/vr/perf/latency/third_party/maestro/LICENSE \
+ chrome/third_party/mock4js/LICENSE \
+ chrome/third_party/mozilla_security_manager/LICENSE \
+ components/cronet/third_party/curl_headers/COPYING \
+ components/cronet/third_party/curl_headers/LICENSE \
+ courgette/third_party/divsufsort/LICENSE \
+ ios/third_party/blink/LICENSE \
+ ios/third_party/earl_grey2/LICENSE \
+ ios/third_party/earl_grey/LICENSE \
+ ios/third_party/edo/LICENSE \
+ ios/third_party/firebase/LICENSE \
+ ios/third_party/fishhook/LICENSE \
+ ios/third_party/gtx/LICENSE \
+ ios/third_party/material_components_ios/LICENSE \
+ ios/third_party/material_font_disk_loader_ios/LICENSE \
+ ios/third_party/material_internationalization_ios/LICENSE \
+ ios/third_party/material_roboto_font_loader_ios/LICENSE \
+ ios/third_party/material_sprited_animation_view_ios/LICENSE \
+ ios/third_party/material_text_accessibility_ios/LICENSE \
+ ios/third_party/motion_animator_objc/LICENSE \
+ ios/third_party/motion_interchange_objc/LICENSE \
+ ios/third_party/motion_transitioning_objc/LICENSE \
+ ios/third_party/ochamcrest/LICENSE \
+ ios/third_party/webkit/LICENSE \
+ LICENSE \
+ LICENSE.chromium_os \
+ mojo/public/LICENSE \
+ native_client/COPYING \
+ native_client/LICENSE \
+ native_client_sdk/src/COPYING \
+ native_client_sdk/src/libraries/third_party/pthreads-win32/COPYING \
+ native_client_sdk/src/libraries/third_party/pthreads-win32/COPYING.LIB \
+ native_client_sdk/src/libraries/third_party/pthreads-win32/LICENSE \
+ native_client_sdk/src/LICENSE \
+ native_client/src/third_party/pnacl_native_newlib_subset/COPYING.NEWLIB \
+ net/third_party/mozilla_security_manager/LICENSE \
+ net/third_party/nss/LICENSE \
+ net/third_party/quiche/src/LICENSE \
+ net/third_party/uri_template/LICENSE \
+ ppapi/LICENSE \
+ third_party/abseil-cpp/LICENSE \
+ third_party/accessibility-audit/LICENSE \
+ third_party/accessibility_test_framework/LICENSE \
+ third_party/afl/src/docs/COPYING \
+ third_party/android_build_tools/bundletool/LICENSE \
+ third_party/android_crazy_linker/LICENSE \
+ third_party/android_crazy_linker/src/LICENSE \
+ third_party/android_data_chart/LICENSE \
+ third_party/android_deps/libs/android_arch_core_common/LICENSE \
+ third_party/android_deps/libs/android_arch_lifecycle_common_java8/LICENSE \
+ third_party/android_deps/libs/android_arch_lifecycle_common/LICENSE \
+ third_party/android_deps/libs/android_arch_lifecycle_runtime/LICENSE \
+ third_party/android_deps/libs/androidx_annotation_annotation/LICENSE \
+ third_party/android_deps/libs/androidx_lifecycle_lifecycle_common/LICENSE \
+ third_party/android_deps/libs/androidx_test_core/LICENSE \
+ third_party/android_deps/libs/androidx_test_ext_junit/LICENSE \
+ third_party/android_deps/libs/androidx_test_monitor/LICENSE \
+ third_party/android_deps/libs/androidx_test_rules/LICENSE \
+ third_party/android_deps/libs/androidx_test_runner/LICENSE \
+ third_party/android_deps/libs/com_android_support_animated_vector_drawable/LICENSE \
+ third_party/android_deps/libs/com_android_support_appcompat_v7/LICENSE \
+ third_party/android_deps/libs/com_android_support_cardview_v7/LICENSE \
+ third_party/android_deps/libs/com_android_support_design/LICENSE \
+ third_party/android_deps/libs/com_android_support_gridlayout_v7/LICENSE \
+ third_party/android_deps/libs/com_android_support_leanback_v17/LICENSE \
+ third_party/android_deps/libs/com_android_support_mediarouter_v7/LICENSE \
+ third_party/android_deps/libs/com_android_support_multidex/LICENSE \
+ third_party/android_deps/libs/com_android_support_palette_v7/LICENSE \
+ third_party/android_deps/libs/com_android_support_preference_leanback_v17/LICENSE \
+ third_party/android_deps/libs/com_android_support_preference_v14/LICENSE \
+ third_party/android_deps/libs/com_android_support_preference_v7/LICENSE \
+ third_party/android_deps/libs/com_android_support_recyclerview_v7/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_annotations/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_compat/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_core_ui/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_core_utils/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_fragment/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_media_compat/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_v13/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_v4/LICENSE \
+ third_party/android_deps/libs/com_android_support_support_vector_drawable/LICENSE \
+ third_party/android_deps/libs/com_android_support_transition/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_auth_api_phone/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_auth_base/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_auth/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_base/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_basement/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_cast_framework/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_cast/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_clearcut/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_fido/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_flags/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_gcm/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_iid/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_instantapps/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_location/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_phenotype/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_places_placereport/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_stats/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_tasks/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_vision_common/LICENSE \
+ third_party/android_deps/libs/com_google_android_gms_play_services_vision/LICENSE \
+ third_party/android_deps/libs/com_google_ar_core/LICENSE \
+ third_party/android_deps/libs/com_google_code_findbugs_jsr305/LICENSE \
+ third_party/android_deps/libs/com_google_dagger_dagger_compiler/LICENSE \
+ third_party/android_deps/libs/com_google_dagger_dagger/LICENSE \
+ third_party/android_deps/libs/com_google_dagger_dagger_producers/LICENSE \
+ third_party/android_deps/libs/com_google_dagger_dagger_spi/LICENSE \
+ third_party/android_deps/libs/com_google_errorprone_error_prone_annotations/LICENSE \
+ third_party/android_deps/libs/com_google_errorprone_javac_shaded/LICENSE \
+ third_party/android_deps/libs/com_google_googlejavaformat_google_java_format/LICENSE \
+ third_party/android_deps/libs/com_google_guava_guava/LICENSE \
+ third_party/android_deps/libs/com_google_j2objc_j2objc_annotations/LICENSE \
+ third_party/android_deps/libs/com_google_protobuf_protobuf_lite/LICENSE \
+ third_party/android_deps/libs/com_squareup_javapoet/LICENSE \
+ third_party/android_deps/libs/javax_annotation_jsr250_api/LICENSE \
+ third_party/android_deps/libs/javax_inject_javax_inject/LICENSE \
+ third_party/android_deps/libs/net_sf_kxml_kxml2/LICENSE \
+ third_party/android_deps/libs/org_checkerframework_checker_compat_qual/LICENSE \
+ third_party/android_deps/libs/org_codehaus_mojo_animal_sniffer_annotations/LICENSE \
+ third_party/android_deps/licenses/Android_SDK_License-December_9_2016.txt \
+ third_party/android_deps/licenses/Codehaus_License-2009.txt \
+ third_party/android_media/LICENSE \
+ third_party/android_opengl/LICENSE \
+ third_party/android_platform/LICENSE \
+ third_party/android_sdk/LICENSE \
+ third_party/android_support_test_runner/LICENSE \
+ third_party/android_swipe_refresh/LICENSE \
+ third_party/android_system_sdk/LICENSE \
+ third_party/angle/LICENSE \
+ third_party/angle/src/common/third_party/smhasher/LICENSE \
+ third_party/angle/src/common/third_party/xxhash/LICENSE \
+ third_party/angle/src/tests/test_utils/third_party/LICENSE \
+ third_party/angle/src/third_party/compiler/LICENSE \
+ third_party/angle/src/third_party/libXNVCtrl/LICENSE \
+ third_party/angle/third_party/deqp/src/external/graphicsfuzz/data/gles3/graphicsfuzz/LICENSE \
+ third_party/angle/third_party/deqp/src/external/vulkancts/LICENSE \
+ third_party/angle/third_party/deqp/src/LICENSE \
+ third_party/angle/third_party/deqp/src/MODULE_LICENSE_APACHE2 \
+ third_party/angle/third_party/glmark2/src/COPYING \
+ third_party/angle/third_party/glmark2/src/COPYING.SGI \
+ third_party/angle/third_party/glmark2/src/src/libjpeg-turbo/LICENSE.md \
+ third_party/angle/third_party/glmark2/src/src/libmatrix/COPYING \
+ third_party/angle/third_party/glmark2/src/src/libpng/LICENSE \
+ third_party/angle/third_party/rapidjson/src/bin/jsonschema/LICENSE \
+ third_party/angle/third_party/rapidjson/src/contrib/natvis/LICENSE \
+ third_party/angle/third_party/rapidjson/src/license.txt \
+ third_party/angle/third_party/vulkan-headers/src/LICENSE.txt \
+ third_party/angle/third_party/vulkan-loader/src/LICENSE.txt \
+ third_party/angle/third_party/vulkan-tools/src/LICENSE.txt \
+ third_party/angle/third_party/vulkan-tools/src/winrt/VulkanRT-License.txt \
+ third_party/angle/third_party/vulkan-validation-layers/src/LICENSE.txt \
+ third_party/angle/util/windows/third_party/StackWalker/LICENSE \
+ third_party/apache-mac/LICENSE \
+ third_party/apache-portable-runtime/LICENSE \
+ third_party/apache-win32/LICENSE.txt \
+ third_party/apk-patch-size-estimator/LICENSE \
+ third_party/apple_apsl/LICENSE \
+ third_party/arcore-android-sdk-client/LICENSE \
+ third_party/arcore-android-sdk/LICENSE \
+ third_party/ashmem/LICENSE \
+ third_party/axe-core/LICENSE \
+ third_party/bazel/LICENSE \
+ third_party/binutils/LICENSE \
+ third_party/blanketjs/LICENSE \
+ third_party/blink/LICENSE_FOR_ABOUT_CREDITS \
+ third_party/blink/perf_tests/speedometer/resources/flightjs-example-app/components/es5-shim/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/flightjs-example-app/components/jasmine-flight/LICENSE.md \
+ third_party/blink/perf_tests/speedometer/resources/flightjs-example-app/LICENSE.md \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/architecture-examples/jquery/node_modules/director/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/architecture-examples/react/license.md \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/architecture-examples/react/node_modules/director/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/architecture-examples/react/node_modules/react/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE \
+ third_party/blink/perf_tests/speedometer/resources/todomvc/license.md \
+ third_party/blink/perf_tests/svg/resources/LICENSES \
+ third_party/blink/renderer/core/LICENSE-APPLE \
+ third_party/blink/renderer/core/LICENSE-LGPL-2 \
+ third_party/blink/renderer/core/LICENSE-LGPL-2.1 \
+ third_party/blink/renderer/devtools/front_end/audits/lighthouse/LICENSE \
+ third_party/blink/renderer/devtools/front_end/audits_worker/lighthouse/LICENSE \
+ third_party/blink/renderer/devtools/front_end/cm/LICENSE \
+ third_party/blink/renderer/devtools/front_end/cm/LICENSE_python \
+ third_party/blink/renderer/devtools/front_end/cm_modes/LICENSE \
+ third_party/blink/renderer/devtools/front_end/formatter_worker/acorn/LICENSE \
+ third_party/blink/renderer/devtools/front_end/terminal/xterm.js/LICENSE \
+ third_party/blink/renderer/devtools/LICENSE \
+ third_party/blink/renderer/devtools/scripts/closure/COPYING \
+ third_party/blink/renderer/platform/testing/data/third_party/Noto/LICENSE_OFL.txt \
+ third_party/blink/renderer/platform/testing/data/third_party/Roboto/LICENSE.txt \
+ third_party/blink/renderer/platform/wtf/dtoa/COPYING \
+ third_party/blink/renderer/platform/wtf/dtoa/LICENSE \
+ third_party/boringssl/src/LICENSE \
+ third_party/boringssl/src/third_party/fiat/LICENSE \
+ third_party/boringssl/src/third_party/googletest/LICENSE \
+ third_party/boringssl/src/third_party/sike/LICENSE \
+ third_party/boringssl/src/third_party/wycheproof_testvectors/LICENSE \
+ third_party/bouncycastle/LICENSE \
+ third_party/breakpad/breakpad/LICENSE \
+ third_party/breakpad/breakpad/src/third_party/curl/COPYING \
+ third_party/breakpad/breakpad/src/third_party/libdisasm/LICENSE \
+ third_party/breakpad/LICENSE \
+ third_party/brotli/LICENSE \
+ third_party/bspatch/LICENSE \
+ third_party/byte_buddy/LICENSE \
+ third_party/cacheinvalidation/src/google/cacheinvalidation/COPYING \
+ third_party/cacheinvalidation/src/java/COPYING \
+ third_party/catapult/common/eslint/LICENSE \
+ third_party/catapult/common/py_vulcanize/third_party/rcssmin/bench/LICENSE.cssmin \
+ third_party/catapult/common/py_vulcanize/third_party/rcssmin/LICENSE \
+ third_party/catapult/common/py_vulcanize/third_party/rjsmin/LICENSE \
+ third_party/catapult/experimental/trace_on_tap/LICENSE \
+ third_party/catapult/experimental/trace_on_tap/third_party/pako/LICENSE \
+ third_party/catapult/LICENSE \
+ third_party/catapult/systrace/profile_chrome/third_party/COPYING \
+ third_party/catapult/systrace/systrace/LICENSE \
+ third_party/catapult/telemetry/third_party/altgraph/doc/license.rst \
+ third_party/catapult/telemetry/third_party/chromite/LICENSE \
+ third_party/catapult/telemetry/third_party/flot/LICENSE.txt \
+ third_party/catapult/telemetry/third_party/mock/LICENSE.txt \
+ third_party/catapult/telemetry/third_party/modulegraph/doc/license.rst \
+ third_party/catapult/telemetry/third_party/mox3/COPYING.txt \
+ third_party/catapult/telemetry/third_party/pyfakefs/pyfakefs/COPYING \
+ third_party/catapult/telemetry/third_party/tsproxy/LICENSE \
+ third_party/catapult/telemetry/third_party/WebKit/LICENSE \
+ third_party/catapult/telemetry/third_party/websocket-client/LICENSE \
+ third_party/catapult/third_party/apiclient/LICENSE \
+ third_party/catapult/third_party/beautifulsoup4/COPYING.txt \
+ third_party/catapult/third_party/cachetools/LICENSE \
+ third_party/catapult/third_party/certifi/LICENSE.txt \
+ third_party/catapult/third_party/chai/LICENSE \
+ third_party/catapult/third_party/chardet/LICENSE \
+ third_party/catapult/third_party/cloudstorage/COPYING \
+ third_party/catapult/third_party/coverage/LICENSE.txt \
+ third_party/catapult/third_party/d3/LICENSE \
+ third_party/catapult/third_party/flot/LICENSE.txt \
+ third_party/catapult/third_party/gae_ts_mon/LICENSE \
+ third_party/catapult/third_party/google-auth/LICENSE \
+ third_party/catapult/third_party/google-endpoints/enum/LICENSE \
+ third_party/catapult/third_party/gsutil/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/apitools/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/argcomplete/LICENSE.rst \
+ third_party/catapult/third_party/gsutil/third_party/boto/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/crcmod/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/crcmod_osx/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/fasteners/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/funcsigs/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/gcs-oauth2-boto-plugin/COPYING \
+ third_party/catapult/third_party/gsutil/third_party/httplib2/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/mock/LICENSE.txt \
+ third_party/catapult/third_party/gsutil/third_party/monotonic/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/oauth2client/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/pyasn1/docs/source/license.rst \
+ third_party/catapult/third_party/gsutil/third_party/pyasn1/LICENSE.rst \
+ third_party/catapult/third_party/gsutil/third_party/pyasn1-modules/LICENSE.txt \
+ third_party/catapult/third_party/gsutil/third_party/python-gflags/COPYING \
+ third_party/catapult/third_party/gsutil/third_party/retry-decorator/LICENSE.txt \
+ third_party/catapult/third_party/gsutil/third_party/rsa/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/six/LICENSE \
+ third_party/catapult/third_party/gsutil/third_party/socksipy-branch/LICENSE \
+ third_party/catapult/third_party/html5lib-python/doc/license.rst \
+ third_party/catapult/third_party/html5lib-python/LICENSE \
+ third_party/catapult/third_party/idb/LICENSE \
+ third_party/catapult/third_party/idna/LICENSE.rst \
+ third_party/catapult/third_party/ijson/LICENSE.txt \
+ third_party/catapult/third_party/mocha/LICENSE \
+ third_party/catapult/third_party/mox3/COPYING.txt \
+ third_party/catapult/third_party/oauth2client/LICENSE \
+ third_party/catapult/third_party/Paste/docs/license.txt \
+ third_party/catapult/third_party/polymer2/bower_components/accessibility-developer-tools/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/async/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/google-apis/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/google-signin/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/lodash/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/marked/LICENSE.md \
+ third_party/catapult/third_party/polymer2/bower_components/mocha/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/moment/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/moment-timezone/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/polymer/LICENSE.txt \
+ third_party/catapult/third_party/polymer2/bower_components/polymer-redux/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/sinon-chai/LICENSE.txt \
+ third_party/catapult/third_party/polymer2/bower_components/stacky/LICENSE \
+ third_party/catapult/third_party/polymer2/bower_components/web-animations-js/COPYING \
+ third_party/catapult/third_party/polymer2/bower_components/webcomponentsjs/LICENSE.md \
+ third_party/catapult/third_party/polymer2/LICENSE.polymer \
+ third_party/catapult/third_party/polymer3/bower_components/polymer/LICENSE.txt \
+ third_party/catapult/third_party/polymer3/LICENSE.polymer \
+ third_party/catapult/third_party/polymer/components/google-apis/LICENSE \
+ third_party/catapult/third_party/polymer/components/google-signin/LICENSE \
+ third_party/catapult/third_party/polymer/components/polymer/LICENSE.txt \
+ third_party/catapult/third_party/polymer/components/promise-polyfill/LICENSE \
+ third_party/catapult/third_party/polymer/components/shadycss/LICENSE.md \
+ third_party/catapult/third_party/polymer/components/web-animations-js/COPYING \
+ third_party/catapult/third_party/polymer/LICENSE.polymer \
+ third_party/catapult/third_party/pyasn1/LICENSE.txt \
+ third_party/catapult/third_party/pyasn1_modules/LICENSE.txt \
+ third_party/catapult/third_party/pyfakefs/COPYING \
+ third_party/catapult/third_party/pyserial/LICENSE.txt \
+ third_party/catapult/third_party/python_gflags/COPYING \
+ third_party/catapult/third_party/redux/LICENSE.md \
+ third_party/catapult/third_party/requests/LICENSE \
+ third_party/catapult/third_party/requests_toolbelt/LICENSE \
+ third_party/catapult/third_party/rsa/LICENSE.txt \
+ third_party/catapult/third_party/six/LICENSE \
+ third_party/catapult/third_party/snap-it/LICENSE \
+ third_party/catapult/third_party/tsmon_client/LICENSE \
+ third_party/catapult/third_party/typ/LICENSE \
+ third_party/catapult/third_party/urllib3/LICENSE.txt \
+ third_party/catapult/third_party/vinn/third_party/parse5/LICENSE \
+ third_party/catapult/third_party/vinn/third_party/v8/LICENSE \
+ third_party/catapult/third_party/vinn/third_party/v8/LICENSE.strongtalk \
+ third_party/catapult/third_party/vinn/third_party/v8/LICENSE.v8 \
+ third_party/catapult/third_party/vinn/third_party/v8/LICENSE.valgrind \
+ third_party/catapult/third_party/webapp2/LICENSE \
+ third_party/catapult/third_party/WebOb/docs/license.txt \
+ third_party/catapult/third_party/zipfile/LICENSE \
+ third_party/catapult/tracing/LICENSE \
+ third_party/catapult/tracing/third_party/chai/LICENSE \
+ third_party/catapult/tracing/third_party/d3/LICENSE \
+ third_party/catapult/tracing/third_party/devscripts/COPYING \
+ third_party/catapult/tracing/third_party/gl-matrix/LICENSE.md \
+ third_party/catapult/tracing/third_party/jpeg-js/LICENSE \
+ third_party/catapult/tracing/third_party/jszip/LICENSE.markdown \
+ third_party/catapult/tracing/third_party/mocha/LICENSE \
+ third_party/catapult/tracing/third_party/pako/LICENSE \
+ third_party/ced/LICENSE \
+ third_party/ced/src/LICENSE \
+ third_party/chaijs/LICENSE \
+ third_party/checkstyle/LICENSE \
+ third_party/checkstyle/LICENSE.apache20 \
+ third_party/chromevox/LICENSE \
+ third_party/chromevox/third_party/closure-library/LICENSE \
+ third_party/chromevox/third_party/sre/LICENSE \
+ third_party/chromite/LICENSE \
+ third_party/chromite/licensing/extra_package_licenses/libarchive-3.1.2.LICENSE \
+ third_party/chromite/scripts/sysmon/LICENSE \
+ third_party/chromite/third_party/boto/LICENSE \
+ third_party/chromite/third_party/httplib2/LICENSE \
+ third_party/chromite/third_party/oauth2client/LICENSE \
+ third_party/chromite/third_party/six/LICENSE \
+ third_party/cld_3/LICENSE \
+ third_party/cld_3/src/LICENSE \
+ third_party/closure_compiler/compiler/COPYING \
+ third_party/closure_compiler/LICENSE \
+ third_party/colorama/LICENSE \
+ third_party/colorama/src/LICENSE.txt \
+ third_party/crashpad/crashpad/LICENSE \
+ third_party/crashpad/crashpad/third_party/apple_cf/APPLE_LICENSE \
+ third_party/crashpad/crashpad/third_party/cpp-httplib/cpp-httplib/LICENSE \
+ third_party/crashpad/crashpad/third_party/getopt/LICENSE \
+ third_party/crashpad/crashpad/third_party/glibc/COPYING.LIB \
+ third_party/crashpad/crashpad/third_party/xnu/APPLE_LICENSE \
+ third_party/crc32c/src/LICENSE \
+ third_party/cros_system_api/LICENSE \
+ third_party/custom_tabs_client/LICENSE \
+ third_party/d3/src/LICENSE \
+ third_party/dav1d/libdav1d/COPYING \
+ third_party/dav1d/LICENSE \
+ third_party/dawn/LICENSE \
+ third_party/decklink/LICENSE \
+ third_party/depot_tools/LICENSE \
+ third_party/depot_tools/third_party/colorama/LICENSE.txt \
+ third_party/depot_tools/third_party/httplib2/LICENSE \
+ third_party/depot_tools/third_party/logilab/astroid/LICENSE.txt \
+ third_party/depot_tools/third_party/logilab/lazy_object_proxy/LICENSE \
+ third_party/depot_tools/third_party/logilab/wrapt/LICENSE \
+ third_party/depot_tools/third_party/mock/LICENSE.txt \
+ third_party/depot_tools/third_party/oauth2client/LICENSE \
+ third_party/depot_tools/third_party/pylint/LICENSE.txt \
+ third_party/depot_tools/third_party/repo/COPYING \
+ third_party/depot_tools/third_party/retry_decorator/LICENSE.google \
+ third_party/depot_tools/third_party/schema/LICENSE-MIT \
+ third_party/devscripts/COPYING \
+ third_party/devtools-node-modules/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/acorn-jsx/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/acorn/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/ajv/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/ansi-escapes/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/ansi-regex/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/ansi-styles/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/argparse/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/astral-regex/license \
+ third_party/devtools-node-modules/third_party/node_modules/@babel/code-frame/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/@babel/highlight/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/balanced-match/LICENSE.md \
+ third_party/devtools-node-modules/third_party/node_modules/brace-expansion/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/callsites/license \
+ third_party/devtools-node-modules/third_party/node_modules/chalk/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/chardet/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/cli-cursor/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/cli-width/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/color-convert/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/color-name/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/concat-map/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/cross-spawn/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/debug/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/deep-is/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/doctrine/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/doctrine/LICENSE.closure-compiler \
+ third_party/devtools-node-modules/third_party/node_modules/doctrine/LICENSE.esprima \
+ third_party/devtools-node-modules/third_party/node_modules/emoji-regex/LICENSE-MIT.txt \
+ third_party/devtools-node-modules/third_party/node_modules/escape-string-regexp/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/eslint/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/eslint-scope/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/eslint-utils/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/eslint-visitor-keys/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/espree/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/esprima/LICENSE.BSD \
+ third_party/devtools-node-modules/third_party/node_modules/esquery/license.txt \
+ third_party/devtools-node-modules/third_party/node_modules/estraverse/LICENSE.BSD \
+ third_party/devtools-node-modules/third_party/node_modules/esutils/LICENSE.BSD \
+ third_party/devtools-node-modules/third_party/node_modules/external-editor/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/fast-deep-equal/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/fast-json-stable-stringify/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/fast-levenshtein/LICENSE.md \
+ third_party/devtools-node-modules/third_party/node_modules/figures/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/file-entry-cache/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/flat-cache/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/flatted/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/fs.realpath/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/functional-red-black-tree/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/globals/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/glob/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/glob-parent/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/glob-parent/node_modules/is-glob/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/has-flag/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/iconv-lite/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/ignore/LICENSE-MIT \
+ third_party/devtools-node-modules/third_party/node_modules/import-fresh/license \
+ third_party/devtools-node-modules/third_party/node_modules/inflight/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/inherits/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/inquirer/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/inquirer/node_modules/ansi-regex/license \
+ third_party/devtools-node-modules/third_party/node_modules/inquirer/node_modules/strip-ansi/license \
+ third_party/devtools-node-modules/third_party/node_modules/isexe/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/is-extglob/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/is-fullwidth-code-point/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/is-glob/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/is-promise/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/json-schema-traverse/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/json-stable-stringify-without-jsonify/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/js-tokens/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/js-yaml/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/levn/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/lodash/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/mimic-fn/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/minimatch/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/minimist/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/mkdirp/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/ms/license.md \
+ third_party/devtools-node-modules/third_party/node_modules/mute-stream/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/nice-try/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/once/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/onetime/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/optionator/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/os-tmpdir/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/parent-module/license \
+ third_party/devtools-node-modules/third_party/node_modules/path-dirname/license \
+ third_party/devtools-node-modules/third_party/node_modules/path-is-absolute/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/path-key/license \
+ third_party/devtools-node-modules/third_party/node_modules/prelude-ls/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/progress/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/punycode/LICENSE-MIT.txt \
+ third_party/devtools-node-modules/third_party/node_modules/regexpp/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/resolve-from/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/restore-cursor/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/rimraf/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/run-async/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/rxjs/_esm2015/LICENSE.txt \
+ third_party/devtools-node-modules/third_party/node_modules/rxjs/_esm5/LICENSE.txt \
+ third_party/devtools-node-modules/third_party/node_modules/rxjs/LICENSE.txt \
+ third_party/devtools-node-modules/third_party/node_modules/rxjs/src/LICENSE.txt \
+ third_party/devtools-node-modules/third_party/node_modules/safer-buffer/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/semver/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/shebang-command/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/shebang-regex/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/signal-exit/LICENSE.txt \
+ third_party/devtools-node-modules/third_party/node_modules/slice-ansi/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/sprintf-js/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/string-width/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/strip-ansi/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/strip-json-comments/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/supports-color/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/table/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/table/node_modules/ansi-regex/license \
+ third_party/devtools-node-modules/third_party/node_modules/table/node_modules/string-width/license \
+ third_party/devtools-node-modules/third_party/node_modules/table/node_modules/strip-ansi/license \
+ third_party/devtools-node-modules/third_party/node_modules/text-table/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/through/LICENSE.APACHE2 \
+ third_party/devtools-node-modules/third_party/node_modules/through/LICENSE.MIT \
+ third_party/devtools-node-modules/third_party/node_modules/tmp/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/tslib/LICENSE.txt \
+ third_party/devtools-node-modules/third_party/node_modules/type-check/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/which/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/wordwrap/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/wrappy/LICENSE \
+ third_party/devtools-node-modules/third_party/node_modules/write/LICENSE \
+ third_party/dom_distiller_js/LICENSE \
+ third_party/emoji-segmenter/LICENSE \
+ third_party/emoji-segmenter/src/LICENSE \
+ third_party/errorprone/LICENSE \
+ third_party/espresso/LICENSE \
+ third_party/expat/files/COPYING \
+ third_party/feed/LICENSE \
+ third_party/ffmpeg/chromium/scripts/license_texts/full_lgpl.txt \
+ third_party/ffmpeg/COPYING.GPLv2 \
+ third_party/ffmpeg/COPYING.GPLv3 \
+ third_party/ffmpeg/COPYING.LGPLv2.1 \
+ third_party/ffmpeg/COPYING.LGPLv3 \
+ third_party/ffmpeg/LICENSE.md \
+ third_party/flac/COPYING.FDL \
+ third_party/flac/COPYING.GPL \
+ third_party/flac/COPYING.LGPL \
+ third_party/flac/COPYING.Xiph \
+ third_party/flatbuffers/LICENSE \
+ third_party/flatbuffers/src/dart/LICENSE \
+ third_party/flatbuffers/src/LICENSE.txt \
+ third_party/flot/LICENSE.txt \
+ third_party/fontconfig/LICENSE \
+ third_party/fontconfig/src/COPYING \
+ third_party/freetype/src/docs/GPLv2.TXT \
+ third_party/freetype/src/docs/LICENSE.TXT \
+ third_party/fuchsia-sdk/LICENSE \
+ third_party/gestures/gestures/LICENSE \
+ third_party/gestures/LICENSE \
+ third_party/gif_player/LICENSE \
+ third_party/glfw/src/LICENSE.md \
+ third_party/glslang/LICENSE \
+ third_party/glslang/src/LICENSE.txt \
+ third_party/google_android_play_core/LICENSE \
+ third_party/google_input_tools/LICENSE \
+ third_party/google_input_tools/third_party/closure_library/LICENSE \
+ third_party/googletest/src/googlemock/LICENSE \
+ third_party/googletest/src/googlemock/scripts/generator/LICENSE \
+ third_party/googletest/src/googletest/LICENSE \
+ third_party/googletest/src/LICENSE \
+ third_party/google_toolbox_for_mac/LICENSE \
+ third_party/google_trust_services/src/LICENSE \
+ third_party/google-truth/LICENSE \
+ third_party/grpc/LICENSE \
+ third_party/grpc/src/LICENSE \
+ third_party/grpc/src/src/php/ext/grpc/LICENSE \
+ third_party/grpc/src/third_party/address_sorting/LICENSE \
+ third_party/grpc/src/third_party/nanopb/LICENSE.txt \
+ third_party/grpc/src/third_party/rake-compiler-dock/LICENSE.txt \
+ third_party/gson/LICENSE \
+ third_party/guava/LICENSE \
+ third_party/gvr-android-keyboard/LICENSE \
+ third_party/gvr-android-sdk/LICENSE \
+ third_party/hamcrest/LICENSE \
+ third_party/harfbuzz-ng/src/COPYING \
+ third_party/harfbuzz-ng/src/test/shaping/data/aots/COPYING \
+ third_party/harfbuzz-ng/src/test/shaping/data/in-house/COPYING \
+ third_party/harfbuzz-ng/src/test/shaping/data/text-rendering-tests/COPYING \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-arabic/script-arabic/language-urdu/crulp/ligatures/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-assamese/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-bengali/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-devanagari/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-gujarati/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-gurmukhi/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-kannada/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-malayalam/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-oriya/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-sinhala/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-tamil/utrrs/LICENSE \
+ third_party/harfbuzz-ng/src/test/shaping/texts/in-house/shaper-indic/script-telugu/utrrs/LICENSE \
+ third_party/hunspell/COPYING \
+ third_party/hunspell/COPYING.LESSER \
+ third_party/hunspell/COPYING.MPL \
+ third_party/iaccessible2/LICENSE \
+ third_party/iccjpeg/LICENSE \
+ third_party/icu4j/LICENSE \
+ third_party/icu/LICENSE \
+ third_party/icu/scripts/LICENSE \
+ third_party/ijar/LICENSE \
+ third_party/ink/LICENSE \
+ third_party/inspector_protocol/LICENSE \
+ third_party/intellij/LICENSE \
+ third_party/isimpledom/LICENSE \
+ third_party/jacoco/LICENSE \
+ third_party/javalang/LICENSE \
+ third_party/jinja2/LICENSE \
+ third_party/jsoncpp/LICENSE \
+ third_party/jsoncpp/source/LICENSE \
+ third_party/jstemplate/COPYING \
+ third_party/junit/LICENSE \
+ third_party/khronos/LICENSE \
+ third_party/lcov/COPYING \
+ third_party/leveldatabase/src/LICENSE \
+ third_party/libaddressinput/LICENSE \
+ third_party/libaddressinput/src/cpp/LICENSE.chromium \
+ third_party/libaddressinput/src/LICENSE \
+ third_party/libaom/source/libaom/LICENSE \
+ third_party/libaom/source/libaom/third_party/fastfeat/LICENSE \
+ third_party/libaom/source/libaom/third_party/googletest/src/googletest/LICENSE \
+ third_party/libaom/source/libaom/third_party/libwebm/LICENSE.TXT \
+ third_party/libaom/source/libaom/third_party/vector/LICENSE \
+ third_party/libaom/source/libaom/third_party/x86inc/LICENSE \
+ third_party/libcxx-pretty-printers/LICENSE \
+ third_party/libevdev/LICENSE \
+ third_party/libFuzzer/LICENSE.TXT \
+ third_party/libjingle_xmpp/LICENSE \
+ third_party/libjpeg/LICENSE \
+ third_party/libjpeg_turbo/LICENSE.md \
+ third_party/liblouis/LICENSE \
+ third_party/liblouis/src/COPYING \
+ third_party/liblouis/src/COPYING.LESSER \
+ third_party/liblouis/src/License.md \
+ third_party/libovr/LICENSE \
+ third_party/libphonenumber/dist/cpp/LICENSE \
+ third_party/libphonenumber/dist/LICENSE \
+ third_party/libphonenumber/dist/LICENSE.Chromium \
+ third_party/libphonenumber/LICENSE \
+ third_party/libpng/LICENSE \
+ third_party/libprotobuf-mutator/src/LICENSE \
+ third_party/libsecret/LICENSE \
+ third_party/libsrtp/LICENSE \
+ third_party/libsync/LICENSE \
+ third_party/libudev/LICENSE \
+ third_party/libusb/src/COPYING \
+ third_party/libvpx/source/libvpx/LICENSE \
+ third_party/libvpx/source/libvpx/third_party/googletest/src/LICENSE \
+ third_party/libvpx/source/libvpx/third_party/libwebm/LICENSE.TXT \
+ third_party/libvpx/source/libvpx/third_party/libyuv/LICENSE \
+ third_party/libvpx/source/libvpx/third_party/x86inc/LICENSE \
+ third_party/libwebm/source/LICENSE.TXT \
+ third_party/libwebp/LICENSE \
+ third_party/libxml/src/COPYING \
+ third_party/libXNVCtrl/LICENSE \
+ third_party/libyuv/LICENSE \
+ third_party/llvm/clang/LICENSE.TXT \
+ third_party/llvm/clang/test/SemaObjC/warn-assign-property-nscopying.m \
+ third_party/llvm/clang/tools/clang-format-vs/ClangFormat/license.txt \
+ third_party/llvm/clang-tools-extra/clangd/clients/clangd-vscode/LICENSE \
+ third_party/llvm/clang-tools-extra/clang-tidy/cert/LICENSE.TXT \
+ third_party/llvm/clang-tools-extra/clang-tidy/hicpp/LICENSE.TXT \
+ third_party/llvm/clang-tools-extra/clang-tidy-vs/ClangTidy/license.txt \
+ third_party/llvm/clang-tools-extra/LICENSE.TXT \
+ third_party/llvm/compiler-rt/LICENSE.TXT \
+ third_party/llvm/libclc/LICENSE.TXT \
+ third_party/llvm/libcxxabi/LICENSE.TXT \
+ third_party/llvm/libcxx/LICENSE.TXT \
+ third_party/llvm/libcxx/utils/google-benchmark/LICENSE \
+ third_party/llvm/libunwind/LICENSE.TXT \
+ third_party/llvm/lldb/LICENSE.TXT \
+ third_party/llvm/lldb/third_party/Python/module/pexpect-4.6/LICENSE \
+ third_party/llvm/lldb/third_party/Python/module/ptyprocess-0.6.0/LICENSE \
+ third_party/llvm/lldb/third_party/Python/module/six/LICENSE \
+ third_party/llvm/lld/LICENSE.TXT \
+ third_party/llvm/llgo/LICENSE.TXT \
+ third_party/llvm/llgo/third_party/gofrontend/libffi/LICENSE \
+ third_party/llvm/llgo/third_party/gofrontend/libgo/LICENSE \
+ third_party/llvm/llgo/third_party/gofrontend/LICENSE \
+ third_party/llvm/llgo/third_party/gotools/LICENSE \
+ third_party/llvm/llgo/third_party/liner/COPYING \
+ third_party/llvm/llvm/include/llvm/Support/LICENSE.TXT \
+ third_party/llvm/llvm/LICENSE.TXT \
+ third_party/llvm/llvm/test/YAMLParser/LICENSE.txt \
+ third_party/llvm/llvm/tools/msbuild/license.txt \
+ third_party/llvm/llvm/utils/benchmark/LICENSE \
+ third_party/llvm/llvm/utils/unittest/googlemock/LICENSE.txt \
+ third_party/llvm/llvm/utils/unittest/googletest/LICENSE.TXT \
+ third_party/llvm/openmp/LICENSE.txt \
+ third_party/llvm/parallel-libs/acxxel/LICENSE.TXT \
+ third_party/llvm/polly/lib/External/isl/LICENSE \
+ third_party/llvm/polly/LICENSE.txt \
+ third_party/llvm/polly/tools/GPURuntime/LICENSE.TXT \
+ third_party/llvm/pstl/LICENSE.txt \
+ third_party/logilab/logilab/astroid/LICENSE.txt \
+ third_party/logilab/logilab/common/LICENSE.txt \
+ third_party/lottie/LICENSE \
+ third_party/lzma_sdk/LICENSE \
+ third_party/markdown/LICENSE \
+ third_party/markupsafe/LICENSE \
+ third_party/material_design_icons/LICENSE \
+ third_party/mesa_headers/LICENSE \
+ third_party/metrics_proto/LICENSE \
+ third_party/microsoft_webauthn/LICENSE \
+ third_party/minigbm/LICENSE \
+ third_party/minigbm/src/LICENSE \
+ third_party/minizip/src/lib/bzip2/LICENSE \
+ third_party/minizip/src/LICENSE \
+ third_party/mocha/LICENSE \
+ third_party/mockito/LICENSE \
+ third_party/modp_b64/LICENSE \
+ third_party/motemplate/LICENSE \
+ third_party/mozilla/LICENSE \
+ third_party/nasm/LICENSE \
+ third_party/netty4/LICENSE \
+ third_party/netty-tcnative/LICENSE \
+ third_party/node/LICENSE \
+ third_party/node/node_modules/acorn-jsx/LICENSE \
+ third_party/node/node_modules/acorn-jsx/node_modules/acorn/LICENSE \
+ third_party/node/node_modules/acorn/LICENSE \
+ third_party/node/node_modules/ajv-keywords/LICENSE \
+ third_party/node/node_modules/ajv/LICENSE \
+ third_party/node/node_modules/ansi-escape-sequences/LICENSE \
+ third_party/node/node_modules/ansi-escapes/license \
+ third_party/node/node_modules/ansi-regex/license \
+ third_party/node/node_modules/ansi-styles/license \
+ third_party/node/node_modules/argparse/LICENSE \
+ third_party/node/node_modules/array-back/LICENSE \
+ third_party/node/node_modules/brace-expansion/LICENSE \
+ third_party/node/node_modules/buffer-from/LICENSE \
+ third_party/node/node_modules/chalk/license \
+ third_party/node/node_modules/circular-json/LICENSE.txt \
+ third_party/node/node_modules/circular-json/template/license.after \
+ third_party/node/node_modules/circular-json/template/license.before \
+ third_party/node/node_modules/cli-cursor/license \
+ third_party/node/node_modules/cli-width/LICENSE \
+ third_party/node/node_modules/clone/LICENSE \
+ third_party/node/node_modules/coa/LICENSE \
+ third_party/node/node_modules/coa/node_modules/ansi-styles/license \
+ third_party/node/node_modules/coa/node_modules/chalk/license \
+ third_party/node/node_modules/coa/node_modules/supports-color/license \
+ third_party/node/node_modules/code-point-at/license \
+ third_party/node/node_modules/co/LICENSE \
+ third_party/node/node_modules/color-convert/LICENSE \
+ third_party/node/node_modules/color-name/LICENSE \
+ third_party/node/node_modules/commander/LICENSE \
+ third_party/node/node_modules/command-line-args/LICENSE \
+ third_party/node/node_modules/command-line-usage/LICENSE \
+ third_party/node/node_modules/concat-map/LICENSE \
+ third_party/node/node_modules/concat-stream/LICENSE \
+ third_party/node/node_modules/core-js/LICENSE \
+ third_party/node/node_modules/core-util-is/LICENSE \
+ third_party/node/node_modules/crisper/LICENSE \
+ third_party/node/node_modules/csso/LICENSE \
+ third_party/node/node_modules/csso/node_modules/css-tree/LICENSE \
+ third_party/node/node_modules/css-select-base-adapter/LICENSE \
+ third_party/node/node_modules/css-select/LICENSE \
+ third_party/node/node_modules/css-tree/LICENSE \
+ third_party/node/node_modules/css-url-regex/license \
+ third_party/node/node_modules/css-what/LICENSE \
+ third_party/node/node_modules/debug/LICENSE \
+ third_party/node/node_modules/deep-extend/LICENSE \
+ third_party/node/node_modules/deep-is/LICENSE \
+ third_party/node/node_modules/define-properties/LICENSE \
+ third_party/node/node_modules/d/LICENSE \
+ third_party/node/node_modules/doctrine/LICENSE \
+ third_party/node/node_modules/doctrine/LICENSE.closure-compiler \
+ third_party/node/node_modules/doctrine/LICENSE.esprima \
+ third_party/node/node_modules/dom5/LICENSE \
+ third_party/node/node_modules/domelementtype/LICENSE \
+ third_party/node/node_modules/dom-serializer/LICENSE \
+ third_party/node/node_modules/domutils/LICENSE \
+ third_party/node/node_modules/entities/LICENSE \
+ third_party/node/node_modules/es5-ext/LICENSE \
+ third_party/node/node_modules/es6-iterator/LICENSE \
+ third_party/node/node_modules/es6-map/LICENSE \
+ third_party/node/node_modules/es6-set/LICENSE \
+ third_party/node/node_modules/es6-symbol/LICENSE \
+ third_party/node/node_modules/es6-weak-map/LICENSE \
+ third_party/node/node_modules/es-abstract/LICENSE \
+ third_party/node/node_modules/escape-string-regexp/license \
+ third_party/node/node_modules/escodegen/LICENSE.BSD \
+ third_party/node/node_modules/escodegen/node_modules/esprima/LICENSE.BSD \
+ third_party/node/node_modules/escodegen/node_modules/source-map/LICENSE \
+ third_party/node/node_modules/escope/LICENSE.BSD \
+ third_party/node/node_modules/eslint/LICENSE \
+ third_party/node/node_modules/espree/LICENSE \
+ third_party/node/node_modules/esprima/LICENSE.BSD \
+ third_party/node/node_modules/esquery/license.txt \
+ third_party/node/node_modules/es-to-primitive/LICENSE \
+ third_party/node/node_modules/estraverse/LICENSE.BSD \
+ third_party/node/node_modules/esutils/LICENSE.BSD \
+ third_party/node/node_modules/event-emitter/LICENSE \
+ third_party/node/node_modules/feature-detect-es6/LICENSE \
+ third_party/node/node_modules/figures/license \
+ third_party/node/node_modules/file-entry-cache/LICENSE \
+ third_party/node/node_modules/find-replace/LICENSE \
+ third_party/node/node_modules/flat-cache/LICENSE \
+ third_party/node/node_modules/fs.realpath/LICENSE \
+ third_party/node/node_modules/function-bind/LICENSE \
+ third_party/node/node_modules/generate-function/LICENSE \
+ third_party/node/node_modules/generate-object-property/LICENSE \
+ third_party/node/node_modules/globals/license \
+ third_party/node/node_modules/glob/LICENSE \
+ third_party/node/node_modules/graceful-fs/LICENSE \
+ third_party/node/node_modules/has-ansi/license \
+ third_party/node/node_modules/has-flag/license \
+ third_party/node/node_modules/has/LICENSE-MIT \
+ third_party/node/node_modules/has-symbols/LICENSE \
+ third_party/node/node_modules/inflight/LICENSE \
+ third_party/node/node_modules/inherits/LICENSE \
+ third_party/node/node_modules/interpret/LICENSE \
+ third_party/node/node_modules/is-callable/LICENSE \
+ third_party/node/node_modules/is-date-object/LICENSE \
+ third_party/node/node_modules/is-fullwidth-code-point/license \
+ third_party/node/node_modules/is-my-json-valid/LICENSE \
+ third_party/node/node_modules/is-property/LICENSE \
+ third_party/node/node_modules/is-regex/LICENSE \
+ third_party/node/node_modules/is-resolvable/LICENSE \
+ third_party/node/node_modules/is-symbol/LICENSE \
+ third_party/node/node_modules/jsonschema/LICENSE \
+ third_party/node/node_modules/json-stable-stringify/LICENSE \
+ third_party/node/node_modules/js-tokens/LICENSE \
+ third_party/node/node_modules/js-yaml/LICENSE \
+ third_party/node/node_modules/levn/LICENSE \
+ third_party/node/node_modules/lodash.camelcase/LICENSE \
+ third_party/node/node_modules/lodash/LICENSE \
+ third_party/node/node_modules/lodash.padend/LICENSE \
+ third_party/node/node_modules/mdn-data/LICENSE \
+ third_party/node/node_modules/minimatch/LICENSE \
+ third_party/node/node_modules/minimist/LICENSE \
+ third_party/node/node_modules/mkdirp/LICENSE \
+ third_party/node/node_modules/mute-stream/LICENSE \
+ third_party/node/node_modules/next-tick/LICENSE \
+ third_party/node/node_modules/nth-check/LICENSE \
+ third_party/node/node_modules/number-is-nan/license \
+ third_party/node/node_modules/object-assign/license \
+ third_party/node/node_modules/object.getownpropertydescriptors/LICENSE \
+ third_party/node/node_modules/object-keys/LICENSE \
+ third_party/node/node_modules/object.values/LICENSE \
+ third_party/node/node_modules/once/LICENSE \
+ third_party/node/node_modules/onetime/license \
+ third_party/node/node_modules/optionator/LICENSE \
+ third_party/node/node_modules/os-homedir/license \
+ third_party/node/node_modules/parse5/LICENSE \
+ third_party/node/node_modules/path-is-absolute/license \
+ third_party/node/node_modules/path-is-inside/LICENSE.txt \
+ third_party/node/node_modules/path-parse/LICENSE \
+ third_party/node/node_modules/pluralize/LICENSE \
+ third_party/node/node_modules/polymer-analyzer/LICENSE \
+ third_party/node/node_modules/polymer-analyzer/node_modules/clone/LICENSE \
+ third_party/node/node_modules/polymer-analyzer/node_modules/dom5/LICENSE \
+ third_party/node/node_modules/polymer-analyzer/node_modules/parse5/LICENSE \
+ third_party/node/node_modules/polymer-bundler/LICENSE \
+ third_party/node/node_modules/polymer-bundler/node_modules/clone/LICENSE \
+ third_party/node/node_modules/polymer-bundler/node_modules/dom5/LICENSE \
+ third_party/node/node_modules/polymer-bundler/node_modules/parse5/LICENSE \
+ third_party/node/node_modules/polymer-css-build/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/ansi-styles/license \
+ third_party/node/node_modules/polymer-css-build/node_modules/array-back/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/chalk/license \
+ third_party/node/node_modules/polymer-css-build/node_modules/clone/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/command-line-args/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/command-line-usage/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/command-line-usage/node_modules/array-back/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/command-line-usage/node_modules/typical/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/deep-extend/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/dom5/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/find-replace/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/parse5/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/supports-color/license \
+ third_party/node/node_modules/polymer-css-build/node_modules/table-layout/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/table-layout/node_modules/array-back/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/table-layout/node_modules/typical/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/typical/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/wordwrapjs/LICENSE \
+ third_party/node/node_modules/polymer-css-build/node_modules/wordwrapjs/node_modules/typical/LICENSE \
+ third_party/node/node_modules/prelude-ls/LICENSE \
+ third_party/node/node_modules/progress/LICENSE \
+ third_party/node/node_modules/q/LICENSE \
+ third_party/node/node_modules/readable-stream/LICENSE \
+ third_party/node/node_modules/rechoir/LICENSE \
+ third_party/node/node_modules/reduce-flatten/LICENSE \
+ third_party/node/node_modules/require-uncached/license \
+ third_party/node/node_modules/resolve-from/license \
+ third_party/node/node_modules/resolve/LICENSE \
+ third_party/node/node_modules/restore-cursor/license \
+ third_party/node/node_modules/rimraf/LICENSE \
+ third_party/node/node_modules/run-async/LICENSE \
+ third_party/node/node_modules/safe-buffer/LICENSE \
+ third_party/node/node_modules/sax/LICENSE \
+ third_party/node/node_modules/shady-css-parser/LICENSE.txt \
+ third_party/node/node_modules/shelljs/LICENSE \
+ third_party/node/node_modules/slice-ansi/license \
+ third_party/node/node_modules/source-map/LICENSE \
+ third_party/node/node_modules/sprintf-js/LICENSE \
+ third_party/node/node_modules/string_decoder/LICENSE \
+ third_party/node/node_modules/string-width/license \
+ third_party/node/node_modules/strip-ansi/license \
+ third_party/node/node_modules/strip-bom/license \
+ third_party/node/node_modules/strip-indent/license \
+ third_party/node/node_modules/strip-json-comments/license \
+ third_party/node/node_modules/supports-color/license \
+ third_party/node/node_modules/svgo/LICENSE \
+ third_party/node/node_modules/svgo/node_modules/ansi-styles/license \
+ third_party/node/node_modules/svgo/node_modules/chalk/license \
+ third_party/node/node_modules/svgo/node_modules/supports-color/license \
+ third_party/node/node_modules/table-layout/LICENSE \
+ third_party/node/node_modules/table/LICENSE \
+ third_party/node/node_modules/table/node_modules/ansi-regex/license \
+ third_party/node/node_modules/table/node_modules/is-fullwidth-code-point/license \
+ third_party/node/node_modules/table/node_modules/string-width/license \
+ third_party/node/node_modules/table/node_modules/strip-ansi/license \
+ third_party/node/node_modules/test-value/LICENSE \
+ third_party/node/node_modules/text-table/LICENSE \
+ third_party/node/node_modules/through/LICENSE.APACHE2 \
+ third_party/node/node_modules/through/LICENSE.MIT \
+ third_party/node/node_modules/type-check/LICENSE \
+ third_party/node/node_modules/typedarray/LICENSE \
+ third_party/node/node_modules/typical/LICENSE \
+ third_party/node/node_modules/uglify-es/LICENSE \
+ third_party/node/node_modules/uglify-es/node_modules/source-map/LICENSE \
+ third_party/node/node_modules/unquote/LICENSE \
+ third_party/node/node_modules/user-home/license \
+ third_party/node/node_modules/util-deprecate/LICENSE \
+ third_party/node/node_modules/util.promisify/LICENSE \
+ third_party/node/node_modules/wordwrapjs/LICENSE \
+ third_party/node/node_modules/wordwrap/LICENSE \
+ third_party/node/node_modules/wrappy/LICENSE \
+ third_party/node/node_modules/write/LICENSE \
+ third_party/nvml/LICENSE \
+ third_party/objenesis/LICENSE \
+ third_party/ocmock/License.txt \
+ third_party/one_euro_filter/LICENSE \
+ third_party/openh264/src/LICENSE \
+ third_party/openscreen/src/LICENSE \
+ third_party/openscreen/src/third_party/tinycbor/src/LICENSE \
+ third_party/openvr/src/LICENSE \
+ third_party/opus/src/COPYING \
+ third_party/opus/src/LICENSE_PLEASE_READ.txt \
+ third_party/ots/LICENSE \
+ third_party/ow2_asm/LICENSE \
+ third_party/pdfium/LICENSE \
+ third_party/pdfium/third_party/bigint/LICENSE \
+ third_party/pdfium/third_party/libpng16/LICENSE \
+ third_party/pdfium/third_party/pymock/LICENSE.txt \
+ third_party/perfetto/MODULE_LICENSE_APACHE2 \
+ third_party/pexpect/LICENSE \
+ third_party/pffft/LICENSE \
+ third_party/ply/LICENSE \
+ third_party/polymer/LICENSE.polymer \
+ third_party/polymer/v1_0/components-chromium/polymer2/LICENSE.txt \
+ third_party/polymer/v1_0/components-chromium/polymer/LICENSE.txt \
+ third_party/polymer/v3_0/components-chromium/polymer/LICENSE.txt \
+ third_party/proguard/LICENSE \
+ third_party/protobuf/LICENSE \
+ third_party/pycoverage/LICENSE \
+ third_party/pyelftools/elftools/construct/LICENSE \
+ third_party/pyelftools/LICENSE \
+ third_party/pyjson5/src/LICENSE \
+ third_party/pylint/pylint/LICENSE.txt \
+ third_party/pymock/LICENSE.txt \
+ third_party/pystache/LICENSE \
+ third_party/Python-Markdown/LICENSE.md \
+ third_party/pywebsocket/src/LICENSE \
+ third_party/qcms/src/COPYING \
+ third_party/quic_trace/src/LICENSE \
+ third_party/quic_trace/src/third_party/fonts/LICENSE \
+ third_party/quic_trace/src/third_party/glew/LICENSE.txt \
+ third_party/qunit/LICENSE \
+ third_party/r8/LICENSE \
+ third_party/re2/LICENSE \
+ third_party/re2/src/LICENSE \
+ third_party/requests/LICENSE \
+ third_party/rnnoise/COPYING \
+ third_party/robolectric/LICENSE \
+ third_party/robolectric/licenses/extreme.indiana.edu.license.txt \
+ third_party/robolectric/licenses/javolution.license.txt \
+ third_party/robolectric/licenses/pivotal.labs.license.txt \
+ third_party/s2cellid/LICENSE \
+ third_party/sfntly/COPYING.txt \
+ third_party/sfntly/src/cpp/COPYING.txt \
+ third_party/sfntly/src/java/COPYING \
+ third_party/shaderc/src/LICENSE \
+ third_party/shaderc/src/third_party/LICENSE.glslang \
+ third_party/shaderc/src/third_party/LICENSE.spirv-tools \
+ third_party/simplejson/LICENSE.txt \
+ third_party/sinonjs/LICENSE \
+ third_party/skia/include/third_party/skcms/LICENSE \
+ third_party/skia/include/third_party/vulkan/LICENSE \
+ third_party/skia/LICENSE \
+ third_party/skia/modules/canvaskit/canvaskit/LICENSE \
+ third_party/skia/modules/pathkit/npm-asmjs/LICENSE \
+ third_party/skia/modules/pathkit/npm-wasm/LICENSE \
+ third_party/skia/third_party/etc1/LICENSE \
+ third_party/skia/third_party/gif/LICENSE \
+ third_party/skia/third_party/skcms/LICENSE \
+ third_party/skia/third_party/vulkanmemoryallocator/include/LICENSE.txt \
+ third_party/skia/third_party/vulkanmemoryallocator/LICENSE \
+ third_party/skia/third_party/wuffs/LICENSE \
+ third_party/smhasher/LICENSE \
+ third_party/snappy/src/COPYING \
+ third_party/speech-dispatcher/COPYING \
+ third_party/spirv-cross/spirv-cross/LICENSE \
+ third_party/spirv-headers/LICENSE \
+ third_party/spirv-headers/src/LICENSE \
+ third_party/SPIRV-Tools/LICENSE \
+ third_party/SPIRV-Tools/src/LICENSE \
+ third_party/sqlite4java/LICENSE \
+ third_party/sqlite/LICENSE \
+ third_party/sqlite/patched/autoconf/tea/license.terms \
+ third_party/sqlite/patched/LICENSE.md \
+ third_party/sqlite/sqlite-src-3290000/autoconf/tea/license.terms \
+ third_party/sqlite/sqlite-src-3290000/LICENSE.md \
+ third_party/sudden_motion_sensor/LICENSE \
+ third_party/swiftshader/LICENSE.txt \
+ third_party/swiftshader/third_party/llvm-7.0/llvm/include/llvm/Support/LICENSE.TXT \
+ third_party/swiftshader/third_party/llvm-7.0/llvm/lib/Target/ARM/LICENSE.TXT \
+ third_party/swiftshader/third_party/llvm-7.0/llvm/LICENSE.TXT \
+ third_party/swiftshader/third_party/llvm-7.0/llvm/test/YAMLParser/LICENSE.txt \
+ third_party/swiftshader/third_party/llvm-7.0/llvm/tools/msbuild/license.txt \
+ third_party/swiftshader/third_party/llvm-7.0/llvm/utils/unittest/googlemock/LICENSE.txt \
+ third_party/swiftshader/third_party/llvm-7.0/llvm/utils/unittest/googletest/LICENSE.TXT \
+ third_party/swiftshader/third_party/llvm-subzero/LICENSE.TXT \
+ third_party/swiftshader/third_party/PowerVR_SDK/License.txt \
+ third_party/swiftshader/third_party/SPIRV-Headers/LICENSE \
+ third_party/swiftshader/third_party/SPIRV-Tools/LICENSE \
+ third_party/swiftshader/third_party/subzero/LICENSE.TXT \
+ third_party/tcmalloc/gperftools-2.0/vendor/COPYING \
+ third_party/tcmalloc/LICENSE \
+ third_party/tcmalloc/vendor/COPYING \
+ third_party/test_fonts/LICENSE \
+ third_party/tlslite/LICENSE \
+ third_party/ub-uiautomator/LICENSE \
+ third_party/unrar/LICENSE \
+ third_party/unrar/src/license.txt \
+ third_party/usb_ids/LICENSE \
+ third_party/usrsctp/LICENSE \
+ third_party/usrsctp/usrsctplib/LICENSE.md \
+ third_party/v4l-utils/COPYING.libv4l \
+ third_party/wayland/LICENSE \
+ third_party/wayland-protocols/LICENSE \
+ third_party/wayland-protocols/src/COPYING \
+ third_party/wayland/src/COPYING \
+ third_party/wds/LICENSE \
+ third_party/wds/src/COPYING \
+ third_party/web-animations-js/LICENSE \
+ third_party/web-animations-js/sources/COPYING \
+ third_party/webdriver/COPYING \
+ third_party/webdriver/LICENSE \
+ third_party/webgl/src/conformance-suites/1.0.1/conformance/LICENSE_CHROMIUM \
+ third_party/webgl/src/conformance-suites/2.0.0/closure-library/LICENSE \
+ third_party/webgl/src/conformance-suites/2.0.0/deqp/LICENSE \
+ third_party/webgl/src/conformance-suites/2.0.0/py/lint/LICENSE \
+ third_party/webgl/src/LICENSE.txt \
+ third_party/webgl/src/resources/html5lib/LICENSE \
+ third_party/webgl/src/sdk/demos/google/san-angeles/gles/license-BSD.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/gles/license-LGPL.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/gles/license.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/gles/t/license-BSD.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/gles/t/license-LGPL.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/gles/t/license.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/glut/license-BSD.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/glut/license-LGPL.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/glut/license.txt \
+ third_party/webgl/src/sdk/demos/google/san-angeles/license.txt \
+ third_party/webgl/src/sdk/demos/intel/fluid/LICENSE \
+ third_party/webgl/src/sdk/tests/closure-library/LICENSE \
+ third_party/webgl/src/sdk/tests/deqp/LICENSE \
+ third_party/webgl/src/sdk/tests/py/lint/LICENSE \
+ third_party/webrtc/common_audio/third_party/fft4g/LICENSE \
+ third_party/webrtc/common_audio/third_party/spl_sqrt_floor/LICENSE \
+ third_party/webrtc/examples/androidapp/third_party/autobanh/LICENSE \
+ third_party/webrtc/examples/androidapp/third_party/autobanh/LICENSE.md \
+ third_party/webrtc/examples/objc/AppRTCMobile/third_party/SocketRocket/LICENSE \
+ third_party/webrtc/LICENSE \
+ third_party/webrtc/license_template.txt \
+ third_party/webrtc/modules/third_party/fft/LICENSE \
+ third_party/webrtc/modules/third_party/g711/LICENSE \
+ third_party/webrtc/modules/third_party/g722/LICENSE \
+ third_party/webrtc/modules/third_party/portaudio/LICENSE \
+ third_party/webrtc/rtc_base/third_party/base64/LICENSE \
+ third_party/webrtc/rtc_base/third_party/sigslot/LICENSE \
+ third_party/webxr_test_pages/LICENSE \
+ third_party/webxr_test_pages/webxr-samples/js/cottontail/LICENSE.md \
+ third_party/webxr_test_pages/webxr-samples/js/third-party/dat.gui/LICENSE \
+ third_party/webxr_test_pages/webxr-samples/js/third-party/gl-matrix/LICENSE \
+ third_party/webxr_test_pages/webxr-samples/LICENSE.md \
+ third_party/widevine/LICENSE \
+ third_party/woff2/LICENSE \
+ third_party/xdg-utils/LICENSE \
+ third_party/xstream/LICENSE \
+ third_party/yasm/source/patched-yasm/COPYING \
+ third_party/yasm/source/patched-yasm/GNU_GPL-2.0 \
+ third_party/yasm/source/patched-yasm/GNU_LGPL-2.0 \
+ third_party/zlib/LICENSE \
+ tools/gn/base/third_party/icu/LICENSE \
+ tools/gn/LICENSE \
+ tools/origin_trials/third_party/ed25519/LICENSE \
+ tools/page_cycler/acid3/LICENSE \
+ tools/swarming_client/LICENSE \
+ tools/swarming_client/third_party/chromium/LICENSE \
+ tools/swarming_client/third_party/colorama/LICENSE.txt \
+ tools/swarming_client/third_party/depot_tools/LICENSE \
+ tools/swarming_client/third_party/infra_libs/LICENSE \
+ tools/swarming_client/third_party/oauth2client/LICENSE \
+ tools/swarming_client/third_party/pyasn1/LICENSE \
+ tools/swarming_client/third_party/rsa/LICENSE \
+ tools/swarming_client/third_party/six/LICENSE \
+ tools/symsrc/COPYING-pefile \
+ tools/win/ChromeDebug/ChromeDebug/LICENSE \
+ url/third_party/mozilla/LICENSE.txt \
+ v8/LICENSE \
+ v8/LICENSE.fdlibm \
+ v8/LICENSE.strongtalk \
+ v8/LICENSE.v8 \
+ v8/LICENSE.valgrind \
+ v8/src/third_party/siphash/LICENSE \
+ v8/src/third_party/utf8-decoder/LICENSE \
+ v8/src/third_party/valgrind/LICENSE \
+ v8/src/third_party/vtune/LICENSE \
+ v8/third_party/colorama/LICENSE \
+ v8/third_party/inspector_protocol/LICENSE \
+ v8/third_party/v8/builtins/LICENSE \
+ v8/third_party/wasm-api/LICENSE \
+
diff --git a/package/libcef/libcef.mk b/package/libcef/libcef.mk
new file mode 100644
index 0000000000..fe69cabb2c
--- /dev/null
+++ b/package/libcef/libcef.mk
@@ -0,0 +1,372 @@
+################################################################################
+#
+# libcef
+#
+################################################################################
+
+# Run $(LIBCEF_PKGDIR)/scripts/version.sh to generate these values.
+# Don't bother trying to update these by hand, LIBCEF_CEF_VERSION is too
+# dependant on git to assemble ourselves.
+LIBCEF_VERSION = f3890bec3b21b01c2b5b026c50f96a9f2f070e7c
+LIBCEF_CEF_COMMIT_NUMBER = 2044
+LIBCEF_CEF_VERSION = 77.1.4+gf3890be+chromium-77.0.3865.90
+LIBCEF_CEF_VERSION_MAJOR = 3
+LIBCEF_CEF_VERSION_MINOR = 1
+LIBCEF_CEF_VERSION_PATCH = 4
+LIBCEF_CHROMIUM_VERSION_MAJOR = 77
+LIBCEF_CHROMIUM_VERSION_MINOR = 0
+LIBCEF_CHROMIUM_VERSION_BUILD = 3865
+LIBCEF_CHROMIUM_VERSION_PATCH = 90
+# End version.sh generated values
+
+LIBCEF_SITE = https://bitbucket.org/chromiumembedded/cef.git
+LIBCEF_SITE_METHOD = git
+LIBCEF_STRIP_COMPONENTS = 0
+
+LIBCEF_INSTALL_STAGING = YES
+LIBCEF_INSTALL_STAGING_INCLUDE_PATH=$(STAGING_DIR)/usr/include/cef
+LIBCEF_INSTALL_STAGING_LIBRARY_PATH=$(STAGING_DIR)/usr/lib/cef
+
+LIBCEF_LICENSE = GPL-2.0 or LGPL-3.0 or GPL-3.0 or GPL-3.0 with exception
+include package/libcef/libcef.license-files.inc
+
+# The Chromium source is fetched from a release tarball.
+LIBCEF_CHROMIUM_VERSION = $(LIBCEF_CHROMIUM_VERSION_MAJOR).$(LIBCEF_CHROMIUM_VERSION_MINOR).$(LIBCEF_CHROMIUM_VERSION_BUILD).$(LIBCEF_CHROMIUM_VERSION_PATCH)
+LIBCEF_EXTRA_DOWNLOADS = https://commondatastorage.googleapis.com/chromium-browser-official/chromium-$(LIBCEF_CHROMIUM_VERSION).tar.xz
+
+LIBCEF_DEPENDENCIES = \
+ alsa-lib \
+ at-spi2-atk \
+ at-spi2-core \
+ atk \
+ cairo \
+ compiler-rt \
+ dbus \
+ ffmpeg \
+ flac \
+ fontconfig \
+ freetype \
+ harfbuzz \
+ host-clang \
+ host-jpeg-turbo \
+ host-libkrb5 \
+ host-libnss \
+ host-libxml2 \
+ host-ninja \
+ host-nodejs \
+ host-pkgconf \
+ host-python \
+ host-webp \
+ jpeg-turbo \
+ libdrm \
+ libglib2 \
+ libgtk3 \
+ libgtkglext \
+ libkrb5 \
+ libnss \
+ libxml2 \
+ libxslt \
+ pango \
+ webp \
+ xlib_libXcomposite \
+ xlib_libXcursor \
+ xlib_libXrandr \
+ xlib_libXScrnSaver
+
+LIBCEF_HOST_PKG_CONFIG_WRAPPER = $(@D)/br-host-pkg-config.sh
+
+LIBCEF_GN_DEFINES = \
+ audio_processing_in_audio_service_supported=false \
+ clang_use_chrome_plugins=false \
+ closure_compile=false \
+ custom_toolchain=\"//build/toolchain/linux/unbundle:default\" \
+ enable_basic_print_dialog=false \
+ enable_nacl=false \
+ enable_service_discovery=false \
+ enable_vr=false \
+ forbid_non_component_debug_builds=false \
+ host_pkg_config=\"$(LIBCEF_HOST_PKG_CONFIG_WRAPPER)\" \
+ host_toolchain=\"//build/toolchain/linux/unbundle:host\" \
+ is_cfi=false \
+ is_unsafe_developer_build=false \
+ link_pulseaudio=false \
+ linux_use_bundled_binutils=false \
+ target_cpu=\"$(BR2_PACKAGE_LIBCEF_TARGET_ARCH)\" \
+ treat_warnings_as_errors=false \
+ use_bundled_fontconfig=false \
+ use_gnome_keyring=false \
+ use_gtk=false \
+ use_jumbo_build=true \
+ use_sysroot=false \
+ use_system_freetype=true \
+ use_system_harfbuzz=true \
+ use_system_libjpeg=true \
+ use_viz_devtools=false
+
+# Use Buildroot system libraries instead of Chromium third_party libraries
+LIBCEF_SYSTEM_LIBS = \
+ ffmpeg \
+ flac \
+ fontconfig \
+ freetype \
+ harfbuzz-ng \
+ libjpeg \
+ libvpx \
+ libwebp \
+ libxml \
+ libxslt \
+ openh264 \
+ yasm
+
+LIBCEF_BUILD_TARGETS = cef chrome_sandbox
+
+# Use the HOSTLD rather than target linker, which warns about host include dirs
+LIBCEF_HOST_LDFLAGS = $(HOST_LDFLAGS) -fuse-ld=$(HOSTLD)
+
+# Use the target sysroot when building for the target
+LIBCEF_TARGET_CFLAGS = $(TARGET_CFLAGS) --sysroot=$(STAGING_DIR)
+LIBCEF_TARGET_CXXFLAGS = $(TARGET_CXXFLAGS) --sysroot=$(STAGING_DIR)
+LIBCEF_TARGET_LDFLAGS = $(TARGET_LDFLAGS) --sysroot=$(STAGING_DIR)
+
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
+# Tell clang where the external toolchain is and to use it
+LIBCEF_TARGET_CFLAGS += --gcc-toolchain=$(TOOLCHAIN_EXTERNAL_INSTALL_DIR) \
+ --target=$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX)
+LIBCEF_TARGET_CXXFLAGS += --gcc-toolchain=$(TOOLCHAIN_EXTERNAL_INSTALL_DIR) \
+ --target=$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX)
+LIBCEF_TARGET_LDFLAGS += --gcc-toolchain=$(TOOLCHAIN_EXTERNAL_INSTALL_DIR) \
+ --target=$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX)
+else
+# Tell clang to use the Buildroot toolchain
+LIBCEF_TARGET_CFLAGS += --target=$(GNU_TARGET_NAME)
+LIBCEF_TARGET_CXXFLAGS += --target=$(GNU_TARGET_NAME)
+LIBCEF_TARGET_LDFLAGS += --target=$(GNU_TARGET_NAME)
+endif
+
+ifeq ($(BR2_i386)$(BR2_x86_64),y)
+LIBCEF_SYSTEM_LIBS += yasm
+LIBCEF_DEPENDENCIES += host-yasm
+endif
+
+ifeq ($(BR2_ENABLE_DEBUG),y)
+LIBCEF_BUILD_OUTPUT_DIR = out/Debug
+LIBCEF_GN_DEFINES += \
+ is_debug=true \
+ is_official_build=false
+else
+LIBCEF_BUILD_OUTPUT_DIR = out/Release
+LIBCEF_GN_DEFINES += \
+ is_debug=false \
+ is_official_build=true
+endif
+
+# We have two build directories. One uses the bundled LLVM libcxx, and the
+# other uses the system C++ standard library. One is used for libcef.so, and
+# the other is for libcef_dll_wrapper.a, that dependant projects statically
+# link against.
+LIBCEF_BUILD_OUTPUT_DIR_SYSTEM_LIBCXX = $(LIBCEF_BUILD_OUTPUT_DIR)_system_libcxx
+
+# tcmalloc has portability issues
+LIBCEF_GN_DEFINES += use_allocator=\"none\"
+
+ifeq ($(BR2_CCACHE),y)
+LIBCEF_GN_DEFINES += cc_wrapper=\"ccache\"
+endif
+
+# LLD is unsupported on i386, and fails during linking
+ifeq ($(BR2_i386)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y)
+LIBCEF_GN_DEFINES += use_lld=false
+# Disable gold as well, to force usage of our toolchain's ld.bfd
+LIBCEF_GN_DEFINES += use_gold=false
+else
+LIBCEF_GN_DEFINES += use_lld=false
+LIBCEF_GN_DEFINES += use_gold=false
+endif
+
+ifeq ($(BR2_PACKAGE_CUPS),y)
+LIBCEF_DEPENDENCIES += cups
+LIBCEF_GN_DEFINES += use_cups=true
+else
+LIBCEF_GN_DEFINES += use_cups=false
+endif
+
+ifeq ($(BR2_PACKAGE_PCIUTILS),y)
+LIBCEF_DEPENDENCIES += pciutils
+LIBCEF_GN_DEFINES += use_libpci=true
+else
+LIBCEF_GN_DEFINES += use_libpci=false
+endif
+
+ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
+LIBCEF_DEPENDENCIES += pulseaudio
+LIBCEF_GN_DEFINES += use_pulseaudio=true
+else
+LIBCEF_GN_DEFINES += use_pulseaudio=false
+endif
+
+define LIBCEF_EXTRACT_CMDS
+ # Extract Chromium source code
+ tar -C $(@D) \
+ --strip-components=1 \
+ -xf $(LIBCEF_DL_DIR)/chromium-$(LIBCEF_CHROMIUM_VERSION).tar.xz
+
+ # Extract CEF to cef dir inside Chromium source code
+ mkdir $(@D)/cef
+ tar -C $(@D)/cef \
+ --strip-components=1 \
+ -xf $(LIBCEF_DL_DIR)/libcef-$(LIBCEF_VERSION).tar.gz
+
+ # Patch the Chromium source with the CEF patches
+ ( cd $(@D); \
+ for cef_patch in cef/patch/patches/*.patch; do \
+ patch -p0 -u -i "$$cef_patch"; \
+ done; \
+ )
+
+ # Copy the toolchain folder into the build directory
+ cp -r $(LIBCEF_PKGDIR)/toolchain $(@D)/
+endef
+
+LIBCEF_TARGET_CONFIGURE_ENV = \
+ $(TARGET_MAKE_ENV) \
+ BUILD_CC="clang" \
+ BUILD_CXX="clang++" \
+ BUILD_AR="$(HOSTAR)" \
+ BUILD_NM="$(HOSTNM)" \
+ BUILD_CFLAGS="$(HOST_CFLAGS)" \
+ BUILD_CXXFLAGS="$(HOST_CXXFLAGS)" \
+ BUILD_LDFLAGS="$(LIBCEF_HOST_LDFLAGS)" \
+ CC="clang" \
+ CXX="clang++" \
+ AR="ar" \
+ NM="nm" \
+ CFLAGS="$(LIBCEF_TARGET_CFLAGS)" \
+ CXXFLAGS="$(LIBCEF_TARGET_CXXFLAGS)" \
+ LDFLAGS="$(LIBCEF_TARGET_LDFLAGS)"
+
+define LIBCEF_CONFIGURE_CMDS
+ # Make the host pkg-config wrapper
+ echo "#!/bin/bash" > $(LIBCEF_HOST_PKG_CONFIG_WRAPPER)
+ echo $(HOST_MAKE_ENV) $(HOST_DIR)/bin/pkg-config '"$${@}"' >> \
+ $(LIBCEF_HOST_PKG_CONFIG_WRAPPER)
+ chmod +x $(LIBCEF_HOST_PKG_CONFIG_WRAPPER)
+
+ # Create include/cef_version.h
+ sed -e "s/{{ cef_version }}/$(LIBCEF_CEF_VERSION)/; \
+ s/{{ cef_version_major }}/$(LIBCEF_CEF_VERSION_MAJOR)/; \
+ s/{{ cef_version_minor }}/$(LIBCEF_CEF_VERSION_MINOR)/; \
+ s/{{ cef_version_patch }}/$(LIBCEF_CEF_VERSION_PATCH)/; \
+ s/{{ cef_commit_number }}/$(LIBCEF_CEF_COMMIT_NUMBER)/; \
+ s/{{ cef_commit_hash }}/$(LIBCEF_VERSION)/; \
+ s/{{ year }}/$$(date +%Y)/; \
+ s/{{ chrome_version_major }}/$(LIBCEF_CHROMIUM_VERSION_MAJOR)/; \
+ s/{{ chrome_version_minor }}/$(LIBCEF_CHROMIUM_VERSION_MINOR)/; \
+ s/{{ chrome_version_build }}/$(LIBCEF_CHROMIUM_VERSION_BUILD)/; \
+ s/{{ chrome_version_patch }}/$(LIBCEF_CHROMIUM_VERSION_PATCH)/;" \
+ $(LIBCEF_PKGDIR)/templates/cef_version.h > \
+ $(@D)/cef/include/cef_version.h
+
+ # Update the CEF API in case someone has patched it
+ ( cd $(@D)/cef/tools; $(TARGET_MAKE_ENV) ./translator.sh )
+
+ # Shim headers allow us to link to unbundled system libraries. Normally
+ # this isn't allowed in "official"/release builds.
+ # Disable the build time error for official builds with system libs.
+ ( cd $(@D); \
+ sed -i 's/OFFICIAL_BUILD/GOOGLE_CHROME_BUILD/' \
+ tools/generate_shim_headers/generate_shim_headers.py \
+ )
+
+ mkdir -p $(@D)/third_party/node/linux/node-linux-x64/bin
+ ln -sf $(HOST_DIR)/bin/node $(@D)/third_party/node/linux/node-linux-x64/bin/
+
+ # Use python2 by default
+ mkdir -p $(@D)/bin
+ ln -sf $(HOST_DIR)/usr/bin/python2 $(@D)/bin/python
+
+ ( cd $(@D); \
+ $(TARGET_MAKE_ENV) \
+ build/linux/unbundle/replace_gn_files.py \
+ --system-libraries $(LIBCEF_SYSTEM_LIBS) \
+ )
+
+ # Generate-ninja config which uses the bundled LLVM C++ library.
+ # This is where the main CEF build will take place
+ ( cd $(@D); \
+ $(LIBCEF_TARGET_CONFIGURE_ENV) \
+ buildtools/linux64/gn gen $(LIBCEF_BUILD_OUTPUT_DIR) \
+ --args="$(LIBCEF_GN_DEFINES) use_custom_libcxx=true" \
+ )
+
+ # Generate-ninja config which uses the host C++ library.
+ # This is where we build the libcef_dll_wrapper.a
+ ( cd $(@D); \
+ $(LIBCEF_TARGET_CONFIGURE_ENV) \
+ buildtools/linux64/gn gen \
+ $(LIBCEF_BUILD_OUTPUT_DIR_SYSTEM_LIBCXX) \
+ --args="$(LIBCEF_GN_DEFINES) use_custom_libcxx=false" \
+ )
+
+ # Create include/cef_config.h
+ $(HOST_DIR)/usr/bin/python $(@D)/cef/tools/make_config_header.py \
+ --header=$(@D)/cef/include/cef_config.h \
+ --cef_gn_config=$(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/args.gn
+endef
+
+define LIBCEF_BUILD_CMDS
+ ( cd $(@D); \
+ $(TARGET_MAKE_ENV) \
+ ninja -j$(PARALLEL_JOBS) \
+ -C $(LIBCEF_BUILD_OUTPUT_DIR) \
+ $(LIBCEF_BUILD_TARGETS) \
+ )
+ ( cd $(@D); \
+ $(TARGET_MAKE_ENV) \
+ ninja -j$(PARALLEL_JOBS) \
+ -C $(LIBCEF_BUILD_OUTPUT_DIR_SYSTEM_LIBCXX) \
+ libcef_dll_wrapper \
+ )
+endef
+
+define LIBCEF_INSTALL_STAGING_CMDS
+ mkdir -p $(LIBCEF_INSTALL_STAGING_LIBRARY_PATH)
+ ( cd $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR_SYSTEM_LIBCXX)/obj/cef; \
+ cp -r libcef_dll_wrapper.a libcef_dll_wrapper \
+ $(LIBCEF_INSTALL_STAGING_LIBRARY_PATH) \
+ )
+
+ mkdir -p $(LIBCEF_INSTALL_STAGING_INCLUDE_PATH)
+ cp -a $(@D)/cef/include $(LIBCEF_INSTALL_STAGING_INCLUDE_PATH)
+
+ # CEF file cef_net_error_list.sh includes the Chromium file
+ # net_error_list.h but expects to be distributed with the correct file
+ # in place.
+ cp $(@D)/net/base/net_error_list.h \
+ $(LIBCEF_INSTALL_STAGING_INCLUDE_PATH)/include/base/internal/cef_net_error_list.h
+
+ $(INSTALL) -m 0644 -D -t $(STAGING_DIR)/usr/lib \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/libcef.so
+endef
+
+define LIBCEF_INSTALL_TARGET_CMDS
+ $(INSTALL) -m 0644 -D -t $(TARGET_DIR)/usr/lib \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/libcef.so \
+
+ # chrome_sandbox gets renamed
+ $(INSTALL) -m 4755 \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/chrome_sandbox \
+ $(TARGET_DIR)/usr/lib/chrome-sandbox
+
+ $(INSTALL) -m 0644 -D -t $(TARGET_DIR)/usr/lib \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/cef.pak \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/cef_100_percent.pak \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/cef_200_percent.pak \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/cef_extensions.pak \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/devtools_resources.pak \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/icudtl.dat
+
+ $(INSTALL) -m 0644 -D -t $(TARGET_DIR)/usr/lib/locales \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/locales/*.pak
+endef
+
+$(eval $(generic-package))
diff --git a/package/libcef/scripts/gather-license-files.sh b/package/libcef/scripts/gather-license-files.sh
new file mode 100755
index 0000000000..9c7114d7b9
--- /dev/null
+++ b/package/libcef/scripts/gather-license-files.sh
@@ -0,0 +1,53 @@
+#!/bin/bash
+# Print licence files for libcef package
+# You can run it like this:
+#
+# package/libcef/scripts/gather-license-files.sh \
+# output/build/libcef-VERSION/ \
+# > package/libcef/libcef.license-files.inc
+
+usage()
+{
+ echo "usage: $0 DIR"
+ echo "DIR must be a buildroot output/build/libcef-<version> directory"
+}
+
+generate_license_file_list()
+{
+ declare -r path="$1"
+
+ echo 'LIBCEF_LICENSE_FILES = \'
+
+ find "$path" -type f -iname "*LICENSE*" -printf "%P\n" -o \
+ -type f -iname "*COPYING*" -printf "%P\n" -o \
+ -type f -iname "*GPL*" -printf "%P\n" | \
+ sed -e '/\.asm$/d' \
+ -e '/\.h$/d' \
+ -e '/\.c$/d' \
+ -e '/\.cc$/d' \
+ -e '/\.cpp$/d' \
+ -e '/\.pyc\?$/d' \
+ -e '/\.pl$/d' \
+ -e '/\.sha1$/d' \
+ -e '/\.patch$/d' \
+ -e '/\.html$/d' \
+ -e '/\.java$/d' \
+ -e '/\.css$/d' \
+ -e '/\.js$/d' \
+ -e '/\.tmpl$/d' \
+ -e '/licensecheck/d' \
+ -e '/wrongplace/d' \
+ -e '/ClangPlugins/d' \
+ -e '/fts5bigpl/d' \
+ -e '/^out\//d' \
+ -e 's,^,\t,' \
+ -e 's,$, \\,' | \
+ sort
+ echo ''
+}
+
+if [ $# -lt 1 ]; then
+ usage
+ exit 1
+fi
+generate_license_file_list "$1"
diff --git a/package/libcef/scripts/version.sh b/package/libcef/scripts/version.sh
new file mode 100755
index 0000000000..19689bec82
--- /dev/null
+++ b/package/libcef/scripts/version.sh
@@ -0,0 +1,48 @@
+#!/bin/bash
+# Print version information for the buildroot libcef package
+# Run this when updating the libcef package to quickly populate the versions
+
+usage()
+{
+ echo "usage: $0 chromium_src"
+ echo "$0 expects \$chromium_src/cef/.git to exist"
+}
+
+pr_cef_version()
+{
+ declare cef_version_major cef_version_minor cef_version_patch
+ declare cef_commit_number cef_commit_hash
+ declare cef_version_str
+ declare -r src_cef="$1/cef"
+
+ cef_commit_number=$(git -C "$src_cef" rev-list --count HEAD)
+ cef_commit_hash=$(git -C "$src_cef" rev-parse HEAD)
+
+ cef_version_str=$(python2 "$src_cef/tools/cef_version.py" current)
+ cef_version_major=$(awk -F= '/CEF_MAJOR/ { print $2 }' \
+ "$src_cef/VERSION.in")
+ cef_version_minor=$(echo "$cef_version_str" | cut -d. -f2)
+ cef_version_patch=$(echo "$cef_version_str" | cut -d+ -f1 | cut -d. -f3)
+
+ echo "LIBCEF_VERSION = $cef_commit_hash"
+ echo "LIBCEF_CEF_COMMIT_NUMBER = $cef_commit_number"
+
+ echo "LIBCEF_CEF_VERSION = $cef_version_str"
+ echo "LIBCEF_CEF_VERSION_MAJOR = $cef_version_major"
+ echo "LIBCEF_CEF_VERSION_MINOR = $cef_version_minor"
+ echo "LIBCEF_CEF_VERSION_PATCH = $cef_version_patch"
+}
+
+pr_chromium_version()
+{
+ declare -r src_chrome="$1/chrome"
+ awk -F= '{ print "LIBCEF_CHROMIUM_VERSION_"$1,"=",$2 }' \
+ "$src_chrome/VERSION"
+}
+
+if [ $# -lt 1 ]; then
+ usage
+ exit 1
+fi
+pr_cef_version "$1"
+pr_chromium_version "$1"
diff --git a/package/libcef/templates/cef_version.h b/package/libcef/templates/cef_version.h
new file mode 100644
index 0000000000..5d6c4685ac
--- /dev/null
+++ b/package/libcef/templates/cef_version.h
@@ -0,0 +1,70 @@
+// Copyright (c) {{ year }} Marshall A. Greenblatt. All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following disclaimer
+// in the documentation and/or other materials provided with the
+// distribution.
+// * Neither the name of Google Inc. nor the name Chromium Embedded
+// Framework nor the names of its contributors may be used to endorse
+// or promote products derived from this software without specific prior
+// written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+//
+// ---------------------------------------------------------------------------
+//
+// This file is generated by the make_version_header.py tool.
+//
+#ifndef CEF_INCLUDE_CEF_VERSION_H_
+#define CEF_INCLUDE_CEF_VERSION_H_
+#define CEF_VERSION "{{ cef_version }}"
+#define CEF_VERSION_MAJOR {{ cef_version_major }}
+#define CEF_VERSION_MINOR {{ cef_version_minor }}
+#define CEF_VERSION_PATCH {{ cef_version_patch }}
+#define CEF_COMMIT_NUMBER {{ cef_commit_number }}
+#define CEF_COMMIT_HASH "{{ cef_commit_hash }}"
+#define COPYRIGHT_YEAR {{ year }}
+#define CHROME_VERSION_MAJOR {{ chrome_version_major }}
+#define CHROME_VERSION_MINOR {{ chrome_version_minor }}
+#define CHROME_VERSION_BUILD {{ chrome_version_build }}
+#define CHROME_VERSION_PATCH {{ chrome_version_patch }}
+#define DO_MAKE_STRING(p) #p
+#define MAKE_STRING(p) DO_MAKE_STRING(p)
+#ifndef APSTUDIO_HIDDEN_SYMBOLS
+#include "include/internal/cef_export.h"
+#ifdef __cplusplus
+extern "C" {
+#endif
+// Returns CEF version information for the libcef library. The |entry|
+// parameter describes which version component will be returned:
+// 0 - CEF_VERSION_MAJOR
+// 1 - CEF_VERSION_MINOR
+// 2 - CEF_VERSION_PATCH
+// 3 - CEF_COMMIT_NUMBER
+// 4 - CHROME_VERSION_MAJOR
+// 5 - CHROME_VERSION_MINOR
+// 6 - CHROME_VERSION_BUILD
+// 7 - CHROME_VERSION_PATCH
+///
+CEF_EXPORT int cef_version_info(int entry);
+#ifdef __cplusplus
+}
+#endif
+#endif // APSTUDIO_HIDDEN_SYMBOLS
+#endif // CEF_INCLUDE_CEF_VERSION_H_
diff --git a/package/libcef/toolchain/BUILD.gn b/package/libcef/toolchain/BUILD.gn
new file mode 100644
index 0000000000..b90430a078
--- /dev/null
+++ b/package/libcef/toolchain/BUILD.gn
@@ -0,0 +1,70 @@
+import("//build/toolchain/gcc_toolchain.gni")
+import("//build/config/sysroot.gni")
+
+gcc_toolchain("host") {
+ cc = getenv("HOST_CC")
+ cxx = getenv("HOST_CXX")
+ ar = getenv("HOST_AR")
+ nm = getenv("HOST_NM")
+ ld = cxx
+
+ extra_cflags = getenv("HOST_CFLAGS")
+ extra_cppflags = getenv("HOST_CPPFLAGS")
+ extra_cxxflags = getenv("HOST_CXXFLAGS")
+ extra_ldflags = getenv("HOST_LDFLAGS")
+
+ toolchain_args = {
+ cc_wrapper = ""
+ current_cpu = host_cpu
+ current_os = host_os
+ is_clang = false
+ use_sysroot = false
+ use_lld = false
+ }
+}
+
+gcc_toolchain("target") {
+ cc = getenv("TARGET_CC")
+ cxx = getenv("TARGET_CXX")
+ ar = getenv("TARGET_AR")
+ nm = getenv("TARGET_NM")
+ ld = cxx
+
+ extra_cflags = getenv("TARGET_CFLAGS")
+ extra_cppflags = getenv("TARGET_CPPFLAGS")
+ extra_cxxflags = getenv("TARGET_CXXFLAGS")
+ extra_ldflags = getenv("TARGET_LDFLAGS")
+
+ toolchain_args = {
+ cc_wrapper = ""
+ current_cpu = target_cpu
+ current_os = target_os
+ is_clang = is_clang
+ use_sysroot = use_sysroot
+ }
+}
+
+gcc_toolchain("v8_snapshot") {
+ cc = getenv("V8_CC")
+ cxx = getenv("V8_CXX")
+ ar = getenv("V8_AR")
+ nm = getenv("V8_NM")
+ ld = cxx
+
+ extra_cflags = getenv("V8_CFLAGS")
+ extra_cppflags = getenv("V8_CPPFLAGS")
+ extra_cxxflags = getenv("V8_CXXFLAGS")
+ extra_ldflags = getenv("V8_LDFLAGS")
+
+ toolchain_args = {
+ cc_wrapper = ""
+ if (target_cpu == "x86" || target_cpu == "arm" || target_cpu == "mipsel") {
+ current_cpu = "x86"
+ } else {
+ current_cpu = "x64"
+ }
+ current_os = host_os
+ is_clang = is_clang
+ use_sysroot = false
+ }
+}
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 14/30] package/libcef: New package
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 14/30] package/libcef: New package Michael Drake
@ 2019-10-19 23:55 ` Arnout Vandecappelle
2019-11-21 11:59 ` Michael Drake
0 siblings, 1 reply; 52+ messages in thread
From: Arnout Vandecappelle @ 2019-10-19 23:55 UTC (permalink / raw)
To: buildroot
On 17/10/2019 17:29, Michael Drake wrote:
> Coauthored-by: Thomas Preston <thomas.preston@codethink.co.uk>
> Cc: Patrick Glaser <pglaser@tesla.com>
> Cc: Jon duSaint <jdusaint@tesla.com>
> Cc: Enis Lavery <elavery@tesla.com>
> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
> ---
> package/Config.in | 1 +
> .../0001-fix-one-euro-filter-build.patch | 33 +
> .../0002-link-against-harfbuzz-subset.patch | 50 +
> package/libcef/Config.in | 75 ++
> package/libcef/libcef.license-files.inc | 1130 +++++++++++++++++
> package/libcef/libcef.mk | 372 ++++++
> .../libcef/scripts/gather-license-files.sh | 53 +
> package/libcef/scripts/version.sh | 48 +
> package/libcef/templates/cef_version.h | 70 +
> package/libcef/toolchain/BUILD.gn | 70 +
I think a patch with this kind of diffstat deserves a commit message with some
text...
[snip]
> +config BR2_PACKAGE_LIBCEF
> + bool "libcef"
> + depends on BR2_HOST_GCC_AT_LEAST_4_9 # gn requires -std=c++14
> + depends on BR2_INSTALL_LIBSTDCPP # icu
> + depends on BR2_USE_WCHAR # icu
> + depends on BR2_PACKAGE_HAS_LIBGL
> + depends on BR2_PACKAGE_XORG7
Please put package dependencies after the toolchain dependencies.
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
> + depends on BR2_TOOLCHAIN_USES_GLIBC
> + depends on BR2_TOOLCHAIN_HAS_THREADS # icu
> + depends on !BR2_BINFMT_FLAT # icu
I'm a bit surprised that with such a long list of selects, icu is the only one
with any dependencies...
> + select BR2_PACKAGE_AT_SPI2_ATK
> + select BR2_PACKAGE_ALSA_LIB
> + select BR2_PACKAGE_COMPILER_RT
> + select BR2_PACKAGE_DBUS
> + select BR2_PACKAGE_FFMPEG
> + select BR2_PACKAGE_FLAC
> + select BR2_PACKAGE_FREETYPE
> + select BR2_PACKAGE_HARFBUZZ
> + select BR2_PACKAGE_LLVM_ENABLE_HOST_ARCH
> + select BR2_PACKAGE_HOST_CLANG
> + select BR2_PACKAGE_HOST_JPEG_TURBO
> + select BR2_PACKAGE_HOST_ICU
> + select BR2_PACKAGE_HOST_LLD
> + select BR2_PACKAGE_HOST_LLVM
> + select BR2_PACKAGE_HOST_NINJA
> + select BR2_PACKAGE_HOST_LIBKRB5
> + select BR2_PACKAGE_HOST_LIBNSS
> + select BR2_PACKAGE_HOST_NODEJS
> + select BR2_PACKAGE_HOST_PKGCONF
> + select BR2_PACKAGE_HOST_PYTHON
> + select BR2_PACKAGE_HOST_WEBP
It is normally not needed to select host packages. Some of these symbols don't
even exist, e.g. ninja.
> + select BR2_PACKAGE_ICU
> + select BR2_PACKAGE_JPEG_TURBO
> + select BR2_PACKAGE_LIBDRM
> + select BR2_PACKAGE_LIBERATION # runtime
> + select BR2_PACKAGE_LIBGLIB2
> + select BR2_PACKAGE_LIBGTK3_X11
> + select BR2_PACKAGE_LIBGTKGLEXT
> + select BR2_PACKAGE_LIBKRB5
> + select BR2_PACKAGE_LIBNSS
> + select BR2_PACKAGE_LIBPNG
> + select BR2_PACKAGE_PCIUTILS
> + select BR2_PACKAGE_PANGO
> + select BR2_PACKAGE_WEBP
> + select BR2_PACKAGE_WEBP_MUX
> + select BR2_PACKAGE_WEBP_DEMUX
> + select BR2_PACKAGE_LIBXML2
> + select BR2_PACKAGE_LIBXSLT
> + select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
> + select BR2_PACKAGE_XLIB_LIBXCURSOR
> + select BR2_PACKAGE_XLIB_LIBXRANDR
> + select BR2_PACKAGE_XLIB_LIBXSCRNSAVER
> + select BR2_PACKAGE_XLIB_LIBXV
> + select BR2_PACKAGE_ZLIB
> + help
> + Chromium Embedded Framework
A bit more help text could be useful. Just take a sentence from the website.
Also, a link to the website is mandatory.
> +
> +if BR2_PACKAGE_LIBCEF
> +
> +config BR2_PACKAGE_LIBCEF_TARGET_ARCH
> + string
> + default "arm" if BR2_arm
> + default "arm64" if BR2_aarch64
> + default "mips" if BR2_mips
> + default "x86" if BR2_i386
> + default "x64" if BR2_x86_64
This implies that you'll need BR2_PACKAGE_LIBCEF_ARCH_DEPENDS.
You can move this symbol out of the condition to the beginning of the file, and
then just do:
config BR2_PACKAGE_LIBCEF_ARCH_DEPENDS
bool
default y
depends on BR2_PACKAGE_LIBCEF_TARGET_ARCH != ""
> +
> +comment "CEF needs toolchain w/ Glibc"
Same name as the package, so libcef, and lowercase glibc.
> + depends on !BR2_TOOLCHAIN_USES_GLIBC
If you put this inside the condition, it will never be visible.
Also, you're missing all the other dependencies.
Don't forget that the comment should depend on the negated toolchain
dependencies (libc, wchar, gcc version, ..) but should also depend on the arch
dependencies (binfmt_flat).
> +
> +comment "CEF depends on X.org and needs an OpenGL backend"
> + depends on !BR2_PACKAGE_XORG7 || !BR2_PACKAGE_HAS_LIBGL
Here also the arch dependencies should be repeated.
> +
> +endif
> diff --git a/package/libcef/libcef.license-files.inc b/package/libcef/libcef.license-files.inc
> new file mode 100644
> index 0000000000..03fd700f24
> --- /dev/null
> +++ b/package/libcef/libcef.license-files.inc
> @@ -0,0 +1,1130 @@
> +LIBCEF_LICENSE_FILES = \
> + base/third_party/cityhash/COPYING \
> + base/third_party/dmg_fp/LICENSE \
Are all of these really used? Well, I guess trying to weed out the really
required ones manually is a bit too much work...
Could you add a comment in front that it is automatically generated?
[snip]
> diff --git a/package/libcef/libcef.mk b/package/libcef/libcef.mk
> new file mode 100644
> index 0000000000..fe69cabb2c
> --- /dev/null
> +++ b/package/libcef/libcef.mk
> @@ -0,0 +1,372 @@
> +################################################################################
> +#
> +# libcef
> +#
> +################################################################################
> +
> +# Run $(LIBCEF_PKGDIR)/scripts/version.sh to generate these values.
> +# Don't bother trying to update these by hand, LIBCEF_CEF_VERSION is too
> +# dependant on git to assemble ourselves.
> +LIBCEF_VERSION = f3890bec3b21b01c2b5b026c50f96a9f2f070e7c
> +LIBCEF_CEF_COMMIT_NUMBER = 2044
> +LIBCEF_CEF_VERSION = 77.1.4+gf3890be+chromium-77.0.3865.90
> +LIBCEF_CEF_VERSION_MAJOR = 3
> +LIBCEF_CEF_VERSION_MINOR = 1
> +LIBCEF_CEF_VERSION_PATCH = 4
> +LIBCEF_CHROMIUM_VERSION_MAJOR = 77
> +LIBCEF_CHROMIUM_VERSION_MINOR = 0
> +LIBCEF_CHROMIUM_VERSION_BUILD = 3865
> +LIBCEF_CHROMIUM_VERSION_PATCH = 90
> +# End version.sh generated values
> +
> +LIBCEF_SITE = https://bitbucket.org/chromiumembedded/cef.git
> +LIBCEF_SITE_METHOD = git
Bitbucket has an auto-archive feature just like github, so we could use that:
https://bitbucket.org/chromiumembedded/cef/get/f3890bec3b21b01c2b5b026c50f96a9f2f070e7c.tar.bz2
I don't know how stable the tarballs are though, so maybe git is better after all.
Something to mention in the commit message :-)
> +LIBCEF_STRIP_COMPONENTS = 0
> +
> +LIBCEF_INSTALL_STAGING = YES
> +LIBCEF_INSTALL_STAGING_INCLUDE_PATH=$(STAGING_DIR)/usr/include/cef
> +LIBCEF_INSTALL_STAGING_LIBRARY_PATH=$(STAGING_DIR)/usr/lib/cef
In general, I'm no fan of defining variables for things where there is little
variance, like for these values.
More importantly, though: define the variables closer to where they're used.
And definitely after all the generic stuff.
> +
> +LIBCEF_LICENSE = GPL-2.0 or LGPL-3.0 or GPL-3.0 or GPL-3.0 with exception
I haven't checked, but I'd be surprised if a packages with such a *load of
bundled dependencies only has those four licenses...
> +include package/libcef/libcef.license-files.inc
> +
> +# The Chromium source is fetched from a release tarball.
> +LIBCEF_CHROMIUM_VERSION = $(LIBCEF_CHROMIUM_VERSION_MAJOR).$(LIBCEF_CHROMIUM_VERSION_MINOR).$(LIBCEF_CHROMIUM_VERSION_BUILD).$(LIBCEF_CHROMIUM_VERSION_PATCH)
The commit message should *definitely* explain that chromium itself is bundled,
and why.
> +LIBCEF_EXTRA_DOWNLOADS = https://commondatastorage.googleapis.com/chromium-browser-official/chromium-$(LIBCEF_CHROMIUM_VERSION).tar.xz
> +
> +LIBCEF_DEPENDENCIES = \
> + alsa-lib \
> + at-spi2-atk \
> + at-spi2-core \
> + atk \
> + cairo \
> + compiler-rt \
> + dbus \
> + ffmpeg \
> + flac \
> + fontconfig \
> + freetype \
> + harfbuzz \
> + host-clang \
> + host-jpeg-turbo \
> + host-libkrb5 \
> + host-libnss \
> + host-libxml2 \
> + host-ninja \
> + host-nodejs \
> + host-pkgconf \
> + host-python \
> + host-webp \
> + jpeg-turbo \
> + libdrm \
> + libglib2 \
> + libgtk3 \
> + libgtkglext \
> + libkrb5 \
> + libnss \
> + libxml2 \
> + libxslt \
> + pango \
> + webp \
> + xlib_libXcomposite \
> + xlib_libXcursor \
> + xlib_libXrandr \
> + xlib_libXScrnSaver
> +
> +LIBCEF_HOST_PKG_CONFIG_WRAPPER = $(@D)/br-host-pkg-config.sh
> +
> +LIBCEF_GN_DEFINES = \
> + audio_processing_in_audio_service_supported=false \
> + clang_use_chrome_plugins=false \
> + closure_compile=false \
> + custom_toolchain=\"//build/toolchain/linux/unbundle:default\" \
> + enable_basic_print_dialog=false \
> + enable_nacl=false \
> + enable_service_discovery=false \
> + enable_vr=false \
> + forbid_non_component_debug_builds=false \
> + host_pkg_config=\"$(LIBCEF_HOST_PKG_CONFIG_WRAPPER)\" \
> + host_toolchain=\"//build/toolchain/linux/unbundle:host\" \
> + is_cfi=false \
> + is_unsafe_developer_build=false \
> + link_pulseaudio=false \
> + linux_use_bundled_binutils=false \
> + target_cpu=\"$(BR2_PACKAGE_LIBCEF_TARGET_ARCH)\" \
> + treat_warnings_as_errors=false \
> + use_bundled_fontconfig=false \
> + use_gnome_keyring=false \
> + use_gtk=false \
> + use_jumbo_build=true \
> + use_sysroot=false \
That's a bit surprising... We do use a sysroot.
> + use_system_freetype=true \
> + use_system_harfbuzz=true \
> + use_system_libjpeg=true \
> + use_viz_devtools=false
> +
> +# Use Buildroot system libraries instead of Chromium third_party libraries
> +LIBCEF_SYSTEM_LIBS = \
> + ffmpeg \
> + flac \
> + fontconfig \
> + freetype \
> + harfbuzz-ng \
> + libjpeg \
> + libvpx \
> + libwebp \
> + libxml \
> + libxslt \
> + openh264 \
> + yasm
> +
> +LIBCEF_BUILD_TARGETS = cef chrome_sandbox
> +
> +# Use the HOSTLD rather than target linker, which warns about host include dirs
> +LIBCEF_HOST_LDFLAGS = $(HOST_LDFLAGS) -fuse-ld=$(HOSTLD)
> +
> +# Use the target sysroot when building for the target
> +LIBCEF_TARGET_CFLAGS = $(TARGET_CFLAGS) --sysroot=$(STAGING_DIR)
The need for this --sysroot is surprising, since the toolchain wrapper already
forces --sysroot.
Oooh, I see, it's using clang... Could you take a look at [1] and check if that
maybe simplifies things?
(Again, a commit message would help to avoid that I have to find out these
things for myself.)
> +LIBCEF_TARGET_CXXFLAGS = $(TARGET_CXXFLAGS) --sysroot=$(STAGING_DIR)
> +LIBCEF_TARGET_LDFLAGS = $(TARGET_LDFLAGS) --sysroot=$(STAGING_DIR)
> +
> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
> +# Tell clang where the external toolchain is and to use it
> +LIBCEF_TARGET_CFLAGS += --gcc-toolchain=$(TOOLCHAIN_EXTERNAL_INSTALL_DIR) \
Can you explain why this --gcc-toolchain is needed? It can find it in $PATH, no?
> + --target=$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX)
This is only valid for custom external toolchains. You want
TOOLCHAIN_EXTERNAL_PREFIX.
> +LIBCEF_TARGET_CXXFLAGS += --gcc-toolchain=$(TOOLCHAIN_EXTERNAL_INSTALL_DIR) \
> + --target=$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX)
> +LIBCEF_TARGET_LDFLAGS += --gcc-toolchain=$(TOOLCHAIN_EXTERNAL_INSTALL_DIR) \
> + --target=$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX)
> +else
> +# Tell clang to use the Buildroot toolchain
> +LIBCEF_TARGET_CFLAGS += --target=$(GNU_TARGET_NAME)
> +LIBCEF_TARGET_CXXFLAGS += --target=$(GNU_TARGET_NAME)
> +LIBCEF_TARGET_LDFLAGS += --target=$(GNU_TARGET_NAME)
So --target needs as argument $(TARGET_CROSS), but without the path and without
the trailing -. Maybe it would be better to define a variable for that in
Makefile.in and use it here?
> +endif
> +
> +ifeq ($(BR2_i386)$(BR2_x86_64),y)
> +LIBCEF_SYSTEM_LIBS += yasm
> +LIBCEF_DEPENDENCIES += host-yasm
> +endif
> +
> +ifeq ($(BR2_ENABLE_DEBUG),y)
> +LIBCEF_BUILD_OUTPUT_DIR = out/Debug
> +LIBCEF_GN_DEFINES += \
> + is_debug=true \
> + is_official_build=false
> +else
> +LIBCEF_BUILD_OUTPUT_DIR = out/Release
> +LIBCEF_GN_DEFINES += \
> + is_debug=false \
> + is_official_build=true
I don't know if we ever can call it an offical build, but OK.
> +endif
> +
> +# We have two build directories. One uses the bundled LLVM libcxx, and the
> +# other uses the system C++ standard library. One is used for libcef.so, and
> +# the other is for libcef_dll_wrapper.a, that dependant projects statically
> +# link against.
> +LIBCEF_BUILD_OUTPUT_DIR_SYSTEM_LIBCXX = $(LIBCEF_BUILD_OUTPUT_DIR)_system_libcxx
> +
> +# tcmalloc has portability issues
> +LIBCEF_GN_DEFINES += use_allocator=\"none\"
> +
> +ifeq ($(BR2_CCACHE),y)
> +LIBCEF_GN_DEFINES += cc_wrapper=\"ccache\"
I would expect $(CCACHE) here.
> +endif
> +
> +# LLD is unsupported on i386, and fails during linking
> +ifeq ($(BR2_i386)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y)
> +LIBCEF_GN_DEFINES += use_lld=false
> +# Disable gold as well, to force usage of our toolchain's ld.bfd
> +LIBCEF_GN_DEFINES += use_gold=false
> +else
> +LIBCEF_GN_DEFINES += use_lld=false
> +LIBCEF_GN_DEFINES += use_gold=false
Both branches have the same content...
> +endif
> +
> +ifeq ($(BR2_PACKAGE_CUPS),y)
> +LIBCEF_DEPENDENCIES += cups
> +LIBCEF_GN_DEFINES += use_cups=true
> +else
> +LIBCEF_GN_DEFINES += use_cups=false
> +endif
> +
> +ifeq ($(BR2_PACKAGE_PCIUTILS),y)
> +LIBCEF_DEPENDENCIES += pciutils
> +LIBCEF_GN_DEFINES += use_libpci=true
> +else
> +LIBCEF_GN_DEFINES += use_libpci=false
> +endif
> +
> +ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
> +LIBCEF_DEPENDENCIES += pulseaudio
> +LIBCEF_GN_DEFINES += use_pulseaudio=true
> +else
> +LIBCEF_GN_DEFINES += use_pulseaudio=false
> +endif
> +
> +define LIBCEF_EXTRACT_CMDS
> + # Extract Chromium source code
> + tar -C $(@D) \
> + --strip-components=1 \
> + -xf $(LIBCEF_DL_DIR)/chromium-$(LIBCEF_CHROMIUM_VERSION).tar.xz
> +
> + # Extract CEF to cef dir inside Chromium source code
> + mkdir $(@D)/cef
> + tar -C $(@D)/cef \
> + --strip-components=1 \
> + -xf $(LIBCEF_DL_DIR)/libcef-$(LIBCEF_VERSION).tar.gz
So Buildroot first extracts (with --strip-components=0) in the top directory,
then chromium gets extracted next to it, and then we extract libcef again in a
subdirectory... That sounds a bit like a roundabout approach, no?
I guess you intended to just do a move here, like
mv $(@D)/libcef-$(LIBCEF_VERSION) $(@D)/cef
Or maybe even better, a symlink.
ln -sf $(@D)/libcef-$(LIBCEF_VERSION) $(@D)/cef
> +
> + # Patch the Chromium source with the CEF patches
> + ( cd $(@D); \
> + for cef_patch in cef/patch/patches/*.patch; do \
> + patch -p0 -u -i "$$cef_patch"; \
Patching would be better to do in a pre- or post-patch hook.
Also, you could use APPLY_PATCHES:
$(APPLY_PATCHES) $(@D) $(@D)/cef/patch/patches *.patch
> + done; \
> + )
> +
> + # Copy the toolchain folder into the build directory
> + cp -r $(LIBCEF_PKGDIR)/toolchain $(@D)/
> +endef
> +
> +LIBCEF_TARGET_CONFIGURE_ENV = \
> + $(TARGET_MAKE_ENV) \
> + BUILD_CC="clang" \
> + BUILD_CXX="clang++" \
> + BUILD_AR="$(HOSTAR)" \
> + BUILD_NM="$(HOSTNM)" \
> + BUILD_CFLAGS="$(HOST_CFLAGS)" \
> + BUILD_CXXFLAGS="$(HOST_CXXFLAGS)" \
> + BUILD_LDFLAGS="$(LIBCEF_HOST_LDFLAGS)" \
> + CC="clang" \
> + CXX="clang++" \
> + AR="ar" \
> + NM="nm" \
> + CFLAGS="$(LIBCEF_TARGET_CFLAGS)" \
> + CXXFLAGS="$(LIBCEF_TARGET_CXXFLAGS)" \
> + LDFLAGS="$(LIBCEF_TARGET_LDFLAGS)"
> +
> +define LIBCEF_CONFIGURE_CMDS
> + # Make the host pkg-config wrapper
> + echo "#!/bin/bash" > $(LIBCEF_HOST_PKG_CONFIG_WRAPPER)
> + echo $(HOST_MAKE_ENV) $(HOST_DIR)/bin/pkg-config '"$${@}"' >> \
> + $(LIBCEF_HOST_PKG_CONFIG_WRAPPER)
> + chmod +x $(LIBCEF_HOST_PKG_CONFIG_WRAPPER)
I think this host pkg-config wrapper could be useful in other places as well,
so I'd move it to the pkgconf package and to $(HOST_DIR)/bin. Yes, we can
bikeshed on its name, but for now it can be called anything.
> +
> + # Create include/cef_version.h
> + sed -e "s/{{ cef_version }}/$(LIBCEF_CEF_VERSION)/; \
> + s/{{ cef_version_major }}/$(LIBCEF_CEF_VERSION_MAJOR)/; \
> + s/{{ cef_version_minor }}/$(LIBCEF_CEF_VERSION_MINOR)/; \
> + s/{{ cef_version_patch }}/$(LIBCEF_CEF_VERSION_PATCH)/; \
> + s/{{ cef_commit_number }}/$(LIBCEF_CEF_COMMIT_NUMBER)/; \
> + s/{{ cef_commit_hash }}/$(LIBCEF_VERSION)/; \
> + s/{{ year }}/$$(date +%Y)/; \
> + s/{{ chrome_version_major }}/$(LIBCEF_CHROMIUM_VERSION_MAJOR)/; \
> + s/{{ chrome_version_minor }}/$(LIBCEF_CHROMIUM_VERSION_MINOR)/; \
> + s/{{ chrome_version_build }}/$(LIBCEF_CHROMIUM_VERSION_BUILD)/; \
> + s/{{ chrome_version_patch }}/$(LIBCEF_CHROMIUM_VERSION_PATCH)/;" \
> + $(LIBCEF_PKGDIR)/templates/cef_version.h > \
> + $(@D)/cef/include/cef_version.h
> +
> + # Update the CEF API in case someone has patched it
> + ( cd $(@D)/cef/tools; $(TARGET_MAKE_ENV) ./translator.sh )
> +
> + # Shim headers allow us to link to unbundled system libraries. Normally
> + # this isn't allowed in "official"/release builds.
> + # Disable the build time error for official builds with system libs.
> + ( cd $(@D); \
> + sed -i 's/OFFICIAL_BUILD/GOOGLE_CHROME_BUILD/' \
> + tools/generate_shim_headers/generate_shim_headers.py \
> + )
> +
> + mkdir -p $(@D)/third_party/node/linux/node-linux-x64/bin
> + ln -sf $(HOST_DIR)/bin/node $(@D)/third_party/node/linux/node-linux-x64/bin/
> +
> + # Use python2 by default
> + mkdir -p $(@D)/bin
> + ln -sf $(HOST_DIR)/usr/bin/python2 $(@D)/bin/python
Why is this needed? If host-python is built, $(HOST_DIR)/bin/python will point
to it (even if host-python3 is built as well).
BTW, $(HOST_DIR)/usr no longer exists (since a bit more than a year...)
[snip]
This is as far as I got with my preliminary review. I can tell you, it's not
going to be trivial to merge this...
Regards,
Arnout
[1] http://patchwork.ozlabs.org/project/buildroot/list/?series=129565
^ permalink raw reply [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 14/30] package/libcef: New package
2019-10-19 23:55 ` Arnout Vandecappelle
@ 2019-11-21 11:59 ` Michael Drake
0 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-11-21 11:59 UTC (permalink / raw)
To: buildroot
Hi Arnout,
Thank you for all the feedback!
We've addressed most of your comments in v3 of the RFC.
For the rest, I'll respond inline below.
On 20/10/2019 00:55, Arnout Vandecappelle wrote:
> On 17/10/2019 17:29, Michael Drake wrote:
>> +
>> +LIBCEF_LICENSE = GPL-2.0 or LGPL-3.0 or GPL-3.0 or GPL-3.0 with exception
>
> I haven't checked, but I'd be surprised if a packages with such a *load of
> bundled dependencies only has those four licenses...
True, we took our inspiration from the qt5webengine package, which is
also based on the Chromium source tree, and already in Buildroot:
https://github.com/buildroot/buildroot/blob/master/package/qt5/qt5webengine/qt5webengine.mk#L20
Perhaps we need to generate a full list from the files listed in the
package/libcef/libcef.license-files.inc file?
>> +ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
>> +# Tell clang where the external toolchain is and to use it
>> +LIBCEF_TARGET_CFLAGS += --gcc-toolchain=$(TOOLCHAIN_EXTERNAL_INSTALL_DIR) \
>
> Can you explain why this --gcc-toolchain is needed? It can find it in $PATH, no?
Without it, when building using an external toolchain, we see
linking errors:
[2852/24834] LINK ./chrome_sandbox
FAILED: chrome_sandbox
clang++ -Wl,--fatal-warnings -Wl,--build-id=sha1 -fPIC
-Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,-z,defs -Wl,--as-needed
-fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -flto=thin
-Wl,--thinlto-jobs=8 -Wl,--thinlto-cache-dir=thinlto-cache
-Wl,--thinlto-cache-policy,cache_size=10\%:cache_size_bytes=10g:cache_size_files=100000
-Wl,--lto-O0 -fwhole-program-vtables -m64 -Wl,-O2 -Wl,--gc-sections
-Wl,--gdb-index -rdynamic -nostdlib++
--sysroot=../../../../host/x86_64-buildroot-linux-gnu/sysroot
-fsanitize=cfi-vcall -fsanitize=cfi-icall -pie -Wl,--disable-new-dtags
-Wno-unknown-warning-option --target=x86_64-tesla-linux-gnu -o
"./chrome_sandbox" -Wl,--start-group @"./chrome_sandbox.rsp"
-Wl,--end-group -ldl -lpthread -lrt
ld.lld: error: cannot open crtbeginS.o: No such file or directory
ld.lld: error: unable to find library -lgcc
ld.lld: error: unable to find library -lgcc
ld.lld: error: cannot open crtendS.o: No such file or directory
clang-9: error: linker command failed with exit code 1 (use -v to see
invocation)
>> +define LIBCEF_EXTRACT_CMDS
>> + # Extract Chromium source code
>> + tar -C $(@D) \
>> + --strip-components=1 \
>> + -xf $(LIBCEF_DL_DIR)/chromium-$(LIBCEF_CHROMIUM_VERSION).tar.xz
>> +
>> + # Extract CEF to cef dir inside Chromium source code
>> + mkdir $(@D)/cef
>> + tar -C $(@D)/cef \
>> + --strip-components=1 \
>> + -xf $(LIBCEF_DL_DIR)/libcef-$(LIBCEF_VERSION).tar.gz
>
> So Buildroot first extracts (with --strip-components=0) in the top directory,
> then chromium gets extracted next to it, and then we extract libcef again in a
> subdirectory... That sounds a bit like a roundabout approach, no?
Actually, I think defining LIBCEF_EXTRACT_CMDS replaces the default
Buildroot extraction commands. We simply extract the Chromium source
into the top level libcef output directory, and then extract the
CEF source into a cef/ directory within that. This is the source
tree layout that the CEF project requires.
Cheers,
Michael
^ permalink raw reply [flat|nested] 52+ messages in thread
* [Buildroot] [RFC PATCH v2 15/30] package/libcef: Add option to build cefclient and cefsimple.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (13 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 14/30] package/libcef: New package Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 16/30] package/libcef: Add option to enable VA-API HW acceleration Michael Drake
` (15 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
From: Thomas Preston <thomas.preston@codethink.co.uk>
Cc: Patrick Glaser <pglaser@tesla.com>
Cc: Jon duSaint <jdusaint@tesla.com>
Cc: Enis Lavery <elavery@tesla.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/libcef/Config.in | 10 ++++++++++
package/libcef/libcef.mk | 18 ++++++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/package/libcef/Config.in b/package/libcef/Config.in
index 85a993bb93..7bdaf17ffd 100644
--- a/package/libcef/Config.in
+++ b/package/libcef/Config.in
@@ -58,6 +58,16 @@ config BR2_PACKAGE_LIBCEF
if BR2_PACKAGE_LIBCEF
+config BR2_PACKAGE_LIBCEF_CEFSIMPLE
+ bool "Enable libcef example application cefsimple."
+ help
+ Enables libcef example application cefsimple.
+
+config BR2_PACKAGE_LIBCEF_CEFCLIENT
+ bool "Enable libcef example application cefclient."
+ help
+ Enables libcef example application cefclient.
+
config BR2_PACKAGE_LIBCEF_TARGET_ARCH
string
default "arm" if BR2_arm
diff --git a/package/libcef/libcef.mk b/package/libcef/libcef.mk
index fe69cabb2c..b20c003a90 100644
--- a/package/libcef/libcef.mk
+++ b/package/libcef/libcef.mk
@@ -204,6 +204,24 @@ else
LIBCEF_GN_DEFINES += use_pulseaudio=false
endif
+ifeq ($(BR2_PACKAGE_LIBCEF_CEFSIMPLE),y)
+LIBCEF_BUILD_TARGETS += cefsimple
+define LIBCEF_INSTALL_CEFSIMPLE
+ $(INSTALL) -m 0755 -D -t $(TARGET_DIR)/usr/bin \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/cefsimple
+endef
+LIBCEF_POST_INSTALL_TARGET_HOOKS += LIBCEF_INSTALL_CEFSIMPLE
+endif
+
+ifeq ($(BR2_PACKAGE_LIBCEF_CEFCLIENT),y)
+LIBCEF_BUILD_TARGETS += cefclient
+define LIBCEF_INSTALL_CEFCLIENT
+ $(INSTALL) -m 0755 -D -t $(TARGET_DIR)/usr/bin \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/cefclient
+endef
+LIBCEF_POST_INSTALL_TARGET_HOOKS += LIBCEF_INSTALL_CEFCLIENT
+endif
+
define LIBCEF_EXTRACT_CMDS
# Extract Chromium source code
tar -C $(@D) \
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 16/30] package/libcef: Add option to enable VA-API HW acceleration.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (14 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 15/30] package/libcef: Add option to build cefclient and cefsimple Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 17/30] package/libcef: Add proprietary codecs build option Michael Drake
` (14 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Cc: Patrick Glaser <pglaser@tesla.com>
Cc: Jon duSaint <jdusaint@tesla.com>
Cc: Enis Lavery <elavery@tesla.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/libcef/Config.in | 6 ++++++
package/libcef/libcef.mk | 7 +++++++
2 files changed, 13 insertions(+)
diff --git a/package/libcef/Config.in b/package/libcef/Config.in
index 7bdaf17ffd..05d577ecb6 100644
--- a/package/libcef/Config.in
+++ b/package/libcef/Config.in
@@ -68,6 +68,12 @@ config BR2_PACKAGE_LIBCEF_CEFCLIENT
help
Enables libcef example application cefclient.
+config BR2_PACKAGE_LIBCEF_VAAPI
+ bool "Enable va-api support in libcef."
+ select BR2_PACKAGE_LIBVA
+ help
+ Enables VA-API-based hardware acceleration.
+
config BR2_PACKAGE_LIBCEF_TARGET_ARCH
string
default "arm" if BR2_arm
diff --git a/package/libcef/libcef.mk b/package/libcef/libcef.mk
index b20c003a90..9fa87cbb89 100644
--- a/package/libcef/libcef.mk
+++ b/package/libcef/libcef.mk
@@ -204,6 +204,13 @@ else
LIBCEF_GN_DEFINES += use_pulseaudio=false
endif
+ifeq ($(BR2_PACKAGE_LIBCEF_VAAPI),y)
+LIBCEF_GN_DEFINES += use_vaapi=true
+LIBCEF_DEPENDENCIES += libva
+else
+LIBCEF_GN_DEFINES += use_vaapi=false
+endif
+
ifeq ($(BR2_PACKAGE_LIBCEF_CEFSIMPLE),y)
LIBCEF_BUILD_TARGETS += cefsimple
define LIBCEF_INSTALL_CEFSIMPLE
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 17/30] package/libcef: Add proprietary codecs build option.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (15 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 16/30] package/libcef: Add option to enable VA-API HW acceleration Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 18/30] package/widevine: Add package for the widevine CDM library Michael Drake
` (13 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
This uses the Chromium bundled ffmpeg.
Cc: Patrick Glaser <pglaser@tesla.com>
Cc: Jon duSaint <jdusaint@tesla.com>
Cc: Enis Lavery <elavery@tesla.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/libcef/Config.in | 10 +++++++++-
package/libcef/libcef.mk | 12 +++++++++---
2 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/package/libcef/Config.in b/package/libcef/Config.in
index 05d577ecb6..46d412f228 100644
--- a/package/libcef/Config.in
+++ b/package/libcef/Config.in
@@ -13,7 +13,7 @@ config BR2_PACKAGE_LIBCEF
select BR2_PACKAGE_ALSA_LIB
select BR2_PACKAGE_COMPILER_RT
select BR2_PACKAGE_DBUS
- select BR2_PACKAGE_FFMPEG
+ select BR2_PACKAGE_FFMPEG if !BR2_PACKAGE_LIBCEF_PROPRIETARY_CODECS
select BR2_PACKAGE_FLAC
select BR2_PACKAGE_FREETYPE
select BR2_PACKAGE_HARFBUZZ
@@ -39,6 +39,7 @@ config BR2_PACKAGE_LIBCEF
select BR2_PACKAGE_LIBGTKGLEXT
select BR2_PACKAGE_LIBKRB5
select BR2_PACKAGE_LIBNSS
+ select BR2_PACKAGE_LIBOPENH264 if BR2_PACKAGE_LIBCEF_PROPRIETARY_CODECS
select BR2_PACKAGE_LIBPNG
select BR2_PACKAGE_PCIUTILS
select BR2_PACKAGE_PANGO
@@ -74,6 +75,13 @@ config BR2_PACKAGE_LIBCEF_VAAPI
help
Enables VA-API-based hardware acceleration.
+config BR2_PACKAGE_LIBCEF_PROPRIETARY_CODECS
+ bool "Enable proprietary codecs in libcef"
+ help
+ Enable proprietary codecs in libcef. This uses
+ the ffmpeg bundled in Chromium, rather than the
+ ffmpeg buildroot package.
+
config BR2_PACKAGE_LIBCEF_TARGET_ARCH
string
default "arm" if BR2_arm
diff --git a/package/libcef/libcef.mk b/package/libcef/libcef.mk
index 9fa87cbb89..e7a4c2b1a3 100644
--- a/package/libcef/libcef.mk
+++ b/package/libcef/libcef.mk
@@ -42,7 +42,6 @@ LIBCEF_DEPENDENCIES = \
cairo \
compiler-rt \
dbus \
- ffmpeg \
flac \
fontconfig \
freetype \
@@ -105,7 +104,6 @@ LIBCEF_GN_DEFINES = \
# Use Buildroot system libraries instead of Chromium third_party libraries
LIBCEF_SYSTEM_LIBS = \
- ffmpeg \
flac \
fontconfig \
freetype \
@@ -115,11 +113,19 @@ LIBCEF_SYSTEM_LIBS = \
libwebp \
libxml \
libxslt \
- openh264 \
yasm
LIBCEF_BUILD_TARGETS = cef chrome_sandbox
+ifeq ($(BR2_PACKAGE_LIBCEF_PROPRIETARY_CODECS),y)
+LIBCEF_GN_DEFINES += \
+ ffmpeg_branding=\"Chrome\" \
+ proprietary_codecs=true
+else
+LIBCEF_DEPENDENCIES += ffmpeg
+LIBCEF_SYSTEM_LIBS += ffmpeg
+endif
+
# Use the HOSTLD rather than target linker, which warns about host include dirs
LIBCEF_HOST_LDFLAGS = $(HOST_LDFLAGS) -fuse-ld=$(HOSTLD)
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 18/30] package/widevine: Add package for the widevine CDM library.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (16 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 17/30] package/libcef: Add proprietary codecs build option Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 19/30] package/libcef: Widevine support depends on widevine package Michael Drake
` (12 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Cc: Patrick Glaser <pglaser@tesla.com>
Cc: Enis Lavery <elavery@tesla.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/Config.in | 1 +
package/widevine/Config.in | 6 ++++++
package/widevine/widevine.mk | 28 ++++++++++++++++++++++++++++
3 files changed, 35 insertions(+)
create mode 100644 package/widevine/Config.in
create mode 100644 package/widevine/widevine.mk
diff --git a/package/Config.in b/package/Config.in
index 5fc2b8a635..d290f88067 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1650,6 +1650,7 @@ menu "Networking"
source "package/usbredir/Config.in"
source "package/wampcc/Config.in"
source "package/websocketpp/Config.in"
+ source "package/widevine/Config.in"
source "package/zeromq/Config.in"
source "package/zmqpp/Config.in"
source "package/zyre/Config.in"
diff --git a/package/widevine/Config.in b/package/widevine/Config.in
new file mode 100644
index 0000000000..d730e6f9bd
--- /dev/null
+++ b/package/widevine/Config.in
@@ -0,0 +1,6 @@
+menuconfig BR2_PACKAGE_WIDEVINE
+ bool "widevine"
+ depends on BR2_i386 || BR2_x86_64
+ help
+ Proprietary content decryption module (CDM) for the digital
+ rights management (DRM) of internet content.
diff --git a/package/widevine/widevine.mk b/package/widevine/widevine.mk
new file mode 100644
index 0000000000..7a7546c5a0
--- /dev/null
+++ b/package/widevine/widevine.mk
@@ -0,0 +1,28 @@
+# Get latest version number from: https://dl.google.com/widevine-cdm/current.txt
+WIDEVINE_VERSION = 1.4.9.1088
+
+ifeq ($(BR2_i386),y)
+WIDEVINE_ARCH = ia32
+else ifeq ($(BR2_x86_64),y)
+WIDEVINE_ARCH = x64
+endif
+
+WIDEVINE_SOURCE = $(WIDEVINE_VERSION)-linux-$(WIDEVINE_ARCH).zip
+WIDEVINE_SITE = https://dl.google.com/widevine-cdm
+WIDEVINE_LICENSE = Proprietary
+WIDEVINE_LICENSE_FILES = LICENSE.txt
+WIDEVINE_INSTALL_STAGING = YES
+
+define WIDEVINE_EXTRACT_CMDS
+ $(UNZIP) $(WIDEVINE_DL_DIR)/$(WIDEVINE_SOURCE) -d $(@D)
+endef
+
+define WIDEVINE_INSTALL_STAGING_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/libwidevinecdm.so $(STAGING_DIR)/usr/lib
+endef
+
+define WIDEVINE_INSTALL_TARGET_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/libwidevinecdm.so $(TARGET_DIR)/usr/lib
+endef
+
+$(eval $(generic-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 19/30] package/libcef: Widevine support depends on widevine package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (17 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 18/30] package/widevine: Add package for the widevine CDM library Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 20/30] package/alsa-lib/alsa-lib: Add host package Michael Drake
` (11 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Cc: Patrick Glaser <pglaser@tesla.com>
Cc: Jon duSaint <jdusaint@tesla.com>
Cc: Enis Lavery <elavery@tesla.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/libcef/Config.in | 6 ++++++
package/libcef/libcef.mk | 7 +++++++
2 files changed, 13 insertions(+)
diff --git a/package/libcef/Config.in b/package/libcef/Config.in
index 46d412f228..c06fc094d3 100644
--- a/package/libcef/Config.in
+++ b/package/libcef/Config.in
@@ -69,6 +69,12 @@ config BR2_PACKAGE_LIBCEF_CEFCLIENT
help
Enables libcef example application cefclient.
+config BR2_PACKAGE_LIBCEF_WIDEVINE
+ bool "Enable Widevine support in libcef."
+ select BR2_PACKAGE_WIDEVINE
+ help
+ Enables Widevine key system support.
+
config BR2_PACKAGE_LIBCEF_VAAPI
bool "Enable va-api support in libcef."
select BR2_PACKAGE_LIBVA
diff --git a/package/libcef/libcef.mk b/package/libcef/libcef.mk
index e7a4c2b1a3..0fa9c61315 100644
--- a/package/libcef/libcef.mk
+++ b/package/libcef/libcef.mk
@@ -210,6 +210,13 @@ else
LIBCEF_GN_DEFINES += use_pulseaudio=false
endif
+ifeq ($(BR2_PACKAGE_LIBCEF_WIDEVINE),y)
+LIBCEF_GN_DEFINES += enable_widevine=true
+LIBCEF_DEPENDENCIES += widevine
+else
+LIBCEF_GN_DEFINES += enable_widevine=false
+endif
+
ifeq ($(BR2_PACKAGE_LIBCEF_VAAPI),y)
LIBCEF_GN_DEFINES += use_vaapi=true
LIBCEF_DEPENDENCIES += libva
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 20/30] package/alsa-lib/alsa-lib: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (18 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 19/30] package/libcef: Widevine support depends on widevine package Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 21/30] package/ffmpeg: " Michael Drake
` (10 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/alsa-lib/alsa-lib.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
index fecf7d7cfa..7502a91259 100644
--- a/package/alsa-lib/alsa-lib.mk
+++ b/package/alsa-lib/alsa-lib.mk
@@ -67,3 +67,4 @@ ALSA_LIB_CONF_ENV = \
LDFLAGS="$(TARGET_LDFLAGS) -lm"
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 21/30] package/ffmpeg: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (19 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 20/30] package/alsa-lib/alsa-lib: Add host package Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 22/30] package/libvpx: " Michael Drake
` (9 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/ffmpeg/ffmpeg.mk | 61 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
index 21fb24e597..cefeb0d5f5 100644
--- a/package/ffmpeg/ffmpeg.mk
+++ b/package/ffmpeg/ffmpeg.mk
@@ -56,6 +56,46 @@ FFMPEG_CONF_OPTS = \
--disable-symver \
--disable-doc
+HOST_FFMPEG_CONF_OPTS = \
+ --enable-avfilter \
+ --disable-version3 \
+ --enable-logging \
+ --enable-optimizations \
+ --disable-extra-warnings \
+ --enable-avdevice \
+ --enable-avcodec \
+ --enable-avformat \
+ --enable-network \
+ --disable-gray \
+ --enable-swscale-alpha \
+ --disable-small \
+ --enable-dct \
+ --enable-fft \
+ --enable-mdct \
+ --enable-rdft \
+ --disable-crystalhd \
+ --disable-dxva2 \
+ --enable-runtime-cpudetect \
+ --disable-hardcoded-tables \
+ --disable-mipsdsp \
+ --disable-mipsdspr2 \
+ --disable-msa \
+ --enable-hwaccels \
+ --disable-cuda \
+ --disable-cuvid \
+ --disable-nvenc \
+ --disable-avisynth \
+ --disable-frei0r \
+ --disable-libopencore-amrnb \
+ --disable-libopencore-amrwb \
+ --disable-libdc1394 \
+ --disable-libgsm \
+ --disable-libilbc \
+ --disable-libvo-amrwbenc \
+ --disable-libxcb \
+ --disable-symver \
+ --disable-doc
+
FFMPEG_DEPENDENCIES += host-pkgconf
ifeq ($(BR2_PACKAGE_FFMPEG_GPL),y)
@@ -406,9 +446,12 @@ endif
ifeq ($(BR2_X86_CPU_HAS_MMX),y)
FFMPEG_CONF_OPTS += --enable-x86asm
FFMPEG_DEPENDENCIES += host-nasm
+HOST_FFMPEG_DEPENDENCIES += host-nasm
else
FFMPEG_CONF_OPTS += --disable-x86asm
FFMPEG_CONF_OPTS += --disable-mmx
+HOST_FFMPEG_CONF_OPTS += --disable-x86asm
+HOST_FFMPEG_CONF_OPTS += --disable-mmx
endif
ifeq ($(BR2_X86_CPU_HAS_SSE),y)
@@ -553,9 +596,27 @@ define FFMPEG_CONFIGURE_CMDS
)
endef
+HOST_FFMPEG_CONF_ENV += CFLAGS="$(HOST_FFMPEG_CFLAGS)"
+
+# Override HOST_FFMPEG_CONFIGURE_CMDS: FFmpeg does not support --target and others
+define HOST_FFMPEG_CONFIGURE_CMDS
+ (cd $(HOST_FFMPEG_SRCDIR) && rm -rf config.cache && \
+ $(HOST_CONFIGURE_OPTS) \
+ $(HOST_CONFIGURE_ARGS) \
+ $(HOST_FFMPEG_CONF_ENV) \
+ ./configure \
+ --prefix="$(HOST_DIR)" \
+ --enable-shared --disable-static \
+ --disable-doc \
+ --disable-debug \
+ $(HOST_FFMPEG_CONF_OPTS) \
+ )
+endef
+
define FFMPEG_REMOVE_EXAMPLE_SRC_FILES
rm -rf $(TARGET_DIR)/usr/share/ffmpeg/examples
endef
FFMPEG_POST_INSTALL_TARGET_HOOKS += FFMPEG_REMOVE_EXAMPLE_SRC_FILES
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 22/30] package/libvpx: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (20 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 21/30] package/ffmpeg: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 23/30] package/x11r7/xcb-util: " Michael Drake
` (8 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/libvpx/libvpx.mk | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/package/libvpx/libvpx.mk b/package/libvpx/libvpx.mk
index 73fe2057de..f4ea019c0e 100644
--- a/package/libvpx/libvpx.mk
+++ b/package/libvpx/libvpx.mk
@@ -15,11 +15,16 @@ LIBVPX_CONF_ENV = \
LD="$(TARGET_CC)" \
CROSS=$(GNU_TARGET_NAME)
+HOST_LIBVPX_CONF_ENV = \
+ LD="$(HOST_CC)"
+
LIBVPX_CONF_OPTS = \
--disable-examples \
--disable-docs \
--disable-unit-tests
+HOST_LIBVPX_CONF_OPTS = $(LIBVPX_CONF_OPTS)
+
# This is not a true autotools package. It is based on the ffmpeg build system
define LIBVPX_CONFIGURE_CMDS
(cd $(LIBVPX_SRCDIR) && rm -rf config.cache && \
@@ -35,10 +40,29 @@ define LIBVPX_CONFIGURE_CMDS
)
endef
+define HOST_LIBVPX_CONFIGURE_CMDS
+ (cd $(HOST_LIBVPX_SRCDIR) && rm -rf config.cache && \
+ $(HOST_CONFIGURE_OPTS) \
+ $(HOST_CONFIGURE_ARGS) \
+ $(HOST_LIBVPX_CONF_ENV) \
+ ./configure \
+ --target=generic-gnu \
+ --enable-pic \
+ --prefix="$(HOST_DIR)" \
+ --enable-shared --disable-static \
+ --disable-debug \
+ $(HOST_LIBVPX_CONF_OPTS) \
+ )
+endef
+
define LIBVPX_BUILD_CMDS
$(TARGET_MAKE_ENV) $(LIBVPX_MAKE_ENV) $(MAKE) -C $(@D) all
endef
+define HOST_LIBVPX_BUILD_CMDS
+ $(HOST_MAKE_ENV) $(HOST_LIBVPX_MAKE_ENV) $(MAKE) -C $(@D) all
+endef
+
define LIBVPX_INSTALL_STAGING_CMDS
$(TARGET_MAKE_ENV) $(LIBVPX_MAKE_ENV) $(MAKE) DESTDIR="$(STAGING_DIR)" -C $(@D) install
endef
@@ -47,4 +71,9 @@ define LIBVPX_INSTALL_TARGET_CMDS
$(TARGET_MAKE_ENV) $(LIBVPX_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
endef
+define HOST_LIBVPX_INSTALL_CMDS
+ $(HOST_MAKE_ENV) $(HOST_LIBVPX_MAKE_ENV) $(MAKE) -C $(@D) install
+endef
+
$(eval $(generic-package))
+$(eval $(host-generic-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 23/30] package/x11r7/xcb-util: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (21 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 22/30] package/libvpx: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 24/30] package/x11r7/xlib_libXScrnSaver: " Michael Drake
` (7 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/x11r7/xcb-util/xcb-util.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/x11r7/xcb-util/xcb-util.mk b/package/x11r7/xcb-util/xcb-util.mk
index bb73530f94..9a4f927364 100644
--- a/package/x11r7/xcb-util/xcb-util.mk
+++ b/package/x11r7/xcb-util/xcb-util.mk
@@ -11,5 +11,7 @@ XCB_UTIL_LICENSE = MIT
XCB_UTIL_LICENSE_FILES = COPYING
XCB_UTIL_INSTALL_STAGING = YES
XCB_UTIL_DEPENDENCIES = libxcb
+HOST_XCB_UTIL_DEPENDENCIES = host-libxcb
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 24/30] package/x11r7/xlib_libXScrnSaver: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (22 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 23/30] package/x11r7/xcb-util: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 25/30] package/x11r7/xlib_libXcomposite: " Michael Drake
` (6 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/x11r7/xlib_libXScrnSaver/xlib_libXScrnSaver.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/x11r7/xlib_libXScrnSaver/xlib_libXScrnSaver.mk b/package/x11r7/xlib_libXScrnSaver/xlib_libXScrnSaver.mk
index 92abb902eb..1292aff5a7 100644
--- a/package/x11r7/xlib_libXScrnSaver/xlib_libXScrnSaver.mk
+++ b/package/x11r7/xlib_libXScrnSaver/xlib_libXScrnSaver.mk
@@ -11,6 +11,8 @@ XLIB_LIBXSCRNSAVER_LICENSE = MIT
XLIB_LIBXSCRNSAVER_LICENSE_FILES = COPYING
XLIB_LIBXSCRNSAVER_INSTALL_STAGING = YES
XLIB_LIBXSCRNSAVER_DEPENDENCIES = xlib_libX11 xlib_libXext xorgproto
+HOST_XLIB_LIBXSCRNSAVER_DEPENDENCIES = host-xlib_libX11 host-xlib_libXext host-xorgproto
XLIB_LIBXSCRNSAVER_CONF_OPTS = --disable-malloc0returnsnull
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 25/30] package/x11r7/xlib_libXcomposite: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (23 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 24/30] package/x11r7/xlib_libXScrnSaver: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 26/30] package/x11r7/xlib_libXext: " Michael Drake
` (5 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/x11r7/xlib_libXcomposite/xlib_libXcomposite.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/x11r7/xlib_libXcomposite/xlib_libXcomposite.mk b/package/x11r7/xlib_libXcomposite/xlib_libXcomposite.mk
index 80e94fe37c..ac32113f48 100644
--- a/package/x11r7/xlib_libXcomposite/xlib_libXcomposite.mk
+++ b/package/x11r7/xlib_libXcomposite/xlib_libXcomposite.mk
@@ -11,5 +11,7 @@ XLIB_LIBXCOMPOSITE_LICENSE = MIT
XLIB_LIBXCOMPOSITE_LICENSE_FILES = COPYING
XLIB_LIBXCOMPOSITE_INSTALL_STAGING = YES
XLIB_LIBXCOMPOSITE_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXfixes xorgproto
+HOST_XLIB_LIBXCOMPOSITE_DEPENDENCIES = host-xlib_libX11 host-xlib_libXext host-xlib_libXfixes host-xorgproto
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 26/30] package/x11r7/xlib_libXext: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (24 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 25/30] package/x11r7/xlib_libXcomposite: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 27/30] package/x11r7/xlib_libXi: " Michael Drake
` (4 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/x11r7/xlib_libXext/xlib_libXext.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/x11r7/xlib_libXext/xlib_libXext.mk b/package/x11r7/xlib_libXext/xlib_libXext.mk
index c63a3b23cc..90f6357e80 100644
--- a/package/x11r7/xlib_libXext/xlib_libXext.mk
+++ b/package/x11r7/xlib_libXext/xlib_libXext.mk
@@ -11,6 +11,8 @@ XLIB_LIBXEXT_LICENSE = MIT
XLIB_LIBXEXT_LICENSE_FILES = COPYING
XLIB_LIBXEXT_INSTALL_STAGING = YES
XLIB_LIBXEXT_DEPENDENCIES = xlib_libX11 xorgproto
+HOST_XLIB_LIBXEXT_DEPENDENCIES = host-xlib_libX11 host-xorgproto
XLIB_LIBXEXT_CONF_OPTS = --disable-malloc0returnsnull
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 27/30] package/x11r7/xlib_libXi: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (25 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 26/30] package/x11r7/xlib_libXext: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 28/30] package/x11r7/xlib_libXrandr: " Michael Drake
` (3 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/x11r7/xlib_libXi/xlib_libXi.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/x11r7/xlib_libXi/xlib_libXi.mk b/package/x11r7/xlib_libXi/xlib_libXi.mk
index de7f3a7d3c..96c4487a7f 100644
--- a/package/x11r7/xlib_libXi/xlib_libXi.mk
+++ b/package/x11r7/xlib_libXi/xlib_libXi.mk
@@ -16,7 +16,14 @@ XLIB_LIBXI_DEPENDENCIES = \
xlib_libXext \
xlib_libXfixes \
xorgproto
+HOST_XLIB_LIBXI_DEPENDENCIES = \
+ host-pkgconf \
+ host-xlib_libX11 \
+ host-xlib_libXext \
+ host-xlib_libXfixes \
+ host-xorgproto
XLIB_LIBXI_CONF_OPTS = --disable-malloc0returnsnull
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 28/30] package/x11r7/xlib_libXrandr: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (26 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 27/30] package/x11r7/xlib_libXi: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 29/30] package/x11r7/xlib_libXtst: " Michael Drake
` (2 subsequent siblings)
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/x11r7/xlib_libXrandr/xlib_libXrandr.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/x11r7/xlib_libXrandr/xlib_libXrandr.mk b/package/x11r7/xlib_libXrandr/xlib_libXrandr.mk
index 23a0d974d0..a8080904af 100644
--- a/package/x11r7/xlib_libXrandr/xlib_libXrandr.mk
+++ b/package/x11r7/xlib_libXrandr/xlib_libXrandr.mk
@@ -11,6 +11,8 @@ XLIB_LIBXRANDR_LICENSE = MIT
XLIB_LIBXRANDR_LICENSE_FILES = COPYING
XLIB_LIBXRANDR_INSTALL_STAGING = YES
XLIB_LIBXRANDR_DEPENDENCIES = xlib_libX11 xlib_libXext xlib_libXrender xorgproto
+HOST_XLIB_LIBXRANDR_DEPENDENCIES = host-xlib_libX11 host-xlib_libXext host-xlib_libXrender host-xorgproto
XLIB_LIBXRANDR_CONF_OPTS = --disable-malloc0returnsnull
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 29/30] package/x11r7/xlib_libXtst: Add host package.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (27 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 28/30] package/x11r7/xlib_libXrandr: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 30/30] package/libcef: Add v8 Snapshot option Michael Drake
2019-10-19 23:58 ` [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Arnout Vandecappelle
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/x11r7/xlib_libXtst/xlib_libXtst.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/x11r7/xlib_libXtst/xlib_libXtst.mk b/package/x11r7/xlib_libXtst/xlib_libXtst.mk
index e0d7e8217c..38878b0e0e 100644
--- a/package/x11r7/xlib_libXtst/xlib_libXtst.mk
+++ b/package/x11r7/xlib_libXtst/xlib_libXtst.mk
@@ -17,4 +17,11 @@ XLIB_LIBXTST_DEPENDENCIES = \
xlib_libXi \
xorgproto
+HOST_XLIB_LIBXTST_DEPENDENCIES = \
+ host-xlib_libX11 \
+ host-xlib_libXext \
+ host-xlib_libXi \
+ host-xorgproto
+
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 30/30] package/libcef: Add v8 Snapshot option.
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (28 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 29/30] package/x11r7/xlib_libXtst: " Michael Drake
@ 2019-10-17 15:29 ` Michael Drake
2019-10-19 23:58 ` [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Arnout Vandecappelle
30 siblings, 0 replies; 52+ messages in thread
From: Michael Drake @ 2019-10-17 15:29 UTC (permalink / raw)
To: buildroot
Coauthored-by: Thomas Preston <thomas.preston@codethink.co.uk>
Cc: Patrick Glaser <pglaser@tesla.com>
Cc: Jon duSaint <jdusaint@tesla.com>
Cc: Enis Lavery <elavery@tesla.com>
Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>
Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
---
package/libcef/Config.in | 22 ++++++++++++++++++++++
package/libcef/libcef.mk | 32 ++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+)
diff --git a/package/libcef/Config.in b/package/libcef/Config.in
index c06fc094d3..9e0fa22ad5 100644
--- a/package/libcef/Config.in
+++ b/package/libcef/Config.in
@@ -69,6 +69,28 @@ config BR2_PACKAGE_LIBCEF_CEFCLIENT
help
Enables libcef example application cefclient.
+config BR2_PACKAGE_LIBCEF_V8_SNAPSHOTS
+ bool "Enable v8 snapshots in libcef"
+ select BR2_PACKAGE_HOST_DBUS
+ select BR2_PACKAGE_HOST_FFMPEG
+ select BR2_PACKAGE_HOST_LIBVPX
+ select BR2_PACKAGE_HOST_LIBXCB
+ select BR2_PACKAGE_HOST_XCB_UTIL
+ select BR2_PACKAGE_HOST_XLIB_LIBXTST
+ help
+ Enables V8 snapshots. This is an optimisation for
+ JavaScript context creation (e.g. opening new tabs).
+ It avoids needing to execute a whole load of JavaScript
+ code that gets run on context initialisation.
+ It works by building a browser for the host, creating
+ a JavaScript context, and saving the JavaScript heap
+ to file. The target browser can then load the recorded
+ JavaScript heap from file, instead of executing the
+ JavaScript code.
+ Note that since this requires building a browser for
+ the host, it requires a lot of extra host packages
+ to be built.
+
config BR2_PACKAGE_LIBCEF_WIDEVINE
bool "Enable Widevine support in libcef."
select BR2_PACKAGE_WIDEVINE
diff --git a/package/libcef/libcef.mk b/package/libcef/libcef.mk
index 0fa9c61315..63e2e3a767 100644
--- a/package/libcef/libcef.mk
+++ b/package/libcef/libcef.mk
@@ -210,6 +210,27 @@ else
LIBCEF_GN_DEFINES += use_pulseaudio=false
endif
+ifeq ($(BR2_PACKAGE_LIBCEF_V8_SNAPSHOTS),y)
+LIBCEF_GN_DEFINES += \
+ v8_snapshot_toolchain=\"//build/toolchain/linux/unbundle:host\" \
+ v8_use_snapshot=true
+LIBCEF_DEPENDENCIES += \
+ host-alsa-lib \
+ host-dbus \
+ host-ffmpeg \
+ host-libvpx \
+ host-libxcb \
+ host-xcb-util \
+ host-xlib_libXcomposite \
+ host-xlib_libXcursor \
+ host-xlib_libXrandr \
+ host-xlib_libXScrnSaver \
+ host-xlib_libXtst
+else
+LIBCEF_GN_DEFINES += \
+ v8_use_snapshot=false
+endif
+
ifeq ($(BR2_PACKAGE_LIBCEF_WIDEVINE),y)
LIBCEF_GN_DEFINES += enable_widevine=true
LIBCEF_DEPENDENCIES += widevine
@@ -242,6 +263,17 @@ endef
LIBCEF_POST_INSTALL_TARGET_HOOKS += LIBCEF_INSTALL_CEFCLIENT
endif
+ifeq ($(BR2_PACKAGE_LIBCEF_V8_SNAPSHOTS),y)
+define LIBCEF_INSTALL_V8_SNAPSHOT_BINARIES
+ # v8 snapshot binaries
+ $(INSTALL) -m 0644 -D -t $(TARGET_DIR)/usr/lib \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/natives_blob.bin \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/snapshot_blob.bin \
+ $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/v8_context_snapshot.bin
+endef
+LIBCEF_POST_INSTALL_TARGET_HOOKS += LIBCEF_INSTALL_V8_SNAPSHOT_BINARIES
+endif
+
define LIBCEF_EXTRACT_CMDS
# Extract Chromium source code
tar -C $(@D) \
--
2.20.1
^ permalink raw reply related [flat|nested] 52+ messages in thread* [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library
2019-10-17 15:28 [Buildroot] [RFC PATCH v2 00/30] Add Chromium Embedded Framework library Michael Drake
` (29 preceding siblings ...)
2019-10-17 15:29 ` [Buildroot] [RFC PATCH v2 30/30] package/libcef: Add v8 Snapshot option Michael Drake
@ 2019-10-19 23:58 ` Arnout Vandecappelle
30 siblings, 0 replies; 52+ messages in thread
From: Arnout Vandecappelle @ 2019-10-19 23:58 UTC (permalink / raw)
To: buildroot
On 17/10/2019 17:28, Michael Drake wrote:
> Hi all,
>
> Here's a work in progress second attempt at adding libcef to Buildroot.
>
> We're still working on:
>
> - Testing integration with dependant packages.
> - Cross compiling.
>
> We'd appreciate any feedback!
Since there has been some feedback now, I've marked the entire series as
Changes Requested in patchwork.
Thanks!
Regards,
Arnout
^ permalink raw reply [flat|nested] 52+ messages in thread