All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Ganapatrao Kulkarni <gklkml16@gmail.com>
Cc: John Garry <john.garry@huawei.com>,
	Ganapatrao Prabhakerrao Kulkarni <gkulkarni@marvell.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	Jan Glauber <jglauber@marvell.com>,
	Jayachandran Chandrasekharan Nair <jnair@marvell.com>,
	Robert Richter <rrichter@marvell.com>,
	Zhangshaokun <zhangshaokun@hisilicon.com>
Subject: Re: [PATCH v6 2/2] drivers/perf: Add CCPI2 PMU support in ThunderX2 UNCORE driver.
Date: Thu, 17 Oct 2019 16:47:51 +0100	[thread overview]
Message-ID: <20191017154750.jgn6e3465qrsu53e@willie-the-truck> (raw)
In-Reply-To: <CAKTKpr4QoTDjbSxO4CvSH2sNvmrTJKjxi+RZH4mYfyDaaN96Sw@mail.gmail.com>

On Thu, Oct 17, 2019 at 12:38:51PM +0530, Ganapatrao Kulkarni wrote:
> On Wed, Oct 16, 2019 at 7:01 PM John Garry <john.garry@huawei.com> wrote:
> > > +TX2_EVENT_ATTR(req_pktsent, CCPI2_EVENT_REQ_PKT_SENT);
> > > +TX2_EVENT_ATTR(snoop_pktsent, CCPI2_EVENT_SNOOP_PKT_SENT);
> > > +TX2_EVENT_ATTR(data_pktsent, CCPI2_EVENT_DATA_PKT_SENT);
> > > +TX2_EVENT_ATTR(gic_pktsent, CCPI2_EVENT_GIC_PKT_SENT);
> > > +
> > > +static struct attribute *ccpi2_pmu_events_attrs[] = {
> > > +     &tx2_pmu_event_attr_req_pktsent.attr.attr,
> > > +     &tx2_pmu_event_attr_snoop_pktsent.attr.attr,
> > > +     &tx2_pmu_event_attr_data_pktsent.attr.attr,
> > > +     &tx2_pmu_event_attr_gic_pktsent.attr.attr,
> > > +     NULL,
> > > +};
> >
> > Hi Ganapatrao,
> >
> > Have you considered adding these as uncore pmu-events in the perf tool?
> >
> At the moment no, since the number of events exposed/listed are very few.

Then sounds like a perfect time to nip it in the bud before the list grows
;)

If you can manage with these things in userspace, then I agree with John
that it would be preferential to do it that way. It also offers more
flexibility if we get the metricgroup stuff working properly (I think it's
buggered for big/little atm).

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Ganapatrao Kulkarni <gklkml16@gmail.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	Ganapatrao Prabhakerrao Kulkarni <gkulkarni@marvell.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	Jan Glauber <jglauber@marvell.com>,
	John Garry <john.garry@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Robert Richter <rrichter@marvell.com>,
	Zhangshaokun <zhangshaokun@hisilicon.com>,
	Jayachandran Chandrasekharan Nair <jnair@marvell.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 2/2] drivers/perf: Add CCPI2 PMU support in ThunderX2 UNCORE driver.
Date: Thu, 17 Oct 2019 16:47:51 +0100	[thread overview]
Message-ID: <20191017154750.jgn6e3465qrsu53e@willie-the-truck> (raw)
In-Reply-To: <CAKTKpr4QoTDjbSxO4CvSH2sNvmrTJKjxi+RZH4mYfyDaaN96Sw@mail.gmail.com>

On Thu, Oct 17, 2019 at 12:38:51PM +0530, Ganapatrao Kulkarni wrote:
> On Wed, Oct 16, 2019 at 7:01 PM John Garry <john.garry@huawei.com> wrote:
> > > +TX2_EVENT_ATTR(req_pktsent, CCPI2_EVENT_REQ_PKT_SENT);
> > > +TX2_EVENT_ATTR(snoop_pktsent, CCPI2_EVENT_SNOOP_PKT_SENT);
> > > +TX2_EVENT_ATTR(data_pktsent, CCPI2_EVENT_DATA_PKT_SENT);
> > > +TX2_EVENT_ATTR(gic_pktsent, CCPI2_EVENT_GIC_PKT_SENT);
> > > +
> > > +static struct attribute *ccpi2_pmu_events_attrs[] = {
> > > +     &tx2_pmu_event_attr_req_pktsent.attr.attr,
> > > +     &tx2_pmu_event_attr_snoop_pktsent.attr.attr,
> > > +     &tx2_pmu_event_attr_data_pktsent.attr.attr,
> > > +     &tx2_pmu_event_attr_gic_pktsent.attr.attr,
> > > +     NULL,
> > > +};
> >
> > Hi Ganapatrao,
> >
> > Have you considered adding these as uncore pmu-events in the perf tool?
> >
> At the moment no, since the number of events exposed/listed are very few.

Then sounds like a perfect time to nip it in the bud before the list grows
;)

If you can manage with these things in userspace, then I agree with John
that it would be preferential to do it that way. It also offers more
flexibility if we get the metricgroup stuff working properly (I think it's
buggered for big/little atm).

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-17 15:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16  9:36 [PATCH v6 0/2] Add CCPI2 PMU support Ganapatrao Prabhakerrao Kulkarni
2019-10-16  9:36 ` Ganapatrao Prabhakerrao Kulkarni
2019-10-16  9:36 ` [PATCH v6 1/2] Documentation: perf: Update documentation for ThunderX2 PMU uncore driver Ganapatrao Prabhakerrao Kulkarni
2019-10-16  9:36   ` Ganapatrao Prabhakerrao Kulkarni
2019-10-16  9:37 ` [PATCH v6 2/2] drivers/perf: Add CCPI2 PMU support in ThunderX2 UNCORE driver Ganapatrao Prabhakerrao Kulkarni
2019-10-16  9:37   ` Ganapatrao Prabhakerrao Kulkarni
2019-10-16 13:30   ` John Garry
2019-10-16 13:30     ` John Garry
2019-10-17  7:08     ` Ganapatrao Kulkarni
2019-10-17  7:08       ` Ganapatrao Kulkarni
2019-10-17 15:47       ` Will Deacon [this message]
2019-10-17 15:47         ` Will Deacon
2019-10-18  4:21         ` Ganapatrao Kulkarni
2019-10-18  4:21           ` Ganapatrao Kulkarni
2019-10-18  8:38           ` John Garry
2019-10-18  8:38             ` John Garry
2019-10-18  9:18             ` Ganapatrao Kulkarni
2019-10-18  9:18               ` Ganapatrao Kulkarni
2019-10-28 21:55 ` [PATCH v6 0/2] Add CCPI2 PMU support Will Deacon
2019-10-28 21:55   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017154750.jgn6e3465qrsu53e@willie-the-truck \
    --to=will@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gklkml16@gmail.com \
    --cc=gkulkarni@marvell.com \
    --cc=jglauber@marvell.com \
    --cc=jnair@marvell.com \
    --cc=john.garry@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rrichter@marvell.com \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.