All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: quintela@redhat.com, dgilbert@redhat.com
Cc: qemu-devel@nongnu.org, Wei Yang <richardw.yang@linux.intel.com>
Subject: [PATCH 4/6] migration/postcopy: set all_zero to true on the first target page
Date: Fri, 18 Oct 2019 08:48:48 +0800	[thread overview]
Message-ID: <20191018004850.9888-5-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20191018004850.9888-1-richardw.yang@linux.intel.com>

For the first target page, all_zero is set to true for this round check.

After target_pages introduced, we could leverage this variable instead
of checking the address offset.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/ram.c b/migration/ram.c
index 5c05376d8d..b5759793a9 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -4067,7 +4067,7 @@ static int ram_load_postcopy(QEMUFile *f)
             page_buffer = postcopy_host_page +
                           ((uintptr_t)host & (block->page_size - 1));
             /* If all TP are zero then we can optimise the place */
-            if (!((uintptr_t)host & (block->page_size - 1))) {
+            if (target_pages == 1) {
                 all_zero = true;
             } else {
                 /* not the 1st TP within the HP */
-- 
2.17.1



  parent reply	other threads:[~2019-10-18  0:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18  0:48 [PATCH 0/6] migration/postcopy: enable compress during postcopy Wei Yang
2019-10-18  0:48 ` [PATCH 1/6] migration/postcopy: reduce memset when it is zero page and matches_target_page_size Wei Yang
2019-11-06 18:18   ` Dr. David Alan Gilbert
2019-10-18  0:48 ` [PATCH 2/6] migration/postcopy: wait for decompress thread in precopy Wei Yang
2019-11-06 19:57   ` Dr. David Alan Gilbert
2019-10-18  0:48 ` [PATCH 3/6] migration/postcopy: count target page number to decide the place_needed Wei Yang
2019-11-06 19:59   ` Dr. David Alan Gilbert
2019-10-18  0:48 ` Wei Yang [this message]
2019-11-06 20:04   ` [PATCH 4/6] migration/postcopy: set all_zero to true on the first target page Dr. David Alan Gilbert
2019-10-18  0:48 ` [PATCH 5/6] migration/postcopy: enable random order target page arrival Wei Yang
2019-11-06 20:08   ` Dr. David Alan Gilbert
2019-11-07  6:00     ` Wei Yang
2019-11-07  9:14       ` Dr. David Alan Gilbert
2019-10-18  0:48 ` [PATCH 6/6] migration/postcopy: enable compress during postcopy Wei Yang
2019-11-06 19:55   ` Dr. David Alan Gilbert
2019-10-18 16:50 ` [PATCH 0/6] " no-reply
2019-10-19  0:15   ` Wei Yang
2019-11-06 20:11 ` Dr. David Alan Gilbert
2019-11-07  6:02   ` Wei Yang
2019-11-07  9:15     ` Dr. David Alan Gilbert
2019-11-07 12:03       ` Wei Yang
2019-11-07 12:06         ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018004850.9888-5-richardw.yang@linux.intel.com \
    --to=richardw.yang@linux.intel.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.