* [PATCH] qemu-img.texi: Describe data_file and data_file_raw
@ 2019-10-18 9:59 Han Han
2019-10-18 14:13 ` Eric Blake
2019-10-18 20:58 ` John Snow
0 siblings, 2 replies; 4+ messages in thread
From: Han Han @ 2019-10-18 9:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Han Han
https://bugzilla.redhat.com/show_bug.cgi?id=1763105
Signed-off-by: Han Han <hhan@redhat.com>
---
qemu-img.texi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index b5156d6316..44596c2d93 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't be changed to NOCOW
by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
+@item data_file
+File name of data file that is stored in the image and used as a default for
+opening the image. If the option is used, qcow2 file only stores the metadata
+of the image.
+
+@item data_file_raw
+This option requires @option{data_file}. If this option is set to @code{on},
+qemu will always keep the external data file consistent as a standalone
+read-only raw image. Default value is @code{off}.
+
@end table
@item Other
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qemu-img.texi: Describe data_file and data_file_raw
2019-10-18 9:59 [PATCH] qemu-img.texi: Describe data_file and data_file_raw Han Han
@ 2019-10-18 14:13 ` Eric Blake
2019-10-18 20:58 ` John Snow
1 sibling, 0 replies; 4+ messages in thread
From: Eric Blake @ 2019-10-18 14:13 UTC (permalink / raw)
To: Han Han, qemu-devel, qemu-block, Kevin Wolf
[cc qemu-block]
On 10/18/19 4:59 AM, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1763105
>
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
> qemu-img.texi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index b5156d6316..44596c2d93 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't be changed to NOCOW
> by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
> the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
>
> +@item data_file
> +File name of data file that is stored in the image and used as a default for
> +opening the image. If the option is used, qcow2 file only stores the metadata
> +of the image.
> +
> +@item data_file_raw
> +This option requires @option{data_file}. If this option is set to @code{on},
> +qemu will always keep the external data file consistent as a standalone
> +read-only raw image. Default value is @code{off}.
> +
> @end table
>
> @item Other
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qemu-img.texi: Describe data_file and data_file_raw
2019-10-18 9:59 [PATCH] qemu-img.texi: Describe data_file and data_file_raw Han Han
2019-10-18 14:13 ` Eric Blake
@ 2019-10-18 20:58 ` John Snow
2019-10-21 1:06 ` Han Han
1 sibling, 1 reply; 4+ messages in thread
From: John Snow @ 2019-10-18 20:58 UTC (permalink / raw)
To: Han Han, qemu-devel; +Cc: Kevin Wolf, Qemu-block
CC qemu-block
On 10/18/19 5:59 AM, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1763105
>
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
> qemu-img.texi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index b5156d6316..44596c2d93 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't be changed to NOCOW
> by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
> the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
>
> +@item data_file
> +File name of data file that is stored in the image and used as a default for
> +opening the image. If the option is used, qcow2 file only stores the metadata
> +of the image.
> +
This is a little unclear, and seems to imply the data file is stored
*IN* the image.
"Optional filename to be used as a data store for this qcow2 file. If
this option is used, the qcow2 file only stores metadata for this image."
> +@item data_file_raw
> +This option requires @option{data_file}. If this option is set to @code{on},
> +qemu will always keep the external data file consistent as a standalone
> +read-only raw image. Default value is @code{off}.
> +
> @end table
>
> @item Other
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qemu-img.texi: Describe data_file and data_file_raw
2019-10-18 20:58 ` John Snow
@ 2019-10-21 1:06 ` Han Han
0 siblings, 0 replies; 4+ messages in thread
From: Han Han @ 2019-10-21 1:06 UTC (permalink / raw)
To: John Snow; +Cc: Kevin Wolf, qemu-devel, Qemu-block
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
On Sat, Oct 19, 2019 at 4:58 AM John Snow <jsnow@redhat.com> wrote:
> CC qemu-block
>
> On 10/18/19 5:59 AM, Han Han wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1763105
> >
> > Signed-off-by: Han Han <hhan@redhat.com>
> > ---
> > qemu-img.texi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/qemu-img.texi b/qemu-img.texi
> > index b5156d6316..44596c2d93 100644
> > --- a/qemu-img.texi
> > +++ b/qemu-img.texi
> > @@ -763,6 +763,16 @@ file which is COW and has data blocks already, it
> couldn't be changed to NOCOW
> > by setting @code{nocow=on}. One can issue @code{lsattr filename} to
> check if
> > the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
> >
> > +@item data_file
> > +File name of data file that is stored in the image and used as a
> default for
> > +opening the image. If the option is used, qcow2 file only stores the
> metadata
> > +of the image.
> > +
>
> This is a little unclear, and seems to imply the data file is stored
> *IN* the image.
>
> "Optional filename to be used as a data store for this qcow2 file. If
> this option is used, the qcow2 file only stores metadata for this image."
>
Thanks for your advice. I will update it in v2.
>
> > +@item data_file_raw
> > +This option requires @option{data_file}. If this option is set to
> @code{on},
> > +qemu will always keep the external data file consistent as a standalone
> > +read-only raw image. Default value is @code{off}.
> > +
> > @end table
> >
> > @item Other
> >
>
>
--
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.
Email: hhan@redhat.com
Phone: +861065339333
[-- Attachment #2: Type: text/html, Size: 2752 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-21 1:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 9:59 [PATCH] qemu-img.texi: Describe data_file and data_file_raw Han Han
2019-10-18 14:13 ` Eric Blake
2019-10-18 20:58 ` John Snow
2019-10-21 1:06 ` Han Han
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.